Yes, thank you for the quick reply. That should be fine.
Our implementation is currently using the Override method to take care of the
ID generation so internally we are able to make progress without an official
answer. Eventually we would like to use upstream fixes of course. The Override
meth
Can we get this reviewed/merged?
> -Original Message-
> From: Jeshua Smith
> Sent: Monday, February 5, 2024 12:01 PM
> To: devel@edk2.groups.io
> Cc: ardb+tianoc...@kernel.org; quic_llind...@quicinc.com;
> pierre.gond...@arm.com; sami.muja...@arm.com; Jeshua Smith
>
> Subject: [PATCH v2]
> > It looks like instead of moving the common code to
> EObjNameSpaceStandard namespace or a new (Arch? Common?) namespace,
> you're renaming the entire EObjNameSpaceArm namespace to
> EObjNameSpaceArch. It seems to me that if ARM code vs. common code is
> being separated out, then the EObjNameSpa
> From: devel@edk2.groups.io On Behalf Of Sunil V L
> via groups.io
> Sent: Tuesday, January 9, 2024 9:29 AM
> DynamicTablesPkg can be used by RISC-V platforms to generate ACPI tables
> from FDT passed from previous stage FW. However, DynamicTablesPkg
> currently is ARM specific even though severa
> > Two physical packages are on a multi-chip module and share resources on
> the module. The module then plugs into the baseboard/motherboard.
>
> Is it possible to elaborate on the resource being shared ?
In our specific case the problem is related to the PPTT's "Identical
Implementation" flag
> From: Pierre Gondois
> Sent: Tuesday, January 9, 2024 1:22 AM
> On 1/8/24 19:12, Jeshua Smith wrote:
> > The code was incorrectly assuming that root nodes had to be physical
> > package nodes and vice versa. This is not always true, so the check is
> > being removed.
>
> Does it mean that you
The code was incorrectly assuming that root nodes had to be physical
package nodes and vice versa. This is not always true, so the check
is being removed.
Signed-off-by: Jeshua Smith
Tested-by: Ashish Singhal
Reviewed-by: Ashish Singhal
---
.../SsdtCpuTopologyGenerator.c| 23 ++
The patches in this series have both individually received:
Reviewed-by: Pierre Gondois
Can this be merged?
-Original Message-
From: Jeshua Smith
Sent: Friday, October 6, 2023 10:28 AM
To: devel@edk2.groups.io
Cc: sami.muja...@arm.com; pierre.gond...@arm.com; Jeshua Smith
Subject: [P
This series has received:
Reviewed-by: Pierre Gondois
And also For 1-2,12-13:
Reviewed-by: Leif Lindholm
Can this be merged?
-Original Message-
From: Pierre Gondois
Sent: Friday, September 22, 2023 8:51 AM
To: Sami Mujawar ; devel@edk2.groups.io
Cc: ardb+tianoc...@kernel.org; quic_lli
Can this be merged?
-Original Message-
From: Pierre Gondois
Sent: Tuesday, October 10, 2023 1:31 AM
To: Jeshua Smith ; devel@edk2.groups.io
Cc: sami.muja...@arm.com; quic_llind...@quicinc.com; ardb+tianoc...@kernel.org
Subject: Re: [PATCH v2] DynamicTablesPkg/AmlLib: Enumerate memory attr
#3 is not currently used by any published code. It is a development aid, which
the ObjectParser itself seems to be.
Here's why I added it. Several people on our team have (not yet upstreamed)
changes that resulted in additional ObjectIDs being added to the ObjectID
enums, but without correspond
Thanks for the review. Reply inline.
-Original Message-
From: Pierre Gondois
Sent: Tuesday, October 10, 2023 4:14 AM
To: Jeshua Smith ; devel@edk2.groups.io
Cc: sami.muja...@arm.com
Subject: Re: [PATCH 1/2] DynamicTablesPkg/TableHelperLib: Fix and improve text
handling
External email:
This fixes two bugs and adds some enhancements to the handling of
characters and strings in objects being printed by the CM ObjectParser.
Bug fixes:
1. PrintOemID() currently attempts to print characters with "%C",
but the correct syntax is (lowercase) "%c". This bug results in
"CC" bein
This patch enhances error handling and reporting in the CM ObjectParser.
Specifically:
1. ObjectIDs used as array indexes are checked for being out of bounds,
and if so an error message is printed before the assert.
2. An error message is printed for unsupported NameSpaceIDs.
3. Adds support for
While using the ConfigurationManagerObjectParser to dump objects and debug
adding new objects, I noticed some bugs and deficiencies. This series is
intended to address those.
Jeshua Smith (2):
DynamicTablesPkg/TableHelperLib: Fix and improve text handling
DynamicTablesPkg/TableHelperLib: Enhan
AmlCodeGenRdQWordMemory's and AmlCodeGenRdDWordMemory's Cacheable
and MemoryRangeType parameters treat specific values as having
specific meanings as defined by the spec. This change adds enums to map
those meanings to their corresponding values.
Signed-off-by: Jeshua Smith
---
Notes:
v2: based
AmlCodeGenRdQWordMemory's and AmlCodeGenRdDWordMemory's Cacheable
and MemoryRangeType parameters treat specific values as having
specific meanings. This change adds enums to map those meanings to their
corresponding values.
Signed-off-by: Jeshua Smith
---
.../Include/Library/AmlLib/AmlLib.h
Not sure it's worth creating a new patchset for, but the "GetEArmObjEtInfo
(OPTIONAL)" comment should probably not have the "Get" prefix (ie. "
EArmObjEtInfo (OPTIONAL)").
-Original Message-
From: Sami Mujawar
Sent: Wednesday, September 13, 2023 6:50 AM
To: devel@edk2.groups.io
Cc: Sam
Hi Sami,
What is the status of getting this series updated, reviewed, and merged?
From: Sami Mujawar
Sent: Thursday, August 3, 2023 1:08 AM
To: Jeshua Smith ; devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH v1 05/11] DynamicTablesPkg: Update MADT
generator for ACPI 6.5
External email: Us
My apologies, I see it there now. I had gotten zero results when I searched for
it on github.com/tianocore/edk2, but it looks like that was user error on my
part.
From: Sami Mujawar
Sent: Thursday, August 3, 2023 1:01 AM
To: Jeshua Smith ; devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH e
This code depends on ArmReadIdAA64Dfr0(), which as far as I can tell is not
present in the EDK2 repo or the patch series mentioned in your 0/3 message.
-Original Message-
From: devel@edk2.groups.io On Behalf Of Jeshua Smith via
groups.io
Sent: Tuesday, August 1, 2023 9:38 AM
To: devel
It looks like you are setting the wrong field here (should be TrbeInterrupt,
not SpeOverflowInterrupt):
+// Setting TrbeInterrupt to 0 ensures backward compatibility with
+// ACPI 6.4
+Gicc->SpeOverflowInterrupt = 0;
-Original Message-
From: devel@edk2.groups.io On Behalf Of
This comment in the code looks wrong:
+// TRBE Interrupt is PPI 13 on FVP model.
+TrbeInterrupt = 31;
-Original Message-
From: devel@edk2.groups.io On Behalf Of Sami Mujawar via
groups.io
Sent: Tuesday, July 25, 2023 4:31 AM
To: devel@edk2.groups.io
Cc: Sami Mujawar ; ardb+tiano
ary 10, 2023 11:50 AM
> > To: devel@edk2.groups.io; jesh...@nvidia.com; Demeter, Miki
> > ; Ni, Ray ; Wang, Jian J
> > ; Gao, Liming ;
> > Gao, Zhichao
> > Cc: Kinney, Michael D
> > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: allow
> > PlatformBo
PM
> > To: Demeter, Miki
> > Cc: devel@edk2.groups.io
> > Subject: FW: [edk2-devel] [PATCH] MdeModulePkg: allow
> PlatformBootManagerLib to use BootNext
> >
> > Miki, this patch, as well as my queries on the mailing list about
> > this topic
> prior to the pat
lf Of Jeshua Smith via
groups.io
Sent: Thursday, January 19, 2023 10:36 AM
To: devel@edk2.groups.io
Cc: jian.j.w...@intel.com; gaolim...@byosoft.com.cn; zhichao@intel.com;
ray...@intel.com; Jeshua Smith
Subject: [edk2-devel] [PATCH] MdeModulePkg: allow PlatformBootManagerLib to use
Boo
caution opening links or attachments
Can you share then code change link of your personal repo? The patch I download
from this email cannot apply to the open source branch.
Thanks,
Zhichao
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Jeshua
> Smith via
Thanks for the review. What is the next step to get this merged?
-Original Message-
From: Gao, Zhichao
Sent: Sunday, January 15, 2023 5:59 PM
To: Jeshua Smith ; devel@edk2.groups.io
Cc: Ni, Ray
Subject: RE: [PATCH] ShellPkg/AcpiView: ERST Parser
External email: Use caution opening link
Currently BdsEntry caches BootNext before calling PlatformBootManagerLib
APIs, with the result that:
- If BootNext is already set, a BootNext value written by the APIs will
be ignored and deleted, and the current boot will use the cached
BootNext value.
- If BootNext is not present, a BootNext valu
, but the subsequent boot
will boot with the BootNext value set by the APIs during the current boot
(because not having a cached value skips the deletion of BootNext).
To me this seems inconsistent and confusing.
From: devel@edk2.groups.io On Behalf Of Jeshua Smith via
groups.io
Sent: Tuesday, Ja
this up from getting reviewed?
-Original Message-
From: devel@edk2.groups.io On Behalf Of Jeshua Smith via
groups.io
Sent: Wednesday, November 30, 2022 11:31 AM
To: devel@edk2.groups.io
Cc: ray...@intel.com; zhichao@intel.com; Jeshua Smith
Subject: [edk2-devel] [PATCH] ShellPkg
Happy New Year!
I'm trying to figure out the proper place to add code to allow the EFI boot
code to respond to the IPMI System Boot Options request to boot a device on the
current boot. My initial thought was to change BootNext in the
PlatformBootManagerLib APIs, but based on the comment
https
I haven’t tried it, but farther down on the page steps 9 and 10 look like
they’re related to the option Mike suggested, so they might be required for it
to work?
From: devel@edk2.groups.io On Behalf Of Sean Rhodes via
groups.io
Sent: Friday, December 16, 2022 1:58 AM
To: devel@edk2.groups.io;
It looks like that function call takes a double as a parameter, which is a type
of floating point number. I’m guessing that’s why the compiler is complaining
that the ‘+nofp’ feature can’t be used with that function.
From: devel@edk2.groups.io On Behalf Of Sami Mujawar via
groups.io
Sent: Frid
Is there anything holding this up from getting reviewed?
-Original Message-
From: devel@edk2.groups.io On Behalf Of Jeshua Smith via
groups.io
Sent: Wednesday, November 30, 2022 11:31 AM
To: devel@edk2.groups.io
Cc: ray...@intel.com; zhichao@intel.com; Jeshua Smith
Subject: [edk2
] UnitTestFrameworkPkg/UnitTestLib: Print
expected Status on ASSERT fail
External email: Use caution opening links or attachments
Reviewed-by: Michael Kubacki
On 11/30/2022 6:02 PM, Jeshua Smith via groups.io wrote:
> Update the UnitTestAssertStatusEqual error message to print out the
> expected va
Update the UnitTestAssertStatusEqual error message to print out the
expected value in addition to the seen value.
Signed-off-by: Jeshua Smith
---
UnitTestFrameworkPkg/Library/UnitTestLib/AssertCmocka.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/UnitTestFrameworkPkg/Libra
Update the UnitTestAssertStatusEqual error message to print out the
expected value in addition to the seen value.
Change-Id: Ic651584dcdbcf1f8cd8166ad8058744fc0587d72
Signed-off-by: Jeshua Smith
---
UnitTestFrameworkPkg/Library/UnitTestLib/AssertCmocka.c | 2 +-
1 file changed, 1 insertion(+), 1
string names in
this same C file.
Best regards,
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Jeshua
> Smith via groups.io
> Sent: Wednesday, November 30, 2022 12:39 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ;
> mikub...@linux.micr
Update the UnitTestAssertStatusEqual error message to print out the
expected value in addition to the seen value.
Signed-off-by: Jeshua Smith
---
UnitTestFrameworkPkg/Library/UnitTestLib/AssertCmocka.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/UnitTestFrameworkPkg/Libra
Add a new parser for the Error Record Serialization Table.
The ERST table describes how an OS can save and retrieve
hardware error information to and from a persistent store.
Signed-off-by: Jeshua Smith
---
.../UefiShellAcpiViewCommandLib/AcpiParser.h | 22 ++
.../Parsers/Erst/ErstParse
41 matches
Mail list logo
