Please submit it in Github Edk2 as pull request. I agree this is a good
change.
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Chun-Yi Lee
> 发送时间: 2024年9月12日 14:52
> 收件人: devel@edk2.groups.io
> 抄送: Zhiguang Liu ; Michael D Kinney
> ; Chun-Yi Lee
> 主题: [edk2-devel] [PATCH] MdePkg DebugLib: Enab
Michael:
Thanks for your great effort. This is a good direction to consolidate code
and issue together. My feedbacks are below:
1. BugZilla supports code first process. What proposal will handle this process
in Github issue flow?
2. BugZilla supports Edk2-Platform and Edk2-Test repo. After the
Is there Pull Request for this patch?
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Xiaoyao Li
> 发送时间: 2024年6月27日 9:27
> 收件人: devel@edk2.groups.io
> 抄送: xiaoyao...@intel.com
> 主题: [edk2-devel] [PATCH] MdePkg/Tdx.h: Fix the order of NumVcpus and
> MaxVcpus
>
> For TDCALL leaf TDG.VP.INFO, the b
Abner:
Is PR for this change?
Thanks
Liming
发件人: devel@edk2.groups.io 代表 Chang, Abner via groups.io
发送时间: 2024年6月18日 10:50
收件人: Chesley, Brit ; devel@edk2.groups.io
主题: Re: [edk2-devel] [PATCH v2 1/1] MdeModulePkg: UsbBusDxe: Rebuild Descriptor
Table
Hi Hao,
What is your comment on t
Zhihao:
I have no other comment for the change in MdeModulePkg. Please create pull
request for it.
Thanks
Liming
> -邮件原件-
> 发件人: Li, Zhihao
> 发送时间: 2024年6月11日 15:36
> 收件人: gaoliming ; devel@edk2.groups.io
> 抄送: Chiu, Chasel ; Desimone, Nathaniel L
> ; Duggapu, Chinni B
> ; Chen, Gang
Can you create pull request for this change? I will add my review for it.
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Dhaval Sharma
> 发送时间: 2024年6月11日 12:09
> 收件人: devel@edk2.groups.io
> 抄送: Liming Gao
> 主题: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: Avoid efi memory
allocation
> for SP type
I just add push label for it.
发件人: Hsueh, Hong-Chih (Neo)
发送时间: 2024年6月4日 23:46
收件人: gaoliming ; devel@edk2.groups.io; Chang,
Abner
抄送: michael.d.kin...@intel.com; zhiguang@intel.com; He, Jiangang
主题: Re: [edk2-devel] [PATCH] MdePkg: Remove non-ASCII characters from
header file (BZ# 47
Zhihao:
If Fsp-T/M is not installed, are they still used in PEI boot? If they are
used, I agree they should be measured.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Li, Zhihao
> 发送时间: 2024年5月29日 11:36
> 收件人: gaoliming ; devel@edk2.groups.io
> 抄送: Chiu, Chasel ; Desimone, Nat
If ASSERT trigs the exception, could call stack show each caller?
Thanks
Liming
> -邮件原件-
> 发件人: Gerd Hoffmann
> 发送时间: 2024年5月29日 21:09
> 收件人: devel@edk2.groups.io; dougfl...@microsoft.com
> 抄送: Liming Gao ; Ard Biesheuvel
>
> 主题: Re: [edk2-devel] [PATCH v3 00/20] NetworkPkg: CVE-2023-452
Lin:
I see there is some discussion. Have you made the agreement with this
change?
Thanks
Liming
发件人: devel@edk2.groups.io 代表 Du Lin
发送时间: 2024年5月29日 21:05
收件人: devel@edk2.groups.io
抄送: Liming Gao ; Ni, Ray ;
Lin, Du
主题: Re: [edk2-devel] [PATCH] MdeModulePkg: Update GCD attribute convers
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: Tan, Dun
> 发送时间: 2024年5月28日 17:44
> 收件人: gaoliming ; devel@edk2.groups.io
> 抄送: Ni, Ray ; Wang, Jian J
> 主题: RE: [edk2-devel] [Patch V2 17/18] MdeModulePkg:Remove MpService2Ppi
> field in SMM_S3_RESUME_STATE
>
> Liming,
>
> Sure, I think we can
Zhihao:
Could you explain the situation that FSP-T/M is not migrated by PeiCore?
Thanks
Liming
> -邮件原件-
> 发件人: Zhihao Li
> 发送时间: 2024年4月29日 11:20
> 收件人: devel@edk2.groups.io
> 抄送: Chasel Chiu ; Nate DeSimone
> ; Duggapu Chinni B
> ; Chen Gang C ; Liming
> Gao
> 主题: [PATCH v1 1/2] MdeM
Dun:
If you confirm that there is no impact on the existing module, you can remove
it.
Thanks
Liming
> -邮件原件-
> 发件人: Tan, Dun
> 发送时间: 2024年5月28日 17:34
> 收件人: gaoliming ; devel@edk2.groups.io
> 抄送: Ni, Ray ; Wang, Jian J
> 主题: RE: [edk2-devel] [Patch V2 17/18] MdeModulePkg:Remove MpSe
Dun:
To be compatible, I suggest to keep the same layout of
SMM_S3_RESUME_STATE. MpService2Ppi field can be kept, but it is not used any
more.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 duntan
> 发送时间: 2024年5月28日 14:35
> 收件人: devel@edk2.groups.io; Tan, Dun ; Liming Gao
>
> 抄
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 duntan
> 发送时间: 2024年5月28日 14:37
> 收件人: devel@edk2.groups.io; Tan, Dun ; Liming Gao
>
> 抄送: Ni, Ray ; Wu, Jiaxin
> 主题: Re: [edk2-devel] [Patch V2 01/18] MdeModulePkg: Add
> gEdkiiS3MtrrSettingGuid
>
> Hi Liming,
>
> Could
week.
Thanks
5. Add more crypt APIs based on Mbedtls (
<https://edk2.groups.io/g/devel/message/118772>
https://edk2.groups.io/g/devel/message/118772)
[Liming] This patch set passes code review in soft feature freeze phase. It
plans to catch this stable tag.
[Mike] This patch se
ch series uses ‘..’ in INF to access source files in another
component. This is not legal. I am surprised this was not caught in code
review.
DEFINE OPENSSL_PATH = ../OpensslLib/openssl
DEFINE BASE_CRYPT_PATH = ../BaseCryptLib
[Mike] I see a reference to some “plat
Jiewen:
If the patch is urgent to be merged, I will help add push label to merge
it with current process.
If the patch is not urgent, it can be merged after TianoCore Code Review
is switched from email to GitHub Pull Requests on US Tuesday.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.
Ray:
This PR doesn’t pass CI. Please check.
Thanks
Liming
发件人: devel@edk2.groups.io 代表 Ni, Ray
发送时间: 2024年5月25日 9:35
收件人: Feng, Ning ; devel@edk2.groups.io; Ni, Ray
; Gao, Liming
主题: Re: [edk2-devel] [PATCH] UefiCpuPkg/MpLib:Do not assume BSP is #0.
I created PR for merge: UefiCpuPkg
Doug:
What’s impact if no EFI_HASH2_PROTOCOL? Does network boot work or not?
Thanks
Liming
发件人: devel@edk2.groups.io 代表 Doug Flick via groups.io
发送时间: 2024年5月25日 0:51
收件人: gaoliming ; devel@edk2.groups.io
主题: Re: [edk2-devel] 回复: [edk2-devel] [PATCH v3 00/20] NetworkPkg:
CVE-2023-45236 a
Hi, all
Because this patch fixes two CVE, I decide to include them in this stable
tag 202405.
https://github.com/tianocore/edk2/pull/5582 has been merged.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 gaoliming via
> groups.io
> 发送时间: 2024年5月24日 22:51
>
te:
> > On Fri, 24 May 2024 at 11:12, gaoliming via groups.io
> > wrote:
> > >
> > > Ard:
> > > Here is Doug PR https://github.com/tianocore/edk2/pull/5582 that
> includes 20 commits. You can check them.
> > >
> >
> > This looks fi
a...@redhat.com; Michael D Kinney
> ; Andrew Fish ;
> quic_llind...@quicinc.com
> 主题: Re: [edk2-devel] [PATCH v3 00/20] NetworkPkg: CVE-2023-45236 and
> CVE-2023-45237
>
> On Fri, 24 May 2024 at 09:01, gaoliming via groups.io
> wrote:
> >
> > Ard and Gerd:
Ard and Gerd:
Doug updated this patch set based on your suggestion. Could you give
reviewed-by or acked-by for the changes in OvmfPkg and ArmVirtPkg if you
have no other comments?
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Doug Flick via
> groups.io
> 发送时间: 2024年5月24日 13:45
>
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Doug Flick via
> groups.io
> 发送时间: 2024年5月24日 13:45
> 收件人: devel@edk2.groups.io
> 抄送: Michael D Kinney ; Liming Gao
> ; Zhiguang Liu
> 主题: [edk2-devel] [PATCH v3 16/20] MdePkg/BaseRngLib AARCH64: Remove
> overzealous ASSERT
Doug:
Have you any update for this patch set?
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Gerd Hoffmann
> 发送时间: 2024年5月17日 17:48
> 收件人: devel@edk2.groups.io; a...@kernel.org
> 抄送: Doug Flick ; Jiewen Yao
> ; Liming Gao (Byosoft address)
>
> 主题: Re: [edk2-devel] 回复: [edk2-deve
Saloni:
Have you any other comments for this patch?
Thanks
Liming
发件人: devel@edk2.groups.io 代表 Doug Flick via groups.io
发送时间: 2024年5月22日 3:29
收件人: Saloni Kasbekar ; devel@edk2.groups.io
主题: Re: [edk2-devel] [PATCH v2 09/13] NetworkPkg: TcpDxe: SECURITY PATCH
CVE-2023-45236
This was m
ould be
good to know if all of the newly added APIs
were tested in a platform integration. A table of the added APIs and the
platform integration test status would be good to
know if there was any functional testing of each API. If there are APIs that
are not covered by any platform integ
Dun:
Is there a Bugzilla for this change?
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 duntan
> 发送时间: 2024年5月17日 17:49
> 收件人: devel@edk2.groups.io
> 抄送: Ray Ni ; Liming Gao ;
> Jiaxin Wu ; Ard Biesheuvel
;
> Leif Lindholm ; Sami Mujawar
> ; Gerd Hoffmann ; Andrew Fish
> ; Jiewe
Patrick:
Commit message needs package name MdePkg.
One comment for the change is below.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Michael Kubacki
> 发送时间: 2024年5月17日 4:20
> 收件人: devel@edk2.groups.io
> 抄送: Liming Gao ; Michael D Kinney
>
> 主题: [edk2-devel] [PATCH v1 1/1]
Abner:
This change is good to me. Reviewed-by: Liming Gao
But, this is not critical issue. So, I suggest to merge it after the stable
tag.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Chang, Abner via
> groups.io
> 发送时间: 2024年5月16日 8:50
> 收件人: Hsueh, Hong-Chih (Neo) ;
> d
would be good to
know if there was any functional testing of each API. If there are APIs that
are not covered by any platform integration
testing, then I would be concerned with such a large change with limited
testing.
Thanks
Liming
发件人: devel@edk2.groups.io <mailto:devel@edk2.groups.io>
Doug:
Thanks for your clarification. For the changes in MdePkg and EmulatorPkg, I
have no comments. Reviewed-by: Liming Gao
Thanks
Liming
发件人: Doug Flick via groups.io
发送时间: 2024年5月10日 2:26
收件人: gaoliming ; devel@edk2.groups.io
主题: Re: [edk2-devel] 回复: [edk2-devel][edk2-stable202405] [
These PRs are all failure. Please update them.
Thanks
Liming
> -邮件原件-
> 发件人: Pethaiyan, Madhan
> 发送时间: 2024年5月13日 20:10
> 收件人: gaoliming ; Kinney, Michael D
> ; devel@edk2.groups.io
> 抄送: Liu, Zhiguang ; Li, Yi1 ; 'GuoX
> Xu'
> 主题: RE: [edk2-devel] [PATCH V1] MdePkg: Update GetImage , G
gaoliming via
groups.io
发送时间: 2024年5月7日 9:25
收件人: devel@edk2.groups.io; annou...@edk2.groups.io
抄送: 'Michael D Kinney' ; 'Andrew Fish'
; 'Leif Lindholm'
主题: [edk2-devel] Soft Feature Freeze starts now for edk2-stable202405
Hi, all
We enter into Soft Feature F
Doug:
From the compatibility point, may PcdEnforceSecureRngAlgorithms default
value be set to FALSE?
Thanks
Liming
发件人: devel@edk2.groups.io 代表 Doug Flick via groups.io
发送时间: 2024年5月10日 2:21
收件人: Ard Biesheuvel ; devel@edk2.groups.io
主题: Re: [edk2-devel] [PATCH v2 03/13] OvmfPkg:Platfor
Sam:
Please help create PR.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Sam Kaynor
> 发送时间: 2024年5月10日 4:51
> 收件人: gaoliming ; devel@edk2.groups.io
> 抄送: 'Ray Ni' ; 'Zhichao Gao' ;
> 'Michael D Kinney' ; 'Zhiguang Liu'
> ; Stuart Yoder
> 主题: Re: [edk2-devel] [PATCH v7 0/5] Addi
It has been merged.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Praveen Sankar
> N via groups.io
> 发送时间: 2024年5月9日 14:33
> 收件人: gaoliming ; devel@edk2.groups.io
> 抄送: Srinivasan Mani ; Sundaresan S
> ; michael.d.kin...@intel.com; zhiguang@intel.com;
> Felix Polyudov ; Rabis
h looks good to me.
Reviewed-by: Sami Mujawar mailto:sami.muja...@arm.com> >
Regards,
Sami Mujawar
From: mailto:devel@edk2.groups.io> > on behalf of
"gaoliming via groups.io" mailto:gaoliming=byosoft.com...@groups.io> >
Reply to: "devel@edk2.grou
Reviewed-by: Yi Li
>
> We want to catch this 202405 stable tag.
> If anyone have feedback, please let me know.
>
> Thanks,
> Wenxing
>
> -----Original Message-
> From: devel@edk2.groups.io On Behalf Of gaoliming
> via group
Doug:
Is there any functionality impact by these two CVE fixes?
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Doug Flick via
> groups.io
> 发送时间: 2024年5月9日 13:56
> 收件人: devel@edk2.groups.io
> 抄送: Liming Gao
> 主题: [edk2-devel] [PATCH v2 00/13] NetworkPkg: CVE-2023-45236 and
> CVE
ate it? I
> > think EDK2 needs ACPI spec to be released to get these definitions
> > added. Also, these are not part of 6.5 and hence names like
> > EFI_ACPI_6_5* are incorrect. So, it will be helpful if you add some
> > commit message why do we need this header.
> >
Sami and Pierre:
What’s your comments for this patch? Is this a required bug fix or new
feature?
Thanks
Liming
发件人: Attar, AbdulLateef (Abdul Lateef)
发送时间: 2024年5月9日 16:39
收件人: gaoliming ; devel@edk2.groups.io
抄送: 'Pierre Gondois' ; 'Sami Mujawar'
主题: Re: [edk2-devel] [edk2-stable202405
Seemly, this change is new feature to add more crypt APIs based on Mbedtls.
This patch set was submitted before soft feature freeze. But, it passed code
review after soft feature freeze starts.
Based on current rule, this patch set is not allowed to be merged for this
stable tag 202405.
If you
Abdul:
Can you give more information why this change is required for this stable
tag 202405?
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Abdul Lateef
> Attar via groups.io
> 发送时间: 2024年5月9日 12:49
> 收件人: devel@edk2.groups.io
> 抄送: Abdul Lateef Attar ; Pierre Gondois
> ; Sami Mu
Ard:
Gerd is the reviewer of OvmfPkg. He gave Acked-by before soft feature freeze.
So, this patch set can be merged for this stable tag 202405.
And, this patch set has been merged.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Ard Biesheuvel
> 发送时间: 2024年5月9日 0:44
> 收件人: W
Reviewed-by: Liming Gao
This is a security fix. So, I think it should catch this stable tag 202405
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Pakkirisamy
> ShanmugavelX
> 发送时间: 2024年5月6日 17:53
> 收件人: devel@edk2.groups.io
> 抄送: Shanmugavel Pakkirisamy ;
> Zhiguang Liu ; Dandan
gt; ; Peter Batard
> 主题: Re: [edk2-devel] pr for stable tag
>
> Yes
>
> On Wed, 8 May 2024 at 17:36, gaoliming via groups.io
> wrote:
> >
> > Ard:
> > So, this patch needs to catch this stable tag. Right?
> >
> > Thanks
> > Liming
> >
Ard:
So, this patch needs to catch this stable tag. Right?
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Ard Biesheuvel
> 发送时间: 2024年5月8日 20:41
> 收件人: Liming Gao (Byosoft address) ; Michael
> Kinney ; Leif Lindholm
> ; edk2-devel-groups-io
> 抄送: Peter Batard
> 主题: [edk2-devel]
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: Chang, Abner
> 发送时间: 2024年5月6日 19:09
> 收件人: Chesley, Brit ; devel@edk2.groups.io
> 抄送: Liming Gao ; Ray Ni ;
Attar,
> AbdulLateef (Abdul Lateef)
> 主题: RE: [PATCH v1 6/6] MdeModulePkg: Adding SpiHc Drivers
>
> [AMD Official Use Only - General]
>
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: Chang, Abner
> 发送时间: 2024年5月6日 19:09
> 收件人: Chesley, Brit ; devel@edk2.groups.io
> 抄送: Liming Gao ; Ray Ni ;
Attar,
> AbdulLateef (Abdul Lateef)
> 主题: RE: [PATCH v1 3/6] MdeModulePkg: Adding SpiBus Drivers
>
> [AMD Official Use Only - General]
>
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: Chang, Abner
> 发送时间: 2024年5月6日 19:08
> 收件人: Chesley, Brit ; devel@edk2.groups.io
> 抄送: Liming Gao ; Ray Ni ;
Attar,
> AbdulLateef (Abdul Lateef)
> 主题: RE: [PATCH v1 4/6] MdeModulePkg:BaseSpiHcPlatformLib: Adding NULL
lib
> instance
>
> [AMD Offic
Yes. I just add PUSH label. If it passes CI, it will be merged.
发件人: devel@edk2.groups.io 代表 Xianglei Cai
发送时间: 2024年5月7日 9:24
收件人: gaoliming ; Shih, More ;
devel@edk2.groups.io
抄送: Ni, Ray ; Lewandowski, Krzysztof
; Huang, Jenny
主题: Re: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Re
I will merge it this week.
发件人: Shih, More
发送时间: 2024年5月6日 11:34
收件人: Cai, Xianglei ; gaoliming
; devel@edk2.groups.io
抄送: Ni, Ray ; Lewandowski, Krzysztof
; Huang, Jenny
主题: Re: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset endpoint
while USB Transaction error
Hi Gaoliming,
Sam:
Thanks for your update. This version patch is good to me. Reviewed-by:
Liming Gao
Besides, is there a Pull Request for this patch set?
Thanks
Liming
> -邮件原件-
> 发件人: Sam Kaynor
> 发送时间: 2024年5月1日 22:58
> 收件人: devel@edk2.groups.io
> 抄送: Ray Ni ; Zhichao Gao ;
> Michael D Kinney ; Lim
Acked-by: Liming Gao
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Dionna Glaze
> via groups.io
> 发送时间: 2024年5月2日 8:50
> 收件人: devel@edk2.groups.io
> 抄送: Dionna Glaze ; Michael D Kinney
> ; Liming Gao ;
> Zhiguang Liu ; Jiewen Yao
> 主题: [edk2-devel] [PATCH v3 1/3] MdePkg: Add TcgSp800155Event3
Felix:
I understand your point. I would suggest to directly add
PI_SPECIFICATION_VERSION definition, and update PEI/DXE/SMM version to align
with it.
Original PEI/DXE/SMM minor and major version definitions are still kept now.
Thanks
Liming
> -邮件原件-
> 发件人: Felix Polyudov
> 发送时间: 2
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: Praveen Sankar N
> 发送时间: 2024年5月2日 19:16
> 收件人: devel@edk2.groups.io
> 抄送: gaolim...@byosoft.com.cn; Srinivasan Mani ;
> Sundaresan S ; michael.d.kin...@intel.com;
> zhiguang@intel.com; Felix Polyudov ; Rabisha R
>
> 主题: [PATCH v4 1/1] MdePkg:
Foster:
This change has been merged.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Nong, Foster
> 发送时间: 2024年4月29日 15:19
> 收件人: devel@edk2.groups.io
> 抄送: Kinney, Michael D ; Liming Gao
> ; Ni, Ray ; Chris Li
>
> 主题: Re: [edk2-devel] [PATCH v2] MdePkg: Add Cxl30.h into
> Indus
I see your patch in ShellPkg. For this change in MdePkg, Reviewed-by: Liming
Gao
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 gaoliming via
> groups.io
> 发送时间: 2024年4月15日 14:33
> 收件人: devel@edk2.groups.io; shenbagade...@ami.com
> 抄送: 'Sainadh
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Shenbagadevi
> R via groups.io
> 发送时间: 2024年4月23日 20:00
> 收件人: devel@edk2.groups.io; Shenbagadevi R
> 抄送: gaolim...@byosoft.com.cn; Sainadh Nagolu ;
> Sundaresan S ; Srinivasan Mani
> ; Ramesh R ; Karthika R
>
> 主题: [edk2-
Praveen:
To be compatible, I would suggest to follow new ACPI version definition to
add new structure for SPCR table version 4, and also need to define version 4
macro.
For example,
#define EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_REVISION_4 0x04
EFI_ACPI_SERIAL_PORT_CONSOLE_RED
Sam:
I would suggest to separate this patch 3/4 to two patches. One is to add UEFI
definition, another is to add EBBR definition. Do you think so?
Thanks
Liming
> -邮件原件-
> 发件人: Sam Kaynor
> 发送时间: 2024年4月29日 21:49
> 收件人: gaoliming ; devel@edk2.groups.io
> 抄送: 'Michael D Kinney' ; 'Zhigua
From: dylanlhdu
Signed-off-by: Lingheng Du
Reviewed-by: Song Huang
Reviewed-by: Bing Fan
---
.../Include/IndustryStandard/AcpiRiscv64.h| 176 ++
1 file changed, 176 insertions(+)
create mode 100644 edk2/MdePkg/Include/IndustryStandard/AcpiRiscv64.
Sam:
I don't find EFI_CONFORMANCE_PROFILE_EBBR_2_1_GUID definition in UEFI 2.10
spec. So, what's its definition from?
Thanks
Liming
> -邮件原件-
> 发件人: Sam Kaynor
> 发送时间: 2024年4月27日 1:53
> 收件人: devel@edk2.groups.io
> 抄送: Michael D Kinney ; Liming Gao
> ; Zhiguang Liu
> 主题: [PATCH v6 3/4] M
Praveen:
I want to know what will happen if the platform doesn't make changes with the
updated table.
According to its impact, we can make direction how and when to merge this
patch.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Praveen
> Sankar N via groups.io
> 发送时间: 20
Foster:
There is CI failure in https://github.com/tianocore/edk2/pull/5585. Please
resolve them first.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 gaoliming via
> groups.io
> 发送时间: 2024年4月23日 21:15
> 收件人: 'Nong, Foster' ; devel@edk2.groups.io;
>
Felix and Sachin:
I don't find PI_SPECIFICATION_MINOR_REVISION definition from the latest
public PI 1.8A. So, this change may not be added now.
Thanks
Liming
> -邮件原件-
> 发件人: Sachin Ganesh
> 发送时间: 2024年4月25日 17:57
> 收件人: Felix Polyudov ; gaoliming
> ; devel@edk2.groups.io
> 抄送: zhiguan
Can you create PR for this patch? If it passes CI, I will add push label.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Xianglei Cai
> 发送时间: 2024年4月25日 17:58
> 收件人: gaoliming ; devel@edk2.groups.io
> 抄送: Ni, Ray ; Lewandowski, Krzysztof
> ; Huang, Jenny ;
> Shih, More
> 主题: Re:
Except for Patch 6/7, others are good to me. Reviewed-by: Liming Gao
I suggest to merge others first. The patch 6/7 to update PI version from 1.7
to 1.8 can be discussed first.
Thanks
Liming
> -邮件原件-
> 发件人: Sachin Ganesh
> 发送时间: 2024年4月20日 5:46
> 收件人: devel@edk2.groups.io
> 抄送: gaolim.
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Guo, Gua
> 发送时间: 2024年4月22日 9:50
> 收件人: devel@edk2.groups.io
> 抄送: gua@intel.com; Rebecca Cran ; Liming Gao
> ; Bob Feng ; Yuwei Chen
>
> 主题: [edk2-devel] [PATCH v1 1/1] BaseTools/Fmmt.py: Python 3.12 support
>
> From:
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Guo, Gua
> 发送时间: 2024年4月21日 20:51
> 收件人: devel@edk2.groups.io
> 抄送: gua@intel.com; saloni.kasbe...@intel.com; Rebecca Cran
> ; Liming Gao ; Bob Feng
> ; Yuwei Chen
> 主题: [edk2-devel] [PATCH v1 1/1] BaseTools/GetUtcDateT
Seemly, this is an incompatible change. What's impact with this change?
Thanks
Liming
> -邮件原件-
> 发件人: Praveen Sankar N
> 发送时间: 2024年4月22日 19:26
> 收件人: devel@edk2.groups.io
> 抄送: michael.d.kin...@intel.com; gaolim...@byosoft.com.cn;
> zhiguang@intel.com; Felix Polyudov ; Srinivasan Man
Seemly, there is no other comments. I create PR
https://github.com/tianocore/edk2/pull/5585 to merge it.
Thanks
Liming
> -邮件原件-
> 发件人: Nong, Foster
> 发送时间: 2024年4月23日 18:07
> 收件人: gaoliming ; devel@edk2.groups.io;
> Kinney, Michael D ; 'Chris Li'
>
> 抄送: Ni, Ray
> 主题: RE: [edk2-devel]
Ashraf:
I just merge it.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Ashraf Ali S
> 发送时间: 2024年4月17日 16:36
> 收件人: devel@edk2.groups.io; S, Ashraf Ali ;
Chen,
> Christine ; Rebecca Cran ;
> Liming Gao
> 抄送: Feng, Bob C ; Chaganty, Rangasai V
>
> 主题: Re: [edk2-devel] [PATCH]
Sami:
I have no comments for this change. Acked-by: Liming Gao
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Sami
> Mujawar
> 发送时间: 2024年4月16日 11:51
> 收件人: devel@edk2.groups.io; rebe...@bsdio.com;
> gaolim...@byosoft.com.cn; bob.c.f...@intel.com; yuwei.c...@intel.com
> 抄送: Yeo
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: Sachin Ganesh
> 发送时间: 2024年4月16日 3:28
> 收件人: devel@edk2.groups.io
> 抄送: gaolim...@byosoft.com.cn; michael.d.kin...@intel.com;
> zhiguang@intel.com; Felix Polyudov ; Dhanaraj V
> ; Sachin Ganesh
> 主题: [PATCH v2 1/5] MdePkg: Add definition for N
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Xianglei Cai
> 发送时间: 2024年4月15日 14:55
> 收件人: devel@edk2.groups.io
> 抄送: Xianglei Cai ; Ray Ni ;
> Liming Gao ; Krzysztof Lewandowski
> ; Jenny Huang ;
> More Shih
> 主题: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Rese
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: Xianglei Cai
> 发送时间: 2024年4月15日 14:34
> 收件人: devel@edk2.groups.io
> 抄送: Xianglei Cai ; Ray Ni ;
> Liming Gao ; Krzysztof Lewandowski
> ; Jenny Huang ;
> More Shih ; Ian Chiu
> 主题: [PATCH V3 1/1] MdeModulePkg/XhciDxe: Add PCD for the delay of
> HCR
Xianglei:
I understand this issue now. I suggest to add the internal definition in
XhciDxe module for transaction error type, such as EDKII_USB_ERR_TRANSACTION.
It can avoid the change in UEFI UsbIo protocol.
Thanks
Liming
发件人: Cai, Xianglei
发送时间: 2024年4月15日 13:27
收件人: gaoliming ; Ni,
Shenbagadevi:
I think you still need to update ShellPkg SmbiosView to support the
updated TYPE17.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Shenbagadevi
> R via groups.io
> 发送时间: 2023年11月17日 18:05
> 收件人: devel@edk2.groups.io; Shenbagadevi R
> 抄送: gaolim...@byosoft.com.cn; S
The change in DSC is not required. PCD default value is from DEC.
Thanks
Liming
> -邮件原件-
> 发件人: Xianglei Cai
> 发送时间: 2024年4月15日 14:25
> 收件人: devel@edk2.groups.io
> 抄送: Xianglei Cai ; Ray Ni ;
> Liming Gao ; Krzysztof Lewandowski
> ; Jenny Huang ;
> More Shih ; Ian Chiu
> 主题: [PATCH V2 1
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Qingyu
> 发送时间: 2024年4月2日 11:56
> 收件人: devel@edk2.groups.io
> 抄送: Dandan Bi ; Liming Gao
>
> 主题: [edk2-devel] [edk2-platforms][PATCH] VirtualKeyboardFeaturePkg:
> Update the comments of ReadKeyStroke and ReadKeyStrokeEx - ma
Xianglei:
Now, UEFI spec doesn’t define EFI_USB_ERR_TRANSACTION. So, we can’t
update UsbIo.h now.
EFI_USB_ERR_TRANSACTION is only used in XhciDxe for error condition check.
I suggest to add comments for current code, don’t need code update.
Thanks
Liming
发件人: Ni, Ray
发送时间: 2024年4
I suggest to define this PCD in MdeModulePkg instead of MdePkg. This PCD is
only consumed by MdeModulePkg XhciDxe module.
Thanks
Liming
发件人: Cai, Xianglei
发送时间: 2024年4月12日 9:54
收件人: Lewandowski, Krzysztof ;
devel@edk2.groups.io; Ni, Ray ; Liming Gao
抄送: Huang, Jenny ; Shih, More
; Chiu, I
gt; instead of
>
> `LibraryClass[4:].isdigit()`
>
> Can you re-review with this change?
>
> -Taylor
>
> On 4/1/2024 6:37 PM, gaoliming via groups.io wrote:
> > Taylor:
> >Thanks for you detail information. I understand this problem. I agree
> your f
Reviewed-by: Liming Gao for this patch set.
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Jason Lou
> 发送时间: 2024年4月14日 23:24
> 收件人: devel@edk2.groups.io
> 抄送: Jason Lou ; Zhiguang Liu
;
> Dandan Bi ; Star Zeng ; Zhichao
> Gao ; Benny Lin ; Gua Guo
> ; Michael D Kinney ;
> Liming Gao
> 主题: [e
PR https://github.com/tianocore/edk2/pull/5539 has been created.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Aaron Li
> 发送时间: 2024年4月1日 10:32
> 收件人: devel@edk2.groups.io; Liming Gao
> 抄送: Bi, Dandan ; Liu, Yun Y ;
> Yao, Jiewen ; Ni, Ray ; Kinney,
> Michael D ; Liu, Zhiguang
>
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Wenxing Hou
> 发送时间: 2024年4月8日 9:47
> 收件人: devel@edk2.groups.io
> 抄送: Michael D Kinney ; Liming Gao
> ; Zhiguang Liu ; Jiewen
> Yao
> 主题: [edk2-devel] [PATCH v2 3/9] MdePkg: Add devAuthBoot GlobalVariable
>
> According to U
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: Qingyu
> 发送时间: 2024年4月8日 17:28
> 收件人: devel@edk2.groups.io
> 抄送: Liming Gao ; Michael D Kinney
> ; Zhiguang Liu ;
> Gahan Saraiya
> 主题: [PATCH] MdePkg: Update the comments of GetInformation function
>
> Refer to Uefi spec 2.10 section 11.11.2, ad
Abner:
The change is good to me. Reviewed-by: Liming Gao
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Chang, Abner
> via groups.io
> 发送时间: 2024年4月4日 17:25
> 收件人: devel@edk2.groups.io
> 抄送: Michael D Kinney ; Liming Gao
> ; Zhiguang Liu ; Abdul
> Lateef Attar ; Hao A Wu ; Ray N
Taylor:
Thanks for you detail information. I understand this problem. I agree your
fix. Reviewed-by: Liming Gao
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Taylor Beebe
> 发送时间: 2024年3月29日 8:28
> 收件人: gaoliming ; devel@edk2.groups.io
> 抄送: 'Rebecca Cran' ; 'Bob Feng'
> ; 'Yuw
Aaron:
Per the specification, it is valid to publish all ACPI table in
EfiAcpiMemoryNVS.
So, I have no other comments for this patch. Reviewed-by: Liming Gao
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Aaron Li
> 发送时间: 2024年4月1日 10:32
> 收件人: devel@edk2.groups.io; Liming Ga
Zifang and Yuting:
The change looks good. But, there are two ways for error report. One is
gCVfrErrorHandle.HandleWarning, another is DefaultValueError. Can we always
use gCVfrErrorHandle.HandleWarning?
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Zhang, Zifeng
> 发送时间: 2024年3月2
Aaron:
Is there a Bugzilla for this issue? What problem will be resolved with this
change?
Thanks
Liming
> -邮件原件-
> 发件人: Aaron Li
> 发送时间: 2024年3月26日 15:58
> 收件人: devel@edk2.groups.io
> 抄送: Zhiguang Liu ; Dandan Bi
> ; Liming Gao ; Liu Yun
> ; Jiewen Yao ; Ray Ni
> ; Michael D Kinney
>
Seemly, this change has no other impact. I agree this change.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Chiu, Ian
> 发送时间: 2024年3月14日 21:40
> 收件人: devel@edk2.groups.io
> 抄送: Ian Chiu ; Hao A Wu ; Ray
> Ni ; More Shih
> 主题: [edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Increase 1
Madhan:
I have no comments for this patch set. Reviewed-by: Liming Gao
Have you create Edk2 PR to verify the changes?
Thanks
Liming
> -邮件原件-
> 发件人: Pethaiyan, Madhan
> 发送时间: 2024年3月14日 16:17
> 收件人: Kinney, Michael D ;
> devel@edk2.groups.io
> 抄送: Liming Gao ; Liu, Zhiguang
> ; Li,
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: Wenxing Hou
> 发送时间: 2024年3月27日 14:16
> 收件人: devel@edk2.groups.io
> 抄送: Michael D Kinney ; Liming Gao
> ; Zhiguang Liu ; Jiewen
> Yao
> 主题: [PATCH v3 1/2] MdePkg: Add UEFI 2.10 DeviceAuthentication
>
> According to UEFI 2.10 spec
> 32.8.2 UEFI Dev
Can you submit a Bugzilla for this problem?
Can you give one example to explain the incorrect usage?
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Taylor Beebe
> 发送时间: 2024年3月23日 3:19
> 收件人: devel@edk2.groups.io
> 抄送: Rebecca Cran ; Liming Gao
> ; Bob Feng ; Yuwei Chen
>
> 主题:
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Wenxing Hou
> 发送时间: 2024年3月6日 11:24
> 收件人: devel@edk2.groups.io
> 抄送: Michael D Kinney ; Liming Gao
> ; Zhiguang Liu ; Jiewen
> Yao
> 主题: [edk2-devel] [PATCH v2 2/2] MdePkg: Add
> gEfiDeviceSignatureDatabaseGuid to dec
>
>
1 - 100 of 656 matches
Mail list logo