Re: [Devel] Patch with 3 improvements/fixes

[Paul Bagyenda]

Applied, thanks. Paul.On Feb 11, 2014, at 12:54, Jacek Raczkiewicz  wrote:Hello, Here is another patch containing allow-adaptations setting for MMSC. It allows setup allow-adaptations=0/1 in the mmsbox.conf for each MMSC, this value is overwritten by the allow-adaptations passed in the sendmms request. By default (if nothing setup) it is set to true.
Regards,Jacek Raczkiewicz2014-01-23 18:27 GMT+01:00 Jacek Raczkiewicz :
I have extracted the patch agains not updated version of mbuni.Apparently point 3) is already in the code base.
Please find the updated patch with only point 1) and 2)
2014/1/23 Jacek Raczkiewicz 

Hello, It this patch we have 3 improvement/fixes:1) when no-archive passed inside the DB connection string it is detected but NOT stripped from the connection string and bcz of that it is causing the database connection to fail. This issue has been fixed.


2) In order to make work SMIL with utf-8 data encoded  in it (subject mostly) we need to parse it with different function and enforce the UTF-8 encoding on it. I also have added the UTF-8 encoding on the text files attached to MM7 SOAP request. Before it was empty and any UTF-8 chars in subject/MMS text were not displayed properly on the handset. For now it is hardcoded to UTF-8


3) When mbuni sends to MMSC and get 'not-success' status it will retry (if that is allowed) up to max-retry times. I have improve this feature by adding the ability to customize the 'retry statuses'. Some statuses from MMSC may be for permanent errors and retrying will not change anything, some may be temprorary. Now user can set which errors should be retried  and the rest will not be retried.


Please review these changes and merge them into mbuni code base.Regards,Jacek Raczkiewicz


___Devel mailing listDevel@mbuni.orghttp://lists.mbuni.org/mailman/listinfo/devel
Paul BAGYENDALogos Solvo LtdTel: +230 465 9761Suite 6B, 6th FloorEbène Mews57 Ebène Cyber CityEbène, MauritiusWeb: http://www.logossolvo.com  Confidentiality: This message and its attachments are confidential and are solely intended for the named above. Should you have received this message in error, you may not use or disclose any information contained; please reply to this message, inform the sender about the error and delete all copies of this message. Security Warning: Please be aware that email is not an absolute secure communication medium, as messages sent by email can be intercepted, corrupted, lost, destroyed or arrive late or incomplete without knowledge of the sender or the recipient. Please take this lack of integrity and confidentiality into account when exchanging messages via email with Logos Solvo Ltd. Viruses: Logos Solvo has taken reasonable steps to ensure this message and its attachments are free from viruses. We advise all recipients to follow good computing practices and ensure that messages received via email and any attachments are actually virus free prior to opening or forwarding. 

___
Devel mailing list
Devel@mbuni.org
http://lists.mbuni.org/mailman/listinfo/devel

Re: [Devel] Patch with 3 improvements/fixes

[Jacek Raczkiewicz]

Here is same patch just cleaned up.


2014-02-11 10:54 GMT+01:00 Jacek Raczkiewicz :

> Hello,
>
> Here is another patch containing allow-adaptations setting for MMSC. It
> allows setup allow-adaptations=0/1 in the mmsbox.conf for each MMSC, this
> value is overwritten by the allow-adaptations passed in the sendmms
> request. By default (if nothing setup) it is set to true.
>
> Regards,
> Jacek Raczkiewicz
>
>
> 2014-01-23 18:27 GMT+01:00 Jacek Raczkiewicz 
> :
>
> I have extracted the patch agains not updated version of mbuni.
>> Apparently point 3) is already in the code base.
>>
>> Please find the updated patch with only point 1) and 2)
>>
>>
>>
>> 2014/1/23 Jacek Raczkiewicz 
>>
>>> Hello,
>>>
>>> It this patch we have 3 improvement/fixes:
>>>
>>> 1) when *no-archive* passed inside the DB connection string it is
>>> detected but NOT stripped from the connection string and bcz of that it is
>>> causing the database connection to fail. This issue has been fixed.
>>>
>>> 2) In order to make work SMIL with utf-8 data encoded  in it (subject
>>> mostly) we need to parse it with different function and enforce the UTF-8
>>> encoding on it. I also have added the UTF-8 encoding on the text files
>>> attached to MM7 SOAP request. Before it was empty and any UTF-8 chars in
>>> subject/MMS text were not displayed properly on the handset. For now it is
>>> hardcoded to UTF-8
>>>
>>> 3) When mbuni sends to MMSC and get 'not-success' status it will retry
>>> (if that is allowed) up to *max-retry* times. I have improve this
>>> feature by adding the ability to customize the 'retry statuses'. Some
>>> statuses from MMSC may be for permanent errors and retrying will not change
>>> anything, some may be temprorary. Now user can set which errors should be
>>> retried  and the rest will not be retried.
>>>
>>> Please review these changes and merge them into mbuni code base.
>>>
>>> Regards,
>>> Jacek Raczkiewicz
>>>
>>
>>
>


allow-adaptations.patch
Description: Binary data
___
Devel mailing list
Devel@mbuni.org
http://lists.mbuni.org/mailman/listinfo/devel

Re: [Devel] Patch with 3 improvements/fixes

[Jacek Raczkiewicz]

Hello,

Here is another patch containing allow-adaptations setting for MMSC. It
allows setup allow-adaptations=0/1 in the mmsbox.conf for each MMSC, this
value is overwritten by the allow-adaptations passed in the sendmms
request. By default (if nothing setup) it is set to true.

Regards,
Jacek Raczkiewicz


2014-01-23 18:27 GMT+01:00 Jacek Raczkiewicz :

> I have extracted the patch agains not updated version of mbuni.
> Apparently point 3) is already in the code base.
>
> Please find the updated patch with only point 1) and 2)
>
>
>
> 2014/1/23 Jacek Raczkiewicz 
>
>> Hello,
>>
>> It this patch we have 3 improvement/fixes:
>>
>> 1) when *no-archive* passed inside the DB connection string it is
>> detected but NOT stripped from the connection string and bcz of that it is
>> causing the database connection to fail. This issue has been fixed.
>>
>> 2) In order to make work SMIL with utf-8 data encoded  in it (subject
>> mostly) we need to parse it with different function and enforce the UTF-8
>> encoding on it. I also have added the UTF-8 encoding on the text files
>> attached to MM7 SOAP request. Before it was empty and any UTF-8 chars in
>> subject/MMS text were not displayed properly on the handset. For now it is
>> hardcoded to UTF-8
>>
>> 3) When mbuni sends to MMSC and get 'not-success' status it will retry
>> (if that is allowed) up to *max-retry* times. I have improve this
>> feature by adding the ability to customize the 'retry statuses'. Some
>> statuses from MMSC may be for permanent errors and retrying will not change
>> anything, some may be temprorary. Now user can set which errors should be
>> retried  and the rest will not be retried.
>>
>> Please review these changes and merge them into mbuni code base.
>>
>> Regards,
>> Jacek Raczkiewicz
>>
>
>


allow-adaptations.patch
Description: Binary data
___
Devel mailing list
Devel@mbuni.org
http://lists.mbuni.org/mailman/listinfo/devel

Re: [Devel] Patch with 3 improvements/fixes

[Jacek Raczkiewicz]

I have extracted the patch agains not updated version of mbuni.
Apparently point 3) is already in the code base.

Please find the updated patch with only point 1) and 2)



2014/1/23 Jacek Raczkiewicz 

> Hello,
>
> It this patch we have 3 improvement/fixes:
>
> 1) when *no-archive* passed inside the DB connection string it is
> detected but NOT stripped from the connection string and bcz of that it is
> causing the database connection to fail. This issue has been fixed.
>
> 2) In order to make work SMIL with utf-8 data encoded  in it (subject
> mostly) we need to parse it with different function and enforce the UTF-8
> encoding on it. I also have added the UTF-8 encoding on the text files
> attached to MM7 SOAP request. Before it was empty and any UTF-8 chars in
> subject/MMS text were not displayed properly on the handset. For now it is
> hardcoded to UTF-8
>
> 3) When mbuni sends to MMSC and get 'not-success' status it will retry (if
> that is allowed) up to *max-retry* times. I have improve this feature by
> adding the ability to customize the 'retry statuses'. Some statuses from
> MMSC may be for permanent errors and retrying will not change anything,
> some may be temprorary. Now user can set which errors should be retried
>  and the rest will not be retried.
>
> Please review these changes and merge them into mbuni code base.
>
> Regards,
> Jacek Raczkiewicz
>


utf-8.1.patch
Description: Binary data
___
Devel mailing list
Devel@mbuni.org
http://lists.mbuni.org/mailman/listinfo/devel