Re: [Devel] Re: [PATCH] MM7_SOAP_COMMAND_REJECTED error 3005

2007-03-21 Thread Vincent CHAVANIS

ok forget my previous message,

Here is the patch with the good filename

--- /mbuni-cvs/mmsbox/bearerbox.c   2007-01-31 10:08:20.0 +0100
+++ /mbuni/mmsbox/bearerbox.c   2007-03-13 23:55:10.0 +0100
@@ -597,12 +609,12 @@
 } else
 tstatus = MM7_SOAP_FORMAT_CORRUPT;

- if (!MM7_SOAP_STATUS_OK(tstatus)) {
+ if (!MM7_SOAP_STATUS_OK(tstatus) && tstatus != 
MM7_SOAP_COMMAND_REJECTED) {
 Octstr *detail =  mm7_soap_header_value(mresp, 
octstr_imm("Details"));

 if (detail == NULL)
  mm7_soap_header_value(mresp, octstr_imm("faultcode"));
 ret = NULL;



- Original Message - 
From: "Vincent CHAVANIS" <[EMAIL PROTECTED]>
To: "Paul Bagyenda" <[EMAIL PROTECTED]>; "Mbuni MMS Gateway Developers" 


Sent: Wednesday, March 21, 2007 4:20 PM
Subject: Re: [Devel] Re: [PATCH] MM7_SOAP_COMMAND_REJECTED error 3005



Sorry,

This was not the good file.
I see that you have made the changes Thansk !

Vincent.



- Original Message - 
From: "Paul Bagyenda" <[EMAIL PROTECTED]>

To: "Mbuni MMS Gateway Developers" 
Sent: Monday, March 19, 2007 11:26 AM
Subject: [Devel] Re: [PATCH] MM7_SOAP_COMMAND_REJECTED error 3005



Hi Vincent,

 Please clarify this patch:
1) The changes to mms_util.h are nowhere in mbuni CVS
2) The error you mention would not cause a re-queueing of the message 
anyway.


P.

On Mar 14, 2007, at 02:20, Vincent CHAVANIS wrote:


Hi all,

Thi patch fixes the command rejected 3005 from the MMSC
A rejected command should not be requeued to be send later.

Vincent.



diff -rbau /mbuni-cvs/mmlib/mms_mm7soap.h /mbuni/mmlib/mms_mm7soap.h
--- /mbuni-cvs/mmlib/mms_mm7soap.h  2006-11-28  13:00:20.0 
+0100

+++ /mbuni/mmlib/mms_mm7soap.h  2007-03-12 17:52:54.0 +0100
@@ -16,6 +16,7 @@

#define MM7_SOAP_OK 1000
#define MM7_SOAP_FORMAT_CORRUPT 2007
+#define MM7_SOAP_COMMAND_REJECTED 3005
#define MM7_SOAP_UNSUPPORTED_OPERATION 4003
#define MM7_SOAP_STATUS_OK(e) ((e) / 1000 == 1)
#define  MM7_DEFAULT_VERSION "5.3.0"


diff -rbau /mbuni-cvs/mmlib/mms_util.h /mbuni/mmlib/mms_util.h
--- /mbuni-cvs/mmlib/mms_util.h 2006-11-25 12:53:40.0 +0100
+++ /mbuni/mmlib/mms_util.h 2007-01-23 11:21:41.0 +0100
@@ -597,12 +609,12 @@
 } else
 tstatus = MM7_SOAP_FORMAT_CORRUPT;

- if (!MM7_SOAP_STATUS_OK(tstatus)) {
+ if (!MM7_SOAP_STATUS_OK(tstatus) && tstatus != 
MM7_SOAP_COMMAND_REJECTED) {
 Octstr *detail =  mm7_soap_header_value(mresp, octstr_imm 
("Details"));

 if (detail == NULL)
  mm7_soap_header_value(mresp, octstr_imm("faultcode"));
 ret = NULL;



--
Telemaque - 06560 SOPHIA-ANTIPOLIS - (FR)
Service Technique/Reseau - NOC
Developpement SMS/MMS/Kiosques
http://www.telemaque.fr/
[EMAIL PROTECTED]
Tel : +33 4 92 90 99 84 (fax 9142)



___
Devel mailing list
Devel@mbuni.org
http://lists.mbuni.org/mailman/listinfo/devel



___
Devel mailing list
Devel@mbuni.org
http://lists.mbuni.org/mailman/listinfo/devel




___
Devel mailing list
Devel@mbuni.org
http://lists.mbuni.org/mailman/listinfo/devel


Re: [Devel] Re: [PATCH] MM7_SOAP_COMMAND_REJECTED error 3005

2007-03-21 Thread Vincent CHAVANIS

Sorry,

This was not the good file.
I see that you have made the changes 
Thansk !


Vincent.



- Original Message - 
From: "Paul Bagyenda" <[EMAIL PROTECTED]>

To: "Mbuni MMS Gateway Developers" 
Sent: Monday, March 19, 2007 11:26 AM
Subject: [Devel] Re: [PATCH] MM7_SOAP_COMMAND_REJECTED error 3005



Hi Vincent,

 Please clarify this patch:
1) The changes to mms_util.h are nowhere in mbuni CVS
2) The error you mention would not cause a re-queueing of the message  
anyway.


P.

On Mar 14, 2007, at 02:20, Vincent CHAVANIS wrote:


Hi all,

Thi patch fixes the command rejected 3005 from the MMSC
A rejected command should not be requeued to be send later.

Vincent.



diff -rbau /mbuni-cvs/mmlib/mms_mm7soap.h /mbuni/mmlib/mms_mm7soap.h
--- /mbuni-cvs/mmlib/mms_mm7soap.h  2006-11-28  
13:00:20.0 +0100

+++ /mbuni/mmlib/mms_mm7soap.h  2007-03-12 17:52:54.0 +0100
@@ -16,6 +16,7 @@

#define MM7_SOAP_OK 1000
#define MM7_SOAP_FORMAT_CORRUPT 2007
+#define MM7_SOAP_COMMAND_REJECTED 3005
#define MM7_SOAP_UNSUPPORTED_OPERATION 4003
#define MM7_SOAP_STATUS_OK(e) ((e) / 1000 == 1)
#define  MM7_DEFAULT_VERSION "5.3.0"


diff -rbau /mbuni-cvs/mmlib/mms_util.h /mbuni/mmlib/mms_util.h
--- /mbuni-cvs/mmlib/mms_util.h 2006-11-25 12:53:40.0 +0100
+++ /mbuni/mmlib/mms_util.h 2007-01-23 11:21:41.0 +0100
@@ -597,12 +609,12 @@
 } else
 tstatus = MM7_SOAP_FORMAT_CORRUPT;

- if (!MM7_SOAP_STATUS_OK(tstatus)) {
+ if (!MM7_SOAP_STATUS_OK(tstatus) && tstatus !=  
MM7_SOAP_COMMAND_REJECTED) {
 Octstr *detail =  mm7_soap_header_value(mresp, octstr_imm 
("Details"));

 if (detail == NULL)
  mm7_soap_header_value(mresp, octstr_imm("faultcode"));
 ret = NULL;



--
Telemaque - 06560 SOPHIA-ANTIPOLIS - (FR)
Service Technique/Reseau - NOC
Developpement SMS/MMS/Kiosques
http://www.telemaque.fr/
[EMAIL PROTECTED]
Tel : +33 4 92 90 99 84 (fax 9142)



___
Devel mailing list
Devel@mbuni.org
http://lists.mbuni.org/mailman/listinfo/devel



___
Devel mailing list
Devel@mbuni.org
http://lists.mbuni.org/mailman/listinfo/devel