On Mon, Oct 26, 2015 at 1:05 PM, Luis Araneda wrote:
> Hi,
>
> You're right on that these pins aren't currently in use by any .dts
> file, but the manufacturer, Sinovoip,
> should be submitting a .dts file for the board soon, and if they
> don't, I'm sure the Linux-Sunxi community will do.
> You c
In order to manage in a better way the nci poll mode state machine, add
mode parameter to deactivate_target functions. This way we can manage
different target state. mode parameter make sense only in nci core.
Signed-off-by: Christophe Ricard
---
include/net/nfc/nfc.h | 2 +-
net/nfc/core.c
Add a minor code style fixes
Cc: sta...@vger.kernel.org
Signed-off-by: Christophe Ricard
---
drivers/nfc/st21nfca/core.c | 2 --
drivers/nfc/st21nfca/i2c.c | 1 +
drivers/nfc/st21nfca/se.c | 2 +-
3 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/nfc/st21nfca/core.c b/dri
Potentially an unexpected HCI event may occur because of a firmware bug.
It could be transparent for the user but at least log this.
Signed-off-by: Christophe Ricard
---
drivers/nfc/st21nfca/core.c | 2 ++
drivers/nfc/st21nfca/dep.c | 1 +
drivers/nfc/st21nfca/se.c | 4
3 files changed,
Remove SPI_DUMP_SKB and I2C_DUMP_SKB as skb is already dumped in ndlc
layer.
Cc: sta...@vger.kernel.org
Signed-off-by: Christophe Ricard
---
drivers/nfc/st-nci/i2c.c | 11 ---
drivers/nfc/st-nci/spi.c | 11 ---
2 files changed, 22 deletions(-)
diff --git a/drivers/nfc/st-nci/i2c
Add support for proprietary commands useful mainly for factory testings.
Here is a list:
- FACTORY_MODE: Allow to set the driver into a mode where no secure element
are activated. It does not consider any NFC_ATTR_VENDOR_DATA.
- HCI_CLEAR_ALL_PIPES: Allow to execute a HCI clear all pipes command.
I
A secure element can be activated in different order. The host_list is
updated keeping a fixed order: .
Cc: sta...@vger.kernel.org
Signed-off-by: Christophe Ricard
---
drivers/nfc/st21nfca/se.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/nfc/st21nfca/se.c b
A secure element can be activated in different order. The host_list is
updated keeping a fixed order: .
Cc: sta...@vger.kernel.org
Signed-off-by: Christophe Ricard
---
drivers/nfc/st-nci/se.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/nfc/st-nci/se.c b/dri
Add some few code style fixes.
Cc: sta...@vger.kernel.org
Signed-off-by: Christophe Ricard
---
drivers/nfc/st-nci/i2c.c | 2 +-
drivers/nfc/st-nci/se.c | 2 +-
net/nfc/nci/hci.c| 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/nfc/st-nci/i2c.c b/drivers/nfc/
Upon some conditions (timing, CLF errors, platform errors...), the irq might
be already active when powering the device.
Add irq_active variable as a guard to avoid kernel warning message
Signed-off-by: Christophe Ricard
---
drivers/nfc/st-nci/i2c.c | 8 +++-
drivers/nfc/st-nci/spi.c | 8 ++
Replace 1 missing st21nfcb by st_nci
Signed-off-by: Christophe Ricard
---
drivers/nfc/st-nci/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nfc/st-nci/Makefile b/drivers/nfc/st-nci/Makefile
index ea40ace..439b2fa 100644
--- a/drivers/nfc/st-nci/Makefile
+++
NFC_HCI_LINK_MGMT_PIPE was never open in nfc_hci_load_session.
Cc: sta...@vger.kernel.org
Signed-off-by: Christophe Ricard
---
drivers/nfc/st21nfca/core.c | 19 +--
1 file changed, 5 insertions(+), 14 deletions(-)
diff --git a/drivers/nfc/st21nfca/core.c b/drivers/nfc/st21nfca/c
It is useless to start from index 0 when looking for a gate because only
dynamic pipes are retrieved with
ST21NFCA_DM_GETINFO(ST21NFCA_DM_GETINFO_PIPE_LIST).
The first dynamic pipe is present at index 3.
Cc: sta...@vger.kernel.org
Signed-off-by: Christophe Ricard
---
drivers/nfc/st21nfca/core.
NFC_CMD_ACTIVATE_TARGET and NFC_ATTR_SE_PARAMS comments are missing.
Signed-off-by: Christophe Ricard
---
include/uapi/linux/nfc.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/uapi/linux/nfc.h b/include/uapi/linux/nfc.h
index dd3f753..399f39f 100644
--- a/include/uapi/linux/nfc.
When initializing ndev->hci_dev->init_data, only gates field was set.
gate_count needs to be initialized as well.
Cc: sta...@vger.kernel.org
Signed-off-by: Christophe Ricard
---
drivers/nfc/st-nci/se.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/nfc/st-nci/se.c b/drivers/nfc/st-n
From: Wang Dongsheng
RCPM is the Run Control and Power Management module performs all
device-level tasks associated with device run control and power
management.
Add this for freescale powerpc platform and layerscape platform.
Signed-off-by: Chenhui Zhao
Signed-off-by: Tang Yuantian
Signed-of
After internal discussion, it appears this timing should be increase to
20 ms for interoperability reason.
Signed-off-by: Christophe Ricard
---
drivers/nfc/st-nci/se.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nfc/st-nci/se.c b/drivers/nfc/st-nci/se.c
index 147e
It is useless to start from index 0 when looking for a gate because only
dynamic pipes are retrieved with ST_NCI_DM_GETINFO(ST_NCI_DM_GETINFO_PIPE_LIST).
The first dynamic pipe is present at index 3.
Cc: sta...@vger.kernel.org
Signed-off-by: Christophe Ricard
---
drivers/nfc/st-nci/se.c | 2 +-
We need to keep initial st_nci_gates values in order for
nfc_hci_dev_connect_gates to create and open pipe when necessary.
For example after a firmware update CLF pipes are cleared. Changing pipe
values in st21nfca_gates was causing nfc_hci_dev_connect_gates not using
accurate pipes value.
Cc: st
NCI_HCI_IDENTITY_MGMT_GATE might be useful to get information for example
about hardware or firmware version.
Signed-off-by: Christophe Ricard
---
drivers/nfc/st-nci/se.c| 3 +++
include/net/nfc/nci_core.h | 1 +
2 files changed, 4 insertions(+)
diff --git a/drivers/nfc/st-nci/se.c b/driver
Potentially an unexpected HCI event may occur because of a firmware bug.
It could be transparent for the user but at least log this.
Signed-off-by: Christophe Ricard
---
drivers/nfc/st-nci/se.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/nfc/st-nci/se.c b/drivers/nfc/st-nci
Add support for proprietary commands useful mainly for factory testings.
Here is a list:
- FACTORY_MODE: Allow to set the driver into a mode where no secure element
are activated. It does not consider any NFC_ATTR_VENDOR_DATA.
- HCI_CLEAR_ALL_PIPES: Allow to execute a HCI clear all pipes command.
I
We need to keep initial st_nci_gates values in order for
nci_hci_dev_connect_gates to create and open pipe when necessary.
For example after a firmware update CLF pipes are cleared. Changing pipe
values in st_nci_gates was causing nci_hci_dev_connect_gates not using
accurate pipes value.
Cc: sta.
In order to align with st21nfca, dts configuration properties ese_present
and uicc_present are made available in st-nci driver.
So far, in early development firmware, because nci_nfcee_mode_set(DISABLE)
was not supported pushed us to try to enable during the secure element
discovery phase.
After
ndev->hci_dev->init_data.gates is already initialized in st_nci_hci_network.
Cc: sta...@vger.kernel.org
Signed-off-by: Christophe Ricard
---
drivers/nfc/st-nci/se.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/nfc/st-nci/se.c b/drivers/nfc/st-nci/se.c
index 4acb945..3ffac0e 1006
When session_id is filled to ff, the pipe configuration is probably
incorrect.
Signed-off-by: Christophe Ricard
---
net/nfc/nci/hci.c | 4
1 file changed, 4 insertions(+)
diff --git a/net/nfc/nci/hci.c b/net/nfc/nci/hci.c
index 43d7931..a937bc6 100644
--- a/net/nfc/nci/hci.c
+++ b/net/nfc/
Hi Samuel,
Please find in the following patchset severals fixes as well as vendor_cmds
support
for st21nfca and st-nci.
vendor_cmds includes production test, trimmings & firmware update commands.
v3:
- Fix st21nfca vendor_cmds by exporting nfc_llc_start/stop
- Remove #include "st21nfca_vendor_cm
nci_hci_clear_all_pipes might be use full in some cases for example after
a firmware update.
Signed-off-by: Christophe Ricard
---
include/net/nfc/nci_core.h | 1 +
net/nfc/nci/hci.c | 15 +++
2 files changed, 16 insertions(+)
diff --git a/include/net/nfc/nci_core.h b/inclu
Align st21nfca driver with or nfc driver:
- Remove st21nfca_ prefix
- Merge st21nfca_se.h, st21nfca_dep.h in st21nfca.h
Signed-off-by: Christophe Ricard
---
drivers/nfc/st21nfca/Makefile |2 +-
drivers/nfc/st21nfca/core.c | 1062 ++
drivers/nfc/s
When receiving data in nci_hci_msg_rx_work, extract pipe value using
NCI_HCP_MSG_GET_PIPE macro.
Cc: sta...@vger.kernel.org
Signed-off-by: Christophe Ricard
---
net/nfc/nci/hci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/nfc/nci/hci.c b/net/nfc/nci/hci.c
index 7
When sending data over SPI, the maximum expected length is the maximum
nci packet payload + data header size + the frame head room (1 for the
ndlc header) + the frame trail room (0).
Cc: sta...@vger.kernel.org
Signed-off-by: Christophe Ricard
---
drivers/nfc/st-nci/spi.c | 4 +++-
1 file changed
st-nci.h already include ndlc.h.
Signed-off-by: Christophe Ricard
---
drivers/nfc/st-nci/i2c.c | 2 +-
drivers/nfc/st-nci/ndlc.c | 1 -
drivers/nfc/st-nci/spi.c | 2 +-
3 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/nfc/st-nci/i2c.c b/drivers/nfc/st-nci/i2c.c
index 707e
Some gates might be interesting to have their pipes created.
Add in nci_hci_connect_gate a call to nci_hci_create_pipe for every gate
different than NCI_HCI_LINK_MGMT_GATE or NCI_HCI_ADMIN_GATE.
In case of an error when opening a pipe, like in hci layer, delete the pipe
if it was created.
Signed-
When sending HCI data over NCI, HCI return code is part of the NCI data.
In order to get correctly the HCI return code, we assume the NCI
communication is successful and extract the return code for the nci_hci
functions return code.
This is done because nci_to_errno does not match hci return code
When sending HCI data over NCI, cmd information should be present only on
the first packet. Each packet shall be specifically allocated and sent to
the NCI layer.
Cc: sta...@vger.kernel.org
Signed-off-by: Christophe Ricard
---
net/nfc/nci/hci.c | 19 ---
1 file changed, 12 insert
NCI_HCI_LINK_MGMT_PIPE was never open in st_nci_hci_load_session.
Signed-off-by: Christophe Ricard
---
drivers/nfc/st-nci/se.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/nfc/st-nci/se.c b/drivers/nfc/st-nci/se.c
index 3ffac0e..3522165 100644
--- a/drivers/nfc/st-nci/se.c
hdev->init_data.gates is already initialized in st21nfca_hci_probe.
Cc: sta...@vger.kernel.org
Signed-off-by: Christophe Ricard
---
drivers/nfc/st21nfca/core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/nfc/st21nfca/core.c b/drivers/nfc/st21nfca/core.c
index 42f1974..67d1c27 1006
Align st-nci driver with or nfc driver:
- Remove st-nci_ prefix
- Merge se.h in st-nci.h
Signed-off-by: Christophe Ricard
---
drivers/nfc/st-nci/core.c | 1 -
drivers/nfc/st-nci/se.c | 1 -
drivers/nfc/st-nci/se.h | 61 -
drivers/nfc/st-nci
Add support to configure GPIO line as input, output or external IRQ pin.
Signed-off-by: Y Vo
---
drivers/gpio/gpio-xgene-sb.c | 234 +++--
1 files changed, 199 insertions(+), 35 deletions(-)
diff --git a/drivers/gpio/gpio-xgene-sb.c b/drivers/gpio/gpio-xgene
V2 Changes:
- support X-Gene standby GPIO as an interrupt controller.
Y Vo (3):
gpio: xgene: add support to configure GPIO line as input, output or
external IRQ pin
Documentation: gpio: Update description for X-Gene standby GPIO
controller DTS binding
arm64: dts: Upda
Update description for X-Gene standby GPIO controller DTS binding to
support GPIO line configuration as input, output or external IRQ pin.
Signed-off-by: Y Vo
---
.../devicetree/bindings/gpio/gpio-xgene-sb.txt | 23 +---
1 files changed, 15 insertions(+), 8 deletions(-)
di
Update APM X-Gene standby GPIO controller DTS entries to support GPIO
line configuration as input, output or external IRQ pin.
Signed-off-by: Y Vo
---
arch/arm64/boot/dts/apm/apm-storm.dtsi | 15 +--
1 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/arch/arm64/boot/dts
Hi Samuel,
I believe there was an issue when you applied my last series.
drivers/nfc/st-nci/vendor_cmds.c is not present and this introduce a
build fix already reported by kbuild robot.
I am sending a new version fixing the points you mention.
Best Regards
Christophe
On 26/10/2015 07:01, Sam
Hi Christophe,
On Sun, Oct 25, 2015 at 10:54:15PM +0100, Christophe Ricard wrote:
> Hi Samuel,
>
> Please find in the following patchset severals fixes as well as vendor_cmds
> support
> for st21nfca and st-nci.
> vendor_cmds includes production test, trimmings & firmware update commands.
>
> v
On Wed, Oct 21, 2015 at 2:24 PM, Ganapatrao Kulkarni
wrote:
> On Tue, Oct 20, 2015 at 8:17 PM, Mark Rutland wrote:
>> Hi,
>>
>> I'm away for the rest of this week and don't have the time to give this
>> a full review, but I've given this a first pass and have some high-level
>> comments:
>>
>> Fi
Hi Sascha,
On Wed, 2015-10-14 at 07:58 +0200, Sascha Hauer wrote:
> On Wed, Oct 14, 2015 at 11:23:35AM +0800, Leilk Liu wrote:
> > This patch support multiple devices for MT8173.
>
> The subject of this patch and also the above sentence should contain the
> board name this patch is changing so th
Hi Mark,
On Mon, 2015-10-19 at 20:27 +0100, Mark Brown wrote:
> On Wed, Oct 14, 2015 at 11:23:30AM +0800, Leilk Liu wrote:
> > This series are based on 4.3-rc1 and provide 5 patches to support
> > mt8173 spi multiple devices.
>
> This doesn't apply against current code, please check and resend.
On Wed, 2015-10-14 at 14:53 +0200, Joerg Roedel wrote:
> On Fri, Oct 09, 2015 at 10:23:07AM +0800, Yong Wu wrote:
> > + /*
> > +* There is a domain for each a iommu device in normal case.
> > +* But MTK only has one iommu domain called the m4u domain which all
> > +* the multimedia HW
On Sat, Oct 24, 2015 at 12:25:31PM +0900, Masahiro Yamada wrote:
> Add aliases to fix the I2C indexes like the other UniPhier boards.
>
> Signed-off-by: Masahiro Yamada
Thanks, applied!
-Olof
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to
Hi,
You're right on that these pins aren't currently in use by any .dts
file, but the manufacturer, Sinovoip,
should be submitting a .dts file for the board soon, and if they
don't, I'm sure the Linux-Sunxi community will do.
You can see a work-in-progress device tree at:
https://github.com/BPI-SI
On Mon, Oct 26, 2015 at 11:50 AM, Ganapatrao Kulkarni
wrote:
> On Mon, Oct 26, 2015 at 7:14 AM, Ming Lei wrote:
>> On Tue, Oct 20, 2015 at 6:45 PM, Ganapatrao Kulkarni
>> wrote:
>>> Adding numa dt binding support for arm64 based platforms.
>>> dt node parsing for numa topology is done using devi
Enable smp for rk3036, and add the smp sram name for adapting.
Signed-off-by: Xing Zheng
Reviewed-by: Heiko Stuebner
---
Changes in v5: None
arch/arm/boot/dts/rk3036.dtsi |5 +
1 file changed, 5 insertions(+)
diff --git a/arch/arm/boot/dts/rk3036.dtsi b/arch/arm/boot/dts/rk3036.dtsi
From: Heiko Stuebner
The dual-core Cortex A7 rk3036 is a bit special in that it does not allow
to control the actual powerdomain of the cpu cores, while the rest of the
smp-bringup like reset control and entry address handling stays the same.
Its bigger sibling, the quad-core rk3128 again allows
Initial release for rk3036, node definitions rk3036 sdk board.
Signed-off-by: Xing Zheng
Reviewed-by: Heiko Stuebner
---
Changes in v5: None
arch/arm/boot/dts/Makefile |1 +
arch/arm/boot/dts/rk3036-evb.dts | 64 +
arch/arm/boot/dts/rk3036.dtsi| 536 ++
Hi,
We need to support rk3036 soc platform via upstream, there are
3 primary parts for the initial release of minimum system: dts,
pinctrl, and clock tree for rk3036, and additional, we can use
these startup and run to init processs.
Thanks.
Changed in v5:
- don't use clk_ APIs in the pll init
Add the dt-bindings header for the rk3036, that gets shared between
the clock controller and the clock references in the dts.
Signed-off-by: Xing Zheng
Reviewed-by: Heiko Stuebner
---
Changes in v5: None
include/dt-bindings/clock/rk3036-cru.h | 195
1 file ch
Add the devicetree binding for the cru on the rk3036 which quite similar
structured as previous clock controllers.
Signed-off-by: Xing Zheng
Reviewed-by: Heiko Stuebner
---
Changes in v5: None
.../bindings/clock/rockchip,rk3036-cru.txt | 56
1 file changed, 56 i
Hi Arnd,
2015-10-10 15:59 GMT+09:00 Masahiro Yamada :
> Hi Arnd,
>
>
> 2015-10-06 15:22 GMT+01:00 Arnd Bergmann :
>> On Tuesday 06 October 2015 16:20:23 Arnd Bergmann wrote:
>>> On Friday 18 September 2015 13:37:31 Masahiro Yamada wrote:
>>> > Hi Olof,
>>> >
>>> > Now Linux 4.3-rc1 is out, so I a
On Mon, Oct 26, 2015 at 7:14 AM, Ming Lei wrote:
> On Tue, Oct 20, 2015 at 6:45 PM, Ganapatrao Kulkarni
> wrote:
>> Adding numa dt binding support for arm64 based platforms.
>> dt node parsing for numa topology is done using device property
>> proximity and device node distance-map.
>>
>> Reviewe
Hi,
On Mon, Oct 26, 2015 at 11:07 AM, Luis Araneda wrote:
> Two additional UARTs tested on the GPIO pins from the
> Banana Pi M2 board
>
> Signed-off-by: Luis Araneda
> ---
IIRC the policy we have is only add stuff that is actually used. I don't
see a follow up patch using these in any boards.
On Mon, Oct 26, 2015 at 03:48:44AM +0100, Rafael J. Wysocki wrote:
> On Mon, Oct 26, 2015 at 1:13 AM, Mark Brown wrote:
> > Should we try to schedule an ad-hoc session today (Monday) for those of
> > us who are here to talk this over?
> I won't mind doing that, what about after the Linus+Dirk se
Two additional UARTs tested on the GPIO pins from the
Banana Pi M2 board
Signed-off-by: Luis Araneda
---
arch/arm/boot/dts/sun6i-a31.dtsi | 14 ++
1 file changed, 14 insertions(+)
diff --git a/arch/arm/boot/dts/sun6i-a31.dtsi b/arch/arm/boot/dts/sun6i-a31.dtsi
index 83c1879..eb02d57
On Mon, Oct 26, 2015 at 1:13 AM, Mark Brown wrote:
> On Sat, Oct 24, 2015 at 03:09:06PM -0500, Rob Herring wrote:
>
>> Let's get agreement on the flow and structure and how to address other
>> issues like suspend, then we can worry about whether this needs to be
>> abstracted from subsystems. We c
Hi Geert,
On Saturday 24 October 2015 19:34:03 Geert Uytterhoeven wrote:
> On Sat, Oct 24, 2015 at 3:10 AM, Stephen Boyd wrote:
> > On 10/22, Geert Uytterhoeven wrote:
> >> On Tue, Oct 20, 2015 at 3:07 PM, Geert Uytterhoeven wrote:
> >>> On Tue, Oct 20, 2015 at 3:00 PM, Michael Turquette wrote:
>
On Fri, Oct 23, 2015 at 7:46 AM, Vishnu Patekar
wrote:
> Allwinner A83T is new octa-core cortex-a7 SOC.
> This adds the basic dtsi, the clocks differs from
> earlier sun8i SOCs.
>
> Signed-off-by: Vishnu Patekar
> ---
> arch/arm/boot/dts/sun8i-a83t.dtsi | 247
> +
On Tue, Oct 20, 2015 at 6:45 PM, Ganapatrao Kulkarni
wrote:
> Adding numa dt binding support for arm64 based platforms.
> dt node parsing for numa topology is done using device property
> proximity and device node distance-map.
>
> Reviewed-by: Robert Richter
> Signed-off-by: Ganapatrao Kulkarni
On Sun, Oct 25, 2015 at 02:54:39PM +0100, Rafael J. Wysocki wrote:
> On Sun, Oct 25, 2015 at 12:06 AM, Mark Brown wrote:
> > There's also the understanding people had that the order things get
> > bound changes the ordering for some of the other cases (perhaps it's a
> > good idea to do that, it
Hello,
On Sat, Oct 3, 2015 at 12:19 AM, Yingjoe Chen wrote:
> Add arch timer node to enable arch-timer support. MT8135 firmware
> doesn't correctly setup arch-timer frequency and CNTVOFF, add
> properties to workaround this.
>
> This also set cpu enable-method to enable SMP.
>
> Signed-off-by: Yi
On Sun, Oct 25, 2015 at 10:25 AM, Geert Uytterhoeven
wrote:
> Until commit 0166dc11be911213 ("of: make CONFIG_OF user selectable"),
> CONFIG_OF=y implied CONFIG_USE_OF=y on ARM, as the former could solely
> be enabled by being selected by the latter.
Arnd sent a similar fix[1] which I prefer.
>
On Sun, Oct 25, 2015 at 03:45:43PM -0500, Andrew F. Davis wrote:
> On 10/24/2015 05:14 PM, Mark Brown wrote:
> >Tbe binding document is buggy and doesn't reflect the code, there's no
> >compatible string in the driver.
> Sure there is:
> drivers/mfd/mt6397-core.c:48:
> .of_compatible = "mediatek
On October 26, 2015 9:13:01 AM GMT+09:00, Mark Brown wrote:
>On Sat, Oct 24, 2015 at 03:09:06PM -0500, Rob Herring wrote:
>
>> Let's get agreement on the flow and structure and how to address
>other
>> issues like suspend, then we can worry about whether this needs to be
>> abstracted from subsyst
On Sat, Oct 24, 2015 at 03:09:06PM -0500, Rob Herring wrote:
> Let's get agreement on the flow and structure and how to address other
> issues like suspend, then we can worry about whether this needs to be
> abstracted from subsystems. We can discuss more this week at KS.
Should we try to schedul
On 10/24/2015 08:55 AM, Rafael J. Wysocki wrote:
> On Thursday, October 22, 2015 03:03:37 PM Tomeu Vizoso wrote:
>> On 22 October 2015 at 03:06, Rafael J. Wysocki wrote:
>>> On Monday, September 21, 2015 04:02:44 PM Tomeu Vizoso wrote:
Walks the OF tree up and finds the closest ancestor that
After internal discussion, it appears this timing should be increase to
20 ms for interoperability reason.
Signed-off-by: Christophe Ricard
---
drivers/nfc/st-nci/se.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nfc/st-nci/se.c b/drivers/nfc/st-nci/se.c
index 147e
Potentially an unexpected HCI event may occur because of a firmware bug.
It could be transparent for the user but at least log this.
Signed-off-by: Christophe Ricard
---
drivers/nfc/st-nci/se.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/nfc/st-nci/se.c b/drivers/nfc/st-nci
NFC_CMD_ACTIVATE_TARGET and NFC_ATTR_SE_PARAMS comments are missing.
Signed-off-by: Christophe Ricard
---
include/uapi/linux/nfc.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/uapi/linux/nfc.h b/include/uapi/linux/nfc.h
index dd3f753..399f39f 100644
--- a/include/uapi/linux/nfc.
A secure element can be activated in different order. The host_list is
updated keeping a fixed order: .
Cc: sta...@vger.kernel.org
Signed-off-by: Christophe Ricard
---
drivers/nfc/st-nci/se.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/nfc/st-nci/se.c b/dri
A secure element can be activated in different order. The host_list is
updated keeping a fixed order: .
Cc: sta...@vger.kernel.org
Signed-off-by: Christophe Ricard
---
drivers/nfc/st21nfca/se.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/nfc/st21nfca/se.c b
Replace 1 missing st21nfcb by st_nci
Signed-off-by: Christophe Ricard
---
drivers/nfc/st-nci/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nfc/st-nci/Makefile b/drivers/nfc/st-nci/Makefile
index ea40ace..439b2fa 100644
--- a/drivers/nfc/st-nci/Makefile
+++
In order to align with st21nfca, dts configuration properties ese_present
and uicc_present are made available in st-nci driver.
So far, in early development firmware, because nci_nfcee_mode_set(DISABLE)
was not supported pushed us to try to enable during the secure element
discovery phase.
After
In order to manage in a better way the nci poll mode state machine, add
mode parameter to deactivate_target functions. This way we can manage
different target state. mode parameter make sense only in nci core.
Signed-off-by: Christophe Ricard
---
include/net/nfc/nfc.h | 2 +-
net/nfc/core.c
When sending HCI data over NCI, HCI return code is part of the NCI data.
In order to get correctly the HCI return code, we assume the NCI
communication is successful and extract the return code for the nci_hci
functions return code.
This is done because nci_to_errno does not match hci return code
When initializing ndev->hci_dev->init_data, only gates field was set.
gate_count needs to be initialized as well.
Cc: sta...@vger.kernel.org
Signed-off-by: Christophe Ricard
---
drivers/nfc/st-nci/se.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/nfc/st-nci/se.c b/drivers/nfc/st-n
Add a minor code style fixes
Cc: sta...@vger.kernel.org
Signed-off-by: Christophe Ricard
---
drivers/nfc/st21nfca/core.c | 2 --
drivers/nfc/st21nfca/i2c.c | 1 +
drivers/nfc/st21nfca/se.c | 2 +-
3 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/nfc/st21nfca/core.c b/dri
Potentially an unexpected HCI event may occur because of a firmware bug.
It could be transparent for the user but at least log this.
Signed-off-by: Christophe Ricard
---
drivers/nfc/st21nfca/core.c | 2 ++
drivers/nfc/st21nfca/dep.c | 1 +
drivers/nfc/st21nfca/se.c | 4
3 files changed,
Add support for proprietary commands useful mainly for factory testings.
Here is a list:
- FACTORY_MODE: Allow to set the driver into a mode where no secure element
are activated. It does not consider any NFC_ATTR_VENDOR_DATA.
- HCI_CLEAR_ALL_PIPES: Allow to execute a HCI clear all pipes command.
I
We need to keep initial st_nci_gates values in order for
nci_hci_dev_connect_gates to create and open pipe when necessary.
For example after a firmware update CLF pipes are cleared. Changing pipe
values in st_nci_gates was causing nci_hci_dev_connect_gates not using
accurate pipes value.
Cc: sta.
Remove SPI_DUMP_SKB and I2C_DUMP_SKB as skb is already dumped in ndlc
layer.
Cc: sta...@vger.kernel.org
Signed-off-by: Christophe Ricard
---
drivers/nfc/st-nci/i2c.c | 11 ---
drivers/nfc/st-nci/spi.c | 11 ---
2 files changed, 22 deletions(-)
diff --git a/drivers/nfc/st-nci/i2c
When sending HCI data over NCI, cmd information should be present only on
the first packet. Each packet shall be specifically allocated and sent to
the NCI layer.
Cc: sta...@vger.kernel.org
Signed-off-by: Christophe Ricard
---
net/nfc/nci/hci.c | 19 ---
1 file changed, 12 insert
Add some few code style fixes.
Cc: sta...@vger.kernel.org
Signed-off-by: Christophe Ricard
---
drivers/nfc/st-nci/i2c.c | 2 +-
drivers/nfc/st-nci/se.c | 2 +-
net/nfc/nci/hci.c| 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/nfc/st-nci/i2c.c b/drivers/nfc/
When sending data over SPI, the maximum expected length is the maximum
nci packet payload + data header size + the frame head room (1 for the
ndlc header) + the frame trail room (0).
Cc: sta...@vger.kernel.org
Signed-off-by: Christophe Ricard
---
drivers/nfc/st-nci/spi.c | 4 +++-
1 file changed
We need to keep initial st_nci_gates values in order for
nfc_hci_dev_connect_gates to create and open pipe when necessary.
For example after a firmware update CLF pipes are cleared. Changing pipe
values in st21nfca_gates was causing nfc_hci_dev_connect_gates not using
accurate pipes value.
Cc: st
Upon some conditions (timing, CLF errors, platform errors...), the irq might
be already active when powering the device.
Add irq_active variable as a guard to avoid kernel warning message
Signed-off-by: Christophe Ricard
---
drivers/nfc/st-nci/i2c.c | 8 +++-
drivers/nfc/st-nci/spi.c | 8 ++
NFC_HCI_LINK_MGMT_PIPE was never open in nfc_hci_load_session.
Cc: sta...@vger.kernel.org
Signed-off-by: Christophe Ricard
---
drivers/nfc/st21nfca/core.c | 19 +--
1 file changed, 5 insertions(+), 14 deletions(-)
diff --git a/drivers/nfc/st21nfca/core.c b/drivers/nfc/st21nfca/c
It is useless to start from index 0 when looking for a gate because only
dynamic pipes are retrieved with
ST21NFCA_DM_GETINFO(ST21NFCA_DM_GETINFO_PIPE_LIST).
The first dynamic pipe is present at index 3.
Cc: sta...@vger.kernel.org
Signed-off-by: Christophe Ricard
---
drivers/nfc/st21nfca/core.
st-nci.h already include ndlc.h.
Signed-off-by: Christophe Ricard
---
drivers/nfc/st-nci/i2c.c | 2 +-
drivers/nfc/st-nci/ndlc.c | 1 -
drivers/nfc/st-nci/spi.c | 2 +-
3 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/nfc/st-nci/i2c.c b/drivers/nfc/st-nci/i2c.c
index 707e
Align st21nfca driver with or nfc driver:
- Remove st21nfca_ prefix
- Merge st21nfca_se.h, st21nfca_dep.h in st21nfca.h
Signed-off-by: Christophe Ricard
---
drivers/nfc/st21nfca/Makefile |2 +-
drivers/nfc/st21nfca/core.c | 1062 ++
drivers/nfc/s
When receiving data in nci_hci_msg_rx_work, extract pipe value using
NCI_HCP_MSG_GET_PIPE macro.
Cc: sta...@vger.kernel.org
Signed-off-by: Christophe Ricard
---
net/nfc/nci/hci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/nfc/nci/hci.c b/net/nfc/nci/hci.c
index 7
hdev->init_data.gates is already initialized in st21nfca_hci_probe.
Cc: sta...@vger.kernel.org
Signed-off-by: Christophe Ricard
---
drivers/nfc/st21nfca/core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/nfc/st21nfca/core.c b/drivers/nfc/st21nfca/core.c
index 42f1974..67d1c27 1006
It is useless to start from index 0 when looking for a gate because only
dynamic pipes are retrieved with ST_NCI_DM_GETINFO(ST_NCI_DM_GETINFO_PIPE_LIST).
The first dynamic pipe is present at index 3.
Cc: sta...@vger.kernel.org
Signed-off-by: Christophe Ricard
---
drivers/nfc/st-nci/se.c | 2 +-
1 - 100 of 140 matches
Mail list logo
