Re: [PATCH v4] of: fix declaration of of_io_request_and_map

a reason why this is done this way. For the best of my knowledge: Acked-by: Daniel Lezcano Fixes: e572f844ca66 ("clocksource/drivers/meson6: Add the COMPILE_TEST option") Fixes: bec8c4617611 ("clocksource/drivers/mediatek: Add the COMPILE_TEST option") Fixes: 4a373b45f94a (

Re: [PATCH v1 02/10] clockevents/drivers: add MPS2 Timer driver

sizeof(struct clockevent_mps2), GFP_KERNEL); + if (!ce) { + ret = -ENOMEM; + pr_err("failed to allocate clockevent: %d\n", ret); There is already a stack trace in the kernel when an allocation fails. With the above fixed: Acked-by: Daniel Lezcano -- <

Re: [RFC PATCH 02/10] clockevents/drivers: add MPS2 Timer driver

On 11/25/2015 03:51 PM, Vladimir Murzin wrote: Hi Daniel, Thanks for you review, I agree on all concerns raised and address them in the next version. Just some points to confirm below (I left only relevant parts). +static irqreturn_t mps2_timer_interrupt(int irq, void *dev_id) +{ +struct c

Re: [RFC PATCH 02/10] clockevents/drivers: add MPS2 Timer driver

On 11/25/2015 11:33 AM, Vladimir Murzin wrote: MPS2 platform has simple 32 bits general purpose countdown timers. The driver uses the first detected timer as a clocksource and the rest of the timers as a clockevent Signed-off-by: Vladimir Murzin --- drivers/clocksource/Kconfig |5 +

Re: [PATCH v2 1/4] clocksource: rockchip: Make the driver more compatible

On 11/03/2015 03:00 AM, Caesar Wang wrote: Daniel, 在 2015年11月03日 01:28, Daniel Lezcano 写道: On 10/31/2015 12:47 AM, Heiko Stuebner wrote: Hi Daniel, Am Freitag, 30. Oktober 2015, 11:42:29 schrieb Daniel Lezcano: On 10/30/2015 04:43 AM, Caesar Wang wrote: Hi Daniel, 在 2015年10月01日 03:14

Re: [PATCH v2 1/4] clocksource: rockchip: Make the driver more compatible

On 10/31/2015 12:47 AM, Heiko Stuebner wrote: Hi Daniel, Am Freitag, 30. Oktober 2015, 11:42:29 schrieb Daniel Lezcano: On 10/30/2015 04:43 AM, Caesar Wang wrote: Hi Daniel, 在 2015年10月01日 03:14, Heiko Stübner 写道: Hi Daniel, Am Dienstag, 29. September 2015, 06:18:03 schrieb Daniel Lezcano

Re: [PATCH v2 1/4] clocksource: rockchip: Make the driver more compatible

On 10/31/2015 12:47 AM, Heiko Stuebner wrote: Hi Daniel, Am Freitag, 30. Oktober 2015, 11:42:29 schrieb Daniel Lezcano: On 10/30/2015 04:43 AM, Caesar Wang wrote: Hi Daniel, 在 2015年10月01日 03:14, Heiko Stübner 写道: Hi Daniel, Am Dienstag, 29. September 2015, 06:18:03 schrieb Daniel Lezcano

Re: [PATCH] Revert "h8300: clocksource"

On 10/30/2015 12:19 PM, Arnd Bergmann wrote: On Friday 30 October 2015 11:26:08 Daniel Lezcano wrote: This reverts commit 618b902d8c098f2fff188119da7b3184c4bc5483. [ ... ] I found that Yoshinori Sato has always addressed all review comments very quickly by rewriting the code in a proper

Re: [PATCH v2 1/4] clocksource: rockchip: Make the driver more compatible

On 10/30/2015 04:43 AM, Caesar Wang wrote: Hi Daniel, 在 2015年10月01日 03:14, Heiko Stübner 写道: Hi Daniel, Am Dienstag, 29. September 2015, 06:18:03 schrieb Daniel Lezcano: On 09/25/2015 04:14 AM, Caesar Wang wrote: Build the arm64 SoCs (e.g.: RK3368) on Rockchip platform, There are some

[PATCH] Revert "h8300: clocksource"

different sub-system maintainers to be in Cc. Instead of that, these drivers passed silently through another tree (arm-soc I guess). Revert these drivers in order to have them re-submitted and reviewed again. There is legacy code to be removed. Signed-off-by: Daniel Lezcano Conflicts

Re: [PATCH v2 1/4] clocksource: rockchip: Make the driver more compatible

of dsb on btw arm32 and arm64, Here we can convert the dsb with insteading of dsb(sy).The "sy" param is the default which you are allow to omit, so on arm32 dsb()and dsb(sy) are the same. Signed-off-by: Caesar Wang Acked-by: Daniel Lezcano -- <http://www.linaro.org/> Linaro.o

Re: [PATCH v2 2/4] clocksource: rockchip: trivial: Make the driver more readability

On 09/25/2015 04:14 AM, Caesar Wang wrote: Let's checkstyle to clean up the macros with such trivial details. Signed-off-by: Caesar Wang --- Acked-by: Daniel Lezcano -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.face

Re: [PATCH v1 1/3] clocksource: rockchip: Make the driver more readability and compatible

Hi Caesar, so thinking a bit more about this patch. I would like to split it into two. One fixing the NO_IRQ and another fixing the dsb(). IIUC, the ARMv8 support is not yet ready and dsb() is not necessary as a fix for the previous kernel version. However, the timer is used with the ARMv7

Re: [PATCH 0/5] add GPT timer support for mt8173

On 07/13/2015 11:32 AM, Yingjoe Chen wrote: This series add GPT timer support for mt8173. This is based on v4.2-rc1 and Matthias' next branch (for dts parts). The first 2 patches comes from 'Add SMP bringup support for mt65xx socs' series [1]. I decide to move these 2 patches to this series, sin

Re: [PATCH v2 1/5] clocksource: mediatek: do not enable GPT_CLK_EVT when setup

On 08/21/2015 04:39 PM, Yingjoe Chen wrote: [ ... ] - Does the spurious interrupt occurs *every* time ? at each boot ? Yes. If you applied this series to enable mtk timer without this fix on mt8173 or mt8135 you can reproduce it. It occurs for every boot. It crash before uart driver is re

Re: [PATCH v2 1/5] clocksource: mediatek: do not enable GPT_CLK_EVT when setup

On 08/17/2015 04:10 PM, Yingjoe Chen wrote: On Thu, 2015-08-13 at 10:35 +0200, Daniel Lezcano wrote: On 07/22/2015 10:14 AM, Yingjoe Chen wrote: Spurious mtk timer interrupt is noticed at boot and cause kernel crash. It seems if GPT is enabled, it will latch irq status even when its IRQ is

Re: [PATCH v2 1/5] clocksource: mediatek: do not enable GPT_CLK_EVT when setup

On 07/22/2015 10:14 AM, Yingjoe Chen wrote: Spurious mtk timer interrupt is noticed at boot and cause kernel crash. It seems if GPT is enabled, it will latch irq status even when its IRQ is disabled. When irq is enabled afterward, we see spurious interrupt. Change init flow to only enable GPT_CLK

Re: [PATCH 0/5] add GPT timer support for mt8173

On 08/11/2015 05:54 PM, Daniel Kurtz wrote: On Mon, Jul 13, 2015 at 5:32 PM, Yingjoe Chen wrote: This series add GPT timer support for mt8173. This is based on v4.2-rc1 and Matthias' next branch (for dts parts). The first 2 patches comes from 'Add SMP bringup support for mt65xx socs' series [1

Re: [PATCH v5 6/7] clocksource: Add Pistachio clocksource-only driver

On 08/06/2015 01:22 PM, Govindraj Raja wrote: From: Ezequiel Garcia The Pistachio SoC provides four general purpose timers, and allow to implement a clocksource driver. This driver can be used as a replacement for the MIPS GIC and MIPS R4K clocksources and sched clocks, which are clocked from

Re: [PATCH v4 6/7] clocksource: Add Pistachio clocksource-only driver

On 08/04/2015 01:37 PM, Ezequiel Garcia wrote: Hi Daniel, Thanks for the review! On 4 August 2015 at 06:21, Daniel Lezcano wrote: On 07/27/2015 04:02 PM, Govindraj Raja wrote: From: Ezequiel Garcia The Pistachio SoC provides four general purpose timers, and allow to implement a

Re: [PATCH v4 0/7] Clocksource changes for Pistachio CPUFreq.

add my ack to patch 7/7 which is the only one that touches arch/mips. Alternatively I can carry this in the MIPS tree which would have tbe benefit of better testing. Ok, go ahead. For the series 1-4: Acked-by: Daniel Lezcano -- <http://www.linaro.org/> Linaro.org │ Open source softw

Re: [PATCH v4 1/7] clocksource: mips-gic: Enable the clock before using it

k_put. Reviewed-by: Andrew Bresticker Signed-off-by: Ezequiel Garcia Acked-by: Daniel Lezcano --- drivers/clocksource/mips-gic-timer.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/clocksource/mips-gic-timer.c b/drivers/clocksource/mips-gic-timer.c index b8

Re: [PATCH v4 6/7] clocksource: Add Pistachio clocksource-only driver

On 07/27/2015 04:02 PM, Govindraj Raja wrote: From: Ezequiel Garcia The Pistachio SoC provides four general purpose timers, and allow to implement a clocksource driver. This driver can be used as a replacement for the MIPS GIC and MIPS R4K clocksources and sched clocks, which are clocked from

Re: [PATCH v2 4/9] clocksource: mediatek: Use GPT as sched clock source

On 05/16/2015 09:58 AM, Yingjoe Chen wrote: When cpu is in deep idle, arch timer will stop counting. Setup GPT as sched clock source so it can keep counting in idle. Signed-off-by: Yingjoe Chen --- Acked-by: Daniel Lezcano -- <http://www.linaro.org/> Linaro.org │ Open source softwa

Re: [PATCH v4] ARM: dts: mt8173: support arm64 cpuidle-dt

to the PSCI version. - Remove the cluster idle state. - Fine tune the latency properties of the idle state. Signed-off-by: Howard Chen Acked-by: Lorenzo Pieralisi A bit late but ... Sounds good. Acked-by: Daniel Lezcano -- <http://www.linaro.org/> Linaro.org │ Open source software f

[PATCH 09/11] dt-bindings: Document the STM32 timer bindings

From: Maxime Coquelin This adds documentation of device tree bindings for the STM32 timer. Tested-by: Chanwoo Choi Acked-by: Rob Herring Signed-off-by: Maxime Coquelin Signed-off-by: Daniel Lezcano --- .../devicetree/bindings/timer/st,stm32-timer.txt | 22 ++ 1 file

[PATCH 06/11] doc: dt: Add documentation for lpc3220-timer

From: Joachim Eastwood Add DT bindings documentation for lpc3220-timer. This timer is used as clocksource on many NXP platforms. Signed-off-by: Joachim Eastwood Signed-off-by: Daniel Lezcano Acked-by: Arnd Bergmann --- .../bindings/timer/nxp,lpc3220-timer.txt | 26

[PATCH 07/11] dt-bindings: Document the ARM System timer bindings

From: Maxime Coquelin This adds documentation of device tree bindings for the ARM System timer. Tested-by: Chanwoo Choi Acked-by: Rob Herring Signed-off-by: Maxime Coquelin Signed-off-by: Daniel Lezcano --- .../devicetree/bindings/arm/armv7m_systick.txt | 26 ++ 1

Re: [PATCH v2 03/12] clocksource: sti: Provide 'use timer as sched clock' capability

On 05/12/2015 02:58 PM, Lee Jones wrote: Signed-off-by: Lee Jones --- Acked-by: Daniel Lezcano -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg&g

Re: [PATCH v2.1 02/12] clocksource: sti: Provide support for the ST LPC Clocksource IP

model combined with a DT 'mode' property to enforce this. The ST LPC Clocksource IP can be used as the system (tick) timer. Signed-off-by: Lee Jones Looks good to me. Acked-by: Daniel Lezcano -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follo

Re: [PATCH v9 2/5] clockevents/drivers: Add STM32 Timer driver

On 05/22/2015 11:03 PM, Maxime Coquelin wrote: STM32 MCUs feature 16 and 32 bits general purpose timers with prescalers. The drivers detects whether the time is 16 or 32 bits, and applies a 1024 prescaler value if it is 16 bits. Reviewed-by: Linus Walleij Tested-by: Chanwoo Choi Signed-off-by:

Re: [PATCH v9 1/5] dt-bindings: Document the STM32 timer bindings

On 05/22/2015 11:03 PM, Maxime Coquelin wrote: This adds documentation of device tree bindings for the STM32 timer. Tested-by: Chanwoo Choi Acked-by: Rob Herring Signed-off-by: Maxime Coquelin Applied to my tree for 4.2. -- Linaro.org │ Open source software for

Re: [PATCH 03/12] clocksource: sti: Provide 'use timer as sched clock' capability

On 05/08/2015 01:47 PM, Paul Bolle wrote: On Fri, 2015-05-08 at 11:29 +0100, Lee Jones wrote: Ah, you mean from menuconfig. I almost forgot what that was. ;) I can add a menu option, no problem. It's not just menuconfig: $ grep -e CONFIG_ARCH_STI -e CONFIG_CLKSRC_ST_LPC .config CON

Re: [PATCH v6 04/15] clocksource/drivers: Add ARM System timer driver

On 04/07/2015 06:30 PM, Maxime Coquelin wrote: This patch adds clocksource support for ARMv7-M's System timer, also known as SysTick. Tested-by: Chanwoo Choi Signed-off-by: Maxime Coquelin Acked-by: Daniel Lezcano --- drivers/clocksource/Kconfig | 7 drivers/clocks

Re: [PATCH v18 04/11] ARM: cpuidle: Add cpuidle support for QCOM cpus

On 03/25/2015 09:25 PM, Lina Iyer wrote: Define ARM_QCOM_CPUIDLE config item to enable cpuidle support. Cc: Stephen Boyd Cc: Arnd Bergmann Cc: Kevin Hilman Cc: Daniel Lezcano Signed-off-by: Lina Iyer Acked-by: Daniel Lezcano --- drivers/cpuidle/Kconfig.arm | 7 +++ 1 file

Re: [PATCH v3 04/15] clocksource: Add ARM System timer driver

On 03/26/2015 09:19 PM, Maxime Coquelin wrote: Hi Daniel, Thanks for the review. Please find my answers below. 2015-03-26 10:50 GMT+01:00 Daniel Lezcano : On 03/12/2015 10:55 PM, Maxime Coquelin wrote: From: Maxime Coquelin This patch adds clocksource support for ARMv7-M's System

Re: [PATCH v3 04/15] clocksource: Add ARM System timer driver

On 03/12/2015 10:55 PM, Maxime Coquelin wrote: From: Maxime Coquelin This patch adds clocksource support for ARMv7-M's System timer, also known as SysTick. Signed-off-by: Maxime Coquelin Hi Maxime, the driver looks good. Three comments below. -- Daniel --- drivers/clocksource/Kconfi

Re: [PATCH 2/2] ARM: cpuidle: Document the code

On 03/24/2015 07:51 PM, Lorenzo Pieralisi wrote: On Tue, Mar 24, 2015 at 09:54:02AM +, Daniel Lezcano wrote: Add kernel-doc format documentation in the code. Signed-off-by: Daniel Lezcano --- [ ... ] + * Returns: + * 0 on success, + * -ENODEV if it fails to find the cpu node in the

[PATCH 2/2] ARM: cpuidle: Document the code

Add kernel-doc format documentation in the code. Signed-off-by: Daniel Lezcano --- arch/arm/kernel/cpuidle.c | 58 +++ 1 file changed, 58 insertions(+) diff --git a/arch/arm/kernel/cpuidle.c b/arch/arm/kernel/cpuidle.c index 2b0dae3..9219613 100644

[PATCH V5 1/2] ARM: cpuidle: Register per cpuidle device

ectly initialized. Signed-off-by: Daniel Lezcano --- drivers/cpuidle/cpuidle-arm.c | 45 +-- 1 file changed, 43 insertions(+), 2 deletions(-) diff --git a/drivers/cpuidle/cpuidle-arm.c b/drivers/cpuidle/cpuidle-arm.c index 1c94b88..545069d 100644 --- a/dr

[PATCH V4] ARM: cpuidle: Register per cpuidle device

ectly initialized. Signed-off-by: Daniel Lezcano --- drivers/cpuidle/cpuidle-arm.c | 46 +-- 1 file changed, 44 insertions(+), 2 deletions(-) diff --git a/drivers/cpuidle/cpuidle-arm.c b/drivers/cpuidle/cpuidle-arm.c index 1c94b88..a7a01ce 100644 --- a/dr

Re: [PATCH V3 7/8] ARM: cpuidle: Register per cpuidle device

On 03/21/2015 09:35 PM, Lorenzo Pieralisi wrote: On Fri, Mar 20, 2015 at 11:44:00AM +, Daniel Lezcano wrote: Some architectures have some cpus which does not support idle states. Let the underlying low level code to return -ENXIO when it is not possible to set an idle state. Well, this

Re: [PATCH V3 0/8] ARM: cpuidle: Unify the ARM64/ARM DT approach

On 03/23/2015 04:27 PM, Lorenzo Pieralisi wrote: On Fri, Mar 20, 2015 at 11:43:53AM +, Daniel Lezcano wrote: There is a big number of cpuidle drivers for the ARM architecture. These drivers have been cleaned up and grouped into the drivers/cpuidle directory to keep track of the changes

Re: [PATCH V3 7/8] ARM: cpuidle: Register per cpuidle device

On 03/21/2015 09:35 PM, Lorenzo Pieralisi wrote: On Fri, Mar 20, 2015 at 11:44:00AM +, Daniel Lezcano wrote: Some architectures have some cpus which does not support idle states. Let the underlying low level code to return -ENXIO when it is not possible to set an idle state. Well, this

Re: [PATCH V3 0/8] ARM: cpuidle: Unify the ARM64/ARM DT approach

On 03/20/2015 07:31 PM, Lorenzo Pieralisi wrote: Hi Daniel, On Fri, Mar 20, 2015 at 11:43:53AM +, Daniel Lezcano wrote: There is a big number of cpuidle drivers for the ARM architecture. These drivers have been cleaned up and grouped into the drivers/cpuidle directory to keep track of the

Re: [PATCH 4/6] ARM64: cpuidle: Rename cpu_init_idle to a common function name

On 03/03/2015 01:29 PM, Daniel Lezcano wrote: With this change the cpuidle-arm64.c file calls the same function name for both ARM and ARM64. Signed-off-by: Daniel Lezcano Hi Catalin, do you mind to ack the ARM64 if you agree with these changes ? Thanks. -- Daniel --- arch/arm64

[PATCH V3 2/8] ARM: cpuidle: Add a cpuidle ops structure to be used for DT

allow with the next patches to a have a common definition with ARM64 and share the same cpuidle driver. The code is optimized to use the __init section intensively in order to reduce the memory footprint after the driver is initialized and unify the function names with ARM64. Signed-off-by: Daniel

[PATCH V3 3/8] ARM64: cpuidle: Replace cpu_suspend by the common ARM/ARM64 function

Call the common ARM/ARM64 'arm_cpuidle_suspend' instead of cpu_suspend function which is specific to ARM64. Signed-off-by: Daniel Lezcano Acked-by: Kevin Hilman Acked-by: Rob Herring --- drivers/cpuidle/cpuidle-arm64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

[PATCH V3 0/8] ARM: cpuidle: Unify the ARM64/ARM DT approach

Used smp_operations style for cpuidle_ops * Fixed some nits in the comments * Added a patch to change the name of the functions * Added per cpu device registration patch Daniel Lezcano (8): ARM: cpuidle: Remove duplicate header inclusion ARM: cpuidle: Add a cpuidle o

[PATCH V3 7/8] ARM: cpuidle: Register per cpuidle device

Some architectures have some cpus which does not support idle states. Let the underlying low level code to return -ENXIO when it is not possible to set an idle state. Signed-off-by: Daniel Lezcano --- drivers/cpuidle/cpuidle-arm.c | 42 -- 1 file changed

[PATCH V3 5/8] ARM64: cpuidle: Remove arm64 reference

In the next patch, this driver will be common across ARM/ARM64. Remove all refs to ARM64 as it will be shared with ARM32. Signed-off-by: Daniel Lezcano Acked-by: Kevin Hilman Acked-by: Rob Herring --- drivers/cpuidle/cpuidle-arm64.c | 34 +- 1 file changed, 17

[PATCH V3 1/8] ARM: cpuidle: Remove duplicate header inclusion

cpuidle.h header file directly, so we can save some line of code. Signed-off-by: Daniel Lezcano Acked-by: Kevin Hilman Acked-by: Lorenzo Pieralisi --- arch/arm/include/asm/cpuidle.h| 2 ++ arch/arm/kernel/cpuidle.c | 2 +- arch/arm/mach-davinci/cpuidle.c | 1 - arch/arm/mach

[PATCH V3 6/8] ARM: cpuidle: Enable the ARM64 driver for both ARM32/ARM64

ARM32 and ARM64 have the same DT definitions and the same approaches. The generic ARM cpuidle driver can be put in common for those two architectures. Signed-off-by: Daniel Lezcano Acked-by: Kevin Hilman Acked-by: Rob Herring --- drivers/cpuidle/Kconfig| 7

[PATCH V3 4/8] ARM64: cpuidle: Rename cpu_init_idle to a common function name

With this change the cpuidle-arm64.c file calls the same function name for both ARM and ARM64. Signed-off-by: Daniel Lezcano Acked-by: Kevin Hilman Acked-by: Rob Herring --- arch/arm64/include/asm/cpuidle.h | 4 ++-- arch/arm64/kernel/cpuidle.c | 2 +- drivers/cpuidle/cpuidle-arm64.c

[PATCH V3 8/8] ARM: cpuidle: Change function name to be consistent with x86

Change the functions name: arm_cpuidle_suspend => arm_idle arm_cpuidle_init=> arm_idle_cpu_init Signed-off-by: Daniel Lezcano --- arch/arm/include/asm/cpuidle.h | 4 ++-- arch/arm/kernel/cpuidle.c| 4 ++-- arch/arm64/include/asm/cpuidle.h | 6 +++--- arch/arm64/kernel/cpu

Re: [PATCH V2 7/8] ARM: cpuidle: Register per cpuidle device

On 03/19/2015 04:42 PM, Lina Iyer wrote: On Thu, Mar 19 2015 at 09:33 -0600, Daniel Lezcano wrote: On 03/19/2015 04:31 PM, Lina Iyer wrote: On Wed, Mar 18 2015 at 12:46 -0600, Daniel Lezcano wrote: Some architectures have some cpus which does not support idle states. Let the underlying low

Re: [PATCH V2 7/8] ARM: cpuidle: Register per cpuidle device

On 03/19/2015 04:31 PM, Lina Iyer wrote: On Wed, Mar 18 2015 at 12:46 -0600, Daniel Lezcano wrote: Some architectures have some cpus which does not support idle states. Let the underlying low level code to return -ENOSYS when it is not possible to set an idle state. Signed-off-by: Daniel

Re: [PATCH V2 7/8] ARM: cpuidle: Register per cpuidle device

On 03/19/2015 12:38 PM, Lorenzo Pieralisi wrote: On Thu, Mar 19, 2015 at 11:27:20AM +, Daniel Lezcano wrote: [...] for_each_possible_cpu(cpu) { ret = arm_cpuidle_init(cpu); + + /* This cpu does not support any idle states */ + if (ret

Re: [PATCH V2 7/8] ARM: cpuidle: Register per cpuidle device

On 03/19/2015 12:08 PM, Lorenzo Pieralisi wrote: On Wed, Mar 18, 2015 at 06:46:11PM +, Daniel Lezcano wrote: Some architectures have some cpus which does not support idle states. Let the underlying low level code to return -ENOSYS when it is not possible to set an idle state. http

[PATCH V2 6/8] ARM: cpuidle: Enable the ARM64 driver for both ARM32/ARM64

ARM32 and ARM64 have the same DT definitions and the same approaches. The generic ARM cpuidle driver can be put in common for those two architectures. Signed-off-by: Daniel Lezcano Acked-by: Kevin Hilman Acked-by: Rob Herring --- drivers/cpuidle/Kconfig| 7

[PATCH V2 4/8] ARM64: cpuidle: Rename cpu_init_idle to a common function name

With this change the cpuidle-arm64.c file calls the same function name for both ARM and ARM64. Signed-off-by: Daniel Lezcano Acked-by: Kevin Hilman Acked-by: Rob Herring --- arch/arm64/include/asm/cpuidle.h | 4 ++-- arch/arm64/kernel/cpuidle.c | 2 +- drivers/cpuidle/cpuidle-arm64.c

[PATCH V2 0/8] ARM: cpuidle: Unify the ARM64/ARM DT approach

dle driver flexibility via the DT. Changelog: V2: * Fixed some nits in the comments * Added a patch to change the name of the functions * Added per cpu device registration patch Daniel Lezcano (8): ARM: cpuidle: Remove duplicate header inclusion ARM: cpuidle: Add a cp

[PATCH V2 3/8] ARM64: cpuidle: Replace cpu_suspend by the common ARM/ARM64 function

Call the common ARM/ARM64 'arm_cpuidle_suspend' instead of cpu_suspend function which is specific to ARM64. Signed-off-by: Daniel Lezcano Acked-by: Kevin Hilman Acked-by: Rob Herring --- drivers/cpuidle/cpuidle-arm64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

[PATCH V2 7/8] ARM: cpuidle: Register per cpuidle device

Some architectures have some cpus which does not support idle states. Let the underlying low level code to return -ENOSYS when it is not possible to set an idle state. Signed-off-by: Daniel Lezcano --- drivers/cpuidle/cpuidle-arm.c | 45 +-- 1 file

[PATCH V2 1/8] ARM: cpuidle: Remove duplicate header inclusion

cpuidle.h header file directly, so we can save some line of code. Signed-off-by: Daniel Lezcano Acked-by: Kevin Hilman Acked-by: Lorenzo Pieralisi --- arch/arm/include/asm/cpuidle.h| 2 ++ arch/arm/kernel/cpuidle.c | 2 +- arch/arm/mach-davinci/cpuidle.c | 1 - arch/arm/mach

[PATCH V2 2/8] ARM: cpuidle: Add a cpuidle ops structure to be used for DT

allow with the next patches to a have a common definition with ARM64 and share the same cpuidle driver. The code is optimized to use the __init section intensively in order to reduce the memory footprint after the driver is initialized and unify the function names with ARM64. Signed-off-by: Daniel

[PATCH V2 8/8] ARM: cpuidle: Change function name to be consistent with x86

Change the functions name: arm_cpuidle_suspend => arm_idle arm_cpuidle_init=> arm_idle_cpu_init Signed-off-by: Daniel Lezcano --- arch/arm/include/asm/cpuidle.h | 4 ++-- arch/arm/kernel/cpuidle.c| 4 ++-- arch/arm64/include/asm/cpuidle.h | 6 +++--- arch/arm64/kernel/cpu

[PATCH V2 5/8] ARM64: cpuidle: Remove arm64 reference

In the next patch, this driver will be common across ARM/ARM64. Remove all refs to ARM64 as it will be shared with ARM32. Signed-off-by: Daniel Lezcano Acked-by: Kevin Hilman Acked-by: Rob Herring --- drivers/cpuidle/cpuidle-arm64.c | 34 +- 1 file changed, 17

Re: [PATCH 2/6] ARM: cpuidle: Add a cpuidle ops structure to be used for DT

On 03/18/2015 02:14 AM, Stephen Boyd wrote: On 03/17/15 04:29, Lorenzo Pieralisi wrote: On Mon, Mar 16, 2015 at 10:08:19PM +, Stephen Boyd wrote: On 03/03/15 04:29, Daniel Lezcano wrote: The code is optimized to use the __init section intensively in order to reduce the memory footprint

Re: [PATCH 2/6] ARM: cpuidle: Add a cpuidle ops structure to be used for DT

On 03/16/2015 07:16 PM, Lorenzo Pieralisi wrote: On Tue, Mar 03, 2015 at 12:29:33PM +, Daniel Lezcano wrote: The current state of the different cpuidle drivers is the different PM Nit: "The current state of cpuidle drivers is such that different ..." Ok. operations are pass

Re: [PATCH 0/6] ARM: cpuidle: Unify the ARM64/ARM DT approach

On 03/13/2015 09:51 PM, Rob Herring wrote: On Thu, Mar 12, 2015 at 9:25 AM, Daniel Lezcano wrote: Catalin, Rob, do you agree with this patchset ? There's very little to do with DT, but looks fine to me. Shall I consider as a acked-by for the entire patchset or only the DT part ? T

Re: [PATCH 0/6] ARM: cpuidle: Unify the ARM64/ARM DT approach

On 03/13/2015 07:29 PM, Catalin Marinas wrote: On Thu, Mar 12, 2015 at 03:25:34PM +0100, Daniel Lezcano wrote: do you agree with this patchset ? In principle yes, apart from some function naming and I'm waiting for Lorenzo's ack as well. Do you plan to upstream this directly via you

Re: [PATCH 3/6] ARM64: cpuidle: Replace cpu_suspend by the common ARM/ARM64 function

On 03/13/2015 07:21 PM, Catalin Marinas wrote: On Tue, Mar 03, 2015 at 01:29:34PM +0100, Daniel Lezcano wrote: Call the common ARM/ARM64 'arm_cpuidle_suspend' instead of cpu_suspend function which is specific to ARM64. Signed-off-by: Daniel Lezcano --- drivers/cpuidle/cpuidle-a

Re: [PATCH 0/6] ARM: cpuidle: Unify the ARM64/ARM DT approach

On 03/13/2015 06:03 PM, Kevin Hilman wrote: Daniel Lezcano writes: There is a big number of cpuidle drivers for the ARM architecture. These drivers have been cleaned up and grouped into the drivers/cpuidle directory to keep track of the changes more easily and ensure the code is following

Re: [PATCH v3 05/12] clocksource: add dependencies for Vybrid pit clocksource

On 03/13/2015 12:36 AM, Stefan Agner wrote: Add the minimal dependencies required to use the Vybrid PIT clocksource driver. Those are not part of the SoC dependencies. Signed-off-by: Stefan Agner Acked-by: Daniel Lezcano --- drivers/clocksource/Kconfig | 2 ++ 1 file changed, 2

Re: [RFC PATCH v15 04/11] ARM: cpuidle: Register cpuidle_ops for QCOM cpus

On 03/12/2015 04:06 PM, Lina Iyer wrote: On Thu, Mar 12 2015 at 06:34 -0600, Daniel Lezcano wrote: On 03/11/2015 07:16 PM, Stephen Boyd wrote: On 03/09/15 08:16, Lina Iyer wrote: [...] +#if IS_ENABLED(CONFIG_QCOM_PM) Why not #ifdef CONFIG_QCOM_PM? I thought IS_ENABLED was for C code

Re: [PATCH 0/6] ARM: cpuidle: Unify the ARM64/ARM DT approach

Catalin, Rob, do you agree with this patchset ? Thanks -- Daniel On 03/03/2015 01:29 PM, Daniel Lezcano wrote: There is a big number of cpuidle drivers for the ARM architecture. These drivers have been cleaned up and grouped into the drivers/cpuidle directory to keep track of the changes

Re: [RFC PATCH v15 04/11] ARM: cpuidle: Register cpuidle_ops for QCOM cpus

On 03/11/2015 07:16 PM, Stephen Boyd wrote: On 03/09/15 08:16, Lina Iyer wrote: Register cpuidle ops for Krait Processor Sub-System. Supports v1 and v2 versions of KPSS. Cc: Stephen Boyd Cc: Arnd Bergmann Cc: Kevin Hilman Cc: Daniel Lezcano Signed-off-by: Lina Iyer --- arch/arm/include

[PATCH 1/6] ARM: cpuidle: Remove duplicate header inclusion

cpuidle.h header file directly, so we can save some line of code. Signed-off-by: Daniel Lezcano --- arch/arm/include/asm/cpuidle.h| 2 ++ arch/arm/kernel/cpuidle.c | 2 +- arch/arm/mach-davinci/cpuidle.c | 1 - arch/arm/mach-imx/cpuidle-imx6q.c | 1 - arch/arm/mach-imx

[PATCH 2/6] ARM: cpuidle: Add a cpuidle ops structure to be used for DT

platform is added. Signed-off-by: Daniel Lezcano --- arch/arm/include/asm/cpuidle.h | 10 + arch/arm/include/asm/cpuidle_ops.h | 3 ++ arch/arm/kernel/cpuidle.c | 85 ++ arch/arm64/include/asm/cpuidle.h | 5 ++- 4 files changed, 102

[PATCH 6/6] ARM: cpuidle: Enable the ARM64 driver for both ARM32/ARM64

ARM32 and ARM64 have the same DT definitions and the same approaches. The generic ARM cpuidle driver can be put in common for those two architectures. Signed-off-by: Daniel Lezcano --- drivers/cpuidle/Kconfig| 7 +-- drivers/cpuidle/Kconfig.arm

[PATCH 5/6] ARM64: cpuidle: Remove arm64 reference

In the next patch, this driver will be common across ARM/ARM64. Remove all refs to ARM64 as it will be shared with ARM32. Signed-off-by: Daniel Lezcano --- drivers/cpuidle/cpuidle-arm64.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a

[PATCH 3/6] ARM64: cpuidle: Replace cpu_suspend by the common ARM/ARM64 function

Call the common ARM/ARM64 'arm_cpuidle_suspend' instead of cpu_suspend function which is specific to ARM64. Signed-off-by: Daniel Lezcano --- drivers/cpuidle/cpuidle-arm64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/cpuidle/cpuidle-arm64.c b/drive

[PATCH 4/6] ARM64: cpuidle: Rename cpu_init_idle to a common function name

With this change the cpuidle-arm64.c file calls the same function name for both ARM and ARM64. Signed-off-by: Daniel Lezcano --- arch/arm64/include/asm/cpuidle.h | 4 ++-- arch/arm64/kernel/cpuidle.c | 2 +- drivers/cpuidle/cpuidle-arm64.c | 2 +- 3 files changed, 4 insertions(+), 4

[PATCH 0/6] ARM: cpuidle: Unify the ARM64/ARM DT approach

cpuidle driver flexibility via the DT. Daniel Lezcano (6): ARM: cpuidle: Remove duplicate header inclusion ARM: cpuidle: Add a cpuidle ops structure to be used for DT ARM64: cpuidle: Replace cpu_suspend by the common ARM/ARM64 function ARM64: cpuidle: Rename cpu_init_idle to a common

Re: [PATCH V2] clockevents: rockchip: Add rockchip timer for rk3288

On 01/26/2015 10:43 AM, Thomas Gleixner wrote: On Sun, 25 Jan 2015, Daniel Lezcano wrote: +static inline void rk_timer_set_mode(enum clock_event_mode mode, +struct clock_event_device *ce) +{ + switch (mode) { + case CLOCK_EVT_MODE_PERIODIC

Re: [PATCH V2] clockevents: rockchip: Add rockchip timer for rk3288

On 01/26/2015 02:25 AM, Kever Yang wrote: Hi Daniel, Hi Kever, [ ... ] +static inline int rk_timer_set_next_event(unsigned long cycles, + struct clock_event_device *ce) +{ +rk_timer_disable(ce); +rk_timer_update_counter(cycles, ce); +rk_timer_enable(ce, TIMER

Re: [PATCH V2] clockevents: rockchip: Add rockchip timer for rk3288

; --- From: Daniel Lezcano Date: Sun, 25 Jan 2015 10:42:59 +0100 Subject: [PATCH] ARM: dts: rockchip: Add rockchip timer node for rk3288 The rk3288 board uses the architected timers and these ones are shutdown when the cpu is powered down. There is a need of a broadcast timer in this case to en

[PATCH V2] clockevents: rockchip: Add rockchip timer for rk3288

7; to the CONTROLREG register with the mode (free running or user) Signed-off-by: Daniel Lezcano --- .../bindings/timer/rockchip,rk3288-timer.txt | 18 +++ arch/arm/boot/dts/rk3288.dtsi | 8 + arch/arm/mach-rockchip/Kconfig | 1 + drivers

Re: [PATCH] clockevents: rockchip: Add rockchip timer for rk3288

On 01/13/2015 12:20 AM, Heiko Stübner wrote: Hi Daniel, sorry it took a bit longer to reply. No problem :) Generally it looks good to me, just some minor issues inline below. Thanks for the review. It would also be nice to include the rockchip list (linux- rockc...@lists.infradead.org) f

[PATCH] clockevents: rockchip: Add rockchip timer for rk3288

7; to the CONTROLREG register with the mode (free running or user) Signed-off-by: Daniel Lezcano --- .../bindings/timer/rockchip,rk3288-timer.txt | 15 ++ arch/arm/boot/dts/rk3288.dtsi | 7 + arch/arm/mach-rockchip/Kconfig | 1 + drivers

Re: [PATCH v14 03/10] qcom: spm: Add Subsystem Power Manager driver

On 12/16/2014 03:38 PM, Arnd Bergmann wrote: On Tuesday 16 December 2014 15:12:22 Daniel Lezcano wrote: At the beginning, all that become from not including mach files from the drivers directory which make sense. Perhaps it is time to write a similar mechanism for the cpuidle drivers where we

Re: [PATCH v14 03/10] qcom: spm: Add Subsystem Power Manager driver

On 12/04/2014 07:20 PM, Arnd Bergmann wrote: On Thursday 04 December 2014 09:28:34 Lina Iyer wrote: On Thu, Dec 04 2014 at 02:02 -0700, Arnd Bergmann wrote: On Thursday 04 December 2014 09:52:39 Daniel Lezcano wrote: On 12/03/2014 09:35 PM, Arnd Bergmann wrote: On Wednesday 03 December 2014

Re: [PATCH v14 03/10] qcom: spm: Add Subsystem Power Manager driver

On 12/03/2014 09:35 PM, Arnd Bergmann wrote: On Wednesday 03 December 2014 07:31:22 Lina Iyer wrote: +static int __init qcom_spm_init(void) +{ +int ret; + +/* + * cpuidle driver need to registered before the cpuidle device + * for any cpu. Register the device for the the cpuidle

Re: [PATCH v14 03/10] qcom: spm: Add Subsystem Power Manager driver

On 12/03/2014 12:05 AM, Lina Iyer wrote: On Tue, Dec 02 2014 at 10:40 -0700, Lina Iyer wrote: + [...] [ ... ] +static int __init qcom_spm_init(void) +{ +int ret; + +/* + * cpuidle driver need to registered before the cpuidle device + * for any cpu. Register the device for the

Re: [PATCH v13 03/10] qcom: spm: Add Subsystem Power Manager driver

On 12/02/2014 04:35 PM, Lina Iyer wrote: On Tue, Dec 02 2014 at 02:53 -0700, Daniel Lezcano wrote: On 12/01/2014 07:50 PM, Lina Iyer wrote: On Thu, Nov 27 2014 at 01:52 -0700, Daniel Lezcano wrote: On 11/27/2014 06:24 AM, Lina Iyer wrote: +static bool cpuidle_drv_init

Re: [PATCH v13 03/10] qcom: spm: Add Subsystem Power Manager driver

On 12/01/2014 07:50 PM, Lina Iyer wrote: On Thu, Nov 27 2014 at 01:52 -0700, Daniel Lezcano wrote: On 11/27/2014 06:24 AM, Lina Iyer wrote: +static bool cpuidle_drv_init; ^ As already said in a previous comment, please find a way to remove that. I will look into it

Re: [PATCH v12 07/10] qcom: cpuidle: Add cpuidle driver for QCOM cpus

Power Collapse. Signed-off-by: Lina Iyer Acked-by: Daniel Lezcano Acked-by: Lorenzo Pieralisi --- .../bindings/arm/msm/qcom,idle-state.txt | 81 ++ drivers/cpuidle/Kconfig.arm| 7 ++ drivers/cpuidle/Makefile | 1

Re: [PATCH v13 00/10] cpuidle driver for QCOM SoCs: 8064, 8074, 8084

Lina, a night for me has passed and I have in the meantime 3 new versions of the patchset obviously done in the hurry and not tested. Furthermore the change log fails to give the details, "Address review comments on spm.c" is just a clue and when I look at the spm.c code all the comments wh

Re: [PATCH v13 03/10] qcom: spm: Add Subsystem Power Manager driver

On 11/27/2014 06:24 AM, Lina Iyer wrote: SPM is a hardware block that controls the peripheral logic surrounding the application cores (cpu/l$). When the core executes WFI instruction, the SPM takes over the putting the core in low power state as configured. The wake up for the SPM is an interrupt

  1   2   >