, will resume soon.
I would suggest keep the regulator first until the new solution got in.
Regards
Dong Aisheng
> arch/arm/boot/dts/imx7d-sdb.dts | 11 +--
> 1 file changed, 1 insertion(+), 10 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx7d-sdb.dts b/arch/arm/boot/dts/imx7d
mmc-esdhc-imx.h| 1 +
> 4 files changed, 130 insertions(+), 4 deletions(-)
>
> --
> 1.9.1
>
The patch set looks good to me.
Acked-by: Dong Aisheng
Regards
Dong Aisheng
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a mess
oo generous.
Better to change to something like:
mmc: sdhci-esdhc-imx: add imx7d support in bingding doc
Regards
Dong Aisheng
> ---
> Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.txt | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bi
ue
> as 2, otherwise it can't pass the tuning procedure.
>
> So this patch add the tuning-step setting in driver, so that user can set
> the tuning-step value in dts.
>
Fix a typo.
For patch title:
mmc: sdhci-esdhc-imx: add tuning-step seting support
s/seting/setting
Regards
ESDHC_MIX_CTRL_DDREN,
> - host->ioaddr + ESDHC_MIX_CTRL);
> + m = readl(host->ioaddr + ESDHC_MIX_CTRL);
Can this line be droped if using the former readback mixctl value?
> + m |= ESDHC_MIX_CTRL_DDREN;
&
On Fri, Aug 07, 2015 at 05:53:01PM +0800, Chen Haibo-B51421 wrote:
>
>
> > -Original Message-
> > From: Dong Aisheng [mailto:aisheng.d...@freescale.com]
> > Sent: Friday, August 07, 2015 3:39 PM
> > To: Chen Haibo-B51421
> > Cc: robh...@kerne
gth
Other than that, this patch looks good to me.
Regards
Dong Aisheng
> Signed-off-by: Haibo Chen
> ---
> drivers/mmc/host/sdhci-esdhc-imx.c | 16
> 1 file changed, 16 insertions(+)
>
> diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c
> b/drivers/mmc/
t;boarddata.tuning_step)
> + tuning_ctrl |=
> imx_data->boarddata.tuning_step << ESDHC_TUNING_STEP_SHIFT;
> + writel(tuning_ctrl, host->ioaddr +
> ESDHC_TUNING_CTRL);
Is there a code indent i
@@ static void esdhc_set_uhs_signaling(struct sdhci_host
> *host, unsigned timing)
> case MMC_TIMING_UHS_SDR25:
> case MMC_TIMING_UHS_SDR50:
> case MMC_TIMING_UHS_SDR104:
> + break;
> case MMC_TIMING_MMC_HS200:
> +
On Wed, Aug 05, 2015 at 03:39:29PM +0800, Chen Haibo-B51421 wrote:
>
>
> > -Original Message-
> > From: Dong Aisheng [mailto:aisheng.d...@freescale.com]
> > Sent: Monday, August 03, 2015 8:10 PM
> > To: Chen Haibo-B51421
> > Cc: robh...@kerne
esdhc_soc_data {
> u32 flags;
> @@ -156,6 +169,12 @@ static struct esdhc_soc_data usdhc_imx6sx_data = {
> | ESDHC_FLAG_HAVE_CAP1 | ESDHC_FLAG_HS200,
> };
>
> +static struct esdhc_soc_data usdhc_imx7d_data = {
> + .flags = ESDHC_FLAG_USDHC |
On Sun, Aug 02, 2015 at 04:59:04PM +0800, Chen Haibo-B51421 wrote:
>
>
> > -Original Message-
> > From: Dong Aisheng [mailto:aisheng.d...@freescale.com]
> > Sent: Friday, July 31, 2015 10:15 PM
> > To: Chen Haibo-B51421
> > Cc: robh...@kernel.org; pawe
On Mon, Aug 03, 2015 at 09:08:28AM +0800, Chen Haibo-B51421 wrote:
>
>
> > -Original Message-
> > From: Dong Aisheng [mailto:aisheng.d...@freescale.com]
> > Sent: Friday, July 31, 2015 10:58 PM
> > To: Chen Haibo-B51421
> > Cc: robh...@kernel.org; pawe
On Fri, Jul 31, 2015 at 04:13:45PM +0100, Russell King - ARM Linux wrote:
> On Fri, Jul 31, 2015 at 10:51:41PM +0800, Dong Aisheng wrote:
> > On Wed, Jul 29, 2015 at 05:03:56PM +0800, Haibo Chen wrote:
> > > i.MX7D support eMMC HS400 mode, this mode can run in 8 bit,200MHZ
> &
+ writel(0x10401040, host->ioaddr + ESDHC_WTMK_LVL);
> + else
> + writel(0x08100810, host->ioaddr + ESDHC_WTMK_LVL);
> +
> host->quirks2 |= SDHCI_QUIRK2_PRESET_VALUE_BROKEN;
> host->mmc->caps |= MMC_CA
* zero if this usdhc is choosed to boot system. Change it
> + * back here, otherwise it will impact the performance a
> + * lot if the burst length is 16.
Can you clarify a bit more on why performance drops a lot if burst
length is 16?
Caused by the b
ctually
for mx7d:
mmc: sdhci-esdhc-imx: change watermark level and burst length for imx7d
Regards
Dong Aisheng
> Signed-off-by: Haibo Chen
> ---
> drivers/mmc/host/sdhci-esdhc-imx.c | 11 ++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/
On Wed, Jul 29, 2015 at 05:03:54PM +0800, Haibo Chen wrote:
> imx7d-sdb board has a eMMC5.0 on usdhc3. This eMMC support HS400.
> This patch add usdhc3 support for HS400
>
It seems this patch should be after
[PATCH v3 4/6] mmc: sdhci-esdhc-imx: add compatible string in bingding doc
Reg
in about this property for better understanding:
e.g. The uSDHC is using one delay cell as default increasing step to do
tuning process. This property allows user to change the tuning step to more
than one delay cells which is useful for some special boards or cards when
the default tuning step ca
+ host->ioaddr + ESDHC_MIX_CTRL);
> + imx_data->is_ddr = 1;
> + if (host->clock == 2)
I can't remember, but could this be a range required by SoC?
> + esdhc_set_strobe_dll(host);
> + break;
scription, the correct tuning-step value only depends on the
> SoC. Why not derive it from the compatible string?
>
'tuning-step' actually depends on board and card.
The commit message should be reformed a bit.
Regards
Dong Aisheng
> Regards,
> Jan Lübbe
> --
> Pen
view it ASAP, maybe can do it tomorrow.
Regards
Dong Aisheng
> .../devicetree/bindings/mmc/fsl-imx-esdhc.txt | 2 +
> arch/arm/boot/dts/imx7d-sdb.dts| 13 +++
> drivers/mmc/host/sdhci-esdhc-imx.c | 97
> +-
> include/l
t would be nice to get
>a few "tested by" to make sure it doesn't break UHS support for some
>SoCs.
>
>Kind regards
>Uffe
>
> Can anyone test this in some other SoC ? Appreciate your help ..
>
>Can you test this
of_parse.
And since sdhci-esdhc-imx is not using mmc_of_parse currently, maybe it's time
to convert to it.
Regards
Dong Aisheng
>
> *NOTE* on CD and WP polarity. To use common for all SD/MMC host controllers
> line
> polarity properties, we have to fix the meaning of the "norm
Ping...
On Wed, Jul 30, 2014 at 7:52 PM, Marc Kleine-Budde wrote:
> On 07/16/2014 11:30 AM, Dong Aisheng wrote:
>> add M_CAN device tree binding documentation
>>
>> Cc: Wolfgang Grandegger
>> Cc: Marc Kleine-Budde
>> Cc: Mark Rutland
>> Cc: Oliver Hartko
Ping...
On Wed, Jul 16, 2014 at 6:40 PM, Dong Aisheng wrote:
> On Wed, Jul 16, 2014 at 12:05:05PM +0200, Marc Kleine-Budde wrote:
>> On 07/16/2014 11:30 AM, Dong Aisheng wrote:
>> > add M_CAN device tree binding documentation
>> >
>> > Cc: Wolfgang Grandegger
On Wed, Jul 16, 2014 at 12:05:05PM +0200, Marc Kleine-Budde wrote:
> On 07/16/2014 11:30 AM, Dong Aisheng wrote:
> > add M_CAN device tree binding documentation
> >
> > Cc: Wolfgang Grandegger
> > Cc: Marc Kleine-Budde
> > Cc: Mark Rutland
> > Cc:
On Wed, Jul 16, 2014 at 03:28:09PM +0530, Varka Bhadram wrote:
> On 07/16/2014 03:00 PM, Dong Aisheng wrote:
> >The patch adds the basic CAN TX/RX function support for Bosch M_CAN
> >controller.
> >For TX, only one dedicated tx buffer is used for sending data.
> >F
add M_CAN device tree binding documentation
Cc: Wolfgang Grandegger
Cc: Marc Kleine-Budde
Cc: Mark Rutland
Cc: Oliver Hartkopp
Cc: Varka Bhadram
Signed-off-by: Dong Aisheng
---
Changes since v4:
- change the name of board dtsi to board dts which is more common
Changes since v3:
- change
: Marc Kleine-Budde
Cc: Mark Rutland
Cc: Oliver Hartkopp
Cc: Varka Bhadram
Signed-off-by: Dong Aisheng
---
changes since v4:
some minor changes:
- introduce m_can_fifo_write and is_lec_err functin
- define macro M_CAN_FIFO_XXX for FIFO
- move m_can_of_table before platform_driver
- a few indent
On Tue, Jul 15, 2014 at 11:21:57AM +0200, Marc Kleine-Budde wrote:
> On 07/15/2014 11:07 AM, Dong Aisheng wrote:
> > On Tue, Jul 15, 2014 at 10:46:32AM +0200, Marc Kleine-Budde wrote:
> >> On 07/15/2014 10:26 AM, Dong Aisheng wrote:
> >>>>>>> +static vo
On Tue, Jul 15, 2014 at 10:46:32AM +0200, Marc Kleine-Budde wrote:
> On 07/15/2014 10:26 AM, Dong Aisheng wrote:
> >>>>> +static void m_can_read_fifo(const struct net_device *dev, struct
> >>>>> can_frame *cf,
> >>>>> +
On Tue, Jul 15, 2014 at 09:29:54AM +0200, Marc Kleine-Budde wrote:
> On 07/15/2014 05:33 AM, Dong Aisheng wrote:
> > On Mon, Jul 14, 2014 at 02:13:46PM +0200, Marc Kleine-Budde wrote:
> >> On 07/14/2014 01:40 PM, Dong Aisheng wrote:
> >>> The patch adds the basic
On Tue, Jul 15, 2014 at 12:45:15PM +0530, Varka Bhadram wrote:
> On 07/15/2014 12:40 PM, Marc Kleine-Budde wrote:
> >On 07/15/2014 08:56 AM, Varka Bhadram wrote:
> >>On 07/15/2014 11:57 AM, Dong Aisheng wrote:
> >>>On Mon, Jul 14, 2014 at 06:17:17PM +0530, Varka
| IR_ELO | IR_BEU | IR_BEC \
> >> +| IR_TOO | IR_MRAF | IR_TSW | IR_TEFL | IR_RF1L \
> >> +| IR_RF0L)
>
> Please move the '|' to the end of the line.
>
Got it.
Regards
Dong Aisheng
--
To unsubscribe from this list: send the line "unsubscribe d
On Mon, Jul 14, 2014 at 06:17:17PM +0530, Varka Bhadram wrote:
> On 07/14/2014 05:10 PM, Dong Aisheng wrote:
>
> (...)
>
> >diff --git a/drivers/net/can/m_can/Makefile b/drivers/net/can/m_can/Makefile
> >new file mode 100644
> >index 000..a6aae67
> >--
On Mon, Jul 14, 2014 at 02:13:46PM +0200, Marc Kleine-Budde wrote:
> On 07/14/2014 01:40 PM, Dong Aisheng wrote:
> > The patch adds the basic CAN TX/RX function support for Bosch M_CAN
> > controller.
> > For TX, only one dedicated tx buffer is used for sending data.
> &g
On Mon, Jul 14, 2014 at 01:52:09PM +0200, Marc Kleine-Budde wrote:
> On 07/14/2014 01:40 PM, Dong Aisheng wrote:
> > add M_CAN device tree binding documentation
> >
> > Cc: Wolfgang Grandegger
> > Cc: Marc Kleine-Budde
> > Cc: Mark Rutland
> > Cc:
add M_CAN device tree binding documentation
Cc: Wolfgang Grandegger
Cc: Marc Kleine-Budde
Cc: Mark Rutland
Cc: Oliver Hartkopp
Cc: Varka Bhadram
Signed-off-by: Dong Aisheng
---
Changes since v3:
- change mram-cfg property name to bosch,mram-cfg
- indent change
---
.../devicetree/bindings
: Marc Kleine-Budde
Cc: Mark Rutland
Cc: Oliver Hartkopp
Cc: Varka Bhadram
Signed-off-by: Dong Aisheng
---
Changes since v3:
A few minor changes:
- use the updated name of bosch,mram-cfg
- remove .owner = THIS_MODULE
- add a line comment for mram_cfg structure
Changes since v2:
- fix
On Mon, Jul 14, 2014 at 01:05:55PM +0530, Varka Bhadram wrote:
> On 07/14/2014 12:51 PM, Dong Aisheng wrote:
> >
> >+dev_dbg(&pdev->dev, "mram_base %p sidf 0x%x %d xidf 0x%x %d rxf0
> >0x%x %d rxf1 0x%x %d rxb 0x%x %d txe 0x%x %d txb 0x%x %d\n",
> &g
On Fri, Jul 11, 2014 at 05:43:19PM +0530, Varka Bhadram wrote:
> On 07/11/2014 05:33 PM, Marc Kleine-Budde wrote:
> >On 07/11/2014 01:13 PM, Varka Bhadram wrote:
> >>On 07/11/2014 03:59 PM, Dong Aisheng wrote:
> >>
> >>(...)
> >>
> >>>+/
On Fri, Jul 11, 2014 at 02:54:00PM +0200, Marc Kleine-Budde wrote:
> On 07/11/2014 12:29 PM, Dong Aisheng wrote:
> > add M_CAN device tree binding documentation
> >
> > Cc: Wolfgang Grandegger
> > Cc: Marc Kleine-Budde
> > Cc: Mark Rutland
> > Cc:
On Mon, Jul 14, 2014 at 10:07:06AM +0530, Varka Bhadram wrote:
> On 07/14/2014 08:54 AM, Dong Aisheng wrote:
> >On Fri, Jul 11, 2014 at 04:11:03PM +0530, Varka Bhadram wrote:
> >>On 07/11/2014 03:59 PM, Dong Aisheng wrote:
> >>>add M_CAN device tree binding documen
On Fri, Jul 11, 2014 at 04:11:03PM +0530, Varka Bhadram wrote:
> On 07/11/2014 03:59 PM, Dong Aisheng wrote:
> >add M_CAN device tree binding documentation
> >
> >Cc: Wolfgang Grandegger
> >Cc: Marc Kleine-Budde
> >Cc: Mark Rutland
> >Cc: Oliver Hartkopp
add M_CAN device tree binding documentation
Cc: Wolfgang Grandegger
Cc: Marc Kleine-Budde
Cc: Mark Rutland
Cc: Oliver Hartkopp
Cc: Varka Bhadram
Signed-off-by: Dong Aisheng
---
.../devicetree/bindings/net/can/m_can.txt | 65
1 files changed, 65 insertions
: Marc Kleine-Budde
Cc: Mark Rutland
Cc: Oliver Hartkopp
Cc: Varka Bhadram
Signed-off-by: Dong Aisheng
---
Changes since v2:
- fix checkpatch warnings
- handle CAN_CTRLMODE_BERR_REPORTING properly that disable LEC error
interrupts (Bus error) if no CAN_CTRLMODE_BERR_REPORTING.
- introduce
On Tue, Jul 08, 2014 at 01:20:18PM +0200, Marc Kleine-Budde wrote:
> On 07/08/2014 01:08 PM, Dong Aisheng wrote:
> > On Tue, Jul 08, 2014 at 12:41:41PM +0200, Marc Kleine-Budde wrote:
> >> On 07/08/2014 12:30 PM, Dong Aisheng wrote:
> >>>> R
On Tue, Jul 08, 2014 at 12:41:41PM +0200, Marc Kleine-Budde wrote:
> On 07/08/2014 12:30 PM, Dong Aisheng wrote:
> >> Regarding the mram and the offsets:
> >>
> >>> fifo_addr = priv->mram_base + priv->rxf0_off + fgi * RXF0_ELEMENT_SIZE;
> >>>
On Fri, Jul 04, 2014 at 06:23:04PM +0530, Varka Bhadram wrote:
> On 07/04/2014 05:23 PM, Dong Aisheng wrote:
> >The patch adds the basic CAN TX/RX function support for Bosch M_CAN
> >controller.
> >For TX, only one dedicated tx buffer is used for sending data.
> >F
On Mon, Jul 07, 2014 at 12:24:03PM +0200, Marc Kleine-Budde wrote:
> On 07/07/2014 09:10 AM, Dong Aisheng wrote:
> > On Fri, Jul 04, 2014 at 02:21:41PM +0200, Marc Kleine-Budde wrote:
> >> On 07/04/2014 01:53 PM, Dong Aisheng wrote:
> >>> The patch adds the basic
On Fri, Jul 04, 2014 at 02:21:41PM +0200, Marc Kleine-Budde wrote:
> On 07/04/2014 01:53 PM, Dong Aisheng wrote:
> > The patch adds the basic CAN TX/RX function support for Bosch M_CAN
> > controller.
> > For TX, only one dedicated tx buffer is used for sending data.
> &g
controller driver,
then we can gain better driver maintainability and future features upgrade.
M_CAN also supports CANFD protocol features like data payload up to 64 bytes
and bitrate switch at runtime, however, this patch still does not add the
support for these features.
Signed-off-by: Dong Aisheng
On Thu, Jul 03, 2014 at 11:20:27AM +0200, Marc Kleine-Budde wrote:
> On 07/03/2014 11:09 AM, Dong Aisheng wrote:
> > On Thu, Jul 03, 2014 at 11:04:36AM +0200, Marc Kleine-Budde wrote:
> >> On 07/03/2014 10:48 AM, Dong Aisheng wrote:
> >>> On Thu, Jul 03, 2014 at 09:12
On Thu, Jul 03, 2014 at 11:04:36AM +0200, Marc Kleine-Budde wrote:
> On 07/03/2014 10:48 AM, Dong Aisheng wrote:
> > On Thu, Jul 03, 2014 at 09:12:49AM +0200, Marc Kleine-Budde wrote:
> >> On 07/03/2014 05:48 AM, Dong Aisheng wrote:
> >>> On Wed, Jul 02, 2014 at 09:13
On Thu, Jul 03, 2014 at 09:12:49AM +0200, Marc Kleine-Budde wrote:
> On 07/03/2014 05:48 AM, Dong Aisheng wrote:
> > On Wed, Jul 02, 2014 at 09:13:07PM +0200, Marc Kleine-Budde wrote:
> >> On 07/02/2014 07:54 PM, Oliver Hartkopp wrote:
> >>> I'm not really
as already.
aliases {
can0 = &flexcan1;
can1 = &flexcan2;
...
}
I'm not sure adding can2&can3 for mcan is properly:
aliases {
can0 = &flexcan1;
can1 = &flexcan2;
can2 = &m_can1;
can3 = &m_can2;
...
}
Si
On Wed, Jul 02, 2014 at 09:57:50AM +0200, Marc Kleine-Budde wrote:
> On 07/02/2014 08:20 AM, Dong Aisheng wrote:
> [...]
>
> >>> +static int m_can_do_rx_poll(struct net_device *dev, int quota)
> >>> +{
> >>> + struct m_can_priv *priv = netdev_priv
On Tue, Jul 01, 2014 at 12:38:48PM +0200, Marc Kleine-Budde wrote:
> On 06/27/2014 12:00 PM, Dong Aisheng wrote:
> > add loopback and monitor mode support.
> >
> > Signed-off-by: Dong Aisheng
>
> Looks good. When finished with the review, I thinks it better to squash
On Tue, Jul 01, 2014 at 12:37:07PM +0200, Marc Kleine-Budde wrote:
> On 06/27/2014 12:00 PM, Dong Aisheng wrote:
> > Add bus error, state change, lost message handling mechanism.
> >
> > Signed-off-by: Dong Aisheng
> > ---
> >
Hi Marc,
On Tue, Jul 01, 2014 at 12:29:17PM +0200, Marc Kleine-Budde wrote:
> On 06/27/2014 12:00 PM, Dong Aisheng wrote:
> > The patch adds the basic CAN TX/RX function support for Bosch M_CAN
> > controller.
> > For TX, only one dedicated tx buffer is used for sending dat
On Fri, Jun 27, 2014 at 08:03:20PM +0200, Oliver Hartkopp wrote:
> Hello Dong,
>
> some general remarks from my side ...
>
> On 27.06.2014 12:00, Dong Aisheng wrote:
> >
> > M_CAN also supports CANFD protocol features like data payload up to 64 bytes
> > and b
Hi Mark,
First of all, thanks for the quick and carefully review.
On Fri, Jun 27, 2014 at 01:35:45PM +0100, Mark Rutland wrote:
> On Fri, Jun 27, 2014 at 11:00:44AM +0100, Dong Aisheng wrote:
> > The patch adds the basic CAN TX/RX function support for Bosch M_CAN
> > control
add loopback and monitor mode support.
Signed-off-by: Dong Aisheng
---
drivers/net/can/m_can.c | 24 ++--
1 files changed, 22 insertions(+), 2 deletions(-)
diff --git a/drivers/net/can/m_can.c b/drivers/net/can/m_can.c
index e4aed71..bbe8a7d 100644
--- a/drivers/net/can
Add bus error, state change, lost message handling mechanism.
Signed-off-by: Dong Aisheng
---
drivers/net/can/m_can.c | 271 +--
1 files changed, 240 insertions(+), 31 deletions(-)
diff --git a/drivers/net/can/m_can.c b/drivers/net/can/m_can.c
index
controller driver,
then we can gain better driver maintainability and future features upgrade.
M_CAN also supports CANFD protocol features like data payload up to 64 bytes
and bitrate switch at runtime, however, this patch still does not add the
support for these features.
Signed-off-by: Dong Aisheng
The patch series adds the basic function support for Bosch M_CAN controller
Dong Aisheng (3):
can: m_can: add Bosch M_CAN controller support
can: m_can: add bus error handling
can: m_can: add loopback and monitor mode support
.../devicetree/bindings/net/can/m_can.txt | 29
67 matches
Mail list logo
