[PATCH v9 2/5] ARM64: add SBSA Generic Watchdog device node in foundation-v8.dts

2015-11-08 Thread fu . wei
From: Fu Wei This can be a example of adding SBSA Generic Watchdog device node into some dts files for the Soc which contains SBSA Generic Watchdog. Acked-by: Arnd Bergmann Signed-off-by: Fu Wei --- arch/arm64/boot/dts/arm/foundation-v8.dts | 7 +++ 1 file changed, 7 insertions(+) diff

[PATCH v9 4/5] Watchdog: introdouce "pretimeout" into framework

2015-11-08 Thread fu . wei
From: Fu Wei Also update Documentation/watchdog/watchdog-kernel-api.txt to introduce: (1)the new elements in the watchdog_device and watchdog_ops struct; (2)the new API "watchdog_init_timeouts" Reasons: (1)kernel already has two watchdog drivers are using "pretimeout":

[PATCH v9 3/5] ARM64: add SBSA Generic Watchdog device node in amd-seattle-soc.dtsi

2015-11-08 Thread fu . wei
From: Fu Wei This can be a example of adding SBSA Generic Watchdog device node into some dts files for the Soc which contains SBSA Generic Watchdog. Acked-by: Arnd Bergmann Acked-by: Suravee Suthikulpanit Tested-by: Suravee Suthikulpanit Signed-off-by: Fu Wei --- arch/arm64/boot/dts/amd

[PATCH v9 5/5] Watchdog: introduce ARM SBSA watchdog driver

2015-11-08 Thread fu . wei
From: Fu Wei This driver bases on linux kernel watchdog framework, and use "pretimeout" in the framework. It supports getting timeout and pretimeout from parameter and FDT at the driver init stage. In first timeout, the interrupt routine run panic to save system context. Signed-off-

[PATCH v9 1/5] Documentation: add sbsa-gwdt driver documentation

2015-11-08 Thread fu . wei
From: Fu Wei The sbsa-gwdt.txt documentation in devicetree/bindings/watchdog is for introducing SBSA(Server Base System Architecture) Generic Watchdog device node info into FDT. Also add sbsa-gwdt introduction in watchdog-parameters.txt Acked-by: Arnd Bergmann Signed-off-by: Fu Wei

[PATCH v9 0/5] Watchdog: introduce ARM SBSA watchdog driver

2015-11-08 Thread fu . wei
From: Fu Wei This patchset: (1)Introduce Documentation/devicetree/bindings/watchdog/sbsa-gwdt.txt for FDT info of SBSA Generic Watchdog, and give two examples of adding SBSA Generic Watchdog device node into the dts files: foundation-v8.dts and amd-seattle-soc.dtsi. (2

Re: [Linaro-acpi] [PATCH v8 5/5] Watchdog: introduce ARM SBSA watchdog driver

2015-11-05 Thread Fu Wei
member of the > Code Aurora Forum, a Linux Foundation Collaborative Project. -- Best regards, Fu Wei Software Engineer Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch Ph: +86 21 61221326(direct) Ph: +86 186 2020 4684 (mobile) Room 1512, Regus One Corporate Avenue,Level 15, One Corporate Ave

Re: [Linaro-acpi] [PATCH v8 5/5] Watchdog: introduce ARM SBSA watchdog driver

2015-11-05 Thread Fu Wei
Hi Guenter, Great thanks for that you are still reviewing this patchset, thanks for your patient. On 6 November 2015 at 00:41, Guenter Roeck wrote: > On 11/05/2015 07:00 AM, Fu Wei wrote: >> >> Hi Timur, >> >> On 5 November 2015 at 22:40, Timur Tabi

Re: [Linaro-acpi] [PATCH v8 5/5] Watchdog: introduce ARM SBSA watchdog driver

2015-11-05 Thread Fu Wei
Hi Timur, On 5 November 2015 at 22:40, Timur Tabi wrote: > Fu Wei wrote: >> >> Did you really read the "Note" above OK, let me paste it again >> and again: >> >> SBSA 2.3 Page 23 : >> If a larger watch period is required then the com

Re: [Linaro-acpi] [PATCH v8 5/5] Watchdog: introduce ARM SBSA watchdog driver

2015-11-05 Thread Fu Wei
Hi Timur, On 5 November 2015 at 22:08, Timur Tabi wrote: > Fu Wei wrote: >> >> SBSA 2.3 Page 23 : >> Note: the watchdog offset register is 32 bits wide. This gives a >> maximum watch period of around 10s at a system >> counter frequency of 400MHz. If a larger wat

Re: [Linaro-acpi] [PATCH v8 5/5] Watchdog: introduce ARM SBSA watchdog driver

2015-11-05 Thread Fu Wei
the Generic Timer) shall run at a minimum frequency of 10MHz and maximum of 400MHz. > > -- > Sent by an employee of the Qualcomm Innovation Center, Inc. > The Qualcomm Innovation Center, Inc. is a member of the > Code Aurora Forum, hosted by The Linux Foundation. -- Be

Re: [Linaro-acpi] [PATCH v8 5/5] Watchdog: introduce ARM SBSA watchdog driver

2015-11-05 Thread Fu Wei
; such short timeouts in the watchdog core. Until then, I would argue that the unless WOR become 64 bit (or more then 32bit), this limitation will be there. > system designers asked for it if they really select the highest possible > clock rate. > even we can make clk to be 100MHz or lo

Re: [PATCH v8 1/5] Documentation: add sbsa-gwdt driver documentation

2015-11-01 Thread Fu Wei
not sure if there is a hardware with WS1 interrupt we need to handle. > > > -- > Qualcomm Innovation Center, Inc. > The Qualcomm Innovation Center, Inc. is a member of the > Code Aurora Forum, a Linux Foundation Collaborative Project. -- Best regards, Fu Wei Software Engineer

Re: [PATCH v8 1/5] Documentation: add sbsa-gwdt driver documentation

2015-11-01 Thread Fu Wei
Hi Mark, Great thanks for your feedback. On 31 October 2015 at 03:05, Mark Rutland wrote: > On Fri, Oct 30, 2015 at 01:53:24PM -0500, Timur Tabi wrote: >> On 10/30/2015 01:35 PM, Fu Wei wrote: >> >>I think maybe Mark was asking why WS1 is optional, not the WS1 >> &g

Re: [PATCH v8 1/5] Documentation: add sbsa-gwdt driver documentation

2015-10-30 Thread Fu Wei
Hi Timur On 31 October 2015 at 01:46, Timur Tabi wrote: > On Tue, Oct 27, 2015 at 11:10 PM, Fu Wei wrote: >> >>> Why is WS1 optional? >> >> According to the description of WS1 in SBSA 2.3 (5.2 Watchdog Operation) >> page 21 >> - &g

Re: [PATCH v8 1/5] Documentation: add sbsa-gwdt driver documentation

2015-10-27 Thread Fu Wei
Hi Mark Thanks for your rapid feedback, I appreciate your help very much. On 28 October 2015 at 00:22, Mark Rutland wrote: > On Wed, Oct 28, 2015 at 12:06:35AM +0800, fu@linaro.org wrote: >> From: Fu Wei >> >> The sbsa-gwdt.txt documentation in devicetree/bin

[PATCH v8 0/5] Watchdog: introduce ARM SBSA watchdog driver

2015-10-27 Thread fu . wei
From: Fu Wei This patchset: (1)Introduce Documentation/devicetree/bindings/watchdog/sbsa-gwdt.txt for FDT info of SBSA Generic Watchdog, and give two examples of adding SBSA Generic Watchdog device node into the dts files: foundation-v8.dts and amd-seattle-soc.dtsi. (2

[PATCH v8 2/5] ARM64: add SBSA Generic Watchdog device node in foundation-v8.dts

2015-10-27 Thread fu . wei
From: Fu Wei This can be a example of adding SBSA Generic Watchdog device node into some dts files for the Soc which contains SBSA Generic Watchdog. Acked-by: Arnd Bergmann Signed-off-by: Fu Wei --- arch/arm64/boot/dts/arm/foundation-v8.dts | 7 +++ 1 file changed, 7 insertions(+) diff

[PATCH v8 5/5] Watchdog: introduce ARM SBSA watchdog driver

2015-10-27 Thread fu . wei
From: Fu Wei This driver bases on linux kernel watchdog framework, and use "pretimeout" in the framework. It supports getting timeout and pretimeout from parameter and FDT at the driver init stage. In first timeout, the interrupt routine run panic to save system context. Signed-off-

[PATCH v8 4/5] Watchdog: introdouce "pretimeout" into framework

2015-10-27 Thread fu . wei
From: Fu Wei Also update Documentation/watchdog/watchdog-kernel-api.txt to introduce: (1)the new elements in the watchdog_device and watchdog_ops struct; (2)the new API "watchdog_init_timeouts" Reasons: (1)kernel already has two watchdog drivers are using "pretimeout":

[PATCH v8 1/5] Documentation: add sbsa-gwdt driver documentation

2015-10-27 Thread fu . wei
From: Fu Wei The sbsa-gwdt.txt documentation in devicetree/bindings/watchdog is for introducing SBSA(Server Base System Architecture) Generic Watchdog device node info into FDT. Also add sbsa-gwdt introduction in watchdog-parameters.txt Acked-by: Arnd Bergmann Signed-off-by: Fu Wei

[PATCH v8 3/5] ARM64: add SBSA Generic Watchdog device node in amd-seattle-soc.dtsi

2015-10-27 Thread fu . wei
From: Fu Wei This can be a example of adding SBSA Generic Watchdog device node into some dts files for the Soc which contains SBSA Generic Watchdog. Acked-by: Arnd Bergmann Acked-by: Suravee Suthikulpanit Tested-by: Suravee Suthikulpanit Signed-off-by: Fu Wei --- arch/arm64/boot/dts/amd

Re: [PATCH v7 5/8] Watchdog: introduce ARM SBSA watchdog driver

2015-10-13 Thread Fu Wei
> +++ b/drivers/watchdog/sbsa_gwdt.c >> >> @@ -0,0 +1,459 @@ >> >> +/* >> >> + * SBSA(Server Base System Architecture) Generic Watchdog driver >> >> + * >> >> + * Copyright (c) 2015, Linaro Ltd. >> >> + * Author: Fu Wei >> >> + *

Re: [PATCH v7 0/8] Watchdog: introduce ARM SBSA watchdog driver

2015-09-30 Thread Fu Wei
Hi Pratyush, Great thanks for your testing, this info is very helpful. :-) my new patchset will come out soon. On 30 September 2015 at 13:13, Pratyush Anand wrote: > Hi Fu Wei, > > On 25/08/2015:01:01:15 AM, fu@linaro.org wrote: >> From: Fu Wei >> >> This pa

Re: [PATCH v7 2/8] ARM64: add SBSA Generic Watchdog device node in foundation-v8.dts

2015-09-15 Thread Fu Wei
Hi Pratyush, On 15 September 2015 at 17:44, Pratyush Anand wrote: > On 15/09/2015:04:43:32 PM, Dave Young wrote: >> On 08/25/15 at 01:01am, fu@linaro.org wrote: >> > From: Fu Wei >> > >> > This can be a example of adding SBSA Generic Watchdog device n

Re: [PATCH v7 2/8] ARM64: add SBSA Generic Watchdog device node in foundation-v8.dts

2015-09-15 Thread Fu Wei
Hi Dave, On 15 September 2015 at 16:43, Dave Young wrote: > On 08/25/15 at 01:01am, fu@linaro.org wrote: >> From: Fu Wei >> >> This can be a example of adding SBSA Generic Watchdog device node >> into some dts files for the Soc which contains SBSA Generic Wat

Re: [PATCH v7 5/8] Watchdog: introduce ARM SBSA watchdog driver

2015-09-15 Thread Fu Wei
Hi Dave, On 15 September 2015 at 16:38, Dave Young wrote: > On 08/25/15 at 01:01am, fu@linaro.org wrote: >> From: Fu Wei >> >> This driver bases on linux kernel watchdog framework, and >> use "pretimeout" in the framework. It supports getting timeout and

Re: [PATCH v4 5/7] Watchdog: introduce ARM SBSA watchdog driver

2015-09-14 Thread Fu Wei
upstreaming, the support is there. After discussing with some kexec/kdump developer, I think this driver can cooperate with kexec/kdump. > > Jon. > -- Best regards, Fu Wei Software Engineer Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch Ph: +86 21 61221326(direct) Ph: +86 186 20

Re: [PATCH v7 5/8] Watchdog: introduce ARM SBSA watchdog driver

2015-09-14 Thread Fu Wei
ut NOT 15 seconds.* If everything goes well, system will keep running. Hope I understand the question correctly, please correct me if I miss something or said anything wrong. Great thanks for your feedback! > > Guenter > -- Best regards, Fu Wei Software Engineer Red Hat Software (

Re: [PATCH v4 5/7] Watchdog: introduce ARM SBSA watchdog driver

2015-09-14 Thread Fu Wei
hdog in kdump kernel(if > the watchdog driver has been registered to watchdog_class). It will eventually > help a watchdog on ARM64 platform as well. > > [1] https://lists.fedoraproject.org/pipermail/kexec/2015-September/002295.html > [2] https://github.com/pratyushanand/kexec-tools/comm

Re: [PATCH v7 8/8] clocksource: simplify ACPI code in arm_arch_timer.c

2015-08-27 Thread Fu Wei
...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Best regards, Fu Wei Software Engineer Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch Ph: +86 21 61221326(direct) Ph: +86 186 2020 4684 (mobile) Room 1512, Regus One Corporate Avenue,Level 15, One C

Re: [PATCH v7 8/8] clocksource: simplify ACPI code in arm_arch_timer.c

2015-08-25 Thread Fu Wei
will add the maintainers of clocksource into cc list. > >> From: Fu Wei >> >> The patch update arm_arch_timer driver to use the function >> provided by the new GTDT driver of ACPI. >> By this way, arm_arch_timer.c can be simplified, and separate >> all the ACPI GTDT

[PATCH v7 0/8] Watchdog: introduce ARM SBSA watchdog driver

2015-08-24 Thread fu . wei
From: Fu Wei This patchset: (1)Introduce Documentation/devicetree/bindings/watchdog/sbsa-gwdt.txt for FDT info of SBSA Generic Watchdog, and give two examples of adding SBSA Generic Watchdog device node into the dts files: foundation-v8.dts and amd-seattle-soc.dtsi. (2

[PATCH v7 2/8] ARM64: add SBSA Generic Watchdog device node in foundation-v8.dts

2015-08-24 Thread fu . wei
From: Fu Wei This can be a example of adding SBSA Generic Watchdog device node into some dts files for the Soc which contains SBSA Generic Watchdog. Acked-by: Arnd Bergmann Signed-off-by: Fu Wei --- arch/arm64/boot/dts/arm/foundation-v8.dts | 7 +++ 1 file changed, 7 insertions(+) diff

[PATCH v7 3/8] ARM64: add SBSA Generic Watchdog device node in amd-seattle-soc.dtsi

2015-08-24 Thread fu . wei
From: Fu Wei This can be a example of adding SBSA Generic Watchdog device node into some dts files for the Soc which contains SBSA Generic Watchdog. Acked-by: Arnd Bergmann Acked-by: Suravee Suthikulpanit Tested-by: Suravee Suthikulpanit Signed-off-by: Fu Wei --- arch/arm64/boot/dts/amd

[PATCH v7 4/8] Watchdog: introdouce "pretimeout" into framework

2015-08-24 Thread fu . wei
From: Fu Wei Also update Documentation/watchdog/watchdog-kernel-api.txt to introduce: (1)the new elements in the watchdog_device and watchdog_ops struct; (2)the new API "watchdog_init_timeouts" Reasons: (1)kernel already has two watchdog drivers are using "pretimeout":

[PATCH v7 6/8] ACPI: add GTDT table parse driver into ACPI driver

2015-08-24 Thread fu . wei
From: Fu Wei This driver adds support for parsing SBSA Generic Watchdog Structure in GTDT, and creating a platform device with that information. This allows the operating system to obtain device data from the resource of platform device. The platform device named "sbsa-gwdt" can be u

[PATCH v7 5/8] Watchdog: introduce ARM SBSA watchdog driver

2015-08-24 Thread fu . wei
From: Fu Wei This driver bases on linux kernel watchdog framework, and use "pretimeout" in the framework. It supports getting timeout and pretimeout from parameter and FDT at the driver init stage. In first timeout, the interrupt routine run panic to save system context. Signed-off-

[PATCH v7 7/8] Watchdog: enable ACPI GTDT support for ARM SBSA watchdog driver

2015-08-24 Thread fu . wei
From: Fu Wei This patch enables ACPI GTDT support for ARM SBSA watchdog driver automatically, if ACPI support is enabled. Signed-off-by: Fu Wei --- drivers/watchdog/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig index b2734f0

[PATCH v7 8/8] clocksource: simplify ACPI code in arm_arch_timer.c

2015-08-24 Thread fu . wei
From: Fu Wei The patch update arm_arch_timer driver to use the function provided by the new GTDT driver of ACPI. By this way, arm_arch_timer.c can be simplified, and separate all the ACPI GTDT knowledge from this timer driver. Signed-off-by: Fu Wei Signed-off-by: Hanjun Guo --- arch/arm64

[PATCH v7 1/8] Documentation: add sbsa-gwdt.txt documentation

2015-08-24 Thread fu . wei
From: Fu Wei The sbsa-gwdt.txt documentation in devicetree/bindings/watchdog is for introducing SBSA(Server Base System Architecture) Generic Watchdog device node info into FDT. Acked-by: Arnd Bergmann Signed-off-by: Fu Wei --- .../devicetree/bindings/watchdog/sbsa-gwdt.txt | 32

Re: [PATCH v6 6/8] ACPI: add GTDT table parse driver into ACPI driver

2015-07-23 Thread Fu Wei
Hi Rafael, Any suggestion on the GTDT patch of this patch set? Please let me know if I can do anything to improve it. If it is OK for you, could you add a "Acked-by:"? Great thanks for your time! :-) On 23 June 2015 at 23:59, wrote: > From: Fu Wei > > This driver adds

Re: [PATCH v6 1/8] Documentation: add sbsa-gwdt.txt documentation

2015-07-15 Thread Fu Wei
Hi Rob, I have got your point by chatting with you though IRC, I will improve my patch according to your suggestion. Thanks for your help. On 14 July 2015 at 23:48, Fu Wei wrote: > Hi Rob, > > Great thanks for your review :-) > > On 14 July 2015 at 22:49, Rob Herring wrote: &g

Re: [PATCH v6 1/8] Documentation: add sbsa-gwdt.txt documentation

2015-07-14 Thread Fu Wei
Hi Rob, Great thanks for your review :-) On 14 July 2015 at 22:49, Rob Herring wrote: > On Tue, Jun 23, 2015 at 9:16 AM, wrote: >> From: Fu Wei >> >> The sbsa-gwdt.txt documentation in devicetree/bindings/watchdog is for >> introducing SBSA(Server Base System Arc

Re: [PATCH v6 0/8] Watchdog: introduce ARM SBSA watchdog driver

2015-07-13 Thread Fu Wei
Hi Guenter, Great thanks for your info, looking forward to your feedback. :-) Have a good vacation! :-) On 13 July 2015 at 23:34, Guenter Roeck wrote: > On Mon, Jul 13, 2015 at 05:09:57PM +0800, Fu Wei wrote: >> Hi Guenter, >> >> If you get some time, could you help me o

Re: [PATCH v6 0/8] Watchdog: introduce ARM SBSA watchdog driver

2015-07-13 Thread Fu Wei
Hi Guenter, If you get some time, could you help me on this patchset again? Great thanks for your help! On 30 June 2015 at 03:16, Guenter Roeck wrote: > On 06/29/2015 09:53 AM, Fu Wei wrote: >> >> Hi Guenter, >> >> Any suggestion on this v6 patchset, for now , I only

Re: [PATCH v6 0/8] Watchdog: introduce ARM SBSA watchdog driver

2015-06-30 Thread Fu Wei
Hi Guenter, Great thanks for your time, I can't tell you how much I appreciate your review! :-) np, I will improve my patchset, once I get your suggestion. :-) On 30 June 2015 at 03:16, Guenter Roeck wrote: > On 06/29/2015 09:53 AM, Fu Wei wrote: >> >> Hi Guenter, >>

Re: [PATCH v6 0/8] Watchdog: introduce ARM SBSA watchdog driver

2015-06-29 Thread Fu Wei
for your help. On 23 June 2015 at 22:16, wrote: > From: Fu Wei > > This patchset: > (1)Introduce Documentation/devicetree/bindings/watchdog/sbsa-gwdt.txt > for FDT info of SBSA Generic Watchdog, and give two examples of > adding SBSA Generic Watchdog device node

Re: [non-pretimeout,4/7] Watchdog: introduce ARM SBSA watchdog driver

2015-06-23 Thread Fu Wei
Hi Guenter On 24 June 2015 at 00:43, Guenter Roeck wrote: > On Wed, Jun 24, 2015 at 12:17:19AM +0800, Fu Wei wrote: >> Hi Guenter, >> >> you always can provide help very quickly, thank you very much :-) >> >> On 23 June 2015 at 23:21, Guenter Roeck wrote: >&g

Re: [non-pretimeout,4/7] Watchdog: introduce ARM SBSA watchdog driver

2015-06-23 Thread Fu Wei
Hi Guenter, you always can provide help very quickly, thank you very much :-) On 23 June 2015 at 23:21, Guenter Roeck wrote: > On Tue, Jun 23, 2015 at 09:26:35PM +0800, Fu Wei wrote: >> Hi Guenter, > [ ...] > >> > >> >> + * When the first timeout

[PATCH v6 8/8] clocksource: simplify ACPI code in arm_arch_timer.c

2015-06-23 Thread fu . wei
From: Fu Wei The patch update arm_arch_timer driver to use the function provided by the new GTDT driver of ACPI. By this way, arm_arch_timer.c can be simplified, and separate all the ACPI GTDT knowledge from this timer driver. Signed-off-by: Fu Wei Signed-off-by: Hanjun Guo --- arch/arm64

[PATCH v6 7/8] Watchdog: enable ACPI GTDT support for ARM SBSA watchdog driver

2015-06-23 Thread fu . wei
From: Fu Wei This patch enables ACPI GTDT support for ARM SBSA watchdog driver automatically, if ACPI support is enabled. Signed-off-by: Fu Wei --- drivers/watchdog/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig index e059850

[PATCH v6 6/8] ACPI: add GTDT table parse driver into ACPI driver

2015-06-23 Thread fu . wei
From: Fu Wei This driver adds support for parsing SBSA Generic Watchdog Structure in GTDT, and creating a platform device with that information. This allows the operating system to obtain device data from the resource of platform device. The platform device named "sbsa-gwdt" can be u

[PATCH v6 5/8] Watchdog: introduce ARM SBSA watchdog driver

2015-06-23 Thread fu . wei
From: Fu Wei This driver bases on linux kernel watchdog framework, and use "pretimeout" in the framework. It supports getting timeout and pretimeout from parameter and FDT at the driver init stage. In first timeout, the interrupt routine run panic to save system context. Signed-off-

[PATCH v6 4/8] Watchdog: introdouce "pretimeout" into framework

2015-06-23 Thread fu . wei
From: Fu Wei Also update Documentation/watchdog/watchdog-kernel-api.txt to introduce: (1)the new elements in the watchdog_device and watchdog_ops struct; (2)the new API "watchdog_init_timeouts" Reasons: (1)kernel already has two watchdog drivers are using "pretimeout":

[PATCH v6 1/8] Documentation: add sbsa-gwdt.txt documentation

2015-06-23 Thread fu . wei
From: Fu Wei The sbsa-gwdt.txt documentation in devicetree/bindings/watchdog is for introducing SBSA(Server Base System Architecture) Generic Watchdog device node info into FDT. Acked-by: Arnd Bergmann Signed-off-by: Fu Wei --- .../devicetree/bindings/watchdog/sbsa-gwdt.txt | 36

[PATCH v6 0/8] Watchdog: introduce ARM SBSA watchdog driver

2015-06-23 Thread fu . wei
From: Fu Wei This patchset: (1)Introduce Documentation/devicetree/bindings/watchdog/sbsa-gwdt.txt for FDT info of SBSA Generic Watchdog, and give two examples of adding SBSA Generic Watchdog device node into the dts files: foundation-v8.dts and amd-seattle-soc.dtsi. (2

[PATCH v6 3/8] ARM64: add SBSA Generic Watchdog device node in amd-seattle-soc.dtsi

2015-06-23 Thread fu . wei
From: Fu Wei This can be a example of adding SBSA Generic Watchdog device node into some dts files for the Soc which contains SBSA Generic Watchdog. Acked-by: Arnd Bergmann Acked-by: Suravee Suthikulpanit Tested-by: Suravee Suthikulpanit Signed-off-by: Fu Wei --- arch/arm64/boot/dts/amd

[PATCH v6 2/8] ARM64: add SBSA Generic Watchdog device node in foundation-v8.dts

2015-06-23 Thread fu . wei
From: Fu Wei This can be a example of adding SBSA Generic Watchdog device node into some dts files for the Soc which contains SBSA Generic Watchdog. Acked-by: Arnd Bergmann Signed-off-by: Fu Wei --- arch/arm64/boot/dts/arm/foundation-v8.dts | 10 ++ 1 file changed, 10 insertions

Re: [non-pretimeout,4/7] Watchdog: introduce ARM SBSA watchdog driver

2015-06-23 Thread Fu Wei
Hi Guenter, On 12 June 2015 at 00:28, Guenter Roeck wrote: > On Thu, Jun 11, 2015 at 01:47:29AM +0800, fu@linaro.org wrote: >> From: Fu Wei >> >> This driver bases on linux kernel watchdog framework. >> It supports getting timeout from parameter and FDT >>

Re: [PATCH non-pretimeout 3/7] ARM64: add SBSA Generic Watchdog device node in amd-seattle-soc.dtsi

2015-06-15 Thread Fu Wei
Hi Guenter, On 14 June 2015 at 21:57, Guenter Roeck wrote: > On 06/14/2015 03:05 AM, Fu Wei wrote: >> >> On 13 June 2015 at 04:54, Timur Tabi wrote: >>> >>> On 06/10/2015 12:47 PM, fu@linaro.org wrote: >>>> >>>> >

Re: [PATCH non-pretimeout 4/7] Watchdog: introduce ARM SBSA watchdog driver

2015-06-14 Thread Fu Wei
Qualcomm Innovation Center, Inc. > The Qualcomm Innovation Center, Inc. is a member of the > Code Aurora Forum, hosted by The Linux Foundation. -- Best regards, Fu Wei Software Engineer Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch Ph: +86 21 61221326(direct) Ph: +86 186 2020 4684 (mob

Re: [PATCH non-pretimeout 3/7] ARM64: add SBSA Generic Watchdog device node in amd-seattle-soc.dtsi

2015-06-14 Thread Fu Wei
c. > The Qualcomm Innovation Center, Inc. is a member of the > Code Aurora Forum, a Linux Foundation Collaborative Project. -- Best regards, Fu Wei Software Engineer Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch Ph: +86 21 61221326(direct) Ph: +86 186 2020 4684 (mobile) Room 1512,

Re: [PATCH v5 4/8] Watchdog: introdouce "pretimeout" into framework

2015-06-11 Thread Fu Wei
Hi Guenter, Great thanks for your time. On 11 June 2015 at 00:21, Guenter Roeck wrote: > On 06/10/2015 06:41 AM, fu@linaro.org wrote: >> >> From: Fu Wei >> >> Also update Documentation/watchdog/watchdog-kernel-api.txt to >> introduce: >> (1)the

Re: [PATCH non-pretimeout 4/7] Watchdog: introduce ARM SBSA watchdog driver

2015-06-10 Thread Fu Wei
Hi Guenter, On 11 June 2015 at 13:49, Guenter Roeck wrote: > On 06/10/2015 10:44 PM, Fu Wei wrote: >> >> Hi Guenter, >> >> On 11 June 2015 at 13:33, Guenter Roeck wrote: >>> >>> On 06/10/2015 10:47 AM, fu....@linaro.org wrote: >>>> >

Re: [PATCH non-pretimeout 4/7] Watchdog: introduce ARM SBSA watchdog driver

2015-06-10 Thread Fu Wei
Hi Guenter, On 11 June 2015 at 13:33, Guenter Roeck wrote: > On 06/10/2015 10:47 AM, fu@linaro.org wrote: >> >> From: Fu Wei >> >> This driver bases on linux kernel watchdog framework. >> It supports getting timeout from parameter and FDT >> at the

Re: [PATCH v4 5/7] Watchdog: introduce ARM SBSA watchdog driver

2015-06-10 Thread Fu Wei
Hi Guenter On 11 June 2015 at 13:13, Guenter Roeck wrote: > On 06/10/2015 08:45 PM, Timur Tabi wrote: >> >> Fu Wei wrote: >>> >>> Could you suggest a good way to use WS0, so we can follow SBSA spec? >> >> >> To avoid the timeout/2 problem, WS

Re: [PATCH v4 5/7] Watchdog: introduce ARM SBSA watchdog driver

2015-06-10 Thread Fu Wei
On 11 June 2015 at 11:45, Timur Tabi wrote: > Fu Wei wrote: >> >> Could you suggest a good way to use WS0, so we can follow SBSA spec? > > > To avoid the timeout/2 problem, WS0 calls panic, which is the "real" > timeout/reset. WS1 is then a "backup"

Re: [PATCH v4 5/7] Watchdog: introduce ARM SBSA watchdog driver

2015-06-10 Thread Fu Wei
On 11 June 2015 at 08:22, Timur Tabi wrote: > Fu Wei wrote: >> >> If we make the first stage timeout is timeout/2, this violates the >> definition of timeout. > > > The documentation says that the hardware needs to reset after the timeout > expires. yes ,

Re: [PATCH v4 5/7] Watchdog: introduce ARM SBSA watchdog driver

2015-06-10 Thread Fu Wei
Hi Guenter, On 10 June 2015 at 23:38, Fu Wei wrote: > Hi Guenter, > > > On 10 June 2015 at 11:41, Fu Wei wrote: >> Hi Guenter, >> >> On 10 June 2015 at 00:45, Guenter Roeck wrote: >>> On 06/09/2015 09:29 AM, Timur Tabi wrote: >>>&g

[PATCH non-pretimeout 5/7] ACPI: add GTDT table parse driver into ACPI driver

2015-06-10 Thread fu . wei
From: Fu Wei This driver adds support for parsing SBSA Generic Watchdog Structure in GTDT, and creating a platform device with that information. This allows the operating system to obtain device data from the resource of platform device. The platform device named "sbsa-gwdt" can be u

[PATCH non-pretimeout 6/7] Watchdog: enable ACPI GTDT support for ARM SBSA watchdog driver

2015-06-10 Thread fu . wei
From: Fu Wei This patch enables ACPI GTDT support for ARM SBSA watchdog driver automatically, if ACPI support is enabled. Signed-off-by: Fu Wei --- drivers/watchdog/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig index 554f18a

[PATCH non-pretimeout 7/7] clocksource: simplify ACPI code in arm_arch_timer.c

2015-06-10 Thread fu . wei
From: Fu Wei The patch update arm_arch_timer driver to use the function provided by the new GTDT driver of ACPI. By this way, arm_arch_timer.c can be simplified, and separate all the ACPI GTDT knowledge from this timer driver. Signed-off-by: Fu Wei Signed-off-by: Hanjun Guo --- arch/arm64

[PATCH non-pretimeout 2/7] ARM64: add SBSA Generic Watchdog device node in foundation-v8.dts

2015-06-10 Thread fu . wei
From: Fu Wei This can be a example of adding SBSA Generic Watchdog device node into some dts files for the Soc which contains SBSA Generic Watchdog. Acked-by: Arnd Bergmann Signed-off-by: Fu Wei --- arch/arm64/boot/dts/arm/foundation-v8.dts | 10 ++ 1 file changed, 10 insertions

[PATCH non-pretimeout 3/7] ARM64: add SBSA Generic Watchdog device node in amd-seattle-soc.dtsi

2015-06-10 Thread fu . wei
From: Fu Wei This can be a example of adding SBSA Generic Watchdog device node into some dts files for the Soc which contains SBSA Generic Watchdog. Acked-by: Arnd Bergmann Acked-by: Suravee Suthikulpanit Tested-by: Suravee Suthikulpanit Signed-off-by: Fu Wei --- arch/arm64/boot/dts/amd

[PATCH non-pretimeout 4/7] Watchdog: introduce ARM SBSA watchdog driver

2015-06-10 Thread fu . wei
From: Fu Wei This driver bases on linux kernel watchdog framework. It supports getting timeout from parameter and FDT at the driver init stage. The first timeout period expires, the interrupt routine got another timeout period to run panic for saving system context. Signed-off-by: Fu Wei

[PATCH non-pretimeout 1/7] Documentation: add sbsa-gwdt.txt documentation

2015-06-10 Thread fu . wei
From: Fu Wei The sbsa-gwdt.txt documentation in devicetree/bindings/watchdog is for introducing SBSA(Server Base System Architecture) Generic Watchdog device node info into FDT. Acked-by: Arnd Bergmann Signed-off-by: Fu Wei --- .../devicetree/bindings/watchdog/sbsa-gwdt.txt | 35

[PATCH non-pretimeout 0/7] Watchdog: introduce ARM SBSA watchdog driver

2015-06-10 Thread fu . wei
From: Fu Wei This patchset: (1)Introduce Documentation/devicetree/bindings/watchdog/sbsa-gwdt.txt for FDT info of SBSA Generic Watchdog, and give two examples of adding SBSA Generic Watchdog device node into the dts files: foundation-v8.dts and amd-seattle-soc.dtsi. (2

Re: [PATCH v4 5/7] Watchdog: introduce ARM SBSA watchdog driver

2015-06-10 Thread Fu Wei
Hi Guenter, On 10 June 2015 at 11:41, Fu Wei wrote: > Hi Guenter, > > On 10 June 2015 at 00:45, Guenter Roeck wrote: >> On 06/09/2015 09:29 AM, Timur Tabi wrote: >>> >>> On 06/09/2015 11:22 AM, Guenter Roeck wrote: >>>> >>>> >>

Re: [PATCH v4 5/7] Watchdog: introduce ARM SBSA watchdog driver

2015-06-10 Thread Fu Wei
On 10 June 2015 at 22:36, Fu Wei wrote: > On 10 June 2015 at 22:22, Timur Tabi wrote: >> Fu Wei wrote: >>> >>> Another weakness of only using WOR is the timeout limited by this >>> 32bit register. >>> 10s @400MHz generic Timer >>> >&

Re: [PATCH v4 5/7] Watchdog: introduce ARM SBSA watchdog driver

2015-06-10 Thread Fu Wei
On 10 June 2015 at 22:22, Timur Tabi wrote: > Fu Wei wrote: >> >> Another weakness of only using WOR is the timeout limited by this >> 32bit register. >> 10s @400MHz generic Timer >> >> I don't think this limit is good for a server, once the server

[PATCH v5 8/8] clocksource: simplify ACPI code in arm_arch_timer.c

2015-06-10 Thread fu . wei
From: Fu Wei The patch update arm_arch_timer driver to use the function provided by the new GTDT driver of ACPI. By this way, arm_arch_timer.c can be simplified, and separate all the ACPI GTDT knowledge from this timer driver. Signed-off-by: Fu Wei Signed-off-by: Hanjun Guo --- arch/arm64

[PATCH v5 7/8] Watchdog: enable ACPI GTDT support for ARM SBSA watchdog driver

2015-06-10 Thread fu . wei
From: Fu Wei This patch enables ACPI GTDT support for ARM SBSA watchdog driver automatically, if ACPI support is enabled. Signed-off-by: Fu Wei --- drivers/watchdog/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig index 554f18a

[PATCH v5 1/8] Documentation: add sbsa-gwdt.txt documentation

2015-06-10 Thread fu . wei
From: Fu Wei The sbsa-gwdt.txt documentation in devicetree/bindings/watchdog is for introducing SBSA(Server Base System Architecture) Generic Watchdog device node info into FDT. Acked-by: Arnd Bergmann Signed-off-by: Fu Wei --- .../devicetree/bindings/watchdog/sbsa-gwdt.txt | 36

[PATCH v5 6/8] ACPI: add GTDT table parse driver into ACPI driver

2015-06-10 Thread fu . wei
From: Fu Wei This driver adds support for parsing SBSA Generic Watchdog Structure in GTDT, and creating a platform device with that information. This allows the operating system to obtain device data from the resource of platform device. The platform device named "sbsa-gwdt" can be u

[PATCH v5 4/8] Watchdog: introdouce "pretimeout" into framework

2015-06-10 Thread fu . wei
From: Fu Wei Also update Documentation/watchdog/watchdog-kernel-api.txt to introduce: (1)the new elements in the watchdog_device and watchdog_ops struct; (2)the new API "watchdog_init_timeouts" Reasons: (1)kernel already has two watchdog drivers are using "pretimeout":

[PATCH v5 5/8] Watchdog: introduce ARM SBSA watchdog driver

2015-06-10 Thread fu . wei
From: Fu Wei This driver bases on linux kernel watchdog framework, and use "pretimeout" in the framework. It supports getting timeout and pretimeout from parameter and FDT at the driver init stage. In first timeout, the interrupt routine run panic to save system context. Signed-off-

[PATCH v5 2/8] ARM64: add SBSA Generic Watchdog device node in foundation-v8.dts

2015-06-10 Thread fu . wei
From: Fu Wei This can be a example of adding SBSA Generic Watchdog device node into some dts files for the Soc which contains SBSA Generic Watchdog. Acked-by: Arnd Bergmann Signed-off-by: Fu Wei --- arch/arm64/boot/dts/arm/foundation-v8.dts | 10 ++ 1 file changed, 10 insertions

[PATCH v5 3/8] ARM64: add SBSA Generic Watchdog device node in amd-seattle-soc.dtsi

2015-06-10 Thread fu . wei
From: Fu Wei This can be a example of adding SBSA Generic Watchdog device node into some dts files for the Soc which contains SBSA Generic Watchdog. Acked-by: Arnd Bergmann Acked-by: Suravee Suthikulpanit Tested-by: Suravee Suthikulpanit Signed-off-by: Fu Wei --- arch/arm64/boot/dts/amd

[PATCH v5 0/8] Watchdog: introduce ARM SBSA watchdog driver

2015-06-10 Thread fu . wei
From: Fu Wei This patchset: (1)Introduce Documentation/devicetree/bindings/watchdog/sbsa-gwdt.txt for FDT info of SBSA Generic Watchdog, and give two examples of adding SBSA Generic Watchdog device node into the dts files: foundation-v8.dts and amd-seattle-soc.dtsi. (2

Re: [PATCH v4 5/7] Watchdog: introduce ARM SBSA watchdog driver

2015-06-09 Thread Fu Wei
Hi Guenter, On 10 June 2015 at 11:41, Fu Wei wrote: > Hi Guenter, > > On 10 June 2015 at 00:45, Guenter Roeck wrote: >> On 06/09/2015 09:29 AM, Timur Tabi wrote: >>> >>> On 06/09/2015 11:22 AM, Guenter Roeck wrote: >>>> >>>> >>

Re: [PATCH v4 5/7] Watchdog: introduce ARM SBSA watchdog driver

2015-06-09 Thread Fu Wei
g the two stage timeouts? Any suggestion ? If we make the first stage timeout is timeout/2, this violates the definition of timeout. I don't think users expect interrupt, panic or reboot at timeout/2. And WS1 definitely isn't a backup of WS0. > > Guenter > -- Best regard

Re: [PATCH v4 5/7] Watchdog: introduce ARM SBSA watchdog driver

2015-06-09 Thread Fu Wei
Hi Guenter, Thanks for your feedback On 9 June 2015 at 16:04, Guenter Roeck wrote: > On 06/08/2015 11:37 PM, Fu Wei wrote: > >> >> I would like to stress that pretimeout == 0 should not happen in a >> real server system, that is why we defined a SBSA watchdog,

Re: [PATCH v4 5/7] Watchdog: introduce ARM SBSA watchdog driver

2015-06-08 Thread Fu Wei
Hi Guenter, Thanks for reply so quickly. On 9 June 2015 at 12:37, Guenter Roeck wrote: > On 06/08/2015 08:59 PM, Fu Wei wrote: >> >> Hi Guenter, >> >> >> On 9 June 2015 at 02:26, Guenter Roeck wrote: >>> >>> On 06/08/2015 09:05 AM, Fu Wei w

Re: [PATCH v4 5/7] Watchdog: introduce ARM SBSA watchdog driver

2015-06-08 Thread Fu Wei
Hi Guenter, On 9 June 2015 at 02:26, Guenter Roeck wrote: > On 06/08/2015 09:05 AM, Fu Wei wrote: >> >> Hi Gurnter >> >> On 3 June 2015 at 01:07, Guenter Roeck wrote: >>> >>> On 06/02/2015 09:55 AM, Fu Wei wrote: >>>> >>>>

Re: [PATCH v4 4/7] Watchdog: introdouce "pretimeout" into framework

2015-06-08 Thread Fu Wei
Hi Guenter, Great thanks for your review, On 3 June 2015 at 00:12, Guenter Roeck wrote: > On 06/01/2015 09:05 PM, fu@linaro.org wrote: >> >> From: Fu Wei >> >> Also update Documentation/watchdog/watchdog-kernel-api.txt to >> introduce: >> (1)the

Re: [PATCH v4 5/7] Watchdog: introduce ARM SBSA watchdog driver

2015-06-08 Thread Fu Wei
the backtrace somewhere (eg in nvram using pstore if that is > supported via acpi or efi). yes, you are right , thanks for explaining this. > > Is there reason to believe that this all won't work on arm64 ? I don't think there is a reason. > > Thanks, > Guenter -- Be

Re: [PATCH v4 5/7] Watchdog: introduce ARM SBSA watchdog driver

2015-06-08 Thread Fu Wei
Hi Gurnter On 3 June 2015 at 01:07, Guenter Roeck wrote: > On 06/02/2015 09:55 AM, Fu Wei wrote: >> >> Hi Timur, >> >> Thanks , feedback inline >> >> On 2 June 2015 at 23:32, Timur Tabi wrote: >>> >>> On 06/01/2015 11:05 PM, fu@l

Re: [PATCH v4 5/7] Watchdog: introduce ARM SBSA watchdog driver

2015-06-02 Thread Fu Wei
d); >> + } >> + >> + /* update pretimeout to WOR */ >> + sbsa_gwdt_set_pretimeout(wdd, wdd->pretimeout); >> + >> + ret = devm_request_irq(dev, irq, sbsa_gwdt_interrupt, 0, >> + pdev->name, gwdt); >&

[PATCH v4 2/7] ARM64: add SBSA Generic Watchdog device node in foundation-v8.dts

2015-06-01 Thread fu . wei
From: Fu Wei This can be a example of adding SBSA Generic Watchdog device node into some dts files for the Soc which contains SBSA Generic Watchdog. Acked-by: Arnd Bergmann Signed-off-by: Fu Wei --- arch/arm64/boot/dts/arm/foundation-v8.dts | 10 ++ 1 file changed, 10 insertions

  1   2   >