Re: [PATCH v7 5/8] iio: adc: fsl,imx25-gcq driver

2015-06-13 Thread Hartmut Knaack
Markus Pargmann schrieb am 03.03.2015 um 08:58: > This is a conversion queue driver for the mx25 SoC. It uses the central > ADC which is used by two seperate independent queues. This driver > prepares different conversion configurations for each possible input. > For a conversion it creates a conve

Re: [PATCH v7 4/8] mfd: fsl imx25 Touchscreen ADC driver

2015-06-13 Thread Hartmut Knaack
Markus Pargmann schrieb am 03.03.2015 um 08:58: > This is the core driver for imx25 touchscreen/adc driver. The module > has one shared ADC and two different conversion queues which use the > ADC. The two queues are identical. Both can be used for general purpose > ADC but one is meant to be used f

Re: [PATCH v7 1/3] iio: adc: Cosmic Circuits 10001 ADC driver

2015-01-10 Thread Hartmut Knaack
leaning] > Signed-off-by: Ezequiel Garcia Acked-by: Hartmut Knaack > --- > drivers/iio/adc/Kconfig | 11 ++ > drivers/iio/adc/Makefile | 1 + > drivers/iio/adc/cc10001_adc.c | 423 > ++ > 3 files changed, 435 insert

Re: [PATCH v5 3/7] iio: Add support for DA9150 GPADC

2015-01-01 Thread Hartmut Knaack
Adam Thomson schrieb am 22.12.2014 um 17:51: > This patch adds support for DA9150 Charger & Fuel-Gauge IC GPADC. > > Signed-off-by: Adam Thomson Reviewed-by: Hartmut Knaack > --- > drivers/iio/adc/Kconfig| 9 + > drivers/iio/adc/Makefile | 1 + >

Re: [PATCH v3 2/2] iio: add driver for the TI DAC8554

2014-12-26 Thread Hartmut Knaack
Jonathan Cameron schrieb am 26.12.2014 um 12:51: > On 15/12/14 11:39, Nikolaus Schulz wrote: >> The TI DAC8554 is a quad-channel Digital-to-Analog Converter with an SPI >> interface. >> >> Changes in v3: >> * Small fixes in the documentation of struct dac8554_state >> * Replace some magic constants

Re: [PATCH v3 2/2] iio: add driver for the TI DAC8554

2014-12-18 Thread Hartmut Knaack
i-z" to "three_state" as per > ABI/testing/sysfs-bus-iio > * Register device late in probe function > * Avoid powerdown broadcast update, which touches all DAC on the bus > > Signed-off-by: Nikolaus Schulz Reviewed-by: Hartmut Knaack &g

Re: [PATCH v2 2/2] iio: add driver for the TI DAC8554

2014-12-13 Thread Hartmut Knaack
Hartmut Knaack schrieb am 13.12.2014 um 12:18: > Nikolaus Schulz schrieb am 12.12.2014 um 16:58: >> On Sat, Dec 06, 2014 at 12:36:19PM +0100, Hartmut Knaack wrote: >>> Nikolaus Schulz schrieb am 24.11.2014 um 20:50: >>>> The TI DAC8554 is a quad-channel Digital-t

Re: [PATCH v2 2/2] iio: add driver for the TI DAC8554

2014-12-13 Thread Hartmut Knaack
Nikolaus Schulz schrieb am 12.12.2014 um 16:58: > On Sat, Dec 06, 2014 at 12:36:19PM +0100, Hartmut Knaack wrote: >> Nikolaus Schulz schrieb am 24.11.2014 um 20:50: >>> The TI DAC8554 is a quad-channel Digital-to-Analog Converter with an SPI >>> interface. >>> &

Re: [PATCH v5 1/3] iio: adc: Cosmic Circuits 10001 ADC driver

2014-12-10 Thread Hartmut Knaack
Ezequiel Garcia schrieb am 27.11.2014 um 16:39: > From: Phani Movva > > This commit adds support for Cosmic Circuits 10001 10-bit ADC device. Still some issues left, unfortunately things I pointed out in my last review. > > Signed-off-by: Phani Movva > Signed-off-by: Naidu Tellapati > [Ezequie

Re: [PATCH v2 2/2] iio: add driver for the TI DAC8554

2014-12-06 Thread Hartmut Knaack
Nikolaus Schulz schrieb am 24.11.2014 um 20:50: > The TI DAC8554 is a quad-channel Digital-to-Analog Converter with an SPI > interface. > > Changes in v2: > * Use DMA-safe buffer for SPI transfer > * Normalize powerdown_mode name "hi-z" to "three_state" as per > ABI/testing/sysfs-bus-iio > * Reg

Re: [PATCH v4 3/8] iio: Add support for DA9150 GPADC

2014-12-04 Thread Hartmut Knaack
Adam Thomson schrieb am 25.11.2014 um 19:25: > This patch adds support for DA9150 Charger & Fuel-Gauge IC GPADC. > Moving iio_map_array_register around requires an adaption of the error out path. Please see my comment inline. > Signed-off-by: Adam Thomson > --- > drivers/iio/adc/Kconfig|

Re: [PATCH v3 1/3] iio: adc: Cosmic Circuits 10001 ADC driver

2014-11-25 Thread Hartmut Knaack
Ezequiel Garcia schrieb am 25.11.2014 23:03: > > > On 11/25/2014 06:41 PM, Hartmut Knaack wrote: >>> >>> Unless I'm missing something, that's exactly what XOR does. >>> >>> Example: >>> >>> reserved_channels = 0x2; >>

Re: [PATCH v3 1/3] iio: adc: Cosmic Circuits 10001 ADC driver

2014-11-25 Thread Hartmut Knaack
Ezequiel Garcia schrieb am 25.11.2014 18:46: > > > On 11/21/2014 10:15 PM, Hartmut Knaack wrote: >> Ezequiel Garcia schrieb am 13.11.2014 15:13: >>> From: Phani Movva >>> >>> This commit adds support for Cosmic Circuits 10001 10-bit ADC device. >&g

Re: [PATCH v3 1/3] iio: adc: Cosmic Circuits 10001 ADC driver

2014-11-21 Thread Hartmut Knaack
Ezequiel Garcia schrieb am 13.11.2014 15:13: > From: Phani Movva > > This commit adds support for Cosmic Circuits 10001 10-bit ADC device. A few more issues - some got newly introduced, some have been overseen earlier (and some are just matter of taste ;-) > > Signed-off-by: Phani Movva > Sign

Re: [PATCH v4 2/2] iio: vadc: Qualcomm SPMI PMIC voltage ADC driver

2014-11-17 Thread Hartmut Knaack
Ivan T. Ivanov schrieb am 12.11.2014 09:55: > > On Tue, 2014-11-11 at 23:39 +0100, Hartmut Knaack wrote: >> Ivan T. Ivanov schrieb am 11.11.2014 09:21: >>> Hi Hartmut, >>> >>> On Mon, 2014-11-10 at 22:11 +0100, Hartmut Knaack wrote: >>>> Iva

Re: [PATCH v4 2/2] iio: vadc: Qualcomm SPMI PMIC voltage ADC driver

2014-11-11 Thread Hartmut Knaack
Ivan T. Ivanov schrieb am 11.11.2014 09:21: > Hi Hartmut, > > On Mon, 2014-11-10 at 22:11 +0100, Hartmut Knaack wrote: >> Ivan T. Ivanov schrieb am 03.11.2014 16:24: >>> From: Stanimir Varbanov >>> >>> The voltage ADC is peripheral of Qualcomm SPMI PMI

Re: [PATCH v4 2/2] iio: vadc: Qualcomm SPMI PMIC voltage ADC driver

2014-11-10 Thread Hartmut Knaack
Ivan T. Ivanov schrieb am 03.11.2014 16:24: > From: Stanimir Varbanov > > The voltage ADC is peripheral of Qualcomm SPMI PMIC chips. It has > 15 bits resolution and register space inside PMIC accessible across > SPMI bus. > > The vadc driver registers itself through IIO interface. Reviewing agai

Re: [PATCH v4 1/2] DT: iio: vadc: document dt binding

2014-11-05 Thread Hartmut Knaack
Ivan T. Ivanov schrieb am 03.11.2014 16:24: > From: Stanimir Varbanov > > Document DT binding for Qualcomm SPMI PMIC voltage ADC > driver. > > Signed-off-by: Stanimir Varbanov > Signed-off-by: Ivan T. Ivanov > --- > .../devicetree/bindings/iio/adc/qcom,spmi-vadc.txt | 129 > +

Re: [PATCH v4] iio: iadc: Qualcomm SPMI PMIC current ADC driver

2014-11-01 Thread Hartmut Knaack
Ivan T. Ivanov schrieb am 01.11.2014 17:39: > > On Fri, 2014-10-31 at 21:13 +0100, Hartmut Knaack wrote: >> Ivan T. Ivanov schrieb am 22.10.2014 16:13: >>> The current ADC is peripheral of Qualcomm SPMI PMIC chips. It has >>> 16 bits resolution and register space

Re: [PATCH 3/4] arm: boot: dts: am335x-evm: Make charge delay a DT parameter for tsc

2014-10-31 Thread Hartmut Knaack
Vignesh R schrieb am 27.10.2014 12:08: > The charge delay value is by default 0xB000. But it can be set to lower > values on some boards as long as false pen-ups are avoided. Lowering the > value increases the sampling rate (though current sampling rate is > sufficient for tsc operation). Hence cha

Re: [PATCH 1/4] input: touchscreen: ti_am335x_tsc Interchange touchscreen and ADC steps

2014-10-31 Thread Hartmut Knaack
Vignesh R schrieb am 27.10.2014 12:08: > From: Brad Griffis > > This patch makes the initial changes required to workaround TSC-false > pen-up interrupts. It is required to implement these changes in order to > remove udelay in the TSC interrupt handler and false pen-up events. > The charge step

Re: [PATCH v4] iio: iadc: Qualcomm SPMI PMIC current ADC driver

2014-10-31 Thread Hartmut Knaack
Ivanov > --- > > Changes: > - Address review comments from Hartmut Knaack > > .../devicetree/bindings/iio/adc/qcom,spmi-iadc.txt | 46 ++ > drivers/iio/adc/Kconfig| 14 + > drivers/iio/adc/Makefile | 1 + > dri

Re: [PATCH v3] iio: iadc: Qualcomm SPMI PMIC current ADC driver

2014-10-19 Thread Hartmut Knaack
Ivan T. Ivanov schrieb am 01.10.2014 18:14: > The current ADC is peripheral of Qualcomm SPMI PMIC chips. It has > 16 bits resolution and register space inside PMIC accessible across > SPMI bus. > > The driver registers itself through IIO interface. > Hi, I spotted some issues, see inline. > Signe

Re: [PATCH v3 1/2] iio: vadc: Qualcomm SPMI PMIC voltage ADC driver

2014-10-12 Thread Hartmut Knaack
Stanimir Varbanov schrieb am 25.09.2014 17:30: > Hi Ivan, > > On 09/25/2014 03:47 PM, Ivan T. Ivanov wrote: >> >> Hi Stan, few comment bellow. >> >> On Wed, 2014-09-24 at 15:56 +0300, Stanimir Varbanov wrote: >>> The voltage ADC is peripheral of Qualcomm SPMI PMIC chips. It has >>> 15bits resoluti

Re: [PATCH v3 1/2] iio: vadc: Qualcomm SPMI PMIC voltage ADC driver

2014-10-12 Thread Hartmut Knaack
Stanimir Varbanov schrieb am 24.09.2014 14:56: > The voltage ADC is peripheral of Qualcomm SPMI PMIC chips. It has > 15bits resolution and register space inside PMIC accessible across > SPMI bus. > > The vadc driver registers itself through IIO interface. Quite a lot of changes. Please see my comm

Re: [PATCH v3 2/2] DT: iio: vadc: document dt binding

2014-10-11 Thread Hartmut Knaack
Hi, two small issues inline. Stanimir Varbanov schrieb am 24.09.2014 14:56: > Document DT binding for Qualcomm SPMI PMIC voltage ADC > driver. > > Signed-off-by: Stanimir Varbanov > Signed-off-by: Ivan T. Ivanov > --- > .../devicetree/bindings/iio/adc/qcom,spmi-vadc.txt | 130 > ++

Re: [PATCH 3/8] iio: Add support for DA9150 GPADC

2014-10-11 Thread Hartmut Knaack
Hi, I have put a few comments inline. Adam Thomson schrieb am 23.09.2014 12:53: > This patch adds support for DA9150 Charger & Fuel-Gauge IC GPADC. > > Signed-off-by: Adam Thomson > --- > drivers/iio/adc/Kconfig| 9 + > drivers/iio/adc/Makefile | 1 + > drivers/iio/adc/da9150-

Re: [PATCH v4 2/3] iio/adc: add support for axp288 adc

2014-09-18 Thread Hartmut Knaack
Jacob Pan schrieb, Am 18.09.2014 01:13: > On Thu, 18 Sep 2014 00:20:00 +0200 > Hartmut Knaack wrote: > >> Jacob Pan schrieb, Am 17.09.2014 02:11: >>> Platform driver for X-Powers AXP288 ADC, which is a sub-device of >>> the customized AXP288 PMIC for Intel Baytra

Re: [PATCH v4 2/3] iio/adc: add support for axp288 adc

2014-09-17 Thread Hartmut Knaack
Hartmut Knaack schrieb, Am 18.09.2014 00:20: > Jacob Pan schrieb, Am 17.09.2014 02:11: >> Platform driver for X-Powers AXP288 ADC, which is a sub-device of the >> customized AXP288 PMIC for Intel Baytrail-CR platforms. GPADC device >> enumerates as one of the MFD cell

Re: [PATCH v4 2/3] iio/adc: add support for axp288 adc

2014-09-17 Thread Hartmut Knaack
Jacob Pan schrieb, Am 17.09.2014 02:11: > Platform driver for X-Powers AXP288 ADC, which is a sub-device of the > customized AXP288 PMIC for Intel Baytrail-CR platforms. GPADC device > enumerates as one of the MFD cell devices. It uses IIO infrastructure > to communicate with userspace and consumer

Re: [PATCH v3] iio: adc: rockchip_saradc: add support for rk3066-tsadc variant

2014-09-16 Thread Hartmut Knaack
erature. The returned voltage can then be converted by a > suitable thermal driver to and actual temperature and used for thermal > handling. > > Signed-off-by: Heiko Stuebner Acked-by: Hartmut Knaack > --- > changes since v2: > - adapt message about the clk rate > changes

Re: [PATCH v3 5/5] iio: add documentation for current attribute

2014-09-14 Thread Hartmut Knaack
Jonathan Cameron schrieb, Am 13.09.2014 21:55: > On 12/09/14 00:15, Jacob Pan wrote: >> Add documentation for input current raw reading and scale. >> >> Signed-off-by: Jacob Pan > The content is fine, but please look at how the other types are handled. > The raw attribute is described along with t

Re: [PATCH v2] iio: adc: rockchip_saradc: add support for rk3066-tsadc variant

2014-09-13 Thread Hartmut Knaack
ead of creating the mask manually > as suggested by Hartmut Knaack > > I've also opted for simply keeping the indent mismatch in > struct rockchip_saradc, as I don't think it's worth the churn > it produces > > .../bindings/iio/adc/rockchip-saradc.txt

Re: [PATCH v2 2/2] DT: iio: vadc: document dt binding

2014-09-12 Thread Hartmut Knaack
Stanimir Varbanov schrieb, Am 11.09.2014 17:13: > Document DT binding for Qualcomm SPMI PMIC voltage ADC > driver. > Still one typo left. > Signed-off-by: Stanimir Varbanov > Signed-off-by: Ivan T. Ivanov > --- > .../devicetree/bindings/iio/adc/qcom,spmi-vadc.txt | 123 >

Re: [PATCH v2 1/2] iio: vadc: Qualcomm SPMI PMIC voltage ADC driver

2014-09-12 Thread Hartmut Knaack
Stanimir Varbanov schrieb, Am 11.09.2014 17:13: > The voltage ADC is peripheral of Qualcomm SPMI PMIC chips. It has > 15bits resolution and register space inside PMIC accessible across > SPMI bus. > > The vadc driver registers itself through IIO interface. > Looks already pretty good. Things you

Re: [PATCH 2/2] DT: iio: vadc: document dt binding

2014-09-09 Thread Hartmut Knaack
Stanimir Varbanov schrieb, Am 05.09.2014 14:14: > Document DT binding for Qualcomm SPMI PMIC voltage ADC > driver. > > Signed-off-by: Stanimir Varbanov > Signed-off-by: Ivan T. Ivanov > --- > .../devicetree/bindings/iio/adc/qcom,spmi-vadc.txt | 110 > > 1 files changed, 1

Re: [PATCH] iio: adc: rockchip_saradc: add support for rk3066-tsadc variant

2014-09-02 Thread Hartmut Knaack
Heiko Stübner schrieb: > Older Rockchip SoCs, at least the rk3066, used a slightly modified saradc > for temperature measurements. This so called tsadc does not contain any > active parts like temperature interrupts and only supports polling the > current temperature. The returned voltage can then

Re: [PATCH 2/2] iio: adc: exynos_adc: Add support for S3C24xx ADC

2014-07-27 Thread Hartmut Knaack
Chanwoo Choi schrieb: > This patch add support for s3c2410/s3c2416/s3c2440/s3c2443 ADC. The s3c24xx > is alomost same as ADCv1. But, There are a little difference as following: > - ADCMUX register address to select channel > - ADCDAT mask (10bit or 12bit ADC resolution according to SoC version) Hi,

Re: [PATCH 1/2] iio: adc: exynos_adc: add support for s3c64xx adc

2014-07-27 Thread Hartmut Knaack
Chanwoo Choi schrieb: > From: Arnd Bergmann > > The ADC in s3c64xx is almost the same as exynosv1, but > has a different 'select' method. Adding this here will be > helpful to move over the existing s3c64xx platform from the > legacy plat-samsung/adc driver to the new exynos-adc. > > Signed-off-by

Re: [PATCH 2/2] iio: exynos-adc: add experimental touchscreen support

2014-07-20 Thread Hartmut Knaack
Jonathan Cameron schrieb: > On 18/07/14 20:29, Arnd Bergmann wrote: >> This adds support for the touchscreen on Samsung s3c64xx. >> The driver is completely untested but shows roughly how >> it could be done, following the example of the at91 driver. >> > Hi Arnd, > >> Open questions include: >> >>

Re: [PATCH 1/2] iio: exynos-adc: add support for s3c64xx adc

2014-07-20 Thread Hartmut Knaack
Arnd Bergmann schrieb: > The ADC in s3c64xx is almost the same as exynosv1, but > has a different 'select' method. Adding this here will be > helpful to move over the existing s3c64xx platform from the > legacy plat-samsung/adc driver to the new exynos-adc. > > Signed-off-by: Arnd Bergmann > --- T

Re: [PATCH v5 1/2] iio: adc: add driver for Rockchip saradc

2014-07-20 Thread Hartmut Knaack
er Reviewed-by: Hartmut Knaack > --- Looks good to me. The fact, that SARADC_DLY_PU_SOC_MASK is defined but never used should be fine under the given circumstances, that no datasheet with register definitions is publicly available. > changes since v4: > - address comments from Hartmut

Re: [PATCH v3 1/2] iio: adc: add driver for Rockchip saradc

2014-07-13 Thread Hartmut Knaack
Heiko Stübner schrieb: > The ADC is a 3-channel signal-ended 10-bit Successive Approximation > Register (SAR) A/D Converter. It uses the supply and ground as its reference > and converts the analog input signal into 10-bit binary digital codes. Is there a datasheet available anywhere, or just under

Re: [PATCH 2/2] dt-bindings: document Rockchip saradc

2014-07-11 Thread Hartmut Knaack
Heiko Stübner schrieb: > This add the necessary binding documentation for the saradc found in all > recent > processors from Rockchip. > > Signed-off-by: Heiko Stuebner > --- Spotted some typos, see inline. > .../bindings/iio/adc/rockchip-saradc.txt | 28 > ++ > 1

Re: [PATCH v7] iio: add support of the max1027

2014-06-23 Thread Hartmut Knaack
Philippe Reynes schrieb: > This driver add partial support of the > maxim 1027/1029/1031. Differential mode is not > supported. > > It was tested on armadeus apf27 board. > > Signed-off-by: Philippe Reynes Reviewed-by: Hartmut Knaack > --- Not sure if it's too late,

Re: [PATCH v6] iio: add support of the max1027

2014-06-14 Thread Hartmut Knaack
feedback) >> - add validate_trigger >> - add validate_device >> - remove useless (void *) cast >> - use allocated buffer for spi_write >> >> v4: (thanks Jonathan Cameron for the feedback) >> - use iio_trigger_generic_data_rdy_poll >> >> v3: (thanks H

Re: [PATCH v6] iio: add support of the max1027

2014-06-14 Thread Hartmut Knaack
the feedback) > - add validate_trigger > - add validate_device > - remove useless (void *) cast > - use allocated buffer for spi_write > > v4: (thanks Jonathan Cameron for the feedback) > - use iio_trigger_generic_data_rdy_poll > > v3: (thanks Hartmut Knaack, Lars-Peter C