Re: [PATCH 10/10] i2c: pca954x: get rid of the i2c deadlock workaround

2016-01-04 Thread Lars-Peter Clausen
On 01/04/2016 04:10 PM, Peter Rosin wrote: > From: Peter Rosin > > Signed-off-by: Peter Rosin It would be quite good if the commit messaged said why it is now safe to remove the workaround. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to maj

Re: [PATCH v2 1/4] iio: adc: add IMX7D ADC driver support

2015-11-13 Thread Lars-Peter Clausen
On 11/13/2015 10:39 AM, Haibo Chen wrote: [...] >>> +static void imx7d_adc_feature_config(struct imx7d_adc *info) >>> +{ >>> + info->adc_feature.clk_pre_div = IMX7D_ADC_ANALOG_CLK_PRE_DIV_4; >>> + info->adc_feature.avg_num = IMX7D_ADC_AVERAGE_NUM_32; >>> + info->adc_feature.core_time_unit = 1

Re: [PATCH v2 1/4] iio: adc: add IMX7D ADC driver support

2015-11-10 Thread Lars-Peter Clausen
On 11/09/2015 02:28 PM, Haibo Chen wrote: > Freescale i.MX7D soc contains a new ADC IP. This patch add this ADC > driver support, and the driver only support ADC software trigger. > > Signed-off-by: Haibo Chen Looks pretty good, a few comments inline. [...] > +#include > +#include > +#include

Re: IIO device indexing issue

2015-11-04 Thread Lars-Peter Clausen
On 11/02/2015 07:47 PM, Vesa Jääskeläinen wrote: > Hi, > > When we were using kernel 3.2 and with that board files we just got IIO > devices with static order so that we knew exactly what iio:device0 is. > > Now with device tree that order is not so static anymore especially when > using device o

Re: [PATCH v3 2/3] iio:adc:palmas: add DT support

2015-10-19 Thread Lars-Peter Clausen
On 10/16/2015 02:53 PM, H. Nikolaus Schaller wrote: [...] > +Optional sub-nodes: > +ti,channel0-current-microamp: Channel 0 current in uA. > + Values are rounded to derive 0uA, 5uA, 15uA, 20uA. > +ti,channel3-current-microamp: Channel 3 current in uA. > + Valid are rounded to derive 0uA, 10

Re: [PATCH 2/5] gpio/xilinx: enable for MIPS

2015-10-14 Thread Lars-Peter Clausen
On 10/14/2015 06:54 PM, Sören Brinkmann wrote: > On Wed, 2015-10-14 at 05:57PM +0200, Lars-Peter Clausen wrote: >> On 10/14/2015 05:18 PM, Sören Brinkmann wrote: >>> On Wed, 2015-10-14 at 01:51PM +0100, Zubair Lutfullah Kakakhel wrote: >>>> MIPSfpga uses the axi gpio

Re: [PATCH 2/5] gpio/xilinx: enable for MIPS

2015-10-14 Thread Lars-Peter Clausen
On 10/14/2015 05:18 PM, Sören Brinkmann wrote: > On Wed, 2015-10-14 at 01:51PM +0100, Zubair Lutfullah Kakakhel wrote: >> MIPSfpga uses the axi gpio controller. Enable the driver for MIPS. >> >> Signed-off-by: Zubair Lutfullah Kakakhel >> --- >> drivers/gpio/Kconfig | 2 +- >> 1 file changed, 1 i

Re: [PATCH v3] iio: mma8452: support either of the available interrupt pins

2015-10-14 Thread Lars-Peter Clausen
On 10/14/2015 03:15 PM, Martin Kepplinger wrote: [...] > + if (irq1 > 0) > + client->irq = irq1; You must not overwrite client->irq, that field is manged by the I2C core and is supposed to be read only for device drivers. > + dev

Re: [PATCHv2 1/3] Documentation: ad5064: Added devicetree bindings documentation

2015-10-13 Thread Lars-Peter Clausen
>> + >> +Optional properties: >> +- vref-supply: phandle to the external reference voltage supply. >> + This should only be set if there is an external reference voltage >> + connected to the vref or vref[A-D] pins. > > I don't understand. Surely the latter case means you're describi

Re: [RFC v2 4/4] iio: chemical: add SGX VZ89x VOC sensor support

2015-09-07 Thread Lars-Peter Clausen
On 09/07/2015 06:27 AM, Matt Ranostay wrote: > Thinking this over do we needed a IIO_CHAN_INFO_PROCESSED_OFFSET to > signal that it needs to be after the (value - offset) * scale > calculation? Well, value * scale + offset = (value + offset/scale) * scale. So just scale your offset inversely to th

Re: [PATCH v4 1/2] Documentation: dt: Add Xilinx zynqmp dma device tree binding documentation

2015-08-24 Thread Lars-Peter Clausen
On 08/06/2015 05:19 AM, Punnaiah Choudary Kalluri wrote: [...] > +Optional properties: > +- xlnx,include-sg: Indicates the controller to operate in simple or scatter > +gather dma mode > +- xlnx,ratectrl: Scheduling interval in terms of clock cycles for > + source AXI t

Re: [PATCH] Altera Modular ADC driver device tree binding

2015-08-20 Thread Lars-Peter Clausen
On 08/20/2015 09:46 AM, Chee Nouk Phoo wrote: > From: Chee Nouk Phoon > > Altera Modular ADC is soft IP that wraps the hardened ADC block in a Max1 > device. It can be configured to dual ADC mode that supports two channel > synchronous sampling or independent single ADCs. ADC sampled values will

[PATCH v2 1/2] devicetree: Add bindings documentation for Analog Devices AXI-DMAC

2015-08-20 Thread Lars-Peter Clausen
. Signed-off-by: Lars-Peter Clausen --- No changes since v1 --- .../devicetree/bindings/dma/adi,axi-dmac.txt | 61 ++ include/dt-bindings/dma/axi-dmac.h | 48 + 2 files changed, 109 insertions(+) create mode 100644 Documentation/devicetree

[PATCH v2 2/2] dmaengine: Add support for the Analog Devices AXI-DMAC DMA controller

2015-08-20 Thread Lars-Peter Clausen
used for the descriptor queue flow control. Currently the driver supports SG, cyclic and interleaved slave DMA. Signed-off-by: Lars-Peter Clausen --- Changes since v1: * Use GFP_NOWAIT instead of GFP_ATOMIC * Add small description of the architecture of the contr

Re: [PATCH 2/2] dmaengine: Add support for the Analog Devices AXI-DMAC DMA controller

2015-08-19 Thread Lars-Peter Clausen
On 08/19/2015 07:12 PM, Vinod Koul wrote: > On Tue, Jul 28, 2015 at 11:38:06AM +0200, Lars-Peter Clausen wrote: >> +static void axi_dmac_start_transfer(struct axi_dmac_chan *chan) >> +{ >> +struct axi_dmac *dmac = chan_to_axi_dmac(chan); >> +struct virt_dma_

Re: [PATCH 2/2] dmaengine: Add support for the Analog Devices AXI-DMAC DMA controller

2015-08-19 Thread Lars-Peter Clausen
On 08/19/2015 06:32 PM, Vinod Koul wrote: > On Tue, Jul 28, 2015 at 11:38:06AM +0200, Lars-Peter Clausen wrote: >> +active = axi_dmac_active_desc(chan); >> +if (!active) >> +return; >> + >> +if (active->cyclic) { >> +

Re: [PATCH v3 1/7] iio: adc: hi8435: Holt HI-8435 threshold detector

2015-08-11 Thread Lars-Peter Clausen
On 08/08/2015 07:56 PM, Jonathan Cameron wrote: > On 29/07/15 13:56, Vladimir Barinov wrote: >> Add Holt threshold detector driver for HI-8435 chip >> >> Signed-off-by: Vladimir Barinov > Because it usually reads better that way, I review from the bottom. > Might make more sense if you read the co

Re: [PATCH v3 5/7] iio: Support triggered events

2015-08-07 Thread Lars-Peter Clausen
Hi, On 07/29/2015 02:57 PM, Vladimir Barinov wrote: > Support triggered events. > > This is useful for chips that don't have their own interrupt sources. > It allows to use generic/standalone iio triggers for those drivers. > Thanks for the patch. Can you describe in more detail how INDIO_EVENT

Re: [PATCH v3 4/7] iio: trigger: Add periodic polling to SYSFS trigger

2015-08-07 Thread Lars-Peter Clausen
On 07/29/2015 02:57 PM, Vladimir Barinov wrote: > Add periodic polling functionality to SYSFS trigger Daniel's hrtimer trigger should be used for this instead of modifying the sysfs trigger timer. See https://lkml.org/lkml/2015/5/8/367 He said he'll send out a new version shortly. - Lars -- To

Re: [PATCH 2/2] iio: proximity: add support for PulsedLight LIDAR

2015-08-03 Thread Lars-Peter Clausen
On 08/02/2015 11:28 PM, Matt Ranostay wrote: > On Sun, Aug 2, 2015 at 2:42 AM, Lars-Peter Clausen wrote: >> On 08/01/2015 05:58 AM, Matt Ranostay wrote: >> [...] >>> + >>> +struct lidar_data { >>> + struct mutex lock; >>> + struct iio_

Re: [PATCH 2/2] iio: proximity: add support for PulsedLight LIDAR

2015-08-02 Thread Lars-Peter Clausen
On 08/02/2015 08:23 PM, Jonathan Cameron wrote: > On 02/08/15 10:42, Lars-Peter Clausen wrote: >> On 08/01/2015 05:58 AM, Matt Ranostay wrote: >> [...] >>> + >>> +struct lidar_data { >>> + struct mutex lock; >>> + struct ii

Re: [PATCH 2/2] iio: proximity: add support for PulsedLight LIDAR

2015-08-02 Thread Lars-Peter Clausen
On 08/01/2015 05:58 AM, Matt Ranostay wrote: > +static int lidar_read_raw(struct iio_dev *indio_dev, > + struct iio_chan_spec const *chan, > + int *val, int *val2, long mask) > +{ > + struct lidar_data *data = iio_priv(indio_dev); > + int ret = -E

Re: [PATCH 2/2] iio: proximity: add support for PulsedLight LIDAR

2015-08-02 Thread Lars-Peter Clausen
On 08/01/2015 05:58 AM, Matt Ranostay wrote: [...] > + > +struct lidar_data { > + struct mutex lock; > + struct iio_dev *indio_dev; > + struct i2c_client *client; > + > + /* config */ > + int calib_bias; > + > + u16 buffer[5]; /* 2 byte distance + 8 byte timestamp */ Needs

[PATCH 1/2] devicetree: Add bindings documentation for Analog Devices AXI-DMAC

2015-07-28 Thread Lars-Peter Clausen
. Signed-off-by: Lars-Peter Clausen --- .../devicetree/bindings/dma/adi,axi-dmac.txt | 54 ++ include/dt-bindings/dma/axi-dmac.h | 48 +++ 2 files changed, 102 insertions(+) create mode 100644 Documentation/devicetree/bindings/dma/adi,axi

[PATCH 2/2] dmaengine: Add support for the Analog Devices AXI-DMAC DMA controller

2015-07-28 Thread Lars-Peter Clausen
used for the descriptor queue flow control. Currently the driver supports SG, cyclic and interleaved slave DMA. Signed-off-by: Lars-Peter Clausen --- MAINTAINERS| 6 + drivers/dma/Kconfig| 10 + drivers/dma/Makefile | 1 + drivers/dma/dma-axi-dmac.c

Re: [PATCH 1/3] iio: adc: hi-843x: Holt HI-8435/8436/8437 descrete ADC

2015-06-18 Thread Lars-Peter Clausen
On 06/07/2015 06:11 PM, Jonathan Cameron wrote: On 01/06/15 13:20, Vladimir Barinov wrote: Add Holt descrete ADC driver for HI-8435/8436/8437 chips Signed-off-by: Vladimir Barinov Hmm. The main issue here is one man's discrete ADC is another man's configurable general purpose input device.

Re: [PATCH 2/2] iio: adc: xilinx-xadc: Add xlnx,extend-name as an optional argument for aux channels

2015-05-26 Thread Lars-Peter Clausen
On 05/23/2015 01:23 PM, Jonathan Cameron wrote: On 19/05/15 18:53, Lars-Peter Clausen wrote: On 05/08/2015 12:44 AM, Xander Huff wrote: To better facilitate user-mode access to optional aux channels, allow device trees to specify a custom extended name for defined channels. Hi, 'extend

[PATCH v2 2/4] mmc: dt: Allow to specify that no write protect signal is present

2015-05-06 Thread Lars-Peter Clausen
n based on the property with the same function from the Synopsys designware mobile storage host controller DT bindings specification. Signed-off-by: Lars-Peter Clausen Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell Cc: Kumar Gala --- Documentation/devicetree/bindings/mmc/m

[PATCH v2 1/4] mmc: Add support for disabling write-protect detection

2015-05-06 Thread Lars-Peter Clausen
. Instead of handling this on a per controller basis this patch adds a new capability flag to the MMC core that can be set to specify that the result of get_ro() is invalid. When the flag is set the core will not call get_ro() and assume that the card is always read-write. Signed-off-by: Lars-Peter

[PATCH 1/2] mmc: sdhci: Add quirk to disable write-protect detection

2015-04-28 Thread Lars-Peter Clausen
-protect status when set. Signed-off-by: Lars-Peter Clausen --- drivers/mmc/host/sdhci.c | 3 +++ drivers/mmc/host/sdhci.h | 2 ++ 2 files changed, 5 insertions(+) diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index c80287a..7448757 100644 --- a/drivers/mmc/host/sdhci.c +++ b

[PATCH 2/2] mmc: sdhci: DT: Allow to specify that no write protect signal is present

2015-04-28 Thread Lars-Peter Clausen
signal is connected. The name for the new property is 'disable-wp' and was chosen based on the property with the same function from the Synopsys designware mobile storage host controller DT bindings specification. Signed-off-by: Lars-Peter Clausen Cc: Rob Herring Cc: Pawel Moll Cc: Mark R

Re: [PATCH V2 1/4] regmap: cache: Add "was_reset" argument to regcache_sync_region()

2015-04-25 Thread Lars-Peter Clausen
On 04/25/2015 12:36 AM, Kevin Cernekee wrote: regcache_sync() and regcache_sync_region() currently assume that the hardware has just emerged from a clean reset, and that all registers are in their default states. But that isn't the only possibility; the device may have been in a different state

Re: [alsa-devel] [PATCH 2/3] ASoC: tas571x: New driver for TI TAS571x power amplifiers

2015-04-16 Thread Lars-Peter Clausen
On 04/15/2015 11:42 PM, Kevin Cernekee wrote: Introduce a new codec driver for the Texas Instruments TAS5711/TAS5717/TAS5719 power amplifier chips. These chips are typically used to take an I2S digital audio input and drive 10-20W into a pair of speakers. Signed-off-by: Kevin Cernekee Looks

Re: [alsa-devel] [PATCH 1/2] ASoC: cygnus-audio: adding device tree bindings

2015-03-31 Thread Lars-Peter Clausen
On 03/31/2015 05:16 AM, Scott Branden wrote: [...] +- ssp-port-id: The ssp port interface to use + Valid value are 0, 1, 2, or 3 (for spdif) How about using 'reg' as the property name here. It is the standard property name for identifying or assigning an address to a sub-node. -- To un

Re: [PATCH_V3] ASoC: jz4740: Add jz4780 support

2015-03-09 Thread Lars-Peter Clausen
Acked-by: Lars-Peter Clausen -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH_V2] ASoC: jz4740: Add jz4780 support

2015-03-09 Thread Lars-Peter Clausen
On 03/09/2015 12:23 PM, Zubair Lutfullah Kakakhel wrote: [...] @@ -460,6 +499,9 @@ static int jz4740_i2s_dev_probe(struct platform_device *pdev) platform_set_drvdata(pdev, i2s); + if (i2s->version >= JZ_I2S_JZ4780) + jz4740_i2s_dai.symmetric_rates = 0; We shouldn'

Re: [PATCH v4] spi: qup: Add DMA capabilities

2015-03-09 Thread Lars-Peter Clausen
On 03/08/2015 01:20 PM, Andy Shevchenko wrote: On Sun, Mar 8, 2015 at 1:21 PM, Lars-Peter Clausen wrote: On 03/07/2015 08:43 PM, Andy Shevchenko wrote: On Sat, Mar 7, 2015 at 1:21 PM, Mark Brown wrote: Applied, but why is there no devm_dma_request_slave_channel_reason()? I suppose the

Re: [PATCH v4] spi: qup: Add DMA capabilities

2015-03-08 Thread Lars-Peter Clausen
On 03/07/2015 08:43 PM, Andy Shevchenko wrote: On Sat, Mar 7, 2015 at 1:21 PM, Mark Brown wrote: On Wed, Mar 04, 2015 at 12:02:05PM +0200, Stanimir Varbanov wrote: From: Andy Gross This patch adds DMA capabilities to the spi-qup driver. If DMA channels are present, the QUP will use DMA inst

Re: [PATCH] ASoC: jz4740: Add jz4780 support

2015-03-07 Thread Lars-Peter Clausen
On 03/06/2015 04:33 PM, Zubair Lutfullah Kakakhel wrote: The jz4780 and jz4740 have very similar i2s blocks. The slight difference is in Rx/Tx fifos. And the bitclocks for input/output are different. This patch adds jz4780 support to the driver Signed-off-by: Zubair Lutfullah Kakakhel Looks

Re: [alsa-devel] [PATCH 2/2] ASoC: simple-card: Add support for samplerate and samplewidth constraints

2015-03-03 Thread Lars-Peter Clausen
On 03/03/2015 01:00 PM, Jyri Sarha wrote: On 03/03/2015 01:30 PM, Mark Brown wrote: On Tue, Mar 03, 2015 at 12:09:14PM +0200, Jyri Sarha wrote: On 03/02/2015 09:58 PM, Lars-Peter Clausen wrote: Can you include a description why this is needed and how and when it is supposed to be used

Re: [alsa-devel] [PATCH 2/2] ASoC: simple-card: Add support for samplerate and samplewidth constraints

2015-03-02 Thread Lars-Peter Clausen
On 03/02/2015 03:14 PM, Jyri Sarha wrote: Add DT properties to dailink for setting samplerate and samplewidth constraints. The DT binding document has been updated. Can you include a description why this is needed and how and when it is supposed to be used? -- To unsubscribe from this list: s

Re: [PATCH_V4 1/3] dt: usb: jz4740: Add DT binding document for OHCI

2015-02-03 Thread Lars-Peter Clausen
On 02/03/2015 11:53 AM, Zubair Lutfullah Kakakhel wrote: On 03/02/15 10:32, Lars-Peter Clausen wrote: On 02/03/2015 11:17 AM, Zubair Lutfullah Kakakhel wrote: [...] V4 Changes Removed clock binding because of pending work in clock tree. Will add binding later. Rather than introduce a bad

Re: [PATCH_V4 1/3] dt: usb: jz4740: Add DT binding document for OHCI

2015-02-03 Thread Lars-Peter Clausen
On 02/03/2015 11:17 AM, Zubair Lutfullah Kakakhel wrote: [...] V4 Changes Removed clock binding because of pending work in clock tree. Will add binding later. Rather than introduce a bad binding now and change later. But this patch is introducing a bad binding. The part needs the clock to work

Re: [alsa-devel] [PATCH_V3 0/4] sound:soc: jz4740: DT, dynamic sampling, enable clocks

2015-01-27 Thread Lars-Peter Clausen
On 01/26/2015 03:53 PM, Zubair Lutfullah Kakakhel wrote: Hi, Here are a few simple patches for the jz4740. For 1-3: Acked-by: Lars-Peter Clausen -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More

Re: [alsa-devel] [PATCH v2 1/3] ASoC: codecs: wm8904: add dt ids table

2015-01-26 Thread Lars-Peter Clausen
On 01/26/2015 05:42 PM, Mark Brown wrote: On Mon, Jan 26, 2015 at 04:24:38PM +0100, Nicolas Ferre wrote: Le 16/01/2015 02:17, Bo Shen a écrit : Does this end up in the i2c_driver_id driver data or do we need some extra code when devtype is assigned to check for an of_node and look at the DT d

Re: [alsa-devel] [PATCH v2 3/3] ASoC: add generic dt-card support

2015-01-26 Thread Lars-Peter Clausen
On 01/24/2015 02:18 PM, Jean-Francois Moine wrote: On Sat, 24 Jan 2015 12:27:35 +0100 Lars-Peter Clausen wrote: On 01/23/2015 07:34 PM, Jean-Francois Moine wrote: On Fri, 23 Jan 2015 14:56:04 +0100 Lars-Peter Clausen wrote: On 01/23/2015 01:15 PM, Jean-Francois Moine wrote: There is no

Re: [alsa-devel] [PATCH 4/4] sound: jz4740: Enable codec clock during dai_probe

2015-01-26 Thread Lars-Peter Clausen
On 01/26/2015 12:30 PM, Zubair Lutfullah Kakakhel wrote: On 26/01/15 10:40, Lars-Peter Clausen wrote: On 01/26/2015 11:18 AM, Zubair Lutfullah Kakakhel wrote: As we are moving away from platform to DT, we cant rely on the board file to do this now. So enable it here. I don't understand

Re: [alsa-devel] [PATCH 2/4] dt: sound: jz4740: Add binding documentation for jz4740-i2s

2015-01-26 Thread Lars-Peter Clausen
On 01/26/2015 12:32 PM, Zubair Lutfullah Kakakhel wrote: On 26/01/15 10:37, Lars-Peter Clausen wrote: On 01/26/2015 11:18 AM, Zubair Lutfullah Kakakhel wrote: [...] +Required properties: +- compatible : "ingenic,jz4740-i2s" +- reg : I2S registers location and length +- clocks : A

Re: [PATCH 4/4] sound: jz4740: Enable codec clock during dai_probe

2015-01-26 Thread Lars-Peter Clausen
On 01/26/2015 11:18 AM, Zubair Lutfullah Kakakhel wrote: As we are moving away from platform to DT, we cant rely on the board file to do this now. So enable it here. I don't understand this changelog. The board file never did this. The driver enables the clock in the startup() callback. Si

Re: [PATCH 2/4] dt: sound: jz4740: Add binding documentation for jz4740-i2s

2015-01-26 Thread Lars-Peter Clausen
On 01/26/2015 11:18 AM, Zubair Lutfullah Kakakhel wrote: [...] +Required properties: +- compatible : "ingenic,jz4740-i2s" +- reg : I2S registers location and length +- clocks : AIC and I2S PLL clock specifiers. +- clock-names: "aic" and "i2s" We also need a handle to the DMA channels. Currently

Re: [PATCH 1/4] sound: soc: jz4740: Add dynamic sampling rate support to jz4740-i2s

2015-01-26 Thread Lars-Peter Clausen
On 01/26/2015 11:18 AM, Zubair Lutfullah Kakakhel wrote: [...] #define JZ_AIC_I2S_FMT_DISABLE_BIT_CLK BIT(12) +#define JZ_AIC_I2S_FMT_DISABLE_BIT_ICLK BIT(13) This looks like it slipped in by accident. Otherwise the patch looks good. -- To unsubscribe from this list: send the line "unsubscrib

Re: [PATCH 25/36] devicetree: document ingenic,jz4780-uart binding

2015-01-25 Thread Lars-Peter Clausen
On 01/18/2015 11:41 PM, Paul Burton wrote: +++ b/Documentation/devicetree/bindings/serial/ingenic,jz4780-uart.txt @@ -0,0 +1,22 @@ +* Ingenic jz4780 UART + +Required properties: +- compatible : "ingenic,jz4780-uart" Same as for the intc binding. Just add the compatible string to the jz4740 uart

Re: [PATCH 31/36] devicetree: document ingenic,jz4780-intc binding

2015-01-25 Thread Lars-Peter Clausen
On 01/18/2015 11:42 PM, Paul Burton wrote: [...] +Ingenic jz4780 SoC Interrupt Controller + +Required properties: + +- compatible : should be "ingenic,jz4780-intc" I don't think we need a second binding specification. Just add the compatibility string to the existing jz4740-intc specification.

Re: [alsa-devel] [PATCH v2 3/3] ASoC: add generic dt-card support

2015-01-24 Thread Lars-Peter Clausen
On 01/23/2015 07:34 PM, Jean-Francois Moine wrote: On Fri, 23 Jan 2015 14:56:04 +0100 Lars-Peter Clausen wrote: On 01/23/2015 01:15 PM, Jean-Francois Moine wrote: [...] The DT should describe the hardware, and the simple-card mixes hardware and software. For example, the kirkwood controller

Re: [alsa-devel] [PATCH v2 3/3] ASoC: add generic dt-card support

2015-01-23 Thread Lars-Peter Clausen
On 01/23/2015 01:15 PM, Jean-Francois Moine wrote: [...] The DT should describe the hardware, and the simple-card mixes hardware and software. For example, the kirkwood controller may create 2 CPU DAIs. With the simple-card, the DT contains a number to reference these DAIs (for example, implicitl

Re: [alsa-devel] [PATCH v2 3/3] ASoC: add generic dt-card support

2015-01-22 Thread Lars-Peter Clausen
On 01/22/2015 09:07 AM, Jean-Francois Moine wrote: On Wed, 21 Jan 2015 21:14:07 +0100 Lars-Peter Clausen wrote: [...] + card->dai_link->dai_fmt = + snd_soc_of_parse_daifmt(of_cpu, "dt-audio-card,", +

Re: [alsa-devel] [PATCH v2 3/3] ASoC: add generic dt-card support

2015-01-21 Thread Lars-Peter Clausen
[...] + card->dai_link->dai_fmt = + snd_soc_of_parse_daifmt(of_cpu, "dt-audio-card,", + NULL, NULL) & + ~SND_SOC_DAIFMT_MASTER_MASK; This one does not seem to be in the bindings documentation. -- To unsubscribe fr

Re: [alsa-devel] [PATCH 1/3] ASoC: samsung: Add machine driver for Trats2

2015-01-05 Thread Lars-Peter Clausen
Hi, A few small comments inline. On 01/05/2015 12:25 PM, Inha Song wrote: --- /dev/null +++ b/sound/soc/samsung/trats2_wm1811.c @@ -0,0 +1,216 @@ [...] +#include +#include +#include +#include +#include +#include "i2s.h" +#include "i2s-regs.h" You probably don't need i2s-regs.h +#includ

Re: [PATCH 5/6] dt-bindings: Add documentation for Rockchip hdmi-audio

2014-12-15 Thread Lars-Peter Clausen
On 12/15/2014 03:55 AM, Yakir Yang wrote: [...] +- codec-name: the dw-hdmi codec's device name +- codec-dai-name: the dw-hdmi codec's dai name Please you phandles for this, the names are Linux driver and framework specific details. That should not leak into the DT bindings. [..] -- To unsubs

Re: [PATCH v2 2/2] iio: add driver for the TI DAC8554

2014-12-13 Thread Lars-Peter Clausen
On 12/06/2014 12:36 PM, Hartmut Knaack wrote: [...] +static int dac8554_read_raw(struct iio_dev *indio_dev, + struct iio_chan_spec const *chan, + int *val, + int *val2, + long m) Commonly, m i

Re: [PATCH v2 2/2] iio: add driver for the TI DAC8554

2014-12-13 Thread Lars-Peter Clausen
On 11/24/2014 08:50 PM, Nikolaus Schulz wrote: [...] +const struct iio_chan_spec dac8554_channels[] = { static [...] + ret = of_property_read_u32(spi->dev.of_node, "address", &addr); This should probably have vendor prefix. + if (ret || addr < 0 || addr > 2) { +

Re: [PATCH v2 2/2] iio: add driver for the TI DAC8554

2014-12-13 Thread Lars-Peter Clausen
On 12/13/2014 12:18 PM, Hartmut Knaack wrote: [...] According to your DT bindings, the regulator from property "vref-supply" should be used. This is missing here. Uhm, it's right below, no? Looking into your DT bindings patch (which unfortunately didn't make it into our list), you specify "vre

Re: [PATCH 3/4] devicetree: bindings: Add defeature-repeated-start property for Cadence I2C

2014-12-02 Thread Lars-Peter Clausen
On 12/02/2014 03:15 PM, Wolfram Sang wrote: What do you do when disable repeated start? Sending STOP and START? If so, this is really something different than repeated start. By using I2C_FUNC_I2C a user expects repeated start, so if the HW does not support it, we should say so and don't try to e

Re: [PATCH v3 1/3] iio: adc: Cosmic Circuits 10001 ADC driver

2014-11-27 Thread Lars-Peter Clausen
[...] + + adc_dev->reg = devm_regulator_get(&pdev->dev, "vref"); + if (IS_ERR_OR_NULL(adc_dev->reg)) + return -EINVAL; if (IS_ERR(adc_dev->reg)) return PTR_ERR(adc_dev->reg); Are you sure? What if devm_regulator_get() returns NULL? I had a

Re: [alsa-devel] [PATCH 4/9] ASoC: ipq806x: Add LPASS CPU DAI driver

2014-11-20 Thread Lars-Peter Clausen
On 11/19/2014 07:52 PM, Kenneth Westfield wrote: [...] +static struct clk *lpaif_mi2s_bit_clk; +static struct clk *lpaif_mi2s_osr_clk; +static struct mi2s_hw_params mi2s_params; Again, no global state please. [...] +static int lpass_cpu_mi2s_prepare(struct snd_pcm_substream *substream, +

Re: [alsa-devel] [PATCH 3/9] ASoC: ipq806x: add native LPAIF driver

2014-11-20 Thread Lars-Peter Clausen
On 11/19/2014 07:52 PM, Kenneth Westfield wrote: From: Kenneth Westfield Add the native LPAIF driver for LPASS block in Qualcomm Technologies SoCs. Change-Id: I0f06f73a1267d7721209e58ce18e0d4897001141 Signed-off-by: Kenneth Westfield Signed-off-by: Banajit Goswami --- sound/soc/qcom/lpass-

Re: [RFC] adp1653: Add device tree bindings for LED controller

2014-11-16 Thread Lars-Peter Clausen
On 11/16/2014 08:59 AM, Pavel Machek wrote: [...] + adp1653: adp1653@30 { + compatible = "ad,adp1653"; The Analog Devices vendor prefix is adi. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org Mor

Re: [alsa-devel] [PATCH 1/3] ASoC: twl4030: don't report EBUSY if no change requested.

2014-11-10 Thread Lars-Peter Clausen
On 11/10/2014 10:45 PM, NeilBrown wrote: On Mon, 10 Nov 2014 08:07:50 +0100 Lars-Peter Clausen wrote: On 11/10/2014 01:45 AM, NeilBrown wrote: diff --git a/sound/soc/codecs/twl4030.c b/sound/soc/codecs/twl4030.c index b6b0cb399599..613b61cee081 100644 --- a/sound/soc/codecs/twl4030.c +++ b

Re: [alsa-devel] [PATCH 1/3] ASoC: twl4030: don't report EBUSY if no change requested.

2014-11-09 Thread Lars-Peter Clausen
On 11/10/2014 01:45 AM, NeilBrown wrote: diff --git a/sound/soc/codecs/twl4030.c b/sound/soc/codecs/twl4030.c index b6b0cb399599..613b61cee081 100644 --- a/sound/soc/codecs/twl4030.c +++ b/sound/soc/codecs/twl4030.c @@ -957,6 +957,16 @@ static int snd_soc_put_twl4030_opmode_enum_double(struct sn

Re: [alsa-devel] [PATCH v3 2/2] ASoC: simple-card: add multi-CODECs in DT

2014-11-07 Thread Lars-Peter Clausen
On 11/07/2014 08:05 PM, Jean-Francois Moine wrote: On Fri, 7 Nov 2014 12:30:35 + Mark Brown wrote: } else { - clk = of_clk_get(args.np, 0); + clk = of_clk_get((struct device_node *) dai_np, 0); Adding this cast looks suspicous - why? As far as I can t

Re: [alsa-devel] [PATCH] ASoC: add xtensa xtfpga I2S interface and platform

2014-10-28 Thread Lars-Peter Clausen
On 10/28/2014 05:04 PM, Mark Brown wrote: On Tue, Oct 28, 2014 at 04:58:24PM +0100, Lars-Peter Clausen wrote: On 10/27/2014 08:07 PM, Max Filippov wrote: + if (tx_active) { + if (i2s->tx_fifo_high < 256) + xtfpga_i2s_refill_fi

Re: [alsa-devel] [PATCH 00/11] Add AXD Audio Processing IP driver

2014-10-28 Thread Lars-Peter Clausen
On 10/28/2014 04:33 PM, Qais Yousef wrote: On 10/28/2014 02:54 PM, Lars-Peter Clausen wrote: On 10/28/2014 02:18 PM, Qais Yousef wrote: On 10/28/2014 11:55 AM, Clemens Ladisch wrote: Qais Yousef wrote: AXD Audio Processing IP performs audio decoding, encoding, mixing, equalisation

Re: [alsa-devel] [PATCH] ASoC: add xtensa xtfpga I2S interface and platform

2014-10-28 Thread Lars-Peter Clausen
On 10/27/2014 08:07 PM, Max Filippov wrote: A few minor things. [...] +static irqreturn_t xtfpga_i2s_interrupt(int irq, void *dev_id) +{ + struct xtfpga_i2s *i2s = dev_id; + struct snd_pcm_substream *tx_substream; + int tx_active; + unsigned int_status; + + regmap_

Re: [PATCH 00/11] Add AXD Audio Processing IP driver

2014-10-28 Thread Lars-Peter Clausen
On 10/28/2014 02:18 PM, Qais Yousef wrote: On 10/28/2014 11:55 AM, Clemens Ladisch wrote: Qais Yousef wrote: AXD Audio Processing IP performs audio decoding, encoding, mixing, equalisation, synchronisation and playback. What exactly do you mean with "synchronisation" and "playback"? Synchron

Re: [alsa-devel] [PATCH 00/11] Add AXD Audio Processing IP driver

2014-10-28 Thread Lars-Peter Clausen
On 10/28/2014 12:26 PM, Qais Yousef wrote: AXD Audio Processing IP performs audio decoding, encoding, mixing, equalisation, synchronisation and playback. This series adds the driver and DT binding document. [...] I added it to drivers/char as this is the best location I could think of at the mome

Re: [alsa-devel] [PATCH] ASoC: simple-card: Add mic and hp detect gpios.

2014-10-02 Thread Lars-Peter Clausen
On 10/01/2014 11:25 PM, Dylan Reid wrote: diff --git a/Documentation/devicetree/bindings/sound/simple-card.txt b/Documentation/devicetree/bindings/sound/simple-card.txt index c2e9841..72d94b7 100644 --- a/Documentation/devicetree/bindings/sound/simple-card.txt +++ b/Documentation/devicetree/bind

Re: [PATCH v2 2/3] ASoC: ssm2602: add device tree bindings

2014-09-29 Thread Lars-Peter Clausen
Acked-by: Lars-Peter Clausen -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] ASoC: ssm2602: add device tree bindings

2014-09-29 Thread Lars-Peter Clausen
On 09/29/2014 04:34 PM, Stefan Kristiansson wrote: On Mon, Sep 29, 2014 at 10:50:24AM +0200, Lars-Peter Clausen wrote: On 09/28/2014 09:57 AM, Stefan Kristiansson wrote: Allow the ssm2602/ssm2603/ssm2604 codec driver to be instantiated from the device tree. Also, add Kconfig prompts to allow

Re: [PATCH 1/2] ASoC: ssm2602: add device tree bindings

2014-09-29 Thread Lars-Peter Clausen
On 09/28/2014 09:57 AM, Stefan Kristiansson wrote: Allow the ssm2602/ssm2603/ssm2604 codec driver to be instantiated from the device tree. Also, add Kconfig prompts to allow manual selection of both the I2C and SPI configuration versions of the driver. Signed-off-by: Stefan Kristiansson Look

Re: [PATCH v2 1/2] Allow DT parsing of secondary devices

2014-08-29 Thread Lars-Peter Clausen
On 08/29/2014 05:15 PM, Jean-Michel Hautbois wrote: This is based on reg and reg-names in DT. Example: reg = <0x10 0x20 0x30>; reg-names = "main", "io", "test"; This function will create dummy devices io and test with addresses 0x20 and 0x30 respectively. Signed-off-by: Jean-Michel Hautbois

Re: [PATCH v2 1/2] Allow DT parsing of secondary devices

2014-08-29 Thread Lars-Peter Clausen
On 08/29/2014 05:15 PM, Jean-Michel Hautbois wrote: This is based on reg and reg-names in DT. Example: reg = <0x10 0x20 0x30>; reg-names = "main", "io", "test"; This function will create dummy devices io and test with addresses 0x20 and 0x30 respectively. Signed-off-by: Jean-Michel Hautbois

Re: [PATCH v2 2/2] adv7604: Use DT parsing in dummy creation

2014-08-29 Thread Lars-Peter Clausen
On 08/29/2014 05:15 PM, Jean-Michel Hautbois wrote: This patch uses DT in order to parse addresses for dummy devices of adv7604. The ADV7604 has thirteen 256-byte maps that can be accessed via the main I²C ports. Each map has it own I²C address and acts as a standard slave device on the I²C bus.

Re: [alsa-devel] [PATCH 8/8] ASoC: add snd-soc-dummy DT support

2014-08-28 Thread Lars-Peter Clausen
On 08/28/2014 02:33 AM, Kuninori Morimoto wrote: Hi Lars Thank you for your comment sound { compatible = "simple-audio-card"; /* FrontEnd */ simple-audio-card,dai-link@0 { ... format = "le

Re: [PATCH] Add support for definition of register maps in DT in ADV7604

2014-08-27 Thread Lars-Peter Clausen
On 08/27/2014 03:03 PM, Hans Verkuil wrote: On 08/27/14 14:53, jean-michel.hautb...@vodalys.com wrote: From: Jean-Michel Hautbois This patch adds support for DT parsing of register maps adresses. This allows multiple adv76xx devices on the same bus. Signed-off-by: Jean-Michel Hautbois ---

Re: [alsa-devel] [PATCH 8/8] ASoC: add snd-soc-dummy DT support

2014-08-27 Thread Lars-Peter Clausen
On 08/27/2014 05:14 AM, Kuninori Morimoto wrote: Hi Mark again But, How about this case ? FE cpu: CPU-A codec: Codec-A BE cpu: CPU-B codec: Codec-B I found 1 method. I can create it if we can assume that "simple-card doen't support above style", If the documenta

Re: [alsa-devel] [PATCH 8/8] ASoC: add snd-soc-dummy DT support

2014-08-26 Thread Lars-Peter Clausen
On 08/26/2014 11:11 AM, Mark Brown wrote: On Tue, Aug 26, 2014 at 01:34:21AM -0700, Kuninori Morimoto wrote: This patch expand route setting by using DAI name. You can select "ak4642-hifi" side "Playback" by below. DT simple-audio-card,routing = "ak4642-hifi Playback"

Re: [alsa-devel] [PATCH 8/8] ASoC: add snd-soc-dummy DT support

2014-08-24 Thread Lars-Peter Clausen
On 08/20/2014 09:13 AM, Kuninori Morimoto wrote: From: Kuninori Morimoto This patch adds snd-soc-dummy DT binding support. The devicetree describes the hardware, the snd-soc-dummy is a software only thing and should not be found in the devicetree. It removes .stream_name from dummy_dai, b

Re: [alsa-devel] [PATCH v3 1/2] ASoC: Add support for CS35L32 Boosted Amplifier

2014-08-05 Thread Lars-Peter Clausen
On 08/05/2014 04:33 PM, Varka Bhadram wrote: On Tuesday 05 August 2014 08:01 PM, Brian Austin wrote: On Mon, 4 Aug 2014, Varka Bhadram wrote: On 08/05/2014 01:41 AM, Brian Austin wrote: +#include +#include +#include +#include +#include +#include +#include +#include +#include +#inclu

Re: [PATCH v2 00/11] ARM: dts: zynq: Prepare Parallella

2014-07-28 Thread Lars-Peter Clausen
On 07/28/2014 06:17 PM, Andreas Färber wrote: Hi Lars-Peter, Am 25.07.2014 01:00, schrieb Andreas Färber: most notably I'm missing ADI ADV7513 and AXI-HDMI support [...] Cc: Lars-Peter Clausen (HDMI) Could you please enlighten us what the status of upstreaming ADV7511/ADV7513 suppo

Re: [PATCH v2 09/11] Documentation: devicetree: Fix ADI AXI SPDIF specification

2014-07-25 Thread Lars-Peter Clausen
On 07/25/2014 01:00 AM, Andreas Färber wrote: The specification requires compatible = "adi,axi-spdif-1.00.a" but driver and example and file name indicate "adi,axi-spdif-tx-1.00.a". Change the specification to match the implementation. Signed-off-by: Andreas Färber

Re: [PATCH v5 1/2] iio: adc: add driver for Rockchip saradc

2014-07-20 Thread Lars-Peter Clausen
On 07/14/2014 10:43 PM, Heiko Stübner wrote: Looks really good overall. [...] +static int rockchip_saradc_read_raw(struct iio_dev *indio_dev, + struct iio_chan_spec const *chan, + int *val, int *val2, long mask) +{ + stru

Re: [alsa-devel] [PATCH 2/2] ASoC: samsung: Add machine driver for odroidx2

2014-07-04 Thread Lars-Peter Clausen
On 07/04/2014 01:24 PM, Sylwester Nawrocki wrote: On 04/07/14 13:10, Lars-Peter Clausen wrote: On 07/04/2014 01:04 PM, Sylwester Nawrocki wrote: On 22/05/14 20:53, Mark Brown wrote: + ret = snd_soc_dai_set_fmt(codec_dai, SND_SOC_DAIFMT_I2S

Re: [alsa-devel] [PATCH 2/2] ASoC: samsung: Add machine driver for odroidx2

2014-07-04 Thread Lars-Peter Clausen
On 07/04/2014 01:04 PM, Sylwester Nawrocki wrote: On 22/05/14 20:53, Mark Brown wrote: + ret = snd_soc_dai_set_fmt(codec_dai, SND_SOC_DAIFMT_I2S + | SND_SOC_DAIFMT_NB_NF + | SND_SOC_DAIFMT_CBM_CFM); + if (re

Re: [alsa-devel] [PATCH 2/2] ASoC: add driver for Rockchip RK3xxx I2S controller

2014-07-01 Thread Lars-Peter Clausen
On 07/01/2014 10:47 AM, jianqun wrote: [...] new file mode 100644 index 000..946b60c --- /dev/null +++ b/sound/soc/rockchip/Kconfig @@ -0,0 +1,16 @@ +config SND_SOC_ROCKCHIP + tristate "ASoC support for Rockchip" + depends on SND_SOC && ARCH_ROCKCHIP No need for SND_SOC this is

Re: [alsa-devel] [PATCH v3 1/2] ASoC: add es8328 codec driver

2014-06-17 Thread Lars-Peter Clausen
On 06/17/2014 01:36 PM, Sean Cross wrote: On 06/17/14 18:46, Charles Keepax wrote: On Tue, Jun 17, 2014 at 05:32:50PM +0800, Sean Cross wrote: Add a codec driver for the Everest ES8328. It supports two separate audio outputs and two separate audio inputs. Signed-off-by: Sean Cross --- Docu

Re: [alsa-devel] [PATCH 2/2] ASoC: Add support for CS4265 CODEC

2014-05-24 Thread Lars-Peter Clausen
On 05/23/2014 09:16 PM, Paul Handrigan wrote: [...] A couple of trivial bits: @@ -300,6 +301,10 @@ config SND_SOC_CS42L73 tristate "Cirrus Logic CS42L73 CODEC" depends on I2C +config SND_SOC_CS4265 + tristate "Cirrus Logic CS4265 CODEC" + depends on I2C select REG

Re: [alsa-devel] [PATCH v3 4/4] ASoC: simple-card: Add DT documentation for multi-DAI links

2014-03-19 Thread Lars-Peter Clausen
On 03/19/2014 08:21 PM, Mark Brown wrote: On Wed, Mar 19, 2014 at 09:15:14PM +0200, Jyri Sarha wrote: On 03/19/2014 08:51 PM, Lars-Peter Clausen wrote: When does this make sense? Either the bitclock is inverted for all of them or for none. Definition of clock signal and it's inve

Re: [alsa-devel] [PATCH v3 4/4] ASoC: simple-card: Add DT documentation for multi-DAI links

2014-03-19 Thread Lars-Peter Clausen
On 03/19/2014 11:08 AM, Jyri Sarha wrote: [...] It may sometimes be helpful to allow overwriting link level settings in dai level. In order to do that it should be possible to write all daifmt settings explicitly like this: bitclock-inversion = <0>; /* <0> = no bitclock-inversion */ When does

Re: [PATCH v2] ASoC: cs42888: Add codec driver support

2014-03-11 Thread Lars-Peter Clausen
On 03/11/2014 04:41 PM, Brian Austin wrote: On Tue, 11 Mar 2014, Nicolin Chen wrote: This patch adds support for the Cirrus Logic CS42888 Audio CODEC that has four 24-bit A/D and eight 24-bit D/A converters. [ CS42888 supports both I2C and SPI control ports. As initial patch, this patch only

Re: [alsa-devel] [PATCH v2 2/4] ASoC: davinci-evm: Add AM43xx-EPOS-EVM audio support

2014-03-04 Thread Lars-Peter Clausen
+static const struct snd_soc_dapm_widget aic31xx_dapm_widgets[] = { + SND_SOC_DAPM_HP("Headphone Jack", NULL), + SND_SOC_DAPM_SPK("Speaker", NULL), + SND_SOC_DAPM_MIC("Mic Jack", NULL), +}; + +/* Logic for EVMs with an aic31xx */ +static int evm_aic31xx_init(struct snd_soc_pcm_

  1   2   >