Re: [PATCH v5 0/5] Add memory mapped read support for ti-qspi

2016-01-04 Thread Vignesh R
Hi Brian, On 12/11/2015 09:39 AM, Vignesh R wrote: > Changes since v4: > Use syscon to access system control module register in ti-qspi driver. > Gentle ping... Are you ok with MTD side changes of this patch series? > Changes since v3: > Rework to introduce spi_flash_read

Re: [PATCH v5 0/5] Add memory mapped read support for ti-qspi

2015-12-21 Thread Vignesh R
On 12/11/2015 09:39 AM, Vignesh R wrote: > Changes since v4: > Use syscon to access system control module register in ti-qspi driver. > > Changes since v3: > Rework to introduce spi_flash_read_message struct. > Support different opcode/addr/data formats as per Brian's s

Re: [PATCH v5 4/5] ARM: dts: DRA7: add entry for qspi mmap region

2015-12-17 Thread Vignesh R
On 12/18/2015 12:15 AM, Tony Lindgren wrote: > * Rob Herring [151211 07:10]: >> On Fri, Dec 11, 2015 at 09:39:59AM +0530, Vignesh R wrote: >>> Add qspi memory mapped region entries for DRA7xx based SoCs. Also, >>> update the binding documents for the control

[PATCH v5 0/5] Add memory mapped read support for ti-qspi

2015-12-10 Thread Vignesh R
based on the discussions here: http://www.spinics.net/lists/linux-spi/msg04796.html Tested on DRA74 EVM and AM437x-SK. Read performance increases from ~100kB/s to ~2.5MB/s. Vignesh R (5): spi: introduce accelerated read support for spi flash devices spi: spi-ti-qspi: add mmap mode read su

[PATCH v5 1/5] spi: introduce accelerated read support for spi flash devices

2015-12-10 Thread Vignesh R
such as memory mapped read etc. m25p80 flash driver and other flash drivers can call this make use of such interfaces. The interface should only be used with SPI flashes and cannot be used with other SPI devices. Signed-off-by: Vignesh R --- v5: No changes. drivers/spi/spi.c | 45

[PATCH v5 3/5] mtd: devices: m25p80: add support for mmap read request

2015-12-10 Thread Vignesh R
Certain spi controllers may provide accelerated interface to read from m25p80 type flash devices. This interface provides better read performance than regular SPI interface. Call spi_flash_read(), if supported, to make use of such interface. Signed-off-by: Vignesh R --- v5: No changes drivers

[PATCH v5 5/5] ARM: dts: AM4372: add entry for qspi mmap region

2015-12-10 Thread Vignesh R
Add qspi memory mapped region entries for AM43xx based SoCs. Also, update the binding documents for the controller to document this change. Acked-by: Rob Herring Signed-off-by: Vignesh R --- v5: No changes. Documentation/devicetree/bindings/spi/ti_qspi.txt | 5 +++-- arch/arm/boot/dts/am4372

[PATCH v5 4/5] ARM: dts: DRA7: add entry for qspi mmap region

2015-12-10 Thread Vignesh R
Add qspi memory mapped region entries for DRA7xx based SoCs. Also, update the binding documents for the controller to document this change. Signed-off-by: Vignesh R --- v5: use syscon to access scm register. Documentation/devicetree/bindings/spi/ti_qspi.txt | 17 + arch/arm

[PATCH v5 2/5] spi: spi-ti-qspi: add mmap mode read support

2015-12-10 Thread Vignesh R
flash over SPI bus and get the requested data. Implement spi_flash_read() callback to support mmap read over SPI flash devices. With this, the read throughput increases from ~100kB/s to ~2.5 MB/s. Signed-off-by: Vignesh R --- v5: * use syscon to access ctrl_mod register. drivers/spi/spi-ti

Re: [PATCH v4 4/5] ARM: dts: DRA7: add entry for qspi mmap region

2015-12-09 Thread Vignesh R
On 12/03/2015 03:51 PM, Vignesh R wrote: > > > On 12/01/2015 10:09 PM, Tony Lindgren wrote: >> * Vignesh R [151130 20:46]: >>> On 12/01/2015 04:04 AM, Tony Lindgren wrote: >>>> ... >> >> OK. They are both on L3 main so that won't cause any

Re: [PATCH v4 3/5] mtd: devices: m25p80: add support for mmap read request

2015-12-03 Thread Vignesh R
Hi, On 12/03/2015 03:12 PM, Cyrille Pitchen wrote: > Hi Vignesh, > > Le 30/11/2015 06:15, Vignesh R a écrit : >> Certain spi controllers may provide accelerated interface to read from >> m25p80 type flash devices. This interface provides better read >> performance

Re: [PATCH v4 4/5] ARM: dts: DRA7: add entry for qspi mmap region

2015-12-03 Thread Vignesh R
On 12/01/2015 10:09 PM, Tony Lindgren wrote: > * Vignesh R [151130 20:46]: >> On 12/01/2015 04:04 AM, Tony Lindgren wrote: >>> >>> Actually none of the IO areas above are within the same interconnect target: >>> >>> 0x4b30 QSPI0 address space

Re: [PATCH v4 2/5] spi: spi-ti-qspi: add mmap mode read support

2015-11-30 Thread Vignesh R
Hi Felipe, On 12/01/2015 04:05 AM, Balbi, Felipe wrote: > > Hi, > > Vignesh R writes: [...] >> +} >> + >> +static int ti_qspi_spi_flash_read(struct spi_device *spi, >> + struct spi_flash_read_message *msg

Re: [PATCH v4 4/5] ARM: dts: DRA7: add entry for qspi mmap region

2015-11-30 Thread Vignesh R
On 12/01/2015 04:04 AM, Tony Lindgren wrote: > * Vignesh R [151129 21:16]: >> Add qspi memory mapped region entries for DRA7xx based SoCs. Also, >> update the binding documents for the controller to document this change. >> >> Acked-by: Rob Herring >> Signed-

[PATCH v4 4/5] ARM: dts: DRA7: add entry for qspi mmap region

2015-11-29 Thread Vignesh R
Add qspi memory mapped region entries for DRA7xx based SoCs. Also, update the binding documents for the controller to document this change. Acked-by: Rob Herring Signed-off-by: Vignesh R --- v4: No changes. Documentation/devicetree/bindings/spi/ti_qspi.txt | 14 ++ arch/arm/boot

[PATCH v4 5/5] ARM: dts: AM4372: add entry for qspi mmap region

2015-11-29 Thread Vignesh R
Add qspi memory mapped region entries for AM43xx based SoCs. Also, update the binding documents for the controller to document this change. Acked-by: Rob Herring Signed-off-by: Vignesh R --- v4: No changes. Documentation/devicetree/bindings/spi/ti_qspi.txt | 5 +++-- arch/arm/boot/dts/am4372

[PATCH v4 2/5] spi: spi-ti-qspi: add mmap mode read support

2015-11-29 Thread Vignesh R
flash over SPI bus and get the requested data. Implement spi_flash_read() callback to support mmap read over SPI flash devices. With this, the read throughput increases from ~100kB/s to ~2.5 MB/s. Signed-off-by: Vignesh R --- drivers/spi/spi-ti-qspi.c | 101

[PATCH v4 1/5] spi: introduce accelerated read support for spi flash devices

2015-11-29 Thread Vignesh R
such as memory mapped read etc. m25p80 flash driver and other flash drivers can call this make use of such interfaces. The interface should only be used with SPI flashes and cannot be used with other SPI devices. Signed-off-by: Vignesh R --- drivers/spi/spi.c | 45

[PATCH v4 3/5] mtd: devices: m25p80: add support for mmap read request

2015-11-29 Thread Vignesh R
Certain spi controllers may provide accelerated interface to read from m25p80 type flash devices. This interface provides better read performance than regular SPI interface. Call spi_flash_read(), if supported, to make use of such interface. Signed-off-by: Vignesh R --- v4: * Use

[PATCH v4 0/5] Add memory mapped read support for ti-qspi

2015-11-29 Thread Vignesh R
ed on DRA74 EVM and AM437x-SK. Read performance increases from ~100kB/s to ~2.5MB/s. Vignesh R (5): spi: introduce accelerated read support for spi flash devices spi: spi-ti-qspi: add mmap mode read support mtd: devices: m25p80: add support for mmap read request ARM: dts: DRA7: add entr

[PATCH] ARM: dts: dra72-evm: Mark uart1 rxd as wakeup capable

2015-11-26 Thread Vignesh R
Uart1 rxd is wakeup capable on DRA72 EVM. Hence, mark rxd line as wakeup capable. This is similar to commit 66b0436977e2c ("ARM: dts: dra7-evm: Mark uart1 rxd as wakeup capable") for DRA74 EVM. Signed-off-by: Vignesh R --- arch/arm/boot/dts/dra72-evm.dts | 2 ++ 1 file changed, 2

Re: [PATCH v3 1/5] spi: introduce mmap read support for spi flash devices

2015-11-16 Thread Vignesh R
Hi Brian, On 11/13/2015 09:35 PM, Cyrille Pitchen wrote: [...] > > In September I've sent a series of patches to enhance the support of QSPI > flash > memories. Patch 4 was dedicated to the m25p80 driver and set the > rx_nbits / tx_nbits fields of spi_transfer struct(s) in order to configure t

Re: [PATCH v3 1/5] spi: introduce mmap read support for spi flash devices

2015-11-11 Thread Vignesh R
Hi Brian, On 11/12/2015 12:54 AM, Brian Norris wrote: > In addition to my other comments: > [...] >> +int (*spi_mtd_mmap_read)(struct spi_device *spi, >> + loff_t from, size_t len, >> + size_t *retlen, u_char *buf, >> +

[PATCH v3 1/5] spi: introduce mmap read support for spi flash devices

2015-11-09 Thread Vignesh R
ck to support memory mapped read interfaces. m25p80 flash driver and other flash drivers can call this to request memory mapped read. The interface should only be used MTD flashes and cannot be used with other SPI devices. Signed-off-by: Vignesh R --- v3: * Remove use of mmap_lock_mutex, use bus_lock_

[PATCH v3 2/5] spi: spi-ti-qspi: add mmap mode read support

2015-11-09 Thread Vignesh R
flash over SPI bus and get the requested data. Implement spi_mtd_mmap_read() callback to support mmap read over SPI flash devices. With this, the read throughput increases from ~100kB/s to ~2.5 MB/s. Signed-off-by: Vignesh R --- v3: * optimize enable/disable of mmap mode drivers/spi/spi-ti

[PATCH v3 5/5] ARM: dts: AM4372: add entry for qspi mmap region

2015-11-09 Thread Vignesh R
Add qspi memory mapped region entries for AM43xx based SoCs. Also, update the binding documents for the controller to document this change. Signed-off-by: Vignesh R Acked-by: Rob Herring --- Documentation/devicetree/bindings/spi/ti_qspi.txt | 5 +++-- arch/arm/boot/dts/am4372.dtsi

[PATCH v3 3/5] mtd: devices: m25p80: add support for mmap read request

2015-11-09 Thread Vignesh R
Certain spi controllers may support memory mapped interface to read from m25p80 type flash devices. This interface provides better read performance than regular SPI interface. Call spi_mtd_mmap_read() interface, if supported, to make use of memory-mapped interface. Signed-off-by: Vignesh R

[PATCH v3 4/5] ARM: dts: DRA7: add entry for qspi mmap region

2015-11-09 Thread Vignesh R
Add qspi memory mapped region entries for DRA7xx based SoCs. Also, update the binding documents for the controller to document this change. Signed-off-by: Vignesh R Acked-by: Rob Herring --- Documentation/devicetree/bindings/spi/ti_qspi.txt | 14 ++ arch/arm/boot/dts/dra7.dtsi

[PATCH v3 0/5] Add memory mapped read support for ti-qspi

2015-11-09 Thread Vignesh R
. This patch series is based on the discussions here: http://www.spinics.net/lists/linux-spi/msg04796.html Tested on DRA74 EVM and AM437x-SK. Read performance increases from ~100kB/s to ~2.5MB/s. Vignesh R (5): spi: introduce mmap read support for spi flash devices spi: spi-ti-qspi: add mmap

Re: [PATCH v2 5/5] ARM: dts: AM4372: add entry for qspi mmap region

2015-11-06 Thread Vignesh R
On 11/06/2015 10:44 AM, Felipe Balbi wrote: > > Hi, > > Rob Herring writes: >> On Tue, Nov 03, 2015 at 03:36:14PM +0530, Vignesh R wrote: >>> Add qspi memory mapped region entries for AM43xx based SoCs. Also, >>> update the binding documents for th

Re: [PATCH v2 1/5] spi: introduce mmap read support for spi flash devices

2015-11-05 Thread Vignesh R
On 11/04/2015 08:09 PM, Mark Brown wrote: > On Tue, Nov 03, 2015 at 03:36:10PM +0530, Vignesh R wrote: > >> +} >> +mutex_lock(&master->mmap_lock_mutex); >> +ret = master->spi_mtd_mmap_read(spi, from, len, retlen, buf, >> +

Re: [PATCH v2 2/5] spi: spi-ti-qspi: add mmap mode read support

2015-11-04 Thread Vignesh R
On 11/04/2015 08:11 PM, Mark Brown wrote: > On Tue, Nov 03, 2015 at 03:36:11PM +0530, Vignesh R wrote: > >> +ti_qspi_enable_memory_map(spi); >> +ti_qspi_setup_mmap_read(spi, read_opcode, addr_width, >> +dummy_bytes); >> +memc

Re: [PATCH v2 1/5] spi: introduce mmap read support for spi flash devices

2015-11-03 Thread Vignesh R
Hi, On 11/03/2015 04:49 PM, Michal Suchanek wrote: > On 3 November 2015 at 11:06, Vignesh R wrote: >> In addition to providing direct access to SPI bus, some spi controller >> hardwares (like ti-qspi) provide special memory mapped port >> to accesses SPI flash devices in o

[PATCH v2 1/5] spi: introduce mmap read support for spi flash devices

2015-11-03 Thread Vignesh R
ck to support memory mapped read interfaces. m25p80 flash driver and other flash drivers can call this to request memory mapped read. The interface should only be used MTD flashes and cannot be used with other SPI devices. Signed-off-by: Vignesh R --- drivers/spi/spi.c

[PATCH v2 4/5] ARM: dts: DRA7: add entry for qspi mmap region

2015-11-03 Thread Vignesh R
Add qspi memory mapped region entries for DRA7xx based SoCs. Also, update the binding documents for the controller to document this change. Signed-off-by: Vignesh R --- Documentation/devicetree/bindings/spi/ti_qspi.txt | 13 + arch/arm/boot/dts/dra7.dtsi | 6

[PATCH v2 2/5] spi: spi-ti-qspi: add mmap mode read support

2015-11-03 Thread Vignesh R
flash over SPI bus and get the requested data. Implement spi_mtd_mmap_read() callback to support mmap read over SPI flash devices. With this, the read throughput increases from ~100kB/s to ~2.5 MB/s. Signed-off-by: Vignesh R --- drivers/spi/spi-ti-qspi.c | 92

[PATCH v2 5/5] ARM: dts: AM4372: add entry for qspi mmap region

2015-11-03 Thread Vignesh R
Add qspi memory mapped region entries for AM43xx based SoCs. Also, update the binding documents for the controller to document this change. Signed-off-by: Vignesh R --- Documentation/devicetree/bindings/spi/ti_qspi.txt | 5 +++-- arch/arm/boot/dts/am4372.dtsi | 4 +++- 2

[PATCH v2 3/5] mtd: devices: m25p80: add support for mmap read request

2015-11-03 Thread Vignesh R
Certain spi controllers may support memory mapped interface to read from m25p80 type flash devices. This interface provides better read performance than regular SPI interface. Call spi_mtd_mmap_read() interface, if supported, to make use of memory-mapped interface. Signed-off-by: Vignesh R

[PATCH v2 0/5] Add memory mapped read support for ti-qspi

2015-11-03 Thread Vignesh R
/lists/linux-spi/msg04796.html Tested on DRA74 EVM and AM437x-SK. Read performance increases from ~100kB/s to ~2.5MB/s. Vignesh R (5): spi: introduce mmap read support for spi flash devices spi: spi-ti-qspi: add mmap mode read support mtd: devices: m25p80: add support for mmap read request

[PATCH v2] ARM: dts: am437x-gp-evm: Add wakeup interrupt source for pixcir_i2c_ts

2015-10-14 Thread Vignesh R
evice tree. Add wakeup irq entry to enable pixcir_i2c_ts to wake the system from low power state. Signed-off-by: Vignesh R --- Since v1: - correct interrupt flag. - add comment wrt wakeup interrupt. arch/arm/boot/dts/am437x-gp-evm.dts | 9 + 1 file changed, 9 insertions(+) diff --git

Re: [PATCH] ARM: dts: am437x-gp-evm: Add wakeup interrupt source for pixcir_i2c_ts

2015-10-14 Thread Vignesh R
On 10/14/2015 04:34 PM, Roger Quadros wrote: > Vignesh, > > On 14/10/15 12:12, Vignesh R wrote: >> >> >> On 10/14/2015 02:16 PM, Roger Quadros wrote: >> >>> >>> On 14/10/15 08:52, Vignesh R wrote: >>>> On am437x-gp-evm, pixcir_i2c_t

Re: [PATCH] ARM: dts: am437x-gp-evm: Add wakeup interrupt source for pixcir_i2c_ts

2015-10-14 Thread Vignesh R
On 10/14/2015 02:16 PM, Roger Quadros wrote: > > On 14/10/15 08:52, Vignesh R wrote: >> On am437x-gp-evm, pixcir_i2c_ts can wakeup the system from lower power >> state via pinctrl and IO daisy chain using generic wakeirq framework. >> With commit 3fffd1283927 ("i

[PATCH] ARM: dts: am437x-gp-evm: Add wakeup interrupt source for pixcir_i2c_ts

2015-10-13 Thread Vignesh R
evice tree. Add wakeup irq entry to enable pixcir_i2c_ts to wake the system from low power state. Signed-off-by: Vignesh R --- arch/arm/boot/dts/am437x-gp-evm.dts | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/am437x-gp-evm.dts b/arch/arm/boot/dts/am437x-gp-evm

Re: [PATCH 1/5] spi: introduce mmap read support for spi flash devices

2015-09-18 Thread Vignesh R
On 09/16/2015 04:26 PM, Mark Brown wrote: > On Wed, Sep 16, 2015 at 03:38:09PM +0530, Vignesh R wrote: > >> But, I didn't get how to integrate with existing message queue. Memory >> mapped read by-passes message queue of SPI core. Could you please >> explain a

Re: [PATCH 3/5] mtd: devices: m25p80: add support for mmap read request

2015-09-16 Thread Vignesh R
On 09/14/2015 11:57 PM, Mark Brown wrote: > On Fri, Sep 04, 2015 at 02:00:00PM +0530, Vignesh R wrote: > >> +if (spi->master->spi_mtd_mmap_read) { >> +return spi->master->spi_mtd_mmap_read(spi, from, len, >> +

Re: [PATCH 1/5] spi: introduce mmap read support for spi flash devices

2015-09-16 Thread Vignesh R
On 09/15/2015 12:05 AM, Mark Brown wrote: > On Fri, Sep 04, 2015 at 04:55:33PM +0530, Jagan Teki wrote: >> On 4 September 2015 at 13:59, Vignesh R wrote: > >>> + * @spi_mtd_mmap_read: some spi-controller hardwares provide memory >>> + * mapped

Re: [PATCH 2/5] spi: spi-ti-qspi: add mmap mode read support

2015-09-16 Thread Vignesh R
On 09/14/2015 11:56 PM, Mark Brown wrote: > On Fri, Sep 04, 2015 at 01:59:59PM +0530, Vignesh R wrote: > >> +static int ti_qspi_spi_mtd_mmap_read(struct spi_device *spi, >> + loff_t from, size_t len, >> +

Re: [PATCH 1/5] spi: introduce mmap read support for spi flash devices

2015-09-16 Thread Vignesh R
On 09/15/2015 12:07 AM, Mark Brown wrote: > On Fri, Sep 04, 2015 at 01:59:58PM +0530, Vignesh R wrote: >> In addition to providing direct access to SPI bus, some spi controller >> hardwares (like ti-qspi) provide special memory mapped port >> to accesses SPI flash devices

[PATCH 0/5] Add memory mapped read support for ti-qspi

2015-09-04 Thread Vignesh R
: http://www.spinics.net/lists/linux-spi/msg04796.html Tested on DRA74 EVM and AM437x-SK. Read performance increases from ~100kB/s to ~2.5MB/s. Vignesh R (5): spi: introduce mmap read support for spi flash devices spi: spi-ti-qspi: add mmap mode read support mtd: devices: m25p80: add support

[PATCH 2/5] spi: spi-ti-qspi: add mmap mode read support

2015-09-04 Thread Vignesh R
over SPI bus and get the requested data. Implement spi_mtd_mmap_read() method to support mmap read over SPI flash devices. With this, the read throughput increases from ~100kB/s to ~2.5 MB/s. Signed-off-by: Vignesh R --- drivers/spi/spi-ti-qspi.c | 106

[PATCH 1/5] spi: introduce mmap read support for spi flash devices

2015-09-04 Thread Vignesh R
od to support memory mapped read interfaces. m25p80 flash driver and other flash drivers can call this to request memory mapped read. The interface should only be used mtd flashes and cannot be used with other spi devices. Signed-off-by: Vignesh R --- include/linux/spi/spi.h | 21 +++

[PATCH 3/5] mtd: devices: m25p80: add support for mmap read request

2015-09-04 Thread Vignesh R
Certain spi controllers may support memory mapped interface to read from m25p80 type flash devices. This interface provides better read performance than regular SPI interface. Call spi_mtd_mmap_read() function, if available, to make use of memory-mapped interface. Signed-off-by: Vignesh R

[PATCH 5/5] ARM: dts: AM4372: add entry for qspi mmap region

2015-09-04 Thread Vignesh R
Add qspi memory mapped region entries for AM43xx based SoCs. Also, update the binding documents for the controller to document this change. Signed-off-by: Vignesh R --- Documentation/devicetree/bindings/spi/ti_qspi.txt | 5 +++-- arch/arm/boot/dts/am4372.dtsi | 4 +++- 2

[PATCH 4/5] ARM: dts: DRA7: add entry for qspi mmap region

2015-09-04 Thread Vignesh R
Add qspi memory mapped region entries for DRA7xx based SoCs. Also, update the binding documents for the controller to document this change. Signed-off-by: Vignesh R --- Documentation/devicetree/bindings/spi/ti_qspi.txt | 13 + arch/arm/boot/dts/dra7.dtsi | 6

Re: [PATCH] input: ti_am335x_tsc: Add open delay parameter

2015-08-21 Thread Vignesh R
On 08/21/2015 03:47 AM, Michael Welling wrote: > On Thu, Aug 20, 2015 at 05:41:30PM +0530, Vignesh R wrote: >> >> >> On 08/19/2015 11:38 PM, Michael Welling wrote: >>> On Wed, Aug 12, 2015 at 01:44:22PM -0500, Michael Welling wrote: >>>> On Wed, Aug 12,

Re: [PATCH] input: ti_am335x_tsc: Add open delay parameter

2015-08-20 Thread Vignesh R
On 08/19/2015 11:38 PM, Michael Welling wrote: > On Wed, Aug 12, 2015 at 01:44:22PM -0500, Michael Welling wrote: >> On Wed, Aug 12, 2015 at 11:56:36AM +0530, Vignesh R wrote: >>> Hi Michael, >>> >>> + Dmitry >>> >>> On 08/12/2015 12

Re: [RFC PATCH 1/5] spi: introduce flag for memory mapped read

2015-08-12 Thread Vignesh R
On 08/07/2015 03:46 PM, Michal Suchanek wrote: [snip] > On 7 August 2015 at 10:35, Vignesh R wrote: >> >> >> On 08/07/2015 01:08 PM, Michal Suchanek wrote: >> >>> Now since the description is clearer it's obvious that ti-qspi cannot >>> work fu

Re: [PATCH] input: ti_am335x_tsc: Add open delay parameter

2015-08-11 Thread Vignesh R
Hi Michael, + Dmitry On 08/12/2015 12:15 AM, Michael Welling wrote: > Adds a device tree parameter to set the open delay on the touchscreen > conversion steps. Increasing this parameter helps the touch accuracy on > some screens. > > Signed-off-by: Michael Welling > --- > .../bindings/input/to

Re: [RFC PATCH 1/5] spi: introduce flag for memory mapped read

2015-08-07 Thread Vignesh R
On 08/07/2015 01:08 PM, Michal Suchanek wrote: > Now since the description is clearer it's obvious that ti-qspi cannot > work fully mmapped as fsl-qspi does because the setup has to be done > over normal spi access and using non-m25p80 devices on the same bus is > a requirement. > > The place w

Re: [RFC PATCH 1/5] spi: introduce flag for memory mapped read

2015-08-06 Thread Vignesh R
On 08/06/2015 03:52 PM, Russell King - ARM Linux wrote: > On Thu, Aug 06, 2015 at 12:01:37PM +0200, Michal Suchanek wrote: >> Disclaimer: I am not familiar with the hardware for which this patch >> adds support. >> >> However, I am familiar m25p80.c and as I understand it the controller >> is bas

Re: [RFC PATCH 1/5] spi: introduce flag for memory mapped read

2015-08-04 Thread Vignesh R
On 08/05/2015 10:51 AM, Michal Suchanek wrote: > Hello, > > On 4 August 2015 at 19:59, R, Vignesh wrote: >> >> >> On 8/4/2015 9:21 PM, Mark Brown wrote: >>> On Mon, Aug 03, 2015 at 10:27:19AM +0530, Vignesh R wrote: >>> >>>> @u

Re: [RFC PATCH 4/5] ARM: dts: DRA7: Add memory map region entries for qspi

2015-08-02 Thread Vignesh R
On 07/31/2015 07:18 PM, Sekhar Nori wrote: > On Tuesday 28 July 2015 02:11 PM, Vignesh R wrote: >> Add qspi memory mapped region entries for DRA7xx based SoCs. >> >> Signed-off-by: Vignesh R >> --- >> arch/arm/boot/dts/am4372.dtsi | 4 +++- >> 1 fi

Re: [RFC PATCH 4/5] ARM: dts: DRA7: Add memory map region entries for qspi

2015-08-02 Thread Vignesh R
On 08/01/2015 02:58 AM, Brian Norris wrote: > On Tue, Jul 28, 2015 at 02:11:15PM +0530, Vignesh R wrote: >> Add qspi memory mapped region entries for DRA7xx based SoCs. >> >> Signed-off-by: Vignesh R >> --- >> arch/arm/boot/dts/am4372.dtsi | 4 +++- >&

Re: [RFC PATCH 4/5] ARM: dts: DRA7: Add memory map region entries for qspi

2015-08-02 Thread Vignesh R
On 07/31/2015 11:49 PM, Mark Brown wrote: > On Tue, Jul 28, 2015 at 02:11:15PM +0530, Vignesh R wrote: >> Add qspi memory mapped region entries for DRA7xx based SoCs. >> >> Signed-off-by: Vignesh R > >> qspi: qspi@4790 { >>

Re: [RFC PATCH 1/5] spi: introduce flag for memory mapped read

2015-08-02 Thread Vignesh R
Hi, On 7/31/2015 11:47 PM, Mark Brown wrote: > On Tue, Jul 28, 2015 at 02:11:12PM +0530, Vignesh R wrote: > >> Introduce use_mmap_read field in spi_message struct. This can be set by >> mtd devices (m25p80) to indicate to spi-master (ti-qspi) to perform >> memory ma

Re: [PATCH v2 2/5] ARM: OMAP2+: DRA7: Add hwmod entries for PWMSS

2015-07-28 Thread Vignesh R
On 07/23/2015 09:05 PM, R, Vignesh wrote: > > > On 7/16/2015 9:01 PM, R, Vignesh wrote: >> Hi, >> >> On 07/16/2015 03:24 AM, Paul Walmsley wrote: >>> Hi, >>> >>> some comments. >>> >>> On Wed, 3 Jun 2015, Vignesh

Re: [PATCH] of/irq: introduce of_has_named_irqs helper

2015-07-28 Thread Vignesh R
On 07/28/2015 11:37 PM, Dmitry Torokhov wrote: > On Tue, Jul 28, 2015 at 11:16:44PM +0530, R, Vignesh wrote: >> Hi, >> >> On 7/28/2015 10:53 PM, Dmitry Torokhov wrote: >>> On Tue, Jul 28, 2015 at 06:53:52PM +0530, Vignesh R wrote: >>>> Hi Dmitry, >>

Re: [PATCH] of/irq: introduce of_has_named_irqs helper

2015-07-28 Thread Vignesh R
Hi Dmitry, On 07/25/2015 01:46 AM, Dmitry Torokhov wrote: > On Fri, Jul 24, 2015 at 12:26:19PM -0700, Dmitry Torokhov wrote: >> On Fri, Jul 24, 2015 at 02:14:57PM -0500, Rob Herring wrote: >>> On Fri, Jul 24, 2015 at 1:26 PM, Dmitry Torokhov >>> wrote: Sometimes drivers might wish to transit

[RFC PATCH 1/5] spi: introduce flag for memory mapped read

2015-07-28 Thread Vignesh R
(hence mmap read is possible) or by other spi devices. Signed-off-by: Vignesh R --- include/linux/spi/spi.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/linux/spi/spi.h b/include/linux/spi/spi.h index d673072346f2..f1a0329ee63f 100644 --- a/include/linux/spi/spi.h +++ b/include

[RFC PATCH 0/5] Add memory mapped read support for TI QSPI.

2015-07-28 Thread Vignesh R
evm with macronix MX66l51235l flash. [1] http://www.ti.com/lit/ug/spruhz6/spruhz6.pdf Section 24.5.4 QSPI Functional Description Vignesh R (5): spi: introduce flag for memory mapped read spi: spi-ti-qspi: Add memory mapped read support mtd: devices: m25p80: set flag to request memory mapped

[RFC PATCH 2/5] spi: spi-ti-qspi: Add memory mapped read support

2015-07-28 Thread Vignesh R
QSPI_SPI_SWITCH_REG. The read_opcode, read mode, dummy bytes are configured in QSPI_SPI_SETUPx_REG, then memcpy is called to copy the requested data from flash to the rx_buf. With this patch, the read speed increased from ~100kB/s to ~2.5MB/s on DRA74 EVM. Signed-off-by: Vignesh R --- drivers/spi/spi-ti-qspi.c

[RFC PATCH 4/5] ARM: dts: DRA7: Add memory map region entries for qspi

2015-07-28 Thread Vignesh R
Add qspi memory mapped region entries for DRA7xx based SoCs. Signed-off-by: Vignesh R --- arch/arm/boot/dts/am4372.dtsi | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi index ade28c790f4b..5317a0f24ab9 100644

[RFC PATCH 5/5] ARM: dts: AM4372: Add memory map region entries for qspi

2015-07-28 Thread Vignesh R
Add qspi memory mapped region entries for AM43xx based SoCs. Signed-off-by: Vignesh R --- arch/arm/boot/dts/dra7.dtsi | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi index 8f1e25bcecbd..75a17c78b0ad 100644 --- a

[RFC PATCH 3/5] mtd: devices: m25p80: set flag to request memory mapped read

2015-07-28 Thread Vignesh R
Set use_mmap_read flag to true, to indicate to spi-master that the spi-message is from mtd layer. This helps spi-master to do memory mapped reads over SPI flash memories, when hardware support is available. Signed-off-by: Vignesh R --- drivers/mtd/devices/m25p80.c | 3 +++ 1 file changed, 3

Re: [PATCH v3 1/2] input: touchscreen: pixcir_i2c_ts: Add support for optional wakeup interrupt

2015-07-27 Thread Vignesh R
On 07/27/2015 04:19 PM, Roger Quadros wrote: > Hi, > > On 23/07/15 17:54, Vignesh R wrote: >> On am437x-gp-evm, pixcir touchscreen can wake the system from low power >> state by generating wake-up interrupt via pinctrl and IO daisy chain. >> Add support for optional

[PATCH v3 2/2] ARM: dts: am437x-gp-evm: Add wakeup interrupt source for pixcir_i2c_tsc

2015-07-23 Thread Vignesh R
Pixcir_i2c_tsc driver can now wakeup the system from lower power state via pinctrl and IO daisy chain using generic wakeirq framwework. Add optional wakeup irq entry to allow pixcir_i2c_tsc to wake system from low power state. Signed-off-by: Vignesh R --- v3: * Drop "irq" suffix from

[PATCH v3 0/2] pixcir_i2c_ts: Add optional wakeup irq support

2015-07-23 Thread Vignesh R
This is the v3 of the patch series to add optional wake irq support for pixcir_i2c_tsc. Tested on am437x-gp-evm, with some out of tree patches to support suspend/resume on am437x. Vignesh R (2): input: touchscreen: pixcir_i2c_ts: Add support for optional wakeup interrupt ARM: dts

[PATCH v3 1/2] input: touchscreen: pixcir_i2c_ts: Add support for optional wakeup interrupt

2015-07-23 Thread Vignesh R
: Add automated device wake IRQ handling"). This is similar in approach to commit 2a0b965cfb6e ("serial: omap: Add support for optional wake-up") Signed-off-by: Vignesh R --- v3: * handle error code returned by of_irq_get_byname() v2: * use of_irq_get_byname() * remove enable/disable_

Re: [PATCH v2 1/2] input: touchscreen: pixcir_i2c_ts: Add support for optional wakeup interrupt

2015-07-21 Thread Vignesh R
Hi Dmitry, On 07/20/2015 11:54 AM, Dmitry Torokhov wrote: > On Sun, Jul 19, 2015 at 11:09:30PM -0700, Tony Lindgren wrote: >> * Vignesh R [150719 21:53]: >>> @@ -445,6 +443,8 @@ static struct pixcir_ts_platform_data >>> *pixcir_parse_dt(struct device *dev) >>&

[PATCH v2 2/2] ARM: dts: AM437x-gp-evm: Add wakeup interrupt source for pixcir_i2c_tsc

2015-07-19 Thread Vignesh R
Pixcir_i2c_tsc driver can now wakeup the system from lower power state via pinctrl and IO daisy chain using generic wakeirq framwework. Add optional wakeup irq entry to allow pixcir_i2c_tsc to wake system from low power state. Signed-off-by: Vignesh R --- v2: * Add interrupt-names property

[PATCH v2 1/2] input: touchscreen: pixcir_i2c_ts: Add support for optional wakeup interrupt

2015-07-19 Thread Vignesh R
: Add automated device wake IRQ handling"). This is similar in approach to commit 2a0b965cfb6e ("serial: omap: Add support for optional wake-up") Signed-off-by: Vignesh R --- v2: * use of_irq_get_byname() * remove enable/disable_wake_irq() drivers/input/touchscreen/

[PATCH v2 0/2] pixcir_i2c_ts: Add optional wakeup irq support

2015-07-19 Thread Vignesh R
of tree patches to support suspend/resume on am437x. Vignesh R (2): input: touchscreen: pixcir_i2c_ts: Add support for optional wakeup interrupt ARM: dts: AM437x-gp-evm: Add wakeup interrupt source for pixcir_i2c_tsc arch/arm/boot/dts/am437x-gp-evm.dts | 4 drivers/input

Re: [PATCH 1/2] input: touchscreen: pixcir_i2c_ts: Add support for optional wakeup interrupt

2015-07-19 Thread Vignesh R
Hi Dmitry, On 7/18/2015 3:21 AM, Dmitry Torokhov wrote: > Hi Vignesh, > > On Fri, Jul 17, 2015 at 12:10:40PM +0530, Vignesh R wrote: >> On am437x-gp-evm, pixcir touchscreen can wake the system from low power >> state by generating wake-up interrupt via pinctrl and IO daisy

[PATCH 0/2] pixcir_i2c_ts: Add optional wakeup irq support

2015-07-16 Thread Vignesh R
of tree patches to support suspend/resume on am437x. Vignesh R (2): input: touchscreen: pixcir_i2c_ts: Add support for optional wakeup interrupt ARM: dts: AM437x-gp-evm: Add wakeup interrupt source for pixcir_i2c_tsc arch/arm/boot/dts/am437x-gp-evm.dts | 3 +++ drivers/input

[PATCH 2/2] ARM: dts: am437x-gp-evm: Add wakeup interrupt source for pixcir_i2c_tsc

2015-07-16 Thread Vignesh R
Pixcir_i2c_tsc driver can now wakeup the system from lower power state via pinctrl and IO daisy chain using generic wakeirq framwework. Add optional wakeup irq entry to allow pixcir_i2c_tsc to wake system from low power state. Signed-off-by: Vignesh R --- arch/arm/boot/dts/am437x-gp-evm.dts | 3

[PATCH 1/2] input: touchscreen: pixcir_i2c_ts: Add support for optional wakeup interrupt

2015-07-16 Thread Vignesh R
: Add automated device wake IRQ handling"). This is similar in approach to commit 2a0b965cfb6e ("serial: omap: Add support for optional wake-up") Signed-off-by: Vignesh R --- drivers/input/touchscreen/pixcir_i2c_ts.c | 14 ++ 1 file changed, 14 insertions(+) diff -

Re: [PATCH v2 0/5] Add support for PWMSS on DRA7

2015-07-05 Thread Vignesh R
On Wednesday 03 June 2015 05:21 PM, Vignesh R wrote: > > Hi, > > This patch series adds support for PWMSS on DRA7. The IP is same as that > present in AM33XX and AM43XX. > The first patch changes clock domain in which PWMSS is present > (l4per2_7xx_clkdm) to SW_WKUP. This

Re: [PATCH v2] w1: masters: omap_hdq: Add support for 1-wire mode

2015-06-11 Thread Vignesh R
Hi, On Thursday 11 June 2015 09:04 PM, Evgeniy Polyakov wrote: > Hi > > 25.05.2015, 08:15, "Vignesh R" : >>> HDQ mode remains unchanged. >>> >>> Signed-off-by: Vignesh R > > I have no experience with omap_hdq platform, but there are quite

[PATCH v2 0/5] Add support for PWMSS on DRA7

2015-06-03 Thread Vignesh R
clock domain to SW_WKUP. This is based on the input from the hardware team. The rest of the patches add hwmod and dt entries and enable PWMSS on DRA7 based SoCs. Vignesh R (5): ARM: OMAP2+: DRA7: clockdomain: change l4per2_7xx_clkdm to SW_WKUP ARM: OMAP2+: DRA7: Add hwmod entries for PWMSS ARM

[PATCH v2 1/5] ARM: OMAP2+: DRA7: clockdomain: change l4per2_7xx_clkdm to SW_WKUP

2015-06-03 Thread Vignesh R
Legacy IPs like PWMSS, present under l4per2_7xx_clkdm, cannot support smart-idle when its clock domain is in HW_AUTO on DRA7 SoCs. Hence, program clock domain to SW_WKUP. Signed-off-by: Vignesh R --- arch/arm/mach-omap2/clockdomains7xx_data.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH v2 2/5] ARM: OMAP2+: DRA7: Add hwmod entries for PWMSS

2015-06-03 Thread Vignesh R
L4PER2_L3_GICLK/2. The TRM does not show the division by 2. [1] www.ti.com/lit/ug/spruhz6/spruhz6.pdf Signed-off-by: Vignesh R --- v2: * add TRM references. arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 239 ++ 1 file changed, 239 insertions(+) diff --git a/arch/arm/mach

[PATCH v2 5/5] ARM: dts: DRA7: Add dt nodes for PWMSS

2015-06-03 Thread Vignesh R
Add PWMSS device tree nodes for DRA7 SoC family and add documentation for dt bindings. Signed-off-by: Vignesh R --- .../devicetree/bindings/pwm/pwm-tiehrpwm.txt | 8 +++ .../devicetree/bindings/pwm/pwm-tipwmss.txt| 17 +- arch/arm/boot/dts/dra7.dtsi

[PATCH v2 3/5] ARM: dts: DRA7: Add TBCLK for PWMSS

2015-06-03 Thread Vignesh R
SPRUHZ6[1], October 2014, Table 29-4 and Section 29.2.2.1, Table 29-19 and the NOTE at the end of the table. [1] www.ti.com/lit/ug/spruhz6/spruhz6.pdf Signed-off-by: Vignesh R --- v2: * add TRM references. arch/arm/boot/dts/dra7.dtsi | 5 + arch/arm/boot/dts/dra7xx-clocks.dtsi

[PATCH v2 4/5] clk: ti: DRA7: Add tbclk data for ehrpwm

2015-06-03 Thread Vignesh R
tbclk is needed by ehrpwm to generate pwm waveforms. Hence, register the required clock information. Signed-off-by: Vignesh R --- drivers/clk/ti/clk-7xx.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/clk/ti/clk-7xx.c b/drivers/clk/ti/clk-7xx.c index 5d2217ae4478..366be43d15fe

Re: [PATCH 2/5] ARM: OMAP2+: DRA7: Add hwmod entries for PWMSS

2015-06-02 Thread Vignesh R
Hi Tero, On Tuesday 02 June 2015 01:51 PM, Tero Kristo wrote: > On 06/01/2015 02:53 PM, Vignesh R wrote: >> Add hwmod entries for the PWMSS on DRA7. > > Can you provide some documentation references for this data? > > I was looking at the TRM and at least the main_clk

Re: [PATCH 3/5] ARM: dts: DRA7: Add TBCLK for PWMSS

2015-06-02 Thread Vignesh R
On Tuesday 02 June 2015 01:52 PM, Tero Kristo wrote: > On 06/01/2015 02:53 PM, Vignesh R wrote: >> tbclk is used by ehrpwm to generate PWM waveform on DRA7 SoC. Add Linux >> clock to control ehrpwm tbclk. > > Care to add TRM reference here? Ok, I will add the following

[PATCH 4/5] clk: ti: DRA7: Add tbclk data for ehrpwm

2015-06-01 Thread Vignesh R
tbclk is needed by ehrpwm to generate pwm waveforms. Hence, register the required clock information. Signed-off-by: Vignesh R --- drivers/clk/ti/clk-7xx.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/clk/ti/clk-7xx.c b/drivers/clk/ti/clk-7xx.c index 5d2217ae4478..366be43d15fe

[PATCH 2/5] ARM: OMAP2+: DRA7: Add hwmod entries for PWMSS

2015-06-01 Thread Vignesh R
Add hwmod entries for the PWMSS on DRA7. Signed-off-by: Vignesh R --- arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 239 ++ 1 file changed, 239 insertions(+) diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c index

[PATCH 3/5] ARM: dts: DRA7: Add TBCLK for PWMSS

2015-06-01 Thread Vignesh R
tbclk is used by ehrpwm to generate PWM waveform on DRA7 SoC. Add Linux clock to control ehrpwm tbclk. Signed-off-by: Vignesh R --- arch/arm/boot/dts/dra7.dtsi | 5 + arch/arm/boot/dts/dra7xx-clocks.dtsi | 26 ++ 2 files changed, 31 insertions(+) diff

[PATCH 5/5] ARM: dts: DRA7: Add dt nodes for PWMSS

2015-06-01 Thread Vignesh R
Add PWMSS device tree nodes for DRA7 SoC family and add documentation for dt bindings. Signed-off-by: Vignesh R --- .../devicetree/bindings/pwm/pwm-tiehrpwm.txt | 8 +++ .../devicetree/bindings/pwm/pwm-tipwmss.txt| 17 +- arch/arm/boot/dts/dra7.dtsi

  1   2   3   >