Re: [PATCH] ahci: qoriq: fixed using uninitialized variable warnings

2015-09-14 Thread Tejun Heo
Hello, Arnd. On Mon, Sep 14, 2015 at 09:45:33AM +0200, Arnd Bergmann wrote: > In general, we really want to leave drivers with a COMPILE_TEST dependency > so they at least get cross-built on x86, ideally on all architectures. Yeah, as long as it doesn't trigger silly warnings or errors on x86, CO

Re: [PATCH] ahci: qoriq: fixed using uninitialized variable warnings

2015-09-14 Thread Arnd Bergmann
On Monday 14 September 2015 14:54:32 Fengguang Wu wrote: > On Mon, Sep 14, 2015 at 06:51:36AM +, Yuantian Tang wrote: > > The ARCH should have been ARM for this driver. > > Do you think this warning would go away if adding a dependency on ARM? > > Yes, that may work. In general, we really wan

Re: [PATCH] ahci: qoriq: fixed using uninitialized variable warnings

2015-09-13 Thread Fengguang Wu
> > > > Regards, > > > Yuantian > > > > > > > -Original Message- > > > > From: Tejun Heo [mailto:hte...@gmail.com] On Behalf Of Tejun Heo > > > > Sent: Friday, September 11, 2015 9:55 PM > > > > To

RE: [PATCH] ahci: qoriq: fixed using uninitialized variable warnings

2015-09-13 Thread Yuantian Tang
B29983 > Cc: Tejun Heo ; hdego...@redhat.com; linux- > i...@vger.kernel.org; linux-ker...@vger.kernel.org; > devicetree@vger.kernel.org > Subject: Re: [PATCH] ahci: qoriq: fixed using uninitialized variable warnings > > Yuantian, > > It's cross compiling on ARCH=openr

Re: [PATCH] ahci: qoriq: fixed using uninitialized variable warnings

2015-09-13 Thread Fengguang Wu
t; > Cc: hdego...@redhat.com; linux-...@vger.kernel.org; linux- > > ker...@vger.kernel.org; devicetree@vger.kernel.org; Fengguang Wu > > > > Subject: Re: [PATCH] ahci: qoriq: fixed using uninitialized variable > > warnings > > > > Hello, Yuantian. > >

RE: [PATCH] ahci: qoriq: fixed using uninitialized variable warnings

2015-09-13 Thread Yuantian Tang
Tejun Heo > Sent: Friday, September 11, 2015 9:55 PM > To: Tang Yuantian-B29983 > Cc: hdego...@redhat.com; linux-...@vger.kernel.org; linux- > ker...@vger.kernel.org; devicetree@vger.kernel.org; Fengguang Wu > > Subject: Re: [PATCH] ahci: qoriq: fixed using uninitialized vari

Re: [PATCH] ahci: qoriq: fixed using uninitialized variable warnings

2015-09-11 Thread Tejun Heo
Hello, Yuantian. On Fri, Sep 11, 2015 at 05:27:25AM +, Yuantian Tang wrote: > Hi Tejun, > > Could you please take the version 1 patch? > The version 2 patch can't address these warnings, and the version 1 can > definitely remove them. > In this case, that would cause any hidden bugs, so no w

RE: [PATCH] ahci: qoriq: fixed using uninitialized variable warnings

2015-09-10 Thread Yuantian Tang
[mailto:hte...@gmail.com] On Behalf Of Tejun Heo > Sent: Wednesday, September 09, 2015 10:02 PM > To: Tang Yuantian-B29983 > Cc: hdego...@redhat.com; linux-...@vger.kernel.org; linux- > ker...@vger.kernel.org; devicetree@vger.kernel.org > Subject: Re: [PATCH] ahci: qoriq: fixed using unini

RE: [PATCH] ahci: qoriq: fixed using uninitialized variable warnings

2015-09-09 Thread Yuantian Tang
rnel.org > Subject: Re: [PATCH] ahci: qoriq: fixed using uninitialized variable warnings > > On Wed, Sep 09, 2015 at 05:16:22PM +0800, yuantian.t...@freescale.com > wrote: > > From: Tang Yuantian > > > > kbuild test robot reports the warnings: > > drive

Re: [PATCH] ahci: qoriq: fixed using uninitialized variable warnings

2015-09-09 Thread Tejun Heo
On Wed, Sep 09, 2015 at 05:16:22PM +0800, yuantian.t...@freescale.com wrote: > From: Tang Yuantian > > kbuild test robot reports the warnings: > drivers/ata/ahci_qoriq.c: In function 'ahci_qoriq_hardreset': > >> include/asm-generic/io.h:163:2: warning: 'px_is' may be used > >> uninitialized in th

Re: [PATCH] ahci: qoriq: fixed using uninitialized variable warnings

2015-09-09 Thread Hans de Goede
Hi, On 09-09-15 11:16, yuantian.t...@freescale.com wrote: From: Tang Yuantian kbuild test robot reports the warnings: drivers/ata/ahci_qoriq.c: In function 'ahci_qoriq_hardreset': include/asm-generic/io.h:163:2: warning: 'px_is' may be used uninitialized in this function [-Wuninitialized] dr

[PATCH] ahci: qoriq: fixed using uninitialized variable warnings

2015-09-09 Thread Yuantian.Tang
From: Tang Yuantian kbuild test robot reports the warnings: drivers/ata/ahci_qoriq.c: In function 'ahci_qoriq_hardreset': >> include/asm-generic/io.h:163:2: warning: 'px_is' may be used >> uninitialized in this function [-Wuninitialized] drivers/ata/ahci_qoriq.c:70:14: note: 'px_is' was declared