Re: [PATCH 1/2] backlight/lp855x: Refactor dt parsing code

2014-11-27 Thread Sean Paul
On Wed, Nov 26, 2014 at 5:32 PM, Kim, Milo wrote: > (Looping backlight class subsystem maintainers) > > Hi Sean, > > Thanks for checking this. I'd like to describe why the original code is > preferred. > > The original code is copying the values of the lp855x platform data from the > DT in advance

Re: [PATCH 1/2] backlight/lp855x: Refactor dt parsing code

2014-11-26 Thread Kim, Milo
(Looping backlight class subsystem maintainers) Hi Sean, Thanks for checking this. I'd like to describe why the original code is preferred. The original code is copying the values of the lp855x platform data from the DT in advance of allocating lp855x data. It guarantees returning quickly i

[PATCH 1/2] backlight/lp855x: Refactor dt parsing code

2014-11-26 Thread Sean Paul
This patch refactors the dt parsing code to avoid setting platform_data, instead just setting lp->pdata directly. This facilitates easier probe deferral since the current scheme would require us to clear out dev->platform_data before deferring. Cc: Stéphane Marchesin Signed-off-by: Sean Paul ---