Re: [PATCH 1/3] iio: adc: hi-843x: Holt HI-8435/8436/8437 descrete ADC

2015-06-24 Thread Vladimir Barinov
On 21.06.2015 17:14, Jonathan Cameron wrote: I'd call this a threshold detector. The device seems to have two comparators for each channel, one for the lower threshold, one for the upper threshold. If the voltage level goes above the upper threshold a FF is set, if it goes below the lower thresho

Re: [PATCH 1/3] iio: adc: hi-843x: Holt HI-8435/8436/8437 descrete ADC

2015-06-21 Thread Jonathan Cameron
On 18/06/15 22:41, Vladimir Barinov wrote: > Hi Lars, > > Thank you for the review. > > On 18.06.2015 22:33, Lars-Peter Clausen wrote: >> On 06/07/2015 06:11 PM, Jonathan Cameron wrote: >>> On 01/06/15 13:20, Vladimir Barinov wrote: Add Holt descrete ADC driver for HI-8435/8436/8437 chips >>

Re: [PATCH 1/3] iio: adc: hi-843x: Holt HI-8435/8436/8437 descrete ADC

2015-06-18 Thread Vladimir Barinov
Hi Lars, Thank you for the review. On 18.06.2015 22:33, Lars-Peter Clausen wrote: On 06/07/2015 06:11 PM, Jonathan Cameron wrote: On 01/06/15 13:20, Vladimir Barinov wrote: Add Holt descrete ADC driver for HI-8435/8436/8437 chips Signed-off-by: Vladimir Barinov Hmm. The main issue here is

Re: [PATCH 1/3] iio: adc: hi-843x: Holt HI-8435/8436/8437 descrete ADC

2015-06-18 Thread Lars-Peter Clausen
On 06/07/2015 06:11 PM, Jonathan Cameron wrote: On 01/06/15 13:20, Vladimir Barinov wrote: Add Holt descrete ADC driver for HI-8435/8436/8437 chips Signed-off-by: Vladimir Barinov Hmm. The main issue here is one man's discrete ADC is another man's configurable general purpose input device.

Re: [PATCH 1/3] iio: adc: hi-843x: Holt HI-8435/8436/8437 descrete ADC

2015-06-07 Thread Jonathan Cameron
On 01/06/15 13:20, Vladimir Barinov wrote: > Add Holt descrete ADC driver for HI-8435/8436/8437 chips > > Signed-off-by: Vladimir Barinov Hmm. The main issue here is one man's discrete ADC is another man's configurable general purpose input device. Anyhow, from an IIO point of view what we care

Re: [PATCH 1/3] iio: adc: hi-843x: Holt HI-8435/8436/8437 descrete ADC

2015-06-03 Thread Vladimir Barinov
Hi Paul, On 03.06.2015 10:05, Paul Bolle wrote: Just a nit, that I spotted while scanning for other issues. On Mon, 2015-06-01 at 15:20 +0300, Vladimir Barinov wrote: --- /dev/null +++ b/drivers/iio/adc/hi-843x.c +ssize_t hi843x_debounce_soft_show(struct device *dev, +

Re: [PATCH 1/3] iio: adc: hi-843x: Holt HI-8435/8436/8437 descrete ADC

2015-06-03 Thread Paul Bolle
Just a nit, that I spotted while scanning for other issues. On Mon, 2015-06-01 at 15:20 +0300, Vladimir Barinov wrote: > --- /dev/null > +++ b/drivers/iio/adc/hi-843x.c > +ssize_t hi843x_debounce_soft_show(struct device *dev, > + struct device_attribute *attr, char *

Re: [PATCH 1/3] iio: adc: hi-843x: Holt HI-8435/8436/8437 descrete ADC

2015-06-01 Thread Vladimir Barinov
Hello Peter, Thank you for the review. On 01.06.2015 15:55, Peter Meerwald wrote: Add Holt descrete ADC driver for HI-8435/8436/8437 chips discrete Thx, will replace in the next try. link to datasheet would be nice, comments below the official link is here: http://www.holtic.com/products/3

Re: [PATCH 1/3] iio: adc: hi-843x: Holt HI-8435/8436/8437 descrete ADC

2015-06-01 Thread Peter Meerwald
> Add Holt descrete ADC driver for HI-8435/8436/8437 chips discrete link to datasheet would be nice, comments below what is the purpose of the driver? the driver-specific ABI needs to be documented under Documentation/ABI/testing/sys-bus-iio-* > > Signed-off-by: Vladimir Barinov > --- > d

[PATCH 1/3] iio: adc: hi-843x: Holt HI-8435/8436/8437 descrete ADC

2015-06-01 Thread Vladimir Barinov
Add Holt descrete ADC driver for HI-8435/8436/8437 chips Signed-off-by: Vladimir Barinov --- drivers/iio/adc/Kconfig | 12 + drivers/iio/adc/Makefile | 1 + drivers/iio/adc/hi-843x.c | 777 ++ 3 files changed, 790 insertions(+) create mode 10064