Re: [PATCH 2/2] drivers/gpio: Port gpio driver to layerscape platform

2015-11-16 Thread Linus Walleij
On Tue, Nov 3, 2015 at 12:19 PM, Liu Gang wrote: > Layerscape has the same ip block/controller as > GPIO on powerpc platform(MPC8XXX). > > So use portable i/o accessors, as in_be32/out_be32 > accessors are Power architecture specific whereas > ioread32/iowrite32 and ioread32be/iowrite32be are > a

Re: [PATCH 2/2] drivers/gpio: Port gpio driver to layerscape platform

2015-11-04 Thread Arnd Bergmann
On Wednesday 04 November 2015 03:17:38 Scott Wood wrote: > > I guess this is fixed per architecture, so you could also do this as > > > > static inline void gpio_out32(u32 val, void __iomem *addr) > > { > > if (IS_ENABLED(CONFIG_ARM)) > > iowrite32(val, addr); > > else if

Re: [PATCH 2/2] drivers/gpio: Port gpio driver to layerscape platform

2015-11-04 Thread Scott Wood
On Wed, 2015-11-04 at 09:53 +0100, Arnd Bergmann wrote: > On Wednesday 04 November 2015 14:48:24 Liu Gang wrote: > > > > +static bool gpio_little_endian; > > +static inline u32 gpio_in32(void __iomem *addr) > > +{ > > + u32 val; > > + > > + if (gpio_little_endian) > > + val = ioread3

Re: [PATCH 2/2] drivers/gpio: Port gpio driver to layerscape platform

2015-11-04 Thread Arnd Bergmann
On Wednesday 04 November 2015 14:48:24 Liu Gang wrote: > Layerscape has the same ip block/controller as > GPIO on powerpc platform(MPC8XXX). > > So use portable i/o accessors, as in_be32/out_be32 > accessors are Power architecture specific whereas > ioread32/iowrite32 and ioread32be/iowrite32be ar

[PATCH 2/2] drivers/gpio: Port gpio driver to layerscape platform

2015-11-03 Thread Liu Gang
Layerscape has the same ip block/controller as GPIO on powerpc platform(MPC8XXX). So use portable i/o accessors, as in_be32/out_be32 accessors are Power architecture specific whereas ioread32/iowrite32 and ioread32be/iowrite32be are available in other architectures. Layerscape GPIO controller's r