Re: [PATCH 2/3] net: hisilicon: new hip04 MDIO driver

2014-04-07 Thread David Miller
From: Zhangfei Gao Date: Sat, 5 Apr 2014 12:35:05 +0800 > +} > + > + > +static int hip04_mdio_reset(struct mii_bus *bus) Please one empty line between functions, not two. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.o

[PATCH 2/3] net: hisilicon: new hip04 MDIO driver

2014-04-04 Thread Zhangfei Gao
Hisilicon hip04 platform mdio driver Reuse Marvell phy drivers/net/phy/marvell.c Signed-off-by: Zhangfei Gao --- drivers/net/ethernet/Kconfig|1 + drivers/net/ethernet/Makefile |1 + drivers/net/ethernet/hisilicon/Kconfig | 31 + drivers/net/ether

Re: [PATCH 2/3] net: hisilicon: new hip04 MDIO driver

2014-04-04 Thread David Miller
When you make a new postings of a patch, you must resend the entire series, not just the patch which is being updated. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/major

[PATCH 2/3] net: hisilicon: new hip04 MDIO driver

2014-04-04 Thread Zhangfei Gao
Hisilicon hip04 platform mdio driver Reuse Marvell phy drivers/net/phy/marvell.c Signed-off-by: Zhangfei Gao --- drivers/net/ethernet/Kconfig|1 + drivers/net/ethernet/Makefile |1 + drivers/net/ethernet/hisilicon/Kconfig | 31 + drivers/net/ether

[PATCH 2/3] net: hisilicon: new hip04 MDIO driver

2014-04-04 Thread Zhangfei Gao
Hisilicon hip04 platform mdio driver Reuse Marvell phy drivers/net/phy/marvell.c Signed-off-by: Zhangfei Gao --- drivers/net/ethernet/Kconfig|1 + drivers/net/ethernet/Makefile |1 + drivers/net/ethernet/hisilicon/Kconfig | 31 + drivers/net/ether

Re: [PATCH 2/3] net: hisilicon: new hip04 MDIO driver

2014-04-04 Thread David Miller
From: zhangfei Date: Fri, 04 Apr 2014 23:40:24 +0800 > Thanks Daivd, could I update following this thread first. You will need to address my feedback, as well as that which anyone else reviewing this series gives to you. It is not acceptable, ever, to "just fix it later". You must fix all issu

Re: [PATCH 2/3] net: hisilicon: new hip04 MDIO driver

2014-04-04 Thread zhangfei
On 04/04/2014 11:30 PM, David Miller wrote: From: Zhangfei Gao Date: Fri, 4 Apr 2014 23:16:36 +0800 +config HIP04_ETH + tristate "HISILICON P04 Ethernet support" + select NET_CORE + select PHYLIB + select MARVELL_PHY + select MFD_SYSCON + ---help--- +

Re: [PATCH 2/3] net: hisilicon: new hip04 MDIO driver

2014-04-04 Thread David Miller
From: Zhangfei Gao Date: Fri, 4 Apr 2014 23:16:36 +0800 > +config HIP04_ETH > + tristate "HISILICON P04 Ethernet support" > + select NET_CORE > + select PHYLIB > + select MARVELL_PHY > + select MFD_SYSCON > + ---help--- > + If you wish to compile a kernel for a hard

[PATCH 2/3] net: hisilicon: new hip04 MDIO driver

2014-04-04 Thread Zhangfei Gao
Hisilicon hip04 platform mdio driver Reuse Marvell phy drivers/net/phy/marvell.c Signed-off-by: Zhangfei Gao --- drivers/net/ethernet/Kconfig|1 + drivers/net/ethernet/Makefile |1 + drivers/net/ethernet/hisilicon/Kconfig | 32 + drivers/net/ether

[PATCH 2/3] net: hisilicon: new hip04 MDIO driver

2014-04-01 Thread Zhangfei Gao
Hisilicon hip04 platform mdio driver Reuse Marvell phy drivers/net/phy/marvell.c Signed-off-by: Zhangfei Gao --- drivers/net/ethernet/Kconfig|1 + drivers/net/ethernet/Makefile |1 + drivers/net/ethernet/hisilicon/Kconfig | 32 + drivers/net/ether

Re: [PATCH 2/3] net: hisilicon: new hip04 MDIO driver

2014-03-30 Thread zhangfei
On 03/31/2014 05:23 AM, David Miller wrote: From: Zhangfei Gao Date: Fri, 28 Mar 2014 23:35:59 +0800 + Note that the answer to this question doesn't directly affect the + kernel: saying N will just cause the configurator to skip all + the questions about MOXA ART devi

Re: [PATCH 2/3] net: hisilicon: new hip04 MDIO driver

2014-03-30 Thread David Miller
From: Zhangfei Gao Date: Fri, 28 Mar 2014 23:35:59 +0800 > + Note that the answer to this question doesn't directly affect the > + kernel: saying N will just cause the configurator to skip all > + the questions about MOXA ART devices. If you say Y, you will be asked > + fo

[PATCH 2/3] net: hisilicon: new hip04 MDIO driver

2014-03-28 Thread Zhangfei Gao
Hisilicon hip04 platform mdio driver Reuse Marvell phy drivers/net/phy/marvell.c Signed-off-by: Zhangfei Gao --- drivers/net/ethernet/Kconfig|1 + drivers/net/ethernet/Makefile |1 + drivers/net/ethernet/hisilicon/Kconfig | 32 + drivers/net/ether

[PATCH 2/3] net: hisilicon: new hip04 MDIO driver

2014-03-24 Thread Zhangfei Gao
Hisilicon hip04 platform mdio driver Reuse Marvell phy drivers/net/phy/marvell.c Signed-off-by: Zhangfei Gao --- drivers/net/ethernet/Kconfig|1 + drivers/net/ethernet/Makefile |1 + drivers/net/ethernet/hisilicon/Kconfig | 32 + drivers/net/ether

[PATCH 2/3] net: hisilicon: new hip04 MDIO driver

2014-03-21 Thread Zhangfei Gao
Hisilicon hip04 platform mdio driver Reuse Marvell phy drivers/net/phy/marvell.c Signed-off-by: Zhangfei Gao --- drivers/net/ethernet/Kconfig|1 + drivers/net/ethernet/Makefile |1 + drivers/net/ethernet/hisilicon/Kconfig | 31 + drivers/net/ether

Re: [PATCH 2/3] net: hisilicon: new hip04 MDIO driver

2014-03-20 Thread Zhangfei Gao
On Fri, Mar 21, 2014 at 1:59 AM, Florian Fainelli wrote: > 2014-03-20 3:53 GMT-07:00 Zhangfei Gao : +static int hip04_mdio_reset(struct mii_bus *bus) +{ + int temp, err, i; + + for (i = 0; i < 2; i++) { + hip04_mdio_write(bus, i, 22, 0);

Re: [PATCH 2/3] net: hisilicon: new hip04 MDIO driver

2014-03-20 Thread Florian Fainelli
2014-03-20 3:53 GMT-07:00 Zhangfei Gao : > Dear Florian > > On Wed, Mar 19, 2014 at 1:28 AM, Florian Fainelli > wrote: >> 2014-03-18 1:40 GMT-07:00 Zhangfei Gao : > >>> +static int hip04_mdio_reset(struct mii_bus *bus) >>> +{ >>> + int temp, err, i; >>> + >>> + for (i = 0; i < 2; i++)

Re: [PATCH 2/3] net: hisilicon: new hip04 MDIO driver

2014-03-20 Thread Zhangfei Gao
Dear Florian On Wed, Mar 19, 2014 at 1:28 AM, Florian Fainelli wrote: > 2014-03-18 1:40 GMT-07:00 Zhangfei Gao : >> +static int hip04_mdio_reset(struct mii_bus *bus) >> +{ >> + int temp, err, i; >> + >> + for (i = 0; i < 2; i++) { >> + hip04_mdio_write(bus, i, 22, 0); >

Re: [PATCH 2/3] net: hisilicon: new hip04 MDIO driver

2014-03-18 Thread Florian Fainelli
2014-03-18 1:40 GMT-07:00 Zhangfei Gao : > Hisilicon hip04 platform mdio driver > Reuse Marvell phy drivers/net/phy/marvell.c > > Signed-off-by: Zhangfei Gao > --- > drivers/net/ethernet/Kconfig|1 + > drivers/net/ethernet/Makefile |1 + > drivers/net/etherne

[PATCH 2/3] net: hisilicon: new hip04 MDIO driver

2014-03-18 Thread Zhangfei Gao
Hisilicon hip04 platform mdio driver Reuse Marvell phy drivers/net/phy/marvell.c Signed-off-by: Zhangfei Gao --- drivers/net/ethernet/Kconfig|1 + drivers/net/ethernet/Makefile |1 + drivers/net/ethernet/hisilicon/Kconfig | 31 + drivers/net/ether