Re: [PATCH 2/3] regulator: Add support for S2MPA01 regulator

2014-01-09 Thread Mark Brown
On Thu, Jan 09, 2014 at 10:39:34AM +0530, Sachin Kamat wrote: > On 8 January 2014 18:00, Mark Brown wrote: > >> +subsys_initcall(s2mpa01_pmic_init); > > module_platform_driver(). > Just a small doubt here. Wouldn't changing this from subsys init to module > init > cause problems to devices lik

Re: [PATCH 2/3] regulator: Add support for S2MPA01 regulator

2014-01-08 Thread Sachin Kamat
Hi Mark, Thanks for reviewing. On 8 January 2014 18:00, Mark Brown wrote: > On Wed, Jan 08, 2014 at 11:56:29AM +0530, Sachin Kamat wrote: > >> + if (!iodev->dev->of_node) { >> + if (pdata) { >> + goto common_reg; >> + } else { >> +

Re: [PATCH 2/3] regulator: Add support for S2MPA01 regulator

2014-01-08 Thread Mark Brown
On Wed, Jan 08, 2014 at 11:56:29AM +0530, Sachin Kamat wrote: > + if (!iodev->dev->of_node) { > + if (pdata) { > + goto common_reg; > + } else { > + dev_err(pdev->dev.parent, > + "Platform data or DT no

[PATCH 2/3] regulator: Add support for S2MPA01 regulator

2014-01-07 Thread Sachin Kamat
Add support for S2MPA01 voltage and current regulator. Signed-off-by: Sachin Kamat --- drivers/regulator/Kconfig |7 + drivers/regulator/Makefile |1 + drivers/regulator/s2mpa01.c | 497 +++ 3 files changed, 505 insertions(+) create mode 10064