Re: [PATCH 3/4] ARM: DT: apq8064: Add USB OTG support

2014-09-29 Thread Srinivas Kandagatla
On 29/09/14 11:53, Mark Rutland wrote: >Its canonical value is "okay" (although in practice anything >other than "disabled" should work). That's not quite true, there are other "bad" values like "fail" and "fail-sss" documented by ePAPR. In Linux, of_device_is_available errs on the side of cau

Re: [PATCH 3/4] ARM: DT: apq8064: Add USB OTG support

2014-09-29 Thread Mark Rutland
On Mon, Sep 29, 2014 at 11:26:41AM +0100, Kiran Padwal wrote: > Hi Srinivas, > > Some review are comments inline. > > On Monday 29 September 2014 02:45 PM, Srinivas Kandagatla wrote: > > This patch adds USB OTG support on USB1 of APQ8064 SOC. > > Tested on IFC6410 with ethernet gadget. > > > > S

Re: [PATCH 3/4] ARM: DT: apq8064: Add USB OTG support

2014-09-29 Thread Kiran Padwal
Hi Srinivas, Some review are comments inline. On Monday 29 September 2014 02:45 PM, Srinivas Kandagatla wrote: > This patch adds USB OTG support on USB1 of APQ8064 SOC. > Tested on IFC6410 with ethernet gadget. > > Signed-off-by: Srinivas Kandagatla > --- > arch/arm/boot/dts/qcom-apq8064-ifc64

[PATCH 3/4] ARM: DT: apq8064: Add USB OTG support

2014-09-29 Thread Srinivas Kandagatla
This patch adds USB OTG support on USB1 of APQ8064 SOC. Tested on IFC6410 with ethernet gadget. Signed-off-by: Srinivas Kandagatla --- arch/arm/boot/dts/qcom-apq8064-ifc6410.dts | 14 + arch/arm/boot/dts/qcom-apq8064.dtsi| 46 ++ 2 files changed, 60 in