On 12.01.2014 20:20, Mark Brown wrote:
On Sat, Jan 11, 2014 at 08:42:43PM +0100, Tomasz Figa wrote:
static struct s3c64xx_pm_domain s3c64xx_pm_irom = {
- .name = "IROM",
.ena = S3C64XX_NORMALCFG_IROM_ON,
.pd = {
+ .name = "domain_irom",
This is nitpicki
On Sun, Jan 12, 2014 at 08:03:50PM +0100, Tomasz Figa wrote:
> Also, there are multiple devices in most domains, so that would
> rather end up being "Domain_I (JPEG, Cam I/F)", "Domain_P (2D, TV
> Enc., Scaler)", "Domain_F (Rot, Post, LCD)".
It's not just that there's multiple devices either, it'
On Sat, Jan 11, 2014 at 08:42:43PM +0100, Tomasz Figa wrote:
> static struct s3c64xx_pm_domain s3c64xx_pm_irom = {
> - .name = "IROM",
> .ena = S3C64XX_NORMALCFG_IROM_ON,
> .pd = {
> + .name = "domain_irom",
This is nitpicking a bit but are you sure this is actually a
On 12.01.2014 19:53, Pavel Machek wrote:
Hi!
Could we get some more descriptive names for the domains?
They are listed like this in user's manual, e.g. DOMAIN_F, DOMAIN_I,
DOMAIN_G, etc.
I guessed so. So the manual sucks. Would it be feasible to get it more
descriptive (like "Domain_G (GPU)
Hi!
> >Could we get some more descriptive names for the domains?
>
> They are listed like this in user's manual, e.g. DOMAIN_F, DOMAIN_I,
> DOMAIN_G, etc.
I guessed so. So the manual sucks. Would it be feasible to get it more
descriptive (like "Domain_G (GPU)")?
Hi Pavel,
On 12.01.2014 12:47, Pavel Machek wrote:
On Sat 2014-01-11 20:42:43, Tomasz Figa wrote:
This patch removes name field from private s3c64xx_pm_domain struct and
moves domain name to dedicated field of generic_pm_domain struct.
When at it, beautify the names a bit, since they are used
On Sat 2014-01-11 20:42:43, Tomasz Figa wrote:
> This patch removes name field from private s3c64xx_pm_domain struct and
> moves domain name to dedicated field of generic_pm_domain struct.
>
> When at it, beautify the names a bit, since they are used by genpd core
> as message prefixes.
>
> Signe
This patch removes name field from private s3c64xx_pm_domain struct and
moves domain name to dedicated field of generic_pm_domain struct.
When at it, beautify the names a bit, since they are used by genpd core
as message prefixes.
Signed-off-by: Tomasz Figa
---
arch/arm/mach-s3c64xx/pm.c | 19 +
