Re: [PATCH v2 1/2] tty: serial: 8250: Add Mediatek UART driver

2014-08-07 Thread One Thousand Gnomes
On Thu, 7 Aug 2014 16:07:41 +0200 Matthias Brugger wrote: > 2014-08-07 15:21 GMT+02:00 Alan Cox : > > > >> + * Some baudrates are not supported by the chip, so we use the next > >> + * lower rate supported and update termios c_flag. > > > > I don't see the termios updating being done no

Re: [PATCH v2 1/2] tty: serial: 8250: Add Mediatek UART driver

2014-08-07 Thread Matthias Brugger
2014-08-07 15:21 GMT+02:00 Alan Cox : > >> + * Some baudrates are not supported by the chip, so we use the next >> + * lower rate supported and update termios c_flag. > > I don't see the termios updating being done now ? Please have a look on the usage of the SET_CFLAG_BAUD macro in the

Re: [PATCH v2 1/2] tty: serial: 8250: Add Mediatek UART driver

2014-08-07 Thread Alan Cox
> + * Some baudrates are not supported by the chip, so we use the next > + * lower rate supported and update termios c_flag. I don't see the termios updating being done now ? > + data->clk = of_clk_get(np, 0); > + if (IS_ERR(data->clk)) { > + pr_warn("Can't get time

[PATCH v2 1/2] tty: serial: 8250: Add Mediatek UART driver

2014-08-06 Thread Matthias Brugger
This patch adds support for the UART block found on Mediatek SoCs. The device has a highspeed register which influences the calcualtion of the divisor. The chip lacks support for some baudrates. When requested, we set the divisor to the next smaller baudrate and adjust the c_cflag accordingly. Sig