Re: [PATCH v2 4/5] regulator: max14577: Add regulator driver for Maxim 14577

2013-11-21 Thread Krzysztof Kozlowski
On Wed, 2013-11-20 at 18:58 +0100, Bartlomiej Zolnierkiewicz wrote: > Err.. > > > I'm missing something obvious "info" is redundant and can be removed > > altogether. > > > > Best regards, > > -- > > Bartlomiej Zolnierkiewicz > > Samsung R&D Institute Poland > > Samsung Electronics > > > > > + f

Re: [PATCH v2 4/5] regulator: max14577: Add regulator driver for Maxim 14577

2013-11-20 Thread Bartlomiej Zolnierkiewicz
On Wednesday, November 20, 2013 06:54:34 PM Bartlomiej Zolnierkiewicz wrote: > > Hi Krzysztof, > > On Wednesday, November 20, 2013 03:12:11 PM Krzysztof Kozlowski wrote: > > MAX14577 chip is a multi-function device which includes MUIC, > > charger and voltage regulator. The driver is located in d

Re: [PATCH v2 4/5] regulator: max14577: Add regulator driver for Maxim 14577

2013-11-20 Thread Bartlomiej Zolnierkiewicz
Hi Krzysztof, On Wednesday, November 20, 2013 03:12:11 PM Krzysztof Kozlowski wrote: > MAX14577 chip is a multi-function device which includes MUIC, > charger and voltage regulator. The driver is located in drivers/mfd. > > This patch adds regulator driver for MAX14577 chip. There are two > regu

Re: [PATCH v2 4/5] regulator: max14577: Add regulator driver for Maxim 14577

2013-11-20 Thread Mark Brown
On Wed, Nov 20, 2013 at 03:12:11PM +0100, Krzysztof Kozlowski wrote: > + size = sizeof(struct regulator_dev *) * pdata->num_regulators; > + info->regulators = devm_kzalloc(&pdev->dev, size, GFP_KERNEL); > + if (!info->regulators) { > + dev_err(&pdev->dev, "Cannot allocate m

[PATCH v2 4/5] regulator: max14577: Add regulator driver for Maxim 14577

2013-11-20 Thread Krzysztof Kozlowski
MAX14577 chip is a multi-function device which includes MUIC, charger and voltage regulator. The driver is located in drivers/mfd. This patch adds regulator driver for MAX14577 chip. There are two regulators in this chip: 1. Safeout LDO with constant voltage output of 4.9V. It can be only enabl