Re: [PATCH v2 5/6] iommu/mediatek: Add mt8173 IOMMU driver

2015-06-05 Thread Will Deacon
On Fri, May 15, 2015 at 10:43:28AM +0100, Yong Wu wrote: > This patch adds support for mediatek m4u (MultiMedia Memory Management Unit). After looking at the page table code, I thought I'd come and check your TLB invalidate code here. > +static void mtk_iommu_tlb_flush_all(void *cookie) > +{ > +

Re: [PATCH v2 5/6] iommu/mediatek: Add mt8173 IOMMU driver

2015-05-27 Thread Yong Wu
Hi Tomasz, Thanks. please help check my comments. The others I will change in next version. On Mon, 2015-05-25 at 17:29 +0900, Tomasz Figa wrote: > Hi, > > Please see my comments inline. > > On Fri, May 15, 2015 at 6:43 PM, Yong Wu wrote: > [snip] > > + > > +struct mtk_iommu_info { > >

Re: [PATCH v2 5/6] iommu/mediatek: Add mt8173 IOMMU driver

2015-05-25 Thread Tomasz Figa
Hi, Please see my comments inline. On Fri, May 15, 2015 at 6:43 PM, Yong Wu wrote: [snip] > + > +struct mtk_iommu_info { > + void __iomem*base; > + int irq; > + struct device *dev; > + struct device *larbdev[MTK_IOMMU_LA