Re: [PATCH v3 5/8] gpio: Add Fujitsu MB86S7x GPIO driver

2015-01-11 Thread Linus Walleij
On Sun, Jan 11, 2015 at 11:40 PM, Linus Walleij wrote: > First I thought maybe this could use the generic MMIO driver > but it seems you need this double register access for setting > the direction so it won't work. > > Otherwise it's sort of close ... have you looks at the option? Bah, sorry I

Re: [PATCH v3 5/8] gpio: Add Fujitsu MB86S7x GPIO driver

2015-01-11 Thread Linus Walleij
On Fri, Jan 9, 2015 at 12:33 PM, Vincent Yang wrote: > From: Jassi Brar > > Driver for Fujitsu MB86S7x SoCs that have a memory mapped GPIO controller. > > Signed-off-by: Andy Green > Signed-off-by: Jassi Brar > Signed-off-by: Vincent Yang > Signed-off-by: Tetsuya Nuriya () > +++ b/Docum

Re: [PATCH v3 5/8] gpio: Add Fujitsu MB86S7x GPIO driver

2015-01-09 Thread Jassi Brar
On 9 January 2015 at 18:22, Russell King - ARM Linux wrote: > On Fri, Jan 09, 2015 at 07:33:32PM +0800, Vincent Yang wrote: >> +static int mb86s70_gpio_remove(struct platform_device *pdev) >> +{ >> + struct mb86s70_gpio_chip *gchip = platform_get_drvdata(pdev); >> + >> + gpiochip_remove(&g

Re: [PATCH v3 5/8] gpio: Add Fujitsu MB86S7x GPIO driver

2015-01-09 Thread Russell King - ARM Linux
On Fri, Jan 09, 2015 at 07:33:32PM +0800, Vincent Yang wrote: > +static int mb86s70_gpio_remove(struct platform_device *pdev) > +{ > + struct mb86s70_gpio_chip *gchip = platform_get_drvdata(pdev); > + > + gpiochip_remove(&gchip->gc); This doesn't disable and unprepare the clock. -- FTTC

[PATCH v3 5/8] gpio: Add Fujitsu MB86S7x GPIO driver

2015-01-09 Thread Vincent Yang
From: Jassi Brar Driver for Fujitsu MB86S7x SoCs that have a memory mapped GPIO controller. Signed-off-by: Andy Green Signed-off-by: Jassi Brar Signed-off-by: Vincent Yang Signed-off-by: Tetsuya Nuriya --- .../bindings/gpio/fujitsu,mb86s70-gpio.txt | 20 ++ drivers/gpio/Kconfig