Re: [PATCH v3 6/6] hwmon: pwm-fan: Update the duty cycle inorder to control the pwm-fan

2015-04-12 Thread Guenter Roeck
On 04/12/2015 08:29 AM, Anand Moon wrote: hi Guenter, I am referring to #linux/drivers/pwm/pwm-samsung.c Will update the comment. Sure, but that doesn't help as patch description for the pwm-fan driver. Guenter -Anand Moon On 12 April 2015 at 20:37, Guenter Roeck wrote: On 04/12/2015 07

Re: [PATCH v3 6/6] hwmon: pwm-fan: Update the duty cycle inorder to control the pwm-fan

2015-04-12 Thread Anand Moon
hi Guenter, I am referring to #linux/drivers/pwm/pwm-samsung.c Will update the comment. -Anand Moon On 12 April 2015 at 20:37, Guenter Roeck wrote: > On 04/12/2015 07:54 AM, Anand Moon wrote: >> >> In order to disable the PWM we need to update using following sequence. >> >> pwm_config

Re: [PATCH v3 6/6] hwmon: pwm-fan: Update the duty cycle inorder to control the pwm-fan

2015-04-12 Thread Guenter Roeck
On 04/12/2015 07:54 AM, Anand Moon wrote: In order to disable the PWM we need to update using following sequence. pwm_config(pwm, 0, period); pwm_disable(pwm); pwm_config() with a zero duty cycle to make it clear the timer and update the PWM registers. pwm_disable will clear th

[PATCH v3 6/6] hwmon: pwm-fan: Update the duty cycle inorder to control the pwm-fan

2015-04-12 Thread Anand Moon
In order to disable the PWM we need to update using following sequence. pwm_config(pwm, 0, period); pwm_disable(pwm); pwm_config() with a zero duty cycle to make it clear the timer and update the PWM registers. pwm_disable will clear the TCON_AUTORELOAD(tcon_chan) and update the