Re: [PATCH v5 1/4] pci: APM X-Gene PCIe controller driver

2014-03-26 Thread Liviu Dudau
On Tue, Mar 25, 2014 at 10:12:14PM +, Tanmay Inamdar wrote: > Hello Liviu, > > Thanks for taking a look. Please see inline. > > On Tue, Mar 25, 2014 at 7:02 AM, Liviu Dudau wrote: > > On Wed, Mar 19, 2014 at 11:12:39PM +, Tanmay Inamdar wrote: > >> This patch adds the AppliedMicro X-Gene

Re: [PATCH v5 1/4] pci: APM X-Gene PCIe controller driver

2014-03-25 Thread Tanmay Inamdar
Hello Liviu, Thanks for taking a look. Please see inline. On Tue, Mar 25, 2014 at 7:02 AM, Liviu Dudau wrote: > On Wed, Mar 19, 2014 at 11:12:39PM +, Tanmay Inamdar wrote: >> This patch adds the AppliedMicro X-Gene SOC PCIe controller driver. >> X-Gene PCIe controller supports maximum up to

Re: [PATCH v5 1/4] pci: APM X-Gene PCIe controller driver

2014-03-25 Thread Tanmay Inamdar
Hello Phil, Thanks for reviewing. Please see inline. On Tue, Mar 25, 2014 at 1:52 AM, wrote: > Hi Tanmay, > > On: 19/03/2014 23:15, Tanmay wrote: >> Subject: [PATCH v5 1/4] pci: APM X-Gene PCIe controller driver >> Sent by: linux-pci-ow...@vger.kernel.org >> >>

Re: [PATCH v5 1/4] pci: APM X-Gene PCIe controller driver

2014-03-25 Thread Bjorn Helgaas
On Tue, Mar 25, 2014 at 8:05 AM, Liviu Dudau wrote: > ... I'm a bit baffled by pci_claim_resource() > as it doesn't seem to be used by some architectures. Does it mean it > is not needed unless you have some BIOS setting up resources for you > and in that case you need to go and claim the resourc

Re: [PATCH v5 1/4] pci: APM X-Gene PCIe controller driver

2014-03-25 Thread Liviu Dudau
On Fri, Mar 21, 2014 at 06:23:27PM +, Tanmay Inamdar wrote: > Hi Sunil, > > I think 'pci_assign_unassigned_bus_resources' should take care of > this. Liviu can comment more. Tanmay, I think you are right. I'm a bit baffled by pci_claim_resource() as it doesn't seem to be used by some architec

Re: [PATCH v5 1/4] pci: APM X-Gene PCIe controller driver

2014-03-25 Thread Liviu Dudau
On Wed, Mar 19, 2014 at 11:12:39PM +, Tanmay Inamdar wrote: > This patch adds the AppliedMicro X-Gene SOC PCIe controller driver. > X-Gene PCIe controller supports maximum up to 8 lanes and GEN3 speed. > X-Gene SOC supports maximum 5 PCIe ports. > > Signed-off-by: Tanmay Inamdar Hi Tanmay,

Re: [PATCH v5 1/4] pci: APM X-Gene PCIe controller driver

2014-03-25 Thread Phil . Edworthy
Hi Tanmay, On: 19/03/2014 23:15, Tanmay wrote: > Subject: [PATCH v5 1/4] pci: APM X-Gene PCIe controller driver > Sent by: linux-pci-ow...@vger.kernel.org > > This patch adds the AppliedMicro X-Gene SOC PCIe controller driver. > X-Gene PCIe controller supports maximum up to 8

Re: [PATCH v5 1/4] pci: APM X-Gene PCIe controller driver

2014-03-21 Thread Tanmay Inamdar
Hi Sunil, I think 'pci_assign_unassigned_bus_resources' should take care of this. Liviu can comment more. Thanks, Tanmay On Fri, Mar 21, 2014 at 3:15 AM, Sunil Kovvuri wrote: > Hi Tanmay, > > Didn't get how PCI resources are enabled for the device. > Liviu Dudau's ARM64 PCI architecture patch e

Re: [PATCH v5 1/4] pci: APM X-Gene PCIe controller driver

2014-03-21 Thread Sunil Kovvuri
Hi Tanmay, Didn't get how PCI resources are enabled for the device. Liviu Dudau's ARM64 PCI architecture patch enables device resources using genenic API. https://lkml.org/lkml/2014/3/14/276 + return pci_enable_resources(dev, mask); pci_enable_resources() checks if resource->parent is non-NULL.

[PATCH v5 1/4] pci: APM X-Gene PCIe controller driver

2014-03-19 Thread Tanmay Inamdar
This patch adds the AppliedMicro X-Gene SOC PCIe controller driver. X-Gene PCIe controller supports maximum up to 8 lanes and GEN3 speed. X-Gene SOC supports maximum 5 PCIe ports. Signed-off-by: Tanmay Inamdar --- drivers/pci/host/Kconfig | 10 + drivers/pci/host/Makefile|1 + driv