Re: [PATCH v6 3/7] regulator: add pbias regulator support

2013-12-20 Thread Balaji T K
On Friday 20 December 2013 09:43 PM, Tony Lindgren wrote: * Mark Brown [131220 08:10]: On Fri, Dec 20, 2013 at 07:57:21AM -0800, Tony Lindgren wrote: * Balaji T K [131220 01:49]: But interrupt was never used/tested AFAIK, there is some settling time before the generated interrupt status is

Re: [PATCH v6 3/7] regulator: add pbias regulator support

2013-12-20 Thread Tony Lindgren
* Mark Brown [131220 08:10]: > On Fri, Dec 20, 2013 at 07:57:21AM -0800, Tony Lindgren wrote: > > * Balaji T K [131220 01:49]: > > > > But interrupt was never used/tested AFAIK, there is some settling time > > > before the generated interrupt status is truely valid, so pbias interrupt > > > is

Re: [PATCH v6 3/7] regulator: add pbias regulator support

2013-12-20 Thread Mark Brown
On Fri, Dec 20, 2013 at 07:57:21AM -0800, Tony Lindgren wrote: > * Balaji T K [131220 01:49]: > > But interrupt was never used/tested AFAIK, there is some settling time > > before the generated interrupt status is truely valid, so pbias interrupt > > is not > > reliable. > OK. Do we need the st

Re: [PATCH v6 3/7] regulator: add pbias regulator support

2013-12-20 Thread Tony Lindgren
* Balaji T K [131220 01:49]: > On Thursday 19 December 2013 10:03 PM, Tony Lindgren wrote: > >>+static int pbias_regulator_enable(struct regulator_dev *rdev) > >>+{ > >>+ struct pbias_regulator_data *data = rdev_get_drvdata(rdev); > >>+ const struct pbias_reg_info *info = data->info; > >>+ i

Re: [PATCH v6 3/7] regulator: add pbias regulator support

2013-12-20 Thread Balaji T K
On Thursday 19 December 2013 10:03 PM, Tony Lindgren wrote: Looks good to me, just few minor comments below. * Balaji T K [131219 04:40]: --- /dev/null +++ b/drivers/regulator/pbias-regulator.c @@ -0,0 +1,255 @@ +/* + * pbias-regulator.c + * + * Copyright (C) 2011 Texas Instruments Incorporate

Re: [PATCH v6 3/7] regulator: add pbias regulator support

2013-12-19 Thread Tony Lindgren
Looks good to me, just few minor comments below. * Balaji T K [131219 04:40]: > --- /dev/null > +++ b/drivers/regulator/pbias-regulator.c > @@ -0,0 +1,255 @@ > +/* > + * pbias-regulator.c > + * > + * Copyright (C) 2011 Texas Instruments Incorporated - http://www.ti.com/ > + * Author: Balaji T K

Re: [PATCH v6 3/7] regulator: add pbias regulator support

2013-12-19 Thread Mark Brown
On Thu, Dec 19, 2013 at 06:08:36PM +0530, Balaji T K wrote: > pbias register controls internal power supply to sd card i/o pads > in most OMAPs (OMAP2-5, DRA7). > Control bits for selecting voltage level and > enabling/disabling are in the same PBIAS register. This is basically fine from a regulat

[PATCH v6 3/7] regulator: add pbias regulator support

2013-12-19 Thread Balaji T K
pbias register controls internal power supply to sd card i/o pads in most OMAPs (OMAP2-5, DRA7). Control bits for selecting voltage level and enabling/disabling are in the same PBIAS register. Signed-off-by: Balaji T K --- Add support for sim pbias and get pbias register offset via standard reg p