Re: [PATCH v7 2/9] nvmem: Add a simple NVMEM framework for consumers

2015-07-13 Thread Srinivas Kandagatla
On 13/07/15 20:06, Stefan Wahren wrote: -#include >#include >#include >#include >#include >-#include please avoid such changes in your patch series. This should be fixed in the first patch. Sure, I know why this happened, the headers were re-ordered in this patch.. I will take care of i

Re: [PATCH v7 2/9] nvmem: Add a simple NVMEM framework for consumers

2015-07-13 Thread Stefan Wahren
Hi Srinivas, > Srinivas Kandagatla hat am 10. Juli 2015 um > 11:44 geschrieben: > > > [...] > --- > drivers/nvmem/core.c | 424 - > include/linux/nvmem-consumer.h | 76 > 2 files changed, 498 insertions(+), 2 deletions(-) > create mode 100644 include

Re: [PATCH v7 2/9] nvmem: Add a simple NVMEM framework for consumers

2015-07-10 Thread Joe Perches
On Fri, 2015-07-10 at 10:44 +0100, Srinivas Kandagatla wrote: > This patch adds just consumers part of the framework just to enable easy > review. Trivial notes: > diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c > @@ -334,6 +335,7 @@ struct nvmem_device *nvmem_register(struct nvmem_confi

[PATCH v7 2/9] nvmem: Add a simple NVMEM framework for consumers

2015-07-10 Thread Srinivas Kandagatla
This patch adds just consumers part of the framework just to enable easy review. Up until now, nvmem drivers were stored in drivers/misc, where they all had to duplicate pretty much the same code to register a sysfs file, allow in-kernel users to access the content of the devices they were driving