Re: [PATCHv2 3/3] fpga manager: Adding FPGA Manager support for Xilinx Zynq 7000

2015-10-22 Thread Moritz Fischer
Hi Alan, On Thu, Oct 22, 2015 at 10:56 AM, atull wrote: > On Fri, 16 Oct 2015, Moritz Fischer wrote: > > Hi Moritz, > > I just noticed a problem regarding private data. Fortunately > it is easy to fix. See below... > >> +static int zynq_fpga_probe(struct platform_device *pdev) >> +{ >> + st

Re: [PATCHv2 3/3] fpga manager: Adding FPGA Manager support for Xilinx Zynq 7000

2015-10-22 Thread atull
On Fri, 16 Oct 2015, Moritz Fischer wrote: Hi Moritz, I just noticed a problem regarding private data. Fortunately it is easy to fix. See below... > +static int zynq_fpga_probe(struct platform_device *pdev) > +{ > + struct device *dev = &pdev->dev; > + struct zynq_fpga_priv *priv; > +

Re: [PATCHv2 3/3] fpga manager: Adding FPGA Manager support for Xilinx Zynq 7000

2015-10-19 Thread Moritz Fischer
On Sun, Oct 18, 2015 at 11:02 AM, Josh Cartwright wrote: > Hey Moritz- > > On Fri, Oct 16, 2015 at 03:42:30PM -0700, Moritz Fischer wrote: >> This commit adds FPGA Manager support for the Xilinx Zynq chip. >> The code borrows some from the xdevcfg driver in Xilinx' >> vendor tree. >> >> Signed-off

Re: [PATCHv2 3/3] fpga manager: Adding FPGA Manager support for Xilinx Zynq 7000

2015-10-18 Thread Josh Cartwright
Hey Moritz- On Fri, Oct 16, 2015 at 03:42:30PM -0700, Moritz Fischer wrote: > This commit adds FPGA Manager support for the Xilinx Zynq chip. > The code borrows some from the xdevcfg driver in Xilinx' > vendor tree. > > Signed-off-by: Moritz Fischer > --- > > v2: > - Replaced locking error fla

[PATCHv2 3/3] fpga manager: Adding FPGA Manager support for Xilinx Zynq 7000

2015-10-16 Thread Moritz Fischer
This commit adds FPGA Manager support for the Xilinx Zynq chip. The code borrows some from the xdevcfg driver in Xilinx' vendor tree. Signed-off-by: Moritz Fischer --- v2: - Replaced locking error flag and broken completion with irq masking and changed completion handling - Dealing with tim