Re: [PATCHv8] dmaengine: Add support for BCM2835

2013-12-03 Thread Russell King - ARM Linux
On Tue, Dec 03, 2013 at 02:04:18PM +0200, Andy Shevchenko wrote: > On Mon, 2013-12-02 at 20:12 +0100, Florian Meier wrote: > > +static void bcm2835_dma_free(struct bcm2835_dmadev *od) > > +{ > > + while (!list_empty(&od->ddev.channels)) { > > + struct bcm2835_chan *c = list_first_entry(

Re: [PATCHv8] dmaengine: Add support for BCM2835

2013-12-03 Thread Andy Shevchenko
On Mon, 2013-12-02 at 20:12 +0100, Florian Meier wrote: > Add support for DMA controller of BCM2835 as used in the Raspberry Pi. > Currently it only supports cyclic DMA. > Overall looks okay now. Few minors comments below and my Reviewed-by: Andy Shevchenko > Signed-off-by: Florian Meier >

[PATCHv8] dmaengine: Add support for BCM2835

2013-12-02 Thread Florian Meier
Add support for DMA controller of BCM2835 as used in the Raspberry Pi. Currently it only supports cyclic DMA. Signed-off-by: Florian Meier --- This version includes some more style improvements suggested in the previous thread. .../devicetree/bindings/dma/bcm2835-dma.txt| 57 ++ drive