Re: [RFC] cpufreq: Add "dvfs-method" binding to probe cpufreq drivers

2014-12-01 Thread Viresh Kumar
On 28 November 2014 at 17:21, Sudeep Holla wrote: >> - Update those platforms to check if DT has "compatible" string in CPU >> node. >> If yes, don't create a device as this will be created by cpufreq-dt. >> > > This fixes how it will work with new DTs, how about old DTs ? > IMO we still need the

Re: [RFC] cpufreq: Add "dvfs-method" binding to probe cpufreq drivers

2014-11-30 Thread santosh.shilim...@oracle.com
On 11/26/14 9:14 PM, Viresh Kumar wrote: On 26 November 2014 at 22:04, santosh shilimkar wrote: Its really not 'dvfs-method' but really the actual driver which you want to probe. Also we should just have one global way to parse DT vs non-DT cpufreq drivers. In other words, instead of matching

Re: [RFC] cpufreq: Add "dvfs-method" binding to probe cpufreq drivers

2014-11-28 Thread Sudeep Holla
On 28/11/14 06:31, Viresh Kumar wrote: On 27 November 2014 at 16:45, Sudeep Holla wrote: It's the general understanding, I am not sure if it's specified anywhere in the kernel Documentation, but I could find the below excerpts from [1]: "The compatibility rules say that new kernels must work

Re: [RFC] cpufreq: Add "dvfs-method" binding to probe cpufreq drivers

2014-11-27 Thread Viresh Kumar
On 27 November 2014 at 16:45, Sudeep Holla wrote: > It's the general understanding, I am not sure if it's specified anywhere > in the kernel Documentation, but I could find the below excerpts from [1]: > > "The compatibility rules say that new kernels must work with older > device trees. If change

Re: [RFC] cpufreq: Add "dvfs-method" binding to probe cpufreq drivers

2014-11-27 Thread Sudeep Holla
On 27/11/14 10:22, Viresh Kumar wrote: On 27 November 2014 at 15:24, Sudeep Holla wrote: No that won't suffice. You can't modify the DTs of the platforms using cpufreq-dt.c as of today. They should continue to work, so either you retain all the existing platform device creation in platform co

Re: [RFC] cpufreq: Add "dvfs-method" binding to probe cpufreq drivers

2014-11-27 Thread Viresh Kumar
On 27 November 2014 at 15:24, Sudeep Holla wrote: > No that won't suffice. You can't modify the DTs of the platforms using > cpufreq-dt.c as of today. They should continue to work, so either you > retain all the existing platform device creation in platform code as is > or do something like below

Re: [RFC] cpufreq: Add "dvfs-method" binding to probe cpufreq drivers

2014-11-27 Thread Sudeep Holla
Hi, On 27/11/14 05:29, Viresh Kumar wrote: Hi Sudeep, On 26 November 2014 at 22:30, Sudeep Holla wrote: On 26/11/14 08:46, Viresh Kumar wrote: We only need to have one entry in cpus@cpu0 node which will match with drivers name. This seems fundamentally broken as the driver always needs to

Re: [RFC] cpufreq: Add "dvfs-method" binding to probe cpufreq drivers

2014-11-26 Thread Viresh Kumar
Hi Sudeep, On 26 November 2014 at 22:30, Sudeep Holla wrote: > On 26/11/14 08:46, Viresh Kumar wrote: >> We only need to have one entry in cpus@cpu0 node which will match with >> drivers >> name. > This seems fundamentally broken as the driver always needs to > unconditionally refer to cpu0. Fur

Re: [RFC] cpufreq: Add "dvfs-method" binding to probe cpufreq drivers

2014-11-26 Thread Viresh Kumar
On 26 November 2014 at 22:04, santosh shilimkar wrote: > Its really not 'dvfs-method' but really the actual driver which you > want to probe. Also we should just have one global way to parse > DT vs non-DT cpufreq drivers. In other words, instead of matching > multiple driver strings for different

Re: [RFC] cpufreq: Add "dvfs-method" binding to probe cpufreq drivers

2014-11-26 Thread Sudeep Holla
On 26/11/14 17:00, Sudeep Holla wrote: Hi Viresh, [...] diff --git a/Documentation/devicetree/bindings/cpufreq/drivers.txt b/Documentation/devicetree/bindings/cpufreq/drivers.txt new file mode 100644 index 000..bd14917 --- /dev/null +++ b/Documentation/devicetree/bindings/cpufreq/driv

Re: [RFC] cpufreq: Add "dvfs-method" binding to probe cpufreq drivers

2014-11-26 Thread Sudeep Holla
Hi Viresh, On 26/11/14 08:46, Viresh Kumar wrote: DT based cpufreq drivers doesn't require much support from platform code now a days as most of the stuff is moved behind generic APIs. Like clk APIs for changing clock rates, regulator APIs for changing voltages, etc. One of the bottleneck still

Re: [RFC] cpufreq: Add "dvfs-method" binding to probe cpufreq drivers

2014-11-26 Thread santosh shilimkar
On 11/26/2014 12:49 AM, Viresh Kumar wrote: Fixing Santosh's email id as he switched employer .. Yeah I did ;-) On 26 November 2014 at 14:16, Viresh Kumar wrote: DT based cpufreq drivers doesn't require much support from platform code now a days as most of the stuff is moved behind generic

Re: [RFC] cpufreq: Add "dvfs-method" binding to probe cpufreq drivers

2014-11-26 Thread Viresh Kumar
Fixing Santosh's email id as he switched employer .. On 26 November 2014 at 14:16, Viresh Kumar wrote: > DT based cpufreq drivers doesn't require much support from platform code now a > days as most of the stuff is moved behind generic APIs. Like clk APIs for > changing clock rates, regulator API

[RFC] cpufreq: Add "dvfs-method" binding to probe cpufreq drivers

2014-11-26 Thread Viresh Kumar
DT based cpufreq drivers doesn't require much support from platform code now a days as most of the stuff is moved behind generic APIs. Like clk APIs for changing clock rates, regulator APIs for changing voltages, etc. One of the bottleneck still left was how to select which cpufreq driver to probe