Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-21 Thread Grant Likely
On Fri, 21 Mar 2014 14:16:20 +0200, Tomi Valkeinen wrote: > On 21/03/14 13:47, Grant Likely wrote: > > > I'm firm on the opinion that the checking must also happen at runtime. > > The biggest part of my objection has been how easy it would be to get a > > linkage out of sync, and dtc is not nece

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-21 Thread Grant Likely
On Fri, Mar 21, 2014 at 12:44 PM, Laurent Pinchart wrote: > Hi Grant, > > On Friday 21 March 2014 08:15:34 Grant Likely wrote: >> Why don't we instead try a Google Hangout or a phone call today. >> Anywhere between 11:30 and 14:00 GMT would work for me. I'd offer to >> provide the tea, but I haven

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-21 Thread Laurent Pinchart
Hi Grant, On Friday 21 March 2014 08:15:34 Grant Likely wrote: > On Fri, 21 Mar 2014 00:26:12 +0100, Laurent Pinchart wrote: > > On Thursday 20 March 2014 23:12:50 Grant Likely wrote: > > > On Thu, 20 Mar 2014 19:52:53 +0100, Laurent Pinchart wrote: > > > > Then we might not be talking about the s

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-21 Thread Tomi Valkeinen
On 21/03/14 13:47, Grant Likely wrote: > I'm firm on the opinion that the checking must also happen at runtime. > The biggest part of my objection has been how easy it would be to get a > linkage out of sync, and dtc is not necessarily the last tool to touch > the dtb before the kernel gets booted

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-21 Thread Tomi Valkeinen
On 20/03/14 19:01, Grant Likely wrote: > I think depending on a generic graph walk is where I have the biggest > concern about the design. I don't think it is a good idea for the master > device to try a generic walk over the graph looking for other devices > that might be components because it ca

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-21 Thread Grant Likely
On Fri, 21 Mar 2014 11:44:24 +0100, Andrzej Hajda wrote: > On 03/20/2014 06:23 PM, Grant Likely wrote: > > On Tue, 11 Mar 2014 14:16:37 +0100, Laurent Pinchart > > wrote: > >> On Tuesday 11 March 2014 14:59:20 Tomi Valkeinen wrote: > >>> So depending on the use case, the endpoints would point to

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-21 Thread Andrzej Hajda
On 03/20/2014 06:23 PM, Grant Likely wrote: > On Tue, 11 Mar 2014 14:16:37 +0100, Laurent Pinchart > wrote: >> On Tuesday 11 March 2014 14:59:20 Tomi Valkeinen wrote: >>> So depending on the use case, the endpoints would point to opposite >>> direction from the encoder's point of view. >>> >>> An

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-21 Thread Tomi Valkeinen
On 20/03/14 20:49, Laurent Pinchart wrote: >> The CPU is the _controlling_ component - it's the component that has to >> configure the peripherals so they all talk to each other in the right >> way. Therefore, the view of it needs to be CPU centric. >> >> If we were providing a DT description for

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-21 Thread Grant Likely
On Fri, 21 Mar 2014 00:26:12 +0100, Laurent Pinchart wrote: > On Thursday 20 March 2014 23:12:50 Grant Likely wrote: > > On Thu, 20 Mar 2014 19:52:53 +0100, Laurent Pinchart wrote: > > > Then we might not be talking about the same thing. I'm talking about DT > > > bindings to represent the topolo

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-20 Thread Laurent Pinchart
Hi Grant, On Thursday 20 March 2014 23:12:50 Grant Likely wrote: > On Thu, 20 Mar 2014 19:52:53 +0100, Laurent Pinchart wrote: > > On Thursday 20 March 2014 18:48:16 Grant Likely wrote: > > > On Thu, 20 Mar 2014 15:38:04 -0300, Mauro Carvalho Chehab wrote: > > > > Em Thu, 20 Mar 2014 17:54:31 +000

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-20 Thread Grant Likely
On Thu, 20 Mar 2014 19:52:53 +0100, Laurent Pinchart wrote: > On Thursday 20 March 2014 18:48:16 Grant Likely wrote: > > On Thu, 20 Mar 2014 15:38:04 -0300, Mauro Carvalho Chehab wrote: > > > Em Thu, 20 Mar 2014 17:54:31 + Grant Likely escreveu: > > > > On Wed, 12 Mar 2014 10:25:56 +, Rus

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-20 Thread Laurent Pinchart
Hi Russell, On Thursday 20 March 2014 18:18:20 Russell King - ARM Linux wrote: > On Thu, Mar 20, 2014 at 07:16:29PM +0100, Laurent Pinchart wrote: > > On Thursday 20 March 2014 17:54:31 Grant Likely wrote: > > > On Wed, 12 Mar 2014 10:25:56 +, Russell King - ARM Linux wrote: > > > > On Mon, Ma

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-20 Thread Laurent Pinchart
On Thursday 20 March 2014 18:48:16 Grant Likely wrote: > On Thu, 20 Mar 2014 15:38:04 -0300, Mauro Carvalho Chehab wrote: > > Em Thu, 20 Mar 2014 17:54:31 + Grant Likely escreveu: > > > On Wed, 12 Mar 2014 10:25:56 +, Russell King - ARM Linux wrote: > > > > On Mon, Mar 10, 2014 at 02:52:53P

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-20 Thread Grant Likely
On Thu, 20 Mar 2014 15:38:04 -0300, Mauro Carvalho Chehab wrote: > Em Thu, 20 Mar 2014 17:54:31 + > Grant Likely escreveu: > > > On Wed, 12 Mar 2014 10:25:56 +, Russell King - ARM Linux > > wrote: > > > On Mon, Mar 10, 2014 at 02:52:53PM +0100, Laurent Pinchart wrote: > > > > In theor

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-20 Thread Laurent Pinchart
Hi Russell, On Thursday 20 March 2014 18:18:20 Russell King - ARM Linux wrote: > On Thu, Mar 20, 2014 at 07:16:29PM +0100, Laurent Pinchart wrote: > > On Thursday 20 March 2014 17:54:31 Grant Likely wrote: > > > On Wed, 12 Mar 2014 10:25:56 +, Russell King - ARM Linux wrote: [snip] > > > > I

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-20 Thread Laurent Pinchart
On Thursday 20 March 2014 18:43:16 Russell King - ARM Linux wrote: > On Thu, Mar 20, 2014 at 03:38:04PM -0300, Mauro Carvalho Chehab wrote: > > Em Thu, 20 Mar 2014 17:54:31 + Grant Likely escreveu: > > > On Wed, 12 Mar 2014 10:25:56 +, Russell King - ARM Linux wrote: > > > > On Mon, Mar 10,

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-20 Thread Russell King - ARM Linux
On Thu, Mar 20, 2014 at 03:38:04PM -0300, Mauro Carvalho Chehab wrote: > Em Thu, 20 Mar 2014 17:54:31 + > Grant Likely escreveu: > > > On Wed, 12 Mar 2014 10:25:56 +, Russell King - ARM Linux > > wrote: > > > On Mon, Mar 10, 2014 at 02:52:53PM +0100, Laurent Pinchart wrote: > > > > In t

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-20 Thread Mauro Carvalho Chehab
Em Thu, 20 Mar 2014 17:54:31 + Grant Likely escreveu: > On Wed, 12 Mar 2014 10:25:56 +, Russell King - ARM Linux > wrote: > > On Mon, Mar 10, 2014 at 02:52:53PM +0100, Laurent Pinchart wrote: > > > In theory unidirectional links in DT are indeed enough. However, let's > > > not > > >

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-20 Thread Russell King - ARM Linux
On Thu, Mar 20, 2014 at 07:16:29PM +0100, Laurent Pinchart wrote: > On Thursday 20 March 2014 17:54:31 Grant Likely wrote: > > On Wed, 12 Mar 2014 10:25:56 +, Russell King - ARM Linux wrote: > > > On Mon, Mar 10, 2014 at 02:52:53PM +0100, Laurent Pinchart wrote: > > > > In theory unidirectional

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-20 Thread Laurent Pinchart
On Thursday 20 March 2014 17:54:31 Grant Likely wrote: > On Wed, 12 Mar 2014 10:25:56 +, Russell King - ARM Linux wrote: > > On Mon, Mar 10, 2014 at 02:52:53PM +0100, Laurent Pinchart wrote: > > > In theory unidirectional links in DT are indeed enough. However, let's > > > not forget the follow

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-20 Thread Grant Likely
On Wed, 12 Mar 2014 10:25:56 +, Russell King - ARM Linux wrote: > On Mon, Mar 10, 2014 at 02:52:53PM +0100, Laurent Pinchart wrote: > > In theory unidirectional links in DT are indeed enough. However, let's not > > forget the following. > > > > - There's no such thing as single start points

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-20 Thread Grant Likely
On Tue, 11 Mar 2014 16:21:49 +0100, Laurent Pinchart wrote: > Hi Philipp, > > On Tuesday 11 March 2014 16:07:00 Philipp Zabel wrote: > > Am Montag, den 10.03.2014, 14:58 + schrieb Grant Likely: > > > On Mon, 10 Mar 2014 14:52:53 +0100, Laurent Pinchart wrote: > > [snip] > > > > > In theory

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-20 Thread Grant Likely
On Tue, 11 Mar 2014 16:07:00 +0100, Philipp Zabel wrote: > Hi Grant, > > Am Montag, den 10.03.2014, 14:58 + schrieb Grant Likely: > > On Mon, 10 Mar 2014 14:52:53 +0100, Laurent Pinchart > > wrote: > > > On Monday 10 March 2014 12:18:20 Tomi Valkeinen wrote: > > > > On 08/03/14 13:41, Gran

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-20 Thread Grant Likely
On Tue, 11 Mar 2014 14:04:34 +0100, Andrzej Hajda wrote: > On 03/10/2014 04:15 PM, Laurent Pinchart wrote: > > Hi Grant, > > > > On Monday 10 March 2014 14:58:15 Grant Likely wrote: > >> On Mon, 10 Mar 2014 14:52:53 +0100, Laurent Pinchart wrote: > >>> On Monday 10 March 2014 12:18:20 Tomi Valkei

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-20 Thread Grant Likely
On Tue, 11 Mar 2014 14:16:37 +0100, Laurent Pinchart wrote: > On Tuesday 11 March 2014 14:59:20 Tomi Valkeinen wrote: > > So depending on the use case, the endpoints would point to opposite > > direction from the encoder's point of view. > > > > And if I gathered Grant's opinion correctly (corre

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-20 Thread Grant Likely
On Tue, 11 Mar 2014 12:43:44 +0100, Laurent Pinchart wrote: > Hi Philipp, > > On Monday 10 March 2014 16:40:30 Philipp Zabel wrote: > > Am Montag, den 10.03.2014, 16:15 +0100 schrieb Laurent Pinchart: > > > On Monday 10 March 2014 14:58:15 Grant Likely wrote: > > > > On Mon, 10 Mar 2014 14:52:53

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-20 Thread Grant Likely
On Mon, 10 Mar 2014 16:15:37 +0100, Laurent Pinchart wrote: > Hi Grant, > > On Monday 10 March 2014 14:58:15 Grant Likely wrote: > > On Mon, 10 Mar 2014 14:52:53 +0100, Laurent Pinchart wrote: > > > On Monday 10 March 2014 12:18:20 Tomi Valkeinen wrote: > > > > On 08/03/14 13:41, Grant Likely wr

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-12 Thread Laurent Pinchart
Hi Russell and Tomi, On Wednesday 12 March 2014 12:47:09 Tomi Valkeinen wrote: > On 12/03/14 12:25, Russell King - ARM Linux wrote: > > On Mon, Mar 10, 2014 at 02:52:53PM +0100, Laurent Pinchart wrote: > >> In theory unidirectional links in DT are indeed enough. However, let's > >> not forget the

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-12 Thread Tomi Valkeinen
On 12/03/14 12:25, Russell King - ARM Linux wrote: > On Mon, Mar 10, 2014 at 02:52:53PM +0100, Laurent Pinchart wrote: >> In theory unidirectional links in DT are indeed enough. However, let's not >> forget the following. >> >> - There's no such thing as single start points for graphs. Sure, in so

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-12 Thread Russell King - ARM Linux
On Mon, Mar 10, 2014 at 02:52:53PM +0100, Laurent Pinchart wrote: > In theory unidirectional links in DT are indeed enough. However, let's not > forget the following. > > - There's no such thing as single start points for graphs. Sure, in some > simple cases the graph will have a single start po

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-11 Thread Philipp Zabel
Hi Laurent, Am Dienstag, den 11.03.2014, 16:21 +0100 schrieb Laurent Pinchart: > Hi Philipp, > > On Tuesday 11 March 2014 16:07:00 Philipp Zabel wrote: > > Am Montag, den 10.03.2014, 14:58 + schrieb Grant Likely: > > > On Mon, 10 Mar 2014 14:52:53 +0100, Laurent Pinchart wrote: > > [snip] >

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-11 Thread Laurent Pinchart
Hi Philipp, On Tuesday 11 March 2014 16:07:00 Philipp Zabel wrote: > Am Montag, den 10.03.2014, 14:58 + schrieb Grant Likely: > > On Mon, 10 Mar 2014 14:52:53 +0100, Laurent Pinchart wrote: [snip] > > > In theory unidirectional links in DT are indeed enough. However, let's > > > not forget t

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-11 Thread Philipp Zabel
Hi Grant, Am Montag, den 10.03.2014, 14:58 + schrieb Grant Likely: > On Mon, 10 Mar 2014 14:52:53 +0100, Laurent Pinchart > wrote: > > On Monday 10 March 2014 12:18:20 Tomi Valkeinen wrote: > > > On 08/03/14 13:41, Grant Likely wrote: > > > >> Ok. If we go for single directional link, the qu

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-11 Thread Philipp Zabel
Hi, Am Dienstag, den 11.03.2014, 15:27 +0200 schrieb Tomi Valkeinen: > On 11/03/14 15:16, Laurent Pinchart wrote: > > >> And if I gathered Grant's opinion correctly (correct me if I'm wrong), > >> he thinks things should be explicit, i.e. the bindings for, say, an > >> encoder should state that t

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-11 Thread Tomi Valkeinen
On 11/03/14 15:16, Laurent Pinchart wrote: >> And if I gathered Grant's opinion correctly (correct me if I'm wrong), >> he thinks things should be explicit, i.e. the bindings for, say, an >> encoder should state that the encoder's output endpoint _must_ contain a >> remote-endpoint property, where

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-11 Thread Laurent Pinchart
Hi Tomi, On Tuesday 11 March 2014 14:59:20 Tomi Valkeinen wrote: > On 11/03/14 13:43, Laurent Pinchart wrote: > >> We could scan the whole tree for entities, ports and endpoints once, in > >> the base oftree code, and put that into a graph structure, adding the > >> backlinks. The of_graph_* helpe

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-11 Thread Andrzej Hajda
On 03/10/2014 04:15 PM, Laurent Pinchart wrote: > Hi Grant, > > On Monday 10 March 2014 14:58:15 Grant Likely wrote: >> On Mon, 10 Mar 2014 14:52:53 +0100, Laurent Pinchart wrote: >>> On Monday 10 March 2014 12:18:20 Tomi Valkeinen wrote: On 08/03/14 13:41, Grant Likely wrote: >> Ok. If w

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-11 Thread Tomi Valkeinen
On 11/03/14 13:43, Laurent Pinchart wrote: >> We could scan the whole tree for entities, ports and endpoints once, in >> the base oftree code, and put that into a graph structure, adding the >> backlinks. >> The of_graph_* helpers could then use that graph instead of the device >> tree. > > That

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-11 Thread Laurent Pinchart
Hi Philipp, On Monday 10 March 2014 16:40:30 Philipp Zabel wrote: > Am Montag, den 10.03.2014, 16:15 +0100 schrieb Laurent Pinchart: > > On Monday 10 March 2014 14:58:15 Grant Likely wrote: > > > On Mon, 10 Mar 2014 14:52:53 +0100, Laurent Pinchart wrote: > > > > On Monday 10 March 2014 12:18:20 T

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-10 Thread Philipp Zabel
Am Montag, den 10.03.2014, 16:15 +0100 schrieb Laurent Pinchart: > Hi Grant, > > On Monday 10 March 2014 14:58:15 Grant Likely wrote: > > On Mon, 10 Mar 2014 14:52:53 +0100, Laurent Pinchart wrote: > > > On Monday 10 March 2014 12:18:20 Tomi Valkeinen wrote: > > > > On 08/03/14 13:41, Grant Likely

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-10 Thread Laurent Pinchart
Hi Grant, On Monday 10 March 2014 14:58:15 Grant Likely wrote: > On Mon, 10 Mar 2014 14:52:53 +0100, Laurent Pinchart wrote: > > On Monday 10 March 2014 12:18:20 Tomi Valkeinen wrote: > > > On 08/03/14 13:41, Grant Likely wrote: > > > >> Ok. If we go for single directional link, the question is th

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-10 Thread Grant Likely
On Mon, 10 Mar 2014 14:52:53 +0100, Laurent Pinchart wrote: > On Monday 10 March 2014 12:18:20 Tomi Valkeinen wrote: > > On 08/03/14 13:41, Grant Likely wrote: > > >> Ok. If we go for single directional link, the question is then: which > > >> way? And is the direction different for display and c

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-10 Thread Grant Likely
On Mon, 10 Mar 2014 12:18:20 +0200, Tomi Valkeinen wrote: > On 08/03/14 13:41, Grant Likely wrote: > > >> Ok. If we go for single directional link, the question is then: which > >> way? And is the direction different for display and camera, which are > >> kind of reflections of each other? > >

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-10 Thread Tomi Valkeinen
On 10/03/14 15:52, Laurent Pinchart wrote: > In theory unidirectional links in DT are indeed enough. However, let's not > forget the following. > > - There's no such thing as single start points for graphs. Sure, in some > simple cases the graph will have a single start point, but that's not a

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-10 Thread Laurent Pinchart
On Monday 10 March 2014 12:18:20 Tomi Valkeinen wrote: > On 08/03/14 13:41, Grant Likely wrote: > >> Ok. If we go for single directional link, the question is then: which > >> way? And is the direction different for display and camera, which are > >> kind of reflections of each other? > > > > In g

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-10 Thread Tomi Valkeinen
On 08/03/14 13:41, Grant Likely wrote: >> Ok. If we go for single directional link, the question is then: which >> way? And is the direction different for display and camera, which are >> kind of reflections of each other? > > In general I would recommend choosing whichever device you would > sen

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-08 Thread Sylwester Nawrocki
On 03/08/2014 12:41 PM, Grant Likely wrote: Another thought. In terms of the pattern, I would add a recommendation > > that there should be a way to identify ports of a particular type. ie. > > If I were using the pattern to implement an patch bay of DSP filters, > > where each input and ou

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-08 Thread Russell King - ARM Linux
On Sat, Mar 08, 2014 at 01:05:50AM +0800, Grant Likely wrote: > On Wed, 26 Feb 2014 15:48:49 +0100, Philipp Zabel > wrote: > > Or two separate display controllers with two parallel outputs each, a > > 4-port multiplexer, and an encoder (e.g. lvds): > > > > ,--. > > | disp

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-08 Thread Grant Likely
On Sat, 8 Mar 2014 12:33:12 +0200, Tomi Valkeinen wrote: > On 07/03/14 19:05, Grant Likely wrote: > > On Wed, 26 Feb 2014 15:48:49 +0100, Philipp Zabel > > wrote: > >> Hi Grant, > >> > >> thank you for the comments. > > > > Hi Philipp, > > > > I've got lots of comments and quesitons below, but

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-08 Thread Tomi Valkeinen
On 07/03/14 19:06, Grant Likely wrote: > On Thu, 27 Feb 2014 10:36:36 +0200, Tomi Valkeinen > wrote: >> On 26/02/14 16:48, Philipp Zabel wrote: >> I would like the document to acknowledge the difference from the phandle+args pattern used elsewhere and a description of when it would

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-08 Thread Tomi Valkeinen
On 07/03/14 19:05, Grant Likely wrote: > On Wed, 26 Feb 2014 15:48:49 +0100, Philipp Zabel > wrote: >> Hi Grant, >> >> thank you for the comments. > > Hi Philipp, > > I've got lots of comments and quesitons below, but I must say thank you > for doing this. It is a helpful description. Thanks f

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-07 Thread Grant Likely
On Thu, 27 Feb 2014 10:36:36 +0200, Tomi Valkeinen wrote: > On 26/02/14 16:48, Philipp Zabel wrote: > > >> I would like the document to acknowledge the difference from the > >> phandle+args pattern used elsewhere and a description of when it would > >> be appropriate to use this instead of a sim

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-07 Thread Grant Likely
On Wed, 26 Feb 2014 15:48:49 +0100, Philipp Zabel wrote: > Hi Grant, > > thank you for the comments. Hi Philipp, I've got lots of comments and quesitons below, but I must say thank you for doing this. It is a helpful description. > > Am Mittwoch, den 26.02.2014, 11:01 + schrieb Grant Lik

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-02-27 Thread Tomi Valkeinen
On 26/02/14 16:48, Philipp Zabel wrote: >> I would like the document to acknowledge the difference from the >> phandle+args pattern used elsewhere and a description of when it would >> be appropriate to use this instead of a simpler binding. > > Alright. The main point of this binding is that the

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-02-26 Thread Philipp Zabel
Hi Grant, thank you for the comments. Am Mittwoch, den 26.02.2014, 11:01 + schrieb Grant Likely: > On Mon, 24 Feb 2014 18:36:29 +0100, Philipp Zabel > wrote: > > Am Dienstag, den 18.02.2014, 16:26 + schrieb Grant Likely: > > > > > > > > You can find it under > > > > Documentation/devi

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-02-26 Thread Grant Likely
On Mon, 24 Feb 2014 18:36:29 +0100, Philipp Zabel wrote: > Am Dienstag, den 18.02.2014, 16:26 + schrieb Grant Likely: > > > > > > You can find it under > > > Documentation/devicetree/bindings/media/video-interfaces.txt > > > > Okay, I think I'm okay with moving the helpers, but I will make

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-02-24 Thread Philipp Zabel
Am Dienstag, den 18.02.2014, 16:26 + schrieb Grant Likely: > On Tue, 18 Feb 2014 08:06:24 +0100, Sascha Hauer > wrote: > > Hi Grant, > > > > On Mon, Feb 17, 2014 at 06:14:51PM +, Grant Likely wrote: > > > On Tue, 11 Feb 2014 07:56:33 -0600, Rob Herring > > > wrote: > > > > On Tue, Feb

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-02-18 Thread Grant Likely
On Tue, 18 Feb 2014 08:06:24 +0100, Sascha Hauer wrote: > Hi Grant, > > On Mon, Feb 17, 2014 at 06:14:51PM +, Grant Likely wrote: > > On Tue, 11 Feb 2014 07:56:33 -0600, Rob Herring > > wrote: > > > On Tue, Feb 11, 2014 at 5:45 AM, Philipp Zabel > > > wrote: > > > > From: Philipp Zabel >

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-02-18 Thread Philipp Zabel
Hi Grant, Am Montag, den 17.02.2014, 18:14 + schrieb Grant Likely: > On Tue, 11 Feb 2014 07:56:33 -0600, Rob Herring wrote: > > On Tue, Feb 11, 2014 at 5:45 AM, Philipp Zabel > > wrote: > > > From: Philipp Zabel > > > > > > This patch moves the parsing helpers used to parse connected graph

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-02-18 Thread Sylwester Nawrocki
On 17/02/14 19:14, Grant Likely wrote: > On Tue, 11 Feb 2014 07:56:33 -0600, Rob Herring wrote: >> > On Tue, Feb 11, 2014 at 5:45 AM, Philipp Zabel >> > wrote: >>> > > From: Philipp Zabel >>> > > >>> > > This patch moves the parsing helpers used to parse connected graphs >>> > > in the device t

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-02-17 Thread Sascha Hauer
Hi Grant, On Mon, Feb 17, 2014 at 06:14:51PM +, Grant Likely wrote: > On Tue, 11 Feb 2014 07:56:33 -0600, Rob Herring wrote: > > On Tue, Feb 11, 2014 at 5:45 AM, Philipp Zabel > > wrote: > > > From: Philipp Zabel > > > > > > This patch moves the parsing helpers used to parse connected grap

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-02-17 Thread Grant Likely
On Tue, 11 Feb 2014 07:56:33 -0600, Rob Herring wrote: > On Tue, Feb 11, 2014 at 5:45 AM, Philipp Zabel wrote: > > From: Philipp Zabel > > > > This patch moves the parsing helpers used to parse connected graphs > > in the device tree, like the video interface bindings documented in > > Documenta

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-02-11 Thread Philipp Zabel
Hi Sylwester, On Tue, Feb 11, 2014 at 06:22:34PM +0100, Sylwester Nawrocki wrote: > drivers/media sounds like a good alternative to me. > > I would just remove also v4l2_of_{parse/get}* and update the users > to call of_graph_* directly, there should not be many of them. For now I'd like to skip

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-02-11 Thread Guennadi Liakhovetski
On Wed, 12 Feb 2014, Mauro Carvalho Chehab wrote: > Em Tue, 11 Feb 2014 18:22:34 +0100 > Sylwester Nawrocki escreveu: > > > (adding Guennadi to Cc) > > > > On 11/02/14 17:36, Philipp Zabel wrote: > > > Am Dienstag, den 11.02.2014, 16:23 +0100 schrieb Laurent Pinchart: > > >> Hi Russell, > > >>

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-02-11 Thread Mauro Carvalho Chehab
Em Tue, 11 Feb 2014 18:22:34 +0100 Sylwester Nawrocki escreveu: > (adding Guennadi to Cc) > > On 11/02/14 17:36, Philipp Zabel wrote: > > Am Dienstag, den 11.02.2014, 16:23 +0100 schrieb Laurent Pinchart: > >> Hi Russell, > >> > >> On Tuesday 11 February 2014 14:52:48 Russell King - ARM Linux wr

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-02-11 Thread Laurent Pinchart
Hi Philipp, On Tuesday 11 February 2014 17:36:57 Philipp Zabel wrote: > Am Dienstag, den 11.02.2014, 16:23 +0100 schrieb Laurent Pinchart: > > On Tuesday 11 February 2014 14:52:48 Russell King - ARM Linux wrote: > > > On Tue, Feb 11, 2014 at 07:56:33AM -0600, Rob Herring wrote: > > > > On Tue, Feb

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-02-11 Thread Sylwester Nawrocki
(adding Guennadi to Cc) On 11/02/14 17:36, Philipp Zabel wrote: > Am Dienstag, den 11.02.2014, 16:23 +0100 schrieb Laurent Pinchart: >> Hi Russell, >> >> On Tuesday 11 February 2014 14:52:48 Russell King - ARM Linux wrote: >>> On Tue, Feb 11, 2014 at 07:56:33AM -0600, Rob Herring wrote: On Tu

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-02-11 Thread Philipp Zabel
Am Dienstag, den 11.02.2014, 16:23 +0100 schrieb Laurent Pinchart: > Hi Russell, > > On Tuesday 11 February 2014 14:52:48 Russell King - ARM Linux wrote: > > On Tue, Feb 11, 2014 at 07:56:33AM -0600, Rob Herring wrote: > > > On Tue, Feb 11, 2014 at 5:45 AM, Philipp Zabel wrote: > > > > This allows

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-02-11 Thread Rob Herring
On Tue, Feb 11, 2014 at 8:52 AM, Russell King - ARM Linux wrote: > On Tue, Feb 11, 2014 at 07:56:33AM -0600, Rob Herring wrote: >> On Tue, Feb 11, 2014 at 5:45 AM, Philipp Zabel >> wrote: >> > This allows to reuse the same parser code from outside the V4L2 framework, >> > most importantly from d

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-02-11 Thread Philipp Zabel
Hi Rob, Am Dienstag, den 11.02.2014, 07:56 -0600 schrieb Rob Herring: > On Tue, Feb 11, 2014 at 5:45 AM, Philipp Zabel wrote: > > From: Philipp Zabel > > > > This patch moves the parsing helpers used to parse connected graphs > > in the device tree, like the video interface bindings documented i

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-02-11 Thread Laurent Pinchart
Hi Russell, On Tuesday 11 February 2014 14:52:48 Russell King - ARM Linux wrote: > On Tue, Feb 11, 2014 at 07:56:33AM -0600, Rob Herring wrote: > > On Tue, Feb 11, 2014 at 5:45 AM, Philipp Zabel wrote: > > > This allows to reuse the same parser code from outside the V4L2 > > > framework, most impo

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-02-11 Thread Russell King - ARM Linux
On Tue, Feb 11, 2014 at 07:56:33AM -0600, Rob Herring wrote: > On Tue, Feb 11, 2014 at 5:45 AM, Philipp Zabel wrote: > > This allows to reuse the same parser code from outside the V4L2 framework, > > most importantly from display drivers. There have been patches that > > duplicate > > the code (a

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-02-11 Thread Rob Herring
On Tue, Feb 11, 2014 at 5:45 AM, Philipp Zabel wrote: > From: Philipp Zabel > > This patch moves the parsing helpers used to parse connected graphs > in the device tree, like the video interface bindings documented in > Documentation/devicetree/bindings/media/video-interfaces.txt, from > drivers/

[RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-02-11 Thread Philipp Zabel
From: Philipp Zabel This patch moves the parsing helpers used to parse connected graphs in the device tree, like the video interface bindings documented in Documentation/devicetree/bindings/media/video-interfaces.txt, from drivers/media/v4l2-core to drivers/of. This allows to reuse the same pars