Re: [dm-devel] [dm-6.4 PATCH v2 3/9] dm bufio: improve concurrent IO performance

2023-03-24 Thread Mike Snitzer
On Fri, Mar 24 2023 at 7:11P -0400, Jens Axboe wrote: > On 3/24/23 4:53?PM, Mike Snitzer wrote: > > On Fri, Mar 24 2023 at 3:34P -0400, > > Jens Axboe wrote: > > > >> Just some random drive-by comments. > >> > >>> diff --git a/drivers/md/dm-bufio.c b/drivers/md/dm-bufio.c > >>> index 1de1bdcd

Re: [dm-devel] [PATCH v2] dm-crypt: reexport sysfs of kcryptd workqueue

2023-03-24 Thread yangerkun
Ping... 在 2023/3/1 11:29, yangerkun 写道: From: yangerkun Once there is a heavy IO load, so many encrypt/decrypt work will occupy all of the cpu, which may lead the poor performance for other service. So the idea like 'a2b8b2d97567 ("dm crypt: export sysfs of kcryptd workqueue")' said seems nece

Re: [dm-devel] [dm-6.4 PATCH v2 3/9] dm bufio: improve concurrent IO performance

2023-03-24 Thread Jens Axboe
On 3/24/23 4:53?PM, Mike Snitzer wrote: > On Fri, Mar 24 2023 at 3:34P -0400, > Jens Axboe wrote: > >> Just some random drive-by comments. >> >>> diff --git a/drivers/md/dm-bufio.c b/drivers/md/dm-bufio.c >>> index 1de1bdcda1ce..a58f8ac3ba75 100644 >>> --- a/drivers/md/dm-bufio.c >>> +++ b/drive

Re: [dm-devel] [dm-6.4 PATCH v2 3/9] dm bufio: improve concurrent IO performance

2023-03-24 Thread Mike Snitzer
On Fri, Mar 24 2023 at 3:34P -0400, Jens Axboe wrote: > Just some random drive-by comments. > > > diff --git a/drivers/md/dm-bufio.c b/drivers/md/dm-bufio.c > > index 1de1bdcda1ce..a58f8ac3ba75 100644 > > --- a/drivers/md/dm-bufio.c > > +++ b/drivers/md/dm-bufio.c > > +static void lru_destroy(s

Re: [dm-devel] [git pull] device mapper fixes for 6.3-rc4

2023-03-24 Thread pr-tracker-bot
The pull request you sent on Fri, 24 Mar 2023 13:21:42 -0400: > git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git > tags/for-6.3/dm-fixes has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/5ad4fe9613cb8c202150f5cce5347fc8926c6c01 Thank you! -- De

Re: [dm-devel] [PATCH v5 03/18] scsi: Rename sd_pr_command

2023-03-24 Thread Bart Van Assche
On 3/24/23 11:17, Mike Christie wrote: Rename sd_pr_command to sd_pr_out_command to match a sd_pr_in_command helper added in the next patches. Reviewed-by: Bart Van Assche -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH v5 02/18] block: Rename BLK_STS_NEXUS to BLK_STS_RESV_CONFLICT

2023-03-24 Thread Bart Van Assche
On 3/24/23 11:17, Mike Christie wrote: BLK_STS_NEXUS is used for NVMe/SCSI reservation conflicts and DASD's locking feature which works similar to NVMe/SCSI reservations where a host can get a lock on a device and when the lock is taken it will get failures. This patch renames BLK_STS_NEXUS so i

Re: [dm-devel] [PATCH v5 01/18] block: Add PR callouts for read keys and reservation

2023-03-24 Thread Bart Van Assche
On 3/24/23 11:17, Mike Christie wrote: Add callouts for reading keys and reservations. This allows LIO to support the READ_KEYS and READ_RESERVATION commands and will allow dm-multipath to optimize it's error handling so it can check if it's getting an error because there's an existing reservatio

Re: [dm-devel] [dm-6.4 PATCH v2 3/9] dm bufio: improve concurrent IO performance

2023-03-24 Thread Jens Axboe
Just some random drive-by comments. > diff --git a/drivers/md/dm-bufio.c b/drivers/md/dm-bufio.c > index 1de1bdcda1ce..a58f8ac3ba75 100644 > --- a/drivers/md/dm-bufio.c > +++ b/drivers/md/dm-bufio.c > +static void lru_destroy(struct lru *lru) > +{ > + BUG_ON(lru->cursor); > + BUG_ON(!list_

Re: [dm-devel] [PATCH v5 04/18] scsi: Move sd_pr_type to header to share

2023-03-24 Thread Bart Van Assche
On 3/24/23 11:17, Mike Christie wrote: diff --git a/include/scsi/scsi_block_pr.h b/include/scsi/scsi_block_pr.h new file mode 100644 index ..44766d7a81d8 --- /dev/null +++ b/include/scsi/scsi_block_pr.h @@ -0,0 +1,36 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef _SCSI_BLOCK_PR_H

[dm-devel] [dm-6.4 PATCH v2 8/9] dm: split discards further if target sets max_discard_granularity

2023-03-24 Thread Mike Snitzer
The block core (bio_split_discard) will already split discards based on the 'discard_granularity' and 'max_discard_sectors' queue_limits. But the DM thin target also needs to ensure that it doesn't receive a discard that spans a 'max_discard_sectors' boundary. Introduce a dm_target 'max_discard_gr

[dm-devel] [dm-6.4 PATCH v2 9/9] dm bio prison v1: improve concurrent IO performance

2023-03-24 Thread Mike Snitzer
From: Joe Thornber Split the bio prison into multiple regions, with a separate rbtree and associated lock for each region. To get fast bio prison locking and not damage the performance of discards too much the bio-prison now stipulates that discards should not cross a BIO_PRISON_MAX_RANGE bounda

[dm-devel] [dm-6.4 PATCH v2 0/9] dm bufio, thin: improve concurrent IO performance

2023-03-24 Thread Mike Snitzer
Hi, This patchset has been staged in linux-next for the 6.4 merge window. The relevant linux-dm.git branch is here: https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/log/?h=dm-6.4 The initial patchset I posted earlier in the week for this line of work didn't properly spli

[dm-devel] [dm-6.4 PATCH v2 4/9] dm bufio: move dm_bufio_client members to avoid spanning cachelines

2023-03-24 Thread Mike Snitzer
Movement also consolidates holes in dm_bufio_client struct. But the overall size of the struct isn't changed. Signed-off-by: Mike Snitzer --- drivers/md/dm-bufio.c | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/drivers/md/dm-bufio.c b/drivers/md/dm

[dm-devel] [dm-6.4 PATCH v2 5/9] dm bufio: use waitqueue_active in __free_buffer_wake

2023-03-24 Thread Mike Snitzer
From: Mikulas Patocka Save one spinlock by using waitqueue_active. We hold the bufio lock at this place, so no one can add entries to the waitqueue at this point. Signed-off-by: Mikulas Patocka Signed-off-by: Mike Snitzer --- drivers/md/dm-bufio.c | 7 ++- 1 file changed, 6 insertions(+),

[dm-devel] [dm-6.4 PATCH v2 3/9] dm bufio: improve concurrent IO performance

2023-03-24 Thread Mike Snitzer
From: Joe Thornber When multiple threads perform IO to a thin device, the underlying dm_bufio object can become a bottleneck; slowing down access to btree nodes that store the thin metadata. Prior to this commit, each bufio instance had a single mutex that was taken for every bufio operation. Th

[dm-devel] [dm-6.4 PATCH v2 7/9] dm thin: speed up cell_defer_no_holder()

2023-03-24 Thread Mike Snitzer
From: Joe Thornber Reduce the time that a spinlock is held in cell_defer_no_holder(). Signed-off-by: Joe Thornber Signed-off-by: Mike Snitzer --- drivers/md/dm-thin.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/md/dm-thin.c b/drivers/md/dm-thin.c

[dm-devel] [dm-6.4 PATCH v2 6/9] dm bufio: use multi-page bio vector

2023-03-24 Thread Mike Snitzer
From: Mikulas Patocka The kernel supports multi page bio vector entries, so we can use them in dm-bufio as an optimization. Signed-off-by: Mikulas Patocka Signed-off-by: Mike Snitzer --- drivers/md/dm-bufio.c | 24 1 file changed, 4 insertions(+), 20 deletions(-) dif

[dm-devel] [dm-6.4 PATCH v2 1/9] dm bufio: remove unused dm_bufio_release_move interface

2023-03-24 Thread Mike Snitzer
From: Joe Thornber Was used by multi-snapshot DM target that never went upstream. Signed-off-by: Joe Thornber Acked-by: Mikulas Patocka Signed-off-by: Mike Snitzer --- drivers/md/dm-bufio.c| 77 include/linux/dm-bufio.h | 6 2 files changed,

[dm-devel] [dm-6.4 PATCH v2 2/9] dm bufio: move dm_buffer struct

2023-03-24 Thread Mike Snitzer
Movement prepares for finer grained dm_buffer changes, in the next commit, to be more easily seen. Signed-off-by: Mike Snitzer --- drivers/md/dm-bufio.c | 97 ++- 1 file changed, 50 insertions(+), 47 deletions(-) diff --git a/drivers/md/dm-bufio.c b/drive

[dm-devel] [git pull] device mapper fixes for 6.3-rc4

2023-03-24 Thread Mike Snitzer
Hi Linus, The following changes since commit d695e44157c8da8d298295d1905428fb2495bc8b: dm: remove unnecessary (void*) conversion in event_callback() (2023-02-20 11:52:49 -0500) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git

Re: [dm-devel] [PATCH] libmultipathd Avoid parsing errors due to unsupported designators

2023-03-24 Thread Benjamin Marzinski
On Thu, Mar 23, 2023 at 08:23:24PM +, Martin Wilck wrote: > On Mon, 2023-03-20 at 12:22 -0700, Brian Bunker wrote: > > Unsupported designators, even if they are correct, will result > > in parsing errors. Add support for these two: > > > > Logical Unit Group (0x6) > > Vendor Specific (0x0) > >