Re: [PATCH 2/5] drm: merge device setup into drm_dev_register()

2013-10-03 Thread Daniel Vetter
On Thu, Oct 3, 2013 at 3:19 PM, David Herrmann wrote: > You mean I should _move_ it to drm_pci.c? It has never been > pci-specific. But sure, I can do that. It actually makes sense. But > I'd like to do that in a followup patch as it's a semantic change > that's not directly related. I will includ

Re: [PATCH 2/5] drm: merge device setup into drm_dev_register()

2013-10-03 Thread David Herrmann
Hi Daniel On Thu, Oct 3, 2013 at 3:15 PM, Daniel Vetter wrote: > On Wed, Oct 02, 2013 at 11:23:35AM +0200, David Herrmann wrote: >> All bus drivers do device setup themselves. This requires us to adjust all >> of them if we introduce new core features. Thus, merge all these into a >> uniform drm_

Re: [PATCH 2/5] drm: merge device setup into drm_dev_register()

2013-10-03 Thread Daniel Vetter
On Wed, Oct 02, 2013 at 11:23:35AM +0200, David Herrmann wrote: > All bus drivers do device setup themselves. This requires us to adjust all > of them if we introduce new core features. Thus, merge all these into a > uniform drm_dev_register() helper. > > Note that this removes the drm_lastclose()

[PATCH 2/5] drm: merge device setup into drm_dev_register()

2013-10-02 Thread David Herrmann
All bus drivers do device setup themselves. This requires us to adjust all of them if we introduce new core features. Thus, merge all these into a uniform drm_dev_register() helper. Note that this removes the drm_lastclose() error path for AGP as it is horribly broken. Moreover, no bus driver call