Re: [PATCH] Staging: TIDSPBRIDGE: Remove UUID helper

2013-12-01 Thread Ivajlo Dimitrov
On 01.12.2013 21:06, Joe Perches wrote: On Sun, 2013-12-01 at 19:07 +0200, Ivaylo DImitrov wrote: From: Ivaylo Dimitrov Custom uuid helper function is needed only in rmgr/dbdcd.c and doesn't need to be exported. It can also be made way simpler by using sscanf. [] diff --git a/drivers/stagin

Re: [PATCH 2/2] Drivers: staging: dgap: checkpatch.pl cleanups

2013-12-01 Thread Dan Carpenter
On Sun, Dec 01, 2013 at 05:43:09PM +0200, Aldo Iljazi wrote: > #define DIGI_DLREQ_GET (('d'<<8) | 220) > @@ -57,7 +57,7 @@ struct downldio { > #define DIGI_NUKE_RESET_ALL (1 << 31) > #define DIGI_NUKE_INHIBIT_POLLER (1 << 30) > #define DIGI_NUKE_BRD_NUMB0x0f > - > + > >

Re: [PATCH 1/2] Drivers: staging: dgap: checkpatch.pl cleanups

2013-12-01 Thread Dan Carpenter
On Sun, Dec 01, 2013 at 05:43:08PM +0200, Aldo Iljazi wrote: > A few checkpatch cleanups, particularly: > > Lines 83, 87, 89, 196: Removed spaces before tabs. > Lines 141, 265.267: Removed trailing whitespace. > Don't send two patches with the exact same subject. regards, dan carpenter ___

[PATCH] Staging: TIDSPBRIDGE: Remove UUID helper

2013-12-01 Thread Ivaylo DImitrov
From: Ivaylo Dimitrov Custom uuid helper function is needed only in rmgr/dbdcd.c and doesn't need to be exported. It can also be made way simpler by using sscanf. Signed-off-by: Ivaylo Dimitrov --- drivers/staging/tidspbridge/Makefile |2 +- drivers/staging/tidspbridge/gen/uu

[PATCH 1/2] Drivers: staging: dgap: checkpatch.pl cleanups

2013-12-01 Thread Aldo Iljazi
A few checkpatch cleanups, particularly: Lines 83, 87, 89, 196: Removed spaces before tabs. Lines 141, 265.267: Removed trailing whitespace. Signed-off-by: Aldo Iljazi --- drivers/staging/dgap/dgap_conf.h | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --g

[PATCH 2/2] Drivers: staging: dgap: checkpatch.pl cleanups

2013-12-01 Thread Aldo Iljazi
A few checkpatch cleanups, particularly: Lines 26, 60: Removed trailing whitespace. Lines 36-38, 42-44, 47: Removed spaces at the start of the lines. Signed-off-by: Aldo Iljazi --- drivers/staging/dgap/dgap_downld.h | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-