On Sun, 2014-05-25 at 21:58 -0700, Chaitanya Hazarey wrote:
> Added a blank line after declarations in many places to fix
> the following warning issued by checkpatch.pl:
Unrelated trivial note:
> diff --git a/drivers/staging/silicom/bpctl_mod.c
> b/drivers/staging/silicom/bpctl_mod.c
> @@ -280
Added a blank line after declarations in many places to fix
the following warning issued by checkpatch.pl:
WARNING: Missing a blank line after declarations
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/silicom/bpctl_mod.c| 88 +++-
drivers/staging/silico
On its way.
Chaitanya
On Sun, May 25, 2014 at 5:51 PM, Greg KH wrote:
> On Sun, May 25, 2014 at 05:36:58PM -0700, Chaitanya Hazarey wrote:
>> Added a blank line after declarations in many places to fix the following
>> warning issued by checkpatch.pl:
>
> Always wrap your lines at 72 columns, l
On Sun, May 25, 2014 at 05:36:58PM -0700, Chaitanya Hazarey wrote:
> Added a blank line after declarations in many places to fix the following
> warning issued by checkpatch.pl:
Always wrap your lines at 72 columns, like git asks you to when you type
in the commit message.
> WARNING: Missing a b
Added a blank line after declarations in many places to fix the following
warning issued by checkpatch.pl:
WARNING: Missing a blank line after declarations
The reason why it was not applying clean against Greg's tree was that
bpctl_mod.c had changed in the functions which are a part of this pat
On Mon, May 26, 2014 at 12:57:39AM +0100, Masaru Nomura wrote:
> > What _branch_ of that git tree did you make it against?
> >
>
> I did my work against
>
> commit 4b660a7f5c8099d88d1a43d8ae138965112592c7
That is a commit, not a branch.
Please work against the staging-next branch, not master.
OK sure, will do Dan.
Greg, the patch has some issues, I did sync to your staging-next
branch and am having issues applying it.
Will send an update when i am able to do it.
Thanks,
Chaitanya
On Sun, May 25, 2014 at 3:30 PM, Dan Carpenter wrote:
> Since you're redoing this one anyway, please u
> What _branch_ of that git tree did you make it against?
>
I did my work against
commit 4b660a7f5c8099d88d1a43d8ae138965112592c7
Thank you,
Masaru
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/list
On Sun, May 25, 2014 at 11:50:03PM +0100, Masaru Nomura wrote:
>
>
>
> 2014-05-25 23:37 GMT+01:00 Greg KH :
>
> On Sun, May 25, 2014 at 11:24:12PM +0100, Masaru Nomura wrote:
> > Remove prohibited space between function name and
> > open parenthesis to meet kernel coding style.
>
Hi all,
On Sun, 25 May 2014 15:12:35 -0700 Greg Kroah-Hartman
wrote:
>
> On Sun, May 25, 2014 at 11:54:14PM +0200, Vincent Stehlé wrote:
> > Commit f9b0e251dfbf 'drm: make mode_valid callback optional' left variable
> > ret
> > unused; remove it.
> >
> > This fixes the following compilation wa
On Sun, May 25, 2014 at 11:24:12PM +0100, Masaru Nomura wrote:
> Remove prohibited space between function name and
> open parenthesis to meet kernel coding style.
> Also fix indenting due to changes to keep readability.
>
> -since v2:
> None. This is the resend of v2 as v2 failed to apply
This sh
Since you're redoing this one anyway, please use a more specific subject
like:
[PATCH] Staging: Silicom: bpctl_mod.c & bypass.c: add blank lines
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproj
Remove prohibited space between function name and
open parenthesis to meet kernel coding style.
Also fix indenting due to changes to keep readability.
-since v2:
None. This is the resend of v2 as v2 failed to apply
Signed-off-by: Masaru Nomura
---
.../staging/lustre/lnet/klnds/socklnd/socklnd.c
On Sun, May 25, 2014 at 10:43:00PM +0200, jes.soren...@redhat.com wrote:
> From: Jes Sorensen
>
> Hi Greg,
>
> Please find attached another round of cleanups, removal of dead code,
> and tidying up most of the #ifdef CONFIG_8723AU_BT_COEXIST mess.
>
> Notably patch 10 fixes an OOPS case if a us
On Sun, May 25, 2014 at 11:59:08AM -0700, Chaitanya Hazarey wrote:
> Added a blank line after declarations in many places to fix the following
> warning issued by checkpatch.pl:
>
> WARNING: Missing a blank line after declarations
>
> Lets see if this works now, this patch is prepared against Gr
On Sun, May 25, 2014 at 11:54:14PM +0200, Vincent Stehlé wrote:
> Commit f9b0e251dfbf 'drm: make mode_valid callback optional' left variable ret
> unused; remove it.
>
> This fixes the following compilation warning:
>
> drivers/staging/imx-drm/imx-tve.c: In function
> ‘imx_tve_connector_mode_v
Commit f9b0e251dfbf 'drm: make mode_valid callback optional' left variable ret
unused; remove it.
This fixes the following compilation warning:
drivers/staging/imx-drm/imx-tve.c: In function ‘imx_tve_connector_mode_valid’:
drivers/staging/imx-drm/imx-tve.c:252:6: warning: unused variable ‘ret
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/include/ioctl_cfg80211.h | 3 ---
drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 7 ---
2 files changed, 10 deletions(-)
diff --git a/drivers/staging/rtl8723au/include/ioctl_cfg80211.h
b/drivers/staging/rtl
From: Jes Sorensen
Use this header for declaring functions that are currently #ifdef'ed
out in the general code.
Start by moving BTDM_1Ant8723A() there and renaming it appropriately.
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/core/rtw_cmd.c | 10
drivers/stag
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/core/rtw_pwrctrl.c| 13 ++---
drivers/staging/rtl8723au/include/rtw_pwrctrl.h | 1 -
drivers/staging/rtl8723au/os_dep/os_intfs.c | 4
drivers/staging/rtl8723au/os_dep/usb_intf.c | 11 +++-
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/include/rtl8723a_bt-coexist.h | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/rtl8723au/include/rtl8723a_bt-coexist.h
b/drivers/staging/rtl8723au/include/rtl8723a_bt-coexist.h
index 2a6a100..0
From: Jes Sorensen
This file is only compiled if CONFIG_8723AU_BT_COEXIST=y
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c
b/drivers/staging/rtl8723au
From: Jes Sorensen
In addition, remove a followon check for false just after having
checked for true.
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/core/rtw_ioctl_set.c | 3 +--
drivers/staging/rtl8723au/core/rtw_led.c | 17 ++---
drivers/staging/rtl8723au/core/r
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/include/ioctl_cfg80211.h | 3 -
drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 166 -
2 files changed, 169 deletions(-)
diff --git a/drivers/staging/rtl8723au/include/ioctl_cfg80211.h
b/dr
From: Jes Sorensen
Make it return bool since it only returns true/false, and get rid of
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/hal/odm.c | 4 +---
drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c | 4 ++--
drivers/staging/rtl8723au/include/rtl8723a
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/core/rtw_cmd.c | 28 +---
1 file changed, 13 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/rtl8723au/core/rtw_cmd.c
b/drivers/staging/rtl8723au/core/rtw_cmd.c
index db97ffb..e4ca
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/core/rtw_cmd.c | 12 +-
drivers/staging/rtl8723au/core/rtw_ioctl_set.c | 24 +---
drivers/staging/rtl8723au/core/rtw_led.c | 31 +-
drivers/staging/rtl8723au/
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 2 --
drivers/staging/rtl8723au/include/rtl8723a_cmd.h | 2 ++
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c
b/drivers/stag
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/core/rtw_cmd.c| 12 +++-
drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c | 8 ++--
drivers/staging/rtl8723au/include/rtl8723a_bt-coexist.h | 2 --
drivers/staging/rtl8723au/include
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/include/rtw_mlme.h | 63
1 file changed, 63 deletions(-)
diff --git a/drivers/staging/rtl8723au/include/rtw_mlme.h
b/drivers/staging/rtl8723au/include/rtw_mlme.h
index 129c524..d601c55 10
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/include/ioctl_cfg80211.h | 19 ---
drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 15 ---
2 files changed, 8 insertions(+), 26 deletions(-)
diff --git a/drivers/staging/rtl8723au/incl
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/core/rtw_cmd.c | 20 +---
1 file changed, 5 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/rtl8723au/core/rtw_cmd.c
b/drivers/staging/rtl8723au/core/rtw_cmd.c
index 646b59b..1696cb8 10064
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/include/rtw_mlme.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723au/include/rtw_mlme.h
b/drivers/staging/rtl8723au/include/rtw_mlme.h
index 1bb9e6c..1aafa26 100644
--- a/dr
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/include/ioctl_cfg80211.h | 19 ---
drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 1 -
2 files changed, 20 deletions(-)
diff --git a/drivers/staging/rtl8723au/include/ioctl_cfg80211.h
b/drivers
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c | 2 +-
drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 6 ++
drivers/staging/rtl8723au/include/rtl8723a_bt-coexist.h | 2 --
drivers/staging/rtl8723au/include/rtl8723a_bt_in
From: Jes Sorensen
Providing a dummy wrapper also allows removing some more
CONFIG_8723AU_BT_COEXIST clutter
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/core/rtw_cmd.c| 7 ++-
drivers/staging/rtl8723au/hal/hal_com.c | 4 +---
drivers/staging/rt
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/core/rtw_pwrctrl.c | 9 +++--
drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c | 2 +-
drivers/staging/rtl8723au/include/rtl8723a_bt_intf.h | 2 ++
3 files changed, 6 insertions(+), 7 deletions(-)
diff
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c | 2 +-
drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 5 ++---
drivers/staging/rtl8723au/include/rtl8723a_bt-coexist.h | 3 ---
drivers/staging/rtl8723au/include/rtl8723a_bt_in
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/include/ieee80211.h | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/staging/rtl8723au/include/ieee80211.h
b/drivers/staging/rtl8723au/include/ieee80211.h
index e69f1cc..69c0f5c 100644
--- a/driv
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/hal/usb_halinit.c | 40 +
1 file changed, 18 insertions(+), 22 deletions(-)
diff --git a/drivers/staging/rtl8723au/hal/usb_halinit.c
b/drivers/staging/rtl8723au/hal/usb_halinit.c
index 203
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/core/rtw_xmit.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/rtl8723au/core/rtw_xmit.c
b/drivers/staging/rtl8723au/core/rtw_xmit.c
index 0c66d35..9060494 10064
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 16 ++--
1 file changed, 6 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c
b/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c
index
From: Jes Sorensen
In addition get rid of some pointless code obfuscating wrappers
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c | 9 ++---
drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 5 ++---
drivers/staging/rtl8723au/include/rtl8723
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
.../staging/rtl8723au/hal/rtl8723a_bt-coexist.c| 46
drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 49 --
drivers/staging/rtl8723au/hal/usb_halinit.c| 4 +-
.../staging/rtl8723au/incl
From: Jes Sorensen
Hi Greg,
Please find attached another round of cleanups, removal of dead code,
and tidying up most of the #ifdef CONFIG_8723AU_BT_COEXIST mess.
Notably patch 10 fixes an OOPS case if a user tries to add a monitor
interface - monitor mode still doesn't work, but at least it do
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/include/ioctl_cfg80211.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8723au/include/ioctl_cfg80211.h
b/drivers/staging/rtl8723au/include/ioctl_cfg80211.h
index 256000f..63e921f 100644
--- a
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
.../staging/rtl8723au/hal/rtl8723a_bt-coexist.c| 39 +-
.../staging/rtl8723au/include/rtl8723a_bt_intf.h | 5 +++
2 files changed, 20 insertions(+), 24 deletions(-)
diff --git a/drivers/staging/rtl8723au/hal/rtl8723a
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/hal/usb_halinit.c | 58 -
1 file changed, 16 insertions(+), 42 deletions(-)
diff --git a/drivers/staging/rtl8723au/hal/usb_halinit.c
b/drivers/staging/rtl8723au/hal/usb_halinit.c
index 2fd
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/core/rtw_cmd.c| 4 +---
drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c | 4 ++--
drivers/staging/rtl8723au/include/rtl8723a_bt-coexist.h | 2 --
drivers/staging/rtl8723au/include/rtl8723a_bt_in
From: Jes Sorensen
... and in one case use is_zero_ether_addr()
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 25 +++
1 file changed, 12 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c
b/d
From: Jes Sorensen
There is no point starting to register the wiphy and then having to
unregister it again if the followon kmalloc() fails.
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 22 --
1 file changed, 12 insertions(+), 10 deleti
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c
b/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c
inde
From: Jes Sorensen
Calling open on the device when changing the interface type is wrong.
Let the stack call open at the right time.
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/staging/rtl8
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 25 ---
1 file changed, 13 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c
b/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/hal/hal_com.c| 11 ---
.../staging/rtl8723au/hal/rtl8723a_bt-coexist.c| 22 +++---
.../rtl8723au/include/rtl8723a_bt-coexist.h| 2 --
.../staging/rtl8723au/include/rtl87
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c | 2 +-
drivers/staging/rtl8723au/hal/usb_halinit.c | 4 ++--
drivers/staging/rtl8723au/include/rtl8723a_bt-coexist.h | 2 --
drivers/staging/rtl8723au/include/rtl8723a_bt_intf
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/core/rtw_pwrctrl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723au/core/rtw_pwrctrl.c
b/drivers/staging/rtl8723au/core/rtw_pwrctrl.c
index 937bbbc..79cc729 100644
--- a/dr
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/core/rtw_pwrctrl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723au/core/rtw_pwrctrl.c
b/drivers/staging/rtl8723au/core/rtw_pwrctrl.c
index 86ce51f..937bbbc 100644
--- a/dr
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/core/rtw_cmd.c | 8 ++--
drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c | 7 +--
drivers/staging/rtl8723au/include/rtl8723a_bt_intf.h | 4 +++-
3 files changed, 6 insertions(+), 13 deletions(-
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 24 +---
1 file changed, 9 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
index def
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/core/rtw_cmd.c | 8 ++--
drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c | 7 +--
drivers/staging/rtl8723au/include/rtl8723a_bt_intf.h | 2 ++
3 files changed, 5 insertions(+), 12 deletions(-)
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 4 ++--
drivers/staging/rtl8723au/core/rtw_recv.c | 12 ++--
drivers/staging/rtl8723au/core/rtw_xmit.c | 12 ++--
3 files changed, 14 insertions(+), 14 deletions(-)
diff
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 24
1 file changed, 16 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
index a99
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/core/rtw_pwrctrl.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8723au/core/rtw_pwrctrl.c
b/drivers/staging/rtl8723au/core/rtw_pwrctrl.c
index f4e32d9..ef9b468 100644
-
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/include/rtw_mlme.h | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/staging/rtl8723au/include/rtw_mlme.h
b/drivers/staging/rtl8723au/include/rtw_mlme.h
index 1aafa26..129c524 100644
--- a/drivers/stag
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/include/drv_types.h | 4
drivers/staging/rtl8723au/include/rtw_mlme.h | 10 --
2 files changed, 14 deletions(-)
diff --git a/drivers/staging/rtl8723au/include/drv_types.h
b/drivers/staging/rtl8723au/in
Added a blank line after declarations in many places to fix the following
warning issued by checkpatch.pl:
WARNING: Missing a blank line after declarations
Lets see if this works now, this patch is prepared against Greg's staging tree.
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/sili
On So, 2014-05-25 at 11:33 -0700, Greg KH wrote:
> On Sun, May 25, 2014 at 08:24:33PM +0200, Manuel Schoelling wrote:
> > On So, 2014-05-25 at 11:14 -0700, Greg KH wrote:
> > > On Sun, May 25, 2014 at 03:08:59PM +0200, Manuel Schölling wrote:
> > > > To be future-proof and for better readability th
On Sun, May 25, 2014 at 08:24:33PM +0200, Manuel Schoelling wrote:
> On So, 2014-05-25 at 11:14 -0700, Greg KH wrote:
> > On Sun, May 25, 2014 at 03:08:59PM +0200, Manuel Schölling wrote:
> > > To be future-proof and for better readability the time comparisons are
> > > modified to use time_before(
Sorry Greg, this is taking so long, will make this against your tree
and send it out.
Thanks for looking into this,
Chaitanya
On Sun, May 25, 2014 at 11:03 AM, Greg KH wrote:
> On Fri, May 23, 2014 at 10:25:28PM -0700, Chaitanya Hazarey wrote:
>> Added a blank line after declarations in many pl
On So, 2014-05-25 at 11:14 -0700, Greg KH wrote:
> On Sun, May 25, 2014 at 03:08:59PM +0200, Manuel Schölling wrote:
> > To be future-proof and for better readability the time comparisons are
> > modified to use time_before() instead of plain, error-prone math.
> >
> > Signed-off-by: Manuel Schöll
On Sun, May 25, 2014 at 03:08:59PM +0200, Manuel Schölling wrote:
> To be future-proof and for better readability the time comparisons are
> modified to use time_before() instead of plain, error-prone math.
>
> Signed-off-by: Manuel Schölling
> ---
> drivers/staging/gdm72xx/gdm_usb.c |2 +-
>
On Sat, May 24, 2014 at 01:06:48PM +0200, Peter Senna Tschudin wrote:
> This patch remove variables that are initialized with a constant,
> are never updated, and are only used as parameter of return.
> Return the constant instead of using a variable.
>
> Verified by compilation only.
>
> The coc
To be future-proof and for better readability the time comparisons are
modified to use time_after_eq() instead of plain, error-prone math.
Signed-off-by: Manuel Schölling
---
drivers/staging/dgnc/dgnc_neo.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/
On Fri, May 23, 2014 at 10:25:28PM -0700, Chaitanya Hazarey wrote:
> Added a blank line after declarations in many places to fix the
> following warning issued by checkpatch.pl:
>
> WARNING: Missing a blank line after declarations
>
> Thanks Greg K-H and Dan for the patience. Hope it works this t
Fixed a lot of errors of the type "ERROR: space required after that ','
(ctx:VxV)"
Added tabs at the beginning of line.
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r819xU_firmware_img.c | 1042
1 file changed, 521 insertions(+), 521 deletions(-)
diff
To be future-proof and for better readability the time comparisons are
modified to use time_before() instead of plain, error-prone math.
Signed-off-by: Manuel Schölling
---
drivers/staging/gdm72xx/gdm_usb.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gd
To be future-proof and for better readability the time comparisons are
modified to use time_before/_after() instead of plain, error-prone math.
To suppress compiler warnings the type of ips_deny_time was changed.
Signed-off-by: Manuel Schölling
---
drivers/staging/rtl8188eu/core/rtw_pwrctrl.c
To be future-proof and for better readability the time comparisons are
modified to use time_before_eq() instead of plain, error-prone math.
Signed-off-by: Manuel Schölling
---
drivers/staging/media/msi3101/sdr-msi3101.c | 28 +--
1 file changed, 14 insertions(+), 14 del
79 matches
Mail list logo