On Tue, Aug 19, 2014 at 09:19:55AM +1000, Con Kolivas wrote:
> As a followup to this discussion:
>
> On Tue, 15 Jul 2014 08:01:13 PM Sam Asadi wrote:
> > Commit f36fdb9f0266 (i8k: Force SMM to run on CPU 0) adds support
> > for multi-core CPUs to the driver. Unfortunately, that causes it
> > to fa
As a followup to this discussion:
On Tue, 15 Jul 2014 08:01:13 PM Sam Asadi wrote:
> Commit f36fdb9f0266 (i8k: Force SMM to run on CPU 0) adds support
> for multi-core CPUs to the driver. Unfortunately, that causes it
> to fail loading if compiled without SMP support, at least on
> 32 bit kernels.
On Mon, Aug 18, 2014 at 03:54:51AM +, Dexuan Cui wrote:
> > -Original Message-
> > From: Dmitry Torokhov
> > Sent: Saturday, August 16, 2014 0:58 AM
> > To: Dexuan Cui
> > > For each char in the string, the host sends 2 events (key down/up with the
> > > char's UNICODE value) to the gue
On Mon, Aug 18, 2014 at 09:34:53AM -0400, Benjamin Romer wrote:
> From: Benjamin Romer
>
> Fix the missing blank lines between declarations and code in
> visorchipset_main.c.
>
> Signed-off-by: Benjamin Romer
This patch is fine, but also next time it's ok to fold the 3 "add blank"
line patches
On Mon, Aug 18, 2014 at 07:19:53PM +0300, Dan Carpenter wrote:
> On Mon, Aug 18, 2014 at 09:21:43AM -0400, Benjamin Romer wrote:
> > #define CHANNEL_GUID_MISMATCH(chType, chName, field, expected, actual,
> > fil, \
> > lin, logCtx) \
> > -
On Mon, Aug 18, 2014 at 09:21:43AM -0400, Benjamin Romer wrote:
> #define CHANNEL_GUID_MISMATCH(chType, chName, field, expected, actual, fil, \
> lin, logCtx) \
> - do {\
> +
The use_interrupts is used only in dagp_request_irq() for checking
a value from user config file. It doesn't need in board_t struct.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c |4 +---
drivers/staging/dgap/dgap.h |1 -
2 files changed, 1 insertions(+), 4 deletions(-)
di
The brd(board_t) is initialized with zero, so "intr_used"
is not needed to set zero when request_irq() is failed.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c |7 +--
1 files changed, 1 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/stagi
On Sun, Aug 17, 2014 at 12:47:57PM -0400, Oleg Drokin wrote:
> The patches are CCed to linux-kernel by most everybody anyway, so do we
> really need to
> spell this out explicitly with an 'L:' line or in some other way?
driver-devel and linux-kernel are CC'd already. CC'ing linux-kernel is
usele
From: Benjamin Romer
There are several else clauses that aren't necessary listed by checkpatch.pl in
visorchipset_main.c. Remove these.
Signed-off-by: Benjamin Romer
---
.../unisys/visorchipset/visorchipset_main.c| 26 +-
1 file changed, 10 insertions(+), 16 deletio
This patch series corrects checkpatch.pl errors in the visorchipset directory.
With these changes, all files in the directory should pass without errors, and
only justifiable warnings should be generated.
Benjamin Romer (4):
staging: unisys: fix spacing in file.c
staging: unisys: fix spacing i
From: Benjamin Romer
There's a missing blank line between code and declarations in file.c.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorchipset/file.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/unisys/visorchipset/file.c
b/drivers/staging/unisys/visor
From: Benjamin Romer
Fix the two spacing errors in parser.c.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorchipset/parser.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/unisys/visorchipset/parser.c
b/drivers/staging/unisys/visorchipset/parser.c
index 8
From: Benjamin Romer
Fix the missing blank lines between declarations and code in
visorchipset_main.c.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorchipset/visorchipset_main.c | 16
1 file changed, 16 insertions(+)
diff --git a/drivers/staging/unisys/visorchi
The function uisutil_copy_fragsinfo_from_skb() in uisutils.c is messy and
over-indented. This patch fixes the function's indentation so it is cleaner.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/uislib/uisutils.c | 48 +---
1 file changed, 25 insertions(+
This patch series fixes all checkpatch.pl errors in the uislib directory. After
this series is applied, all files should pass without anything but justifiable
warnings.
Benjamin Romer (5):
staging: unisys: fix spacing in uislib.c
staging: unisys: simplify destroy_bus() in uislib.c
staging: u
Fix the missing blank line between code and declarations in uisthread.c.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/uislib/uisthread.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/unisys/uislib/uisthread.c
b/drivers/staging/unisys/uislib/uisthread.c
index c9
Fix the line spacing between code and local variables in uislib.c.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/uislib/uislib.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/staging/unisys/uislib/uislib.c
b/drivers/staging/unisys/uislib/uislib.c
index 4cb3487.
Remove the extraneous return from the uislib module exit function.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/uislib/uislib.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/unisys/uislib/uislib.c
b/drivers/staging/unisys/uislib/uislib.c
index 17cfc21..8b89fe3 1
The destroy_bus() function is heavily indented and many lines extend past the
right margin. This patch simplifies the function without changing its effects.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/uislib/uislib.c | 84 ++
1 file changed, 44 insert
The comments for the large union CONTROLVM_MESSAGE_PACKET were inconsistently
placed and one extended past the 80 char limit. These are cleaned up.
Signed-off-by: Benjamin Romer
---
.../include/channels/controlvmchannel.h| 41 --
1 file changed, 30 insertions(+),
Remove the do blocks around several macros and fix spacing and trailing
semicolons.
Signed-off-by: Benjamin Romer
---
.../unisys/common-spar/include/channels/iochannel.h| 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/unisys/common-spar/i
The CHANNEL_*_MISMATCH error message macros should not be inside of do blocks.
Signed-off-by: Benjamin Romer
---
.../staging/unisys/common-spar/include/channels/channel.h| 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/unisys/common-spar/includ
This patch series finishes clean-up in the common-spar directory tree, so that
all files pass through checkpatch.pl cleanly, or with only justifiable warnings
remaining, like over-80-character lines for error messages.
Benjamin Romer (4):
staging: unisys: remove do{} while(0) in macros in channe
Two functions were missing space between declarations and code.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/common-spar/include/channels/channel.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/unisys/common-spar/include/channels/channel.h
b/drivers/staging/u
Hey,
Op 18-08-14 om 14:57 schreef Dan Carpenter:
> On Thu, Aug 14, 2014 at 11:53:38AM +0200, Maarten Lankhorst wrote:
>> According to the documentation sync_fence_create takes ownership of the
>> point,
>> not a reference on the point.
>>
> What are the user visible effects of this bug? I assume
On Thu, Aug 14, 2014 at 11:53:38AM +0200, Maarten Lankhorst wrote:
> According to the documentation sync_fence_create takes ownership of the point,
> not a reference on the point.
>
What are the user visible effects of this bug? I assume this is a real
bug but judging solely based on your patch
Dear winner,
Your email address has won you One Million Euro, from Online Lotto, all the
E-mail addresses were selected from a data base of internet e-mail users,
from which your e-mail address came out as the winning coupon.
Winning expiring date 30th of August, 2014. Contact our fiduciary Agen
The output prints some struct variable contents, but uses a wrong
variable name. This is fixed by this patch.
Signed-off-by: Matthias Beyer
---
drivers/staging/bcm/Bcmchar.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/stagin
On 15 August 2014 08:06, wrote:
> From: Roger Tseng
>
> Current code erroneously fill the last byte of R2 response with an undefined
> value. In addition, the controller actually 'offloads' the last byte
> (CRC7, end bit) while receiving R2 response and thus it's impossible to get
> the
> actua
On 15 August 2014 08:06, wrote:
> From: Roger Tseng
>
> Current code erroneously fill the last byte of R2 response with an undefined
> value. In addition, the controller actually 'offloads' the last byte
> (CRC7, end bit) while receiving R2 response and thus it's impossible to get
> the
> actua
On 2014-08-18 04:43, Chase Southwood wrote:
We initialize 'irqbit' to 0, only to properly set it immediately
afterwards. Just remove the zero-initialization.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
drivers/staging/comedi/drivers/s626.c | 1 -
1 file changed
On 2014-08-18 04:43, Chase Southwood wrote:
cppcheck was complaining that the variable 'stat' is being reassigned
before the old value is used. Upon inspection, I found that
dt2801_writecmd() cannot fail, always returns 0, and most callers already
do not bother with assigning its return value an
33 matches
Mail list logo
