Re: [PATCH] Fixed all coding style issues for drivers/staging/media/lirc/

2014-10-01 Thread Ilia Mirkin
On Thu, Oct 2, 2014 at 12:40 AM, Amber Thrall wrote: > Fixed various coding style issues, including strings over 80 characters long > and many > deprecated printk's have been replaced with proper methods. > > Signed-off-by: Amber Thrall > --- > drivers/staging/media/lirc/lirc_bt829.c | 2 +- >

[PATCH] Fixed all coding style issues for drivers/staging/media/lirc/

2014-10-01 Thread Amber Thrall
Fixed various coding style issues, including strings over 80 characters long and many deprecated printk's have been replaced with proper methods. Signed-off-by: Amber Thrall --- drivers/staging/media/lirc/lirc_bt829.c | 2 +- drivers/staging/media/lirc/lirc_imon.c | 4 +- drivers/staging/

Re: [PATCH] Fixed all coding style issues for drivers/staging/media/lirc/

2014-10-01 Thread Greg KH
On Wed, Oct 01, 2014 at 07:35:51PM -0700, Amber Thrall wrote: > Fixed various coding sytles. You need to be specific as to what you changed. Also, use get_maintainer to figure out who to sent this to (hint, not me...) greg k-h ___ devel mailing list de

[PATCH] Fixed all coding style issues for drivers/staging/media/lirc/

2014-10-01 Thread Amber Thrall
Fixed various coding sytles. Signed-off-by: Amber Thrall --- drivers/staging/media/lirc/lirc_bt829.c | 2 +- drivers/staging/media/lirc/lirc_imon.c | 4 +- drivers/staging/media/lirc/lirc_sasem.c | 6 +-- drivers/staging/media/lirc/lirc_serial.c | 29 ++ drivers/staging/media/

Re: [PATCH v2] staging: Add Xilinx Clocking Wizard driver

2014-10-01 Thread Sören Brinkmann
On Thu, 2014-10-02 at 02:19AM +0300, Laurent Pinchart wrote: > Hi Sören, > > Thank you for the patch. > > On Wednesday 01 October 2014 14:02:32 Soren Brinkmann wrote: > > Add a driver for the Xilinx Clocking Wizard soft IP. The clocking wizard > > provides an AXI interface to dynamically reconfig

Re: [PATCH v2] staging: Add Xilinx Clocking Wizard driver

2014-10-01 Thread Laurent Pinchart
Hi Sören, Thank you for the patch. On Wednesday 01 October 2014 14:02:32 Soren Brinkmann wrote: > Add a driver for the Xilinx Clocking Wizard soft IP. The clocking wizard > provides an AXI interface to dynamically reconfigure the clocking > resources of Xilinx FPGAs. > > Signed-off-by: Soren Bri

[PATCH] staging: rts5208: Clean up coding style in rtsx_chip.c to get rid of checkpatch.pl warnings

2014-10-01 Thread Giedrius Statkevicius
Fix 10 occurences of coding style errors where the line exceeds 80 characters by breaking them into more lines. Checkpatch.pl reports these errors as: 'WARNING: line over 80 characters' Also, removes unnecessary returns in two void functions by removing the return statements. Checkpatch.pl report

Re: [PATCH] staging: nokia_h4: remove deprecated IRQF_DISABLED

2014-10-01 Thread Aaro Koskinen
Hi, On Wed, Oct 01, 2014 at 10:33:48PM +0200, Michael Opdenacker wrote: > Remove the use of the IRQF_DISABLED flag > from drivers/staging/nokia_h4p/nokia_core.c > > It's a NOOP since 2.6.35 and it will be removed soon. This driver has been deleted from the staging tree already. A. _

[PATCH v2] staging: Add Xilinx Clocking Wizard driver

2014-10-01 Thread Soren Brinkmann
Add a driver for the Xilinx Clocking Wizard soft IP. The clocking wizard provides an AXI interface to dynamically reconfigure the clocking resources of Xilinx FPGAs. Signed-off-by: Soren Brinkmann --- Hi Greg, Dan, I fixed the things Dan pointed out, please take this v2 instead of the original p

[PATCH] staging: nokia_h4: remove deprecated IRQF_DISABLED

2014-10-01 Thread Michael Opdenacker
Remove the use of the IRQF_DISABLED flag from drivers/staging/nokia_h4p/nokia_core.c It's a NOOP since 2.6.35 and it will be removed soon. Signed-off-by: Michael Opdenacker --- drivers/staging/nokia_h4p/nokia_core.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/driver

Re: [PATCH] staging: Add Xilinx Clocking Wizard driver

2014-10-01 Thread Sören Brinkmann
On Wed, 2014-10-01 at 09:58PM +0300, Dan Carpenter wrote: > On Wed, Oct 01, 2014 at 10:21:48AM -0700, Soren Brinkmann wrote: > > +enum clk_wzrd_inp_clks { > > + wzrd_clk_in1, > > + wzrd_s_axi_aclk, > > + wzrd_clk_inp_max > > +}; > > + > > +enum clk_wzrd_int_clks { > > + wzrd_clk_mul, > > +

Re: [PATCH] Staging: rtl8712 removed unnecessary else after return

2014-10-01 Thread Joe Perches
On Wed, 2014-10-01 at 16:44 +0200, Nitin Kuppelur wrote: > Removed unnecessary else after return to solve > checkpatch.pl warning [] > diff --git a/drivers/staging/rtl8712/hal_init.c > b/drivers/staging/rtl8712/hal_init.c [] > @@ -389,10 +389,8 @@ uint rtl871x_hal_init(struct _adapter *padapter) >

Re: [PATCH] staging: Add Xilinx Clocking Wizard driver

2014-10-01 Thread Dan Carpenter
On Wed, Oct 01, 2014 at 10:21:48AM -0700, Soren Brinkmann wrote: > +enum clk_wzrd_inp_clks { > + wzrd_clk_in1, > + wzrd_s_axi_aclk, > + wzrd_clk_inp_max > +}; > + > +enum clk_wzrd_int_clks { > + wzrd_clk_mul, > + wzrd_clk_mul_div, > + wzrd_clk_int_max > +}; > + > +/** > + *

Re: [PATCH] staging: Add Xilinx Clocking Wizard driver

2014-10-01 Thread Sören Brinkmann
On Wed, 2014-10-01 at 10:57AM -0700, Greg Kroah-Hartman wrote: > On Wed, Oct 01, 2014 at 10:46:16AM -0700, Sören Brinkmann wrote: > > On Wed, 2014-10-01 at 10:39AM -0700, Greg Kroah-Hartman wrote: > > > On Wed, Oct 01, 2014 at 10:21:48AM -0700, Soren Brinkmann wrote: > > > > Add a driver for the Xi

Re: [PATCH] staging: Add Xilinx Clocking Wizard driver

2014-10-01 Thread Sören Brinkmann
On Wed, 2014-10-01 at 10:39AM -0700, Greg Kroah-Hartman wrote: > On Wed, Oct 01, 2014 at 10:21:48AM -0700, Soren Brinkmann wrote: > > Add a driver for the Xilinx Clocking Wizard soft IP. The clocking wizard > > provides an AXI interface to dynamically reconfigure the clocking > > resources of Xilin

Re: [PATCH] staging: Add Xilinx Clocking Wizard driver

2014-10-01 Thread Greg Kroah-Hartman
On Wed, Oct 01, 2014 at 10:46:16AM -0700, Sören Brinkmann wrote: > On Wed, 2014-10-01 at 10:39AM -0700, Greg Kroah-Hartman wrote: > > On Wed, Oct 01, 2014 at 10:21:48AM -0700, Soren Brinkmann wrote: > > > Add a driver for the Xilinx Clocking Wizard soft IP. The clocking wizard > > > provides an AXI

Re: [PATCH] staging: Add Xilinx Clocking Wizard driver

2014-10-01 Thread Greg Kroah-Hartman
On Wed, Oct 01, 2014 at 10:21:48AM -0700, Soren Brinkmann wrote: > Add a driver for the Xilinx Clocking Wizard soft IP. The clocking wizard > provides an AXI interface to dynamically reconfigure the clocking > resources of Xilinx FPGAs. Why not just do the few things you have on the TODO list and

[PATCH] staging: Add Xilinx Clocking Wizard driver

2014-10-01 Thread Soren Brinkmann
Add a driver for the Xilinx Clocking Wizard soft IP. The clocking wizard provides an AXI interface to dynamically reconfigure the clocking resources of Xilinx FPGAs. Signed-off-by: Soren Brinkmann --- drivers/staging/Kconfig| 2 + drivers/staging/Makefile

[PATCH] staging: dgap: remove unused variable 'orig_count'

2014-10-01 Thread Rahul Bedarkar
This patch fixes sparse warning warning: variable ‘orig_count’ set but not used [-Wunused-but-set-variable] Signed-off-by: Rahul Bedarkar --- drivers/staging/dgap/dgap.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index 06c

[PATCH] staging: bcm: fix sparse warning in module_param

2014-10-01 Thread Rahul Bedarkar
This patch fixes sparse warning in module_param warning: pointer targets in return differ in signedness [-Wpointer-sign] Signed-off-by: Rahul Bedarkar --- drivers/staging/bcm/InterfaceInit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/bcm/InterfaceInit.c

[PATCH] Staging: rtl8712:ieee80211 remove unnecessary else

2014-10-01 Thread Nitin Kuppelur
Removed unnecessary else after return/break to solve checkpatch.pl warning Signed-off-by: Nitin Kuppelur --- drivers/staging/rtl8712/ieee80211.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8712/ieee80211.c b/drivers/staging/rtl8712/ieee8

[PATCH] Staging: rtl8712 removed unnecessary else after return

2014-10-01 Thread Nitin Kuppelur
Removed unnecessary else after return to solve checkpatch.pl warning Signed-off-by: Nitin Kuppelur --- drivers/staging/rtl8712/hal_init.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8712/hal_init.c b/drivers/staging/rtl8712/hal_init.c index 81cd6

Re: [PATCH] Staging: Android: alarm-dev: Fixed a y2038 issue

2014-10-01 Thread Dan Carpenter
On Wed, Oct 01, 2014 at 10:16:26PM +0530, Somya Anand wrote: > Fixed y2038 issue by replacing timespec with timespec64. > This breaks the userspace API. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxd