On Tue 2015-01-13 09:40:18, Pantelis Antoniou wrote:
> Hi Pavel,
>
> > On Jan 13, 2015, at 09:28 , Pavel Machek wrote:
> >
> > Hi!
> >
> >> +What: /sys/class/fpga_manager//firmware
> >> +Date: October 2014
> >> +KernelVersion:3.18
> >>
Hi Pavel,
> On Jan 13, 2015, at 09:28 , Pavel Machek wrote:
>
> Hi!
>
>> +What: /sys/class/fpga_manager//firmware
>> +Date: October 2014
>> +KernelVersion: 3.18
>> +Contact:Alan Tull
>> +Description:Name of th
Hi!
> +What: /sys/class/fpga_manager//firmware
> +Date: October 2014
> +KernelVersion: 3.18
> +Contact:Alan Tull
> +Description:Name of the FPGA image file to load using
> firmware
> class
On Mon, Jan 12, 2015 at 07:41:34PM -0800, Greg Kroah-Hartman wrote:
On Mon, Dec 22, 2014 at 05:08:34PM +0100, Krzysztof Adamski wrote:
This fixes following checkpatch.pl error:
ERROR: space prohibited before that ',' (ctx:WxW)
Signed-off-by: Krzysztof Adamski
---
drivers/staging/vt6656/rxtx.c
On Tue, Jan 13, 2015 at 11:54:27AM +0530, Sudip Mukherjee wrote:
> On Mon, Jan 12, 2015 at 09:58:17PM -0800, Greg KH wrote:
> > On Tue, Jan 13, 2015 at 10:53:12AM +0530, Sudip Mukherjee wrote:
> > >
> > > any reason why this return was removed ?
> >
> > Because it's not needed.
>
> yes, it is no
On Mon, Jan 12, 2015 at 09:58:17PM -0800, Greg KH wrote:
> On Tue, Jan 13, 2015 at 10:53:12AM +0530, Sudip Mukherjee wrote:
> > On Tue, Jan 13, 2015 at 03:51:36AM +1100, Emrys Bayliss wrote:
> > > This patch fixes the following checkpatch.pl error:
> > > rxtx.c:588: WARNING: else is not generally u
On Tue, Jan 13, 2015 at 10:53:12AM +0530, Sudip Mukherjee wrote:
> On Tue, Jan 13, 2015 at 03:51:36AM +1100, Emrys Bayliss wrote:
> > This patch fixes the following checkpatch.pl error:
> > rxtx.c:588: WARNING: else is not generally useful after a break or return
>
> was the checkpatch error solve
On Thu, Jan 01, 2015 at 06:18:32PM +0100, Rickard Strandqvist wrote:
> Removes some functions that are not used anywhere:
> STAvClearAllCounter() STAvClear802_11Counter()
> STAvUpdateTDStatCounterEx() STAvUpdateRDStatCounterEx()
>
> This was partially found by using a static code analysis program
On Sun, Dec 21, 2014 at 07:03:03PM +0100, Rickard Strandqvist wrote:
> Removes some functions that are not used anywhere:
> SROMbAutoLoad() SROMvReadSubSysVenId() SROMvWriteEtherAddress()
> SROMvWriteAllContents() SROMbIsRegBitsOff() SROMbIsRegBitsOn()
> SROMvRegBitsOff() SROMvRegBitsOn()
>
> This
On Tue, Dec 16, 2014 at 09:30:21AM +0100, Krzysztof Adamski wrote:
> Both struct ieee80211_rts and struct ieee80211_hdr defined in
> linux/ieee80211.h are declared as __aligned(2) so it is safe to use
> ether_addr_copy() instead of memcpy().
>
> Signed-off-by: Krzysztof Adamski
> ---
> drivers/
On Wed, Dec 10, 2014 at 01:50:16PM +0800, Fred Chou wrote:
> From: Fred Chou
>
> Removed the unused function MACvGetShortRetryLimit, which also
> fixed the following sparse warning:
> drivers/staging/vt6655/mac.c:162:6: warning:
> symbol 'MACvGetShortRetryLimit' was not declared. Should it be st
On Mon, Dec 22, 2014 at 05:08:34PM +0100, Krzysztof Adamski wrote:
> This fixes following checkpatch.pl error:
> ERROR: space prohibited before that ',' (ctx:WxW)
>
> Signed-off-by: Krzysztof Adamski
> ---
> drivers/staging/vt6656/rxtx.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
On Mon, Dec 22, 2014 at 05:15:41PM +0100, Krzysztof Adamski wrote:
> This patch fixes checkpatch.pl warning:
> WARNING: Prefer ether_addr_copy() over memcpy() if the Ethernet
> addresses are __aligned(2)
>
> current_net_addr and permanent_net_addr members of vnt_private alignment
> is changed to a
On Wed, Dec 10, 2014 at 06:05:31PM +0100, Krzysztof Adamski wrote:
> This fixes following checkpatch.pl error:
> ERROR: space prohibited before that ',' (ctx:WxW)
>
> Signed-off-by: Krzysztof Adamski
> ---
> drivers/staging/vt6656/rxtx.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
On Tue, Dec 09, 2014 at 08:58:31PM +0530, Adithya K wrote:
> From: Adithya Krishnamurthy
>
> Fixed sparse warning(symbol was not declared. Should it be static) fix.
>
> Signed-off-by: Adithya Krishnamurthy
> ---
> ---
> drivers/staging/vt6655/device_main.c | 2 +-
> 1 file changed, 1 insertion
On Sun, Dec 07, 2014 at 11:02:44PM +0100, Rickard Strandqvist wrote:
> Remove the function MACbCompareContext() that is not used anywhere.
>
> This was partially found by using a static code analysis program called
> cppcheck.
>
> Signed-off-by: Rickard Strandqvist
> ---
> drivers/staging/vt66
On Tue, Dec 16, 2014 at 03:39:50PM +0800, sunwxg wrote:
> From: Sun Wang
>
> Subject: [PATCH] staging:vt6655 Add extern variable in head file
Why is this in the middle of the patch? I would have to hand edit it
out :(
>
> Extern variable must be declared in head file. Compiler can catch the
On Tue, Jan 13, 2015 at 03:51:36AM +1100, Emrys Bayliss wrote:
> This patch fixes the following checkpatch.pl error:
> rxtx.c:588: WARNING: else is not generally useful after a break or return
was the checkpatch error solved with this change? have you checked?
and the checkpatch is giving error a
On Tue, Jan 13, 2015 at 8:26 AM, K. Y. Srinivasan
wrote:
The Hyper-V clocksource is continuous; mark it accordingly.
Signed-off-by: K. Y. Srinivasan
Cc: stable
---
arch/x86/kernel/cpu/mshyperv.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
Acked-by: Jason Wang
diff --gi
The Hyper-V clocksource is continuous; mark it accordingly.
Signed-off-by: K. Y. Srinivasan
Cc: stable
---
arch/x86/kernel/cpu/mshyperv.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/x86/kernel/cpu/mshyperv.c b/arch/x86/kernel/cpu/mshyperv.c
index a450373..93915
On Mon, Jan 12, 2015 at 11:01:03PM +0100, Takashi Iwai wrote:
> At Mon, 12 Jan 2015 12:42:33 -0800,
> Greg Kroah-Hartman wrote:
> >
> > Hi Takashi,
> >
> > Here are all of the line6 patches that have been sent to me that were in
> > my queue, including the series from Chris that caused you to wan
At Mon, 12 Jan 2015 17:35:01 +0100,
Takashi Iwai wrote:
>
> At Sun, 11 Jan 2015 15:04:55 -0600,
> Chris Rorvick wrote:
> >
> > > At Fri, 9 Jan 2015 23:35:46 -0600,
> > > Chris Rorvick wrote:
> > >>
> > >> I have a TonePort UX2 that I've used for testing, meaning that some of
> > >> this is reall
At Mon, 12 Jan 2015 12:42:33 -0800,
Greg Kroah-Hartman wrote:
>
> Hi Takashi,
>
> Here are all of the line6 patches that have been sent to me that were in
> my queue, including the series from Chris that caused you to want to
> move the driver out of staging. I included it here as it had to be
>
On Mon, Jan 12, 2015 at 09:01:34PM +, One Thousand Gnomes wrote:
> There are plenty of people today who treat the FPGA as an entirely
> dynamic resource. It's not like flashing a controller, its near
> immediate.
But this is a completely different use case. Remember, there are
*megabytes* of i
> Then configure udev to load right firmware for you, or ln -s
> image-i-want-now socfpga-fpga-image to select the one to read...?
Your conceptual model is wrong. FPGA firmware is dynamic. There are
already people who lazy reload FPGA firmware on taskswitches. This
proposed fpga manager is broken
From: Chris Rorvick
The driver only supports interface 1 of the Pocket POD. Use the device
table to filter on this.
Signed-off-by: Chris Rorvick
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/line6/driver.c | 12 ++--
1 file changed, 2 insertions(
From: Chris Rorvick
These are now only used to build the device table. Each entry in this
table is already clearly documented as to what device it maps to so the
macros become unnecessary indirection.
Signed-off-by: Chris Rorvick
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Greg Kroah-Hartman
From: Chris Rorvick
The current logic uses the index of the matched entry from the device
table as an offset to the corresponding properties entry. The values
of the new `line6_device_type' enum are ordered such that they can be
used as an index into either of these arrays. Drop the device entr
From: Chris Rorvick
The device type can now be used to determine the addresses of the
control endpoints for the interface. Drop the conditional logic and
make these values properties.
Signed-off-by: Chris Rorvick
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Greg Kroah-Hartman
---
drivers/sta
From: Chris Rorvick
The driver uses a different altsetting depending on the interface. Add
device type entries for each of these.
Signed-off-by: Chris Rorvick
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/line6/driver.c | 41 -
From: Chris Rorvick
Casting the `struct usb_line6' pointer at the call point makes the code
difficult to read. This is substantially cleaned up by moving the cast
into the callees.
Signed-off-by: Chris Rorvick
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Greg Kroah-Hartman
---
drivers/stagin
From: Chris Rorvick
Signed-off-by: Chris Rorvick
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/line6/driver.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/line6/driver.c b/drivers/staging/line6/driver.c
index 6dc8a0d4c4b6..acde205a6
From: Chris Rorvick
The device type can now be used to determine the addresses of the
audio endpoints for the interface. Drop the conditional logic and make
these values properties.
Signed-off-by: Chris Rorvick
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Greg Kroah-Hartman
---
drivers/stagi
From: Chris Rorvick
The `LINE6_CAP_CTRL_PCM_HW' macro combines three capabilities to save
horizontal space when defining the properties entries. Now that these
are no longer limited to single lines this is not such a concern.
Specify capabilities individually when defining each property for
bett
From: Chris Rorvick
Which *_process_message() function (if any) to call when data is
received is known at initialization. Add a function pointer to the
`usb_line6' struct and use to call into the appropriate logic instead
of evaluating the conditional logic for each message.
Signed-off-by: Chri
From: Chris Rorvick
Including "BIT" in the macro name is pointless. Replace with "CAP" to
provide some context for what its value represents.
Signed-off-by: Chris Rorvick
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/line6/driver.c | 8
drive
From: Chris Rorvick
The PODxt Live device has both a POD and a Variax interface. Add device
type entries for each of these.
Signed-off-by: Chris Rorvick
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/line6/driver.c | 112 --
From: Chris Rorvick
Which *_disconnect() to call on disconnect is known at initialization.
Add a function pointer to the `usb_line6' struct and use to call into
the appropriate logic instead of evaluating the conditional logic.
Signed-off-by: Chris Rorvick
Reviewed-by: Stefan Hajnoczi
Signed-o
From: Chris Rorvick
Remove declarations from the header and move the definitions up in the
source so they need not be forward declared.
Signed-off-by: Chris Rorvick
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/line6/pod.c | 58 ++
From: Chris Rorvick
Casting the `struct usb_line6' pointer at the call point makes the code
difficult to read. This is substantially cleaned up by moving the cast
into the callees.
Signed-off-by: Chris Rorvick
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Greg Kroah-Hartman
---
drivers/stagin
From: Chris Rorvick
Specify the index of the properties entry explicitly to define this
structure more robustly. Also, drop the `L6PROP' macro in favor of
initializing each member explicitly on its own line since horizontal
space is limited and more attributes will be added later.
Signed-off-by
From: Chris Rorvick
The device type can now be used to determine the altsetting for the
interface. Drop the conditional logic and make this value a property.
Signed-off-by: Chris Rorvick
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/line6/driver.c | 74 +
From: Jonas Lundqvist
Fix three space prohibited errors in pcm.h found by checkpatch.pl.
Signed-off-by: Jonas Lundqvist
Reviewed-by: Jeremiah Mahler
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/line6/pcm.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/dri
From: Chris Rorvick
Commit 1027f476f507 (staging: line6: sync with upstream) removed PCM
from the Pocket POD capabilities but left the endpoint configuration.
Signed-off-by: Chris Rorvick
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/line6/pcm.c | 5 -
From: Chris Rorvick
This function was no longer used as of commit 2807904441d4 (staging:
line6: drop MIDI parameter sysfs attrs).
Signed-off-by: Chris Rorvick
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/line6/pod.c | 9 -
drivers/staging/line6/p
From: Chris Rorvick
The driver only supports interface 0 of the TonePort UX2 and POD Studio
UX2 devices. Use the device table to filter on this.
Signed-off-by: Chris Rorvick
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/line6/driver.c | 20 --
From: Chris Rorvick
The driver currently uses the device's idProduct as input to several
switch statements. In some cases this is not sufficiently granular and
the interface number must be taken into account.
Store the device type in `usb_line6' and key off of it instead. New
types can then be
Hi Takashi,
Here are all of the line6 patches that have been sent to me that were in
my queue, including the series from Chris that caused you to want to
move the driver out of staging. I included it here as it had to be
tweaked due to some earlier patches in my queue.
thanks,
greg k-h
__
From: Chris Rorvick
Support for these devices appears to have never been completed. Remove
them from the device table along with a minimal amount of supporting
code.
Signed-off-by: Chris Rorvick
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/line6/driver.
From: Rickard Strandqvist
The NULL check was done to late, and there it was a risk
of a possible null pointer dereference.
This was partially found by using a static code analysis program called
cppcheck.
Signed-off-by: Rickard Strandqvist
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Greg Kro
From: Chris Rorvick
The `device_bit' member was no longer used as of commit 2807904441d4
(staging: line6: drop MIDI parameter sysfs attrs).
Signed-off-by: Chris Rorvick
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/line6/driver.c | 44 +++
From: Chris Rorvick
Define an enum containing the supported devices and associate each entry
in the device table to the respective value.
Signed-off-by: Chris Rorvick
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/line6/driver.c | 54 ++
From: Chris Rorvick
Wrap USB_DEVICE to avoid repeating the Line 6 vendor ID.
Signed-off-by: Chris Rorvick
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/line6/driver.c | 40 +---
1 file changed, 21 insertions(+), 19 dele
On Mon, Dec 22, 2014 at 10:45:01PM +0200, Dmitriy Polyanskiy wrote:
> This is a patch to pcm.h file that fixes up some space warnings
> found by checkpatch.pl
>
> Signed-off-by: Dmitriy Polyanskiy
> ---
> drivers/staging/line6/pcm.h |6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-
On Sat, Dec 27, 2014 at 05:00:10PM +1100, Damon Swayn wrote:
> Fixed a coding style issue reported by checkpatch surrounding the
> spacing of comma's
>
> Signed-off-by: Damon Swayn
> ---
> drivers/staging/line6/pcm.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Sorry, someone e
At Mon, 12 Jan 2015 11:52:27 -0800,
Greg Kroah-Hartman wrote:
>
> On Mon, Jan 12, 2015 at 05:35:01PM +0100, Takashi Iwai wrote:
> > At Sun, 11 Jan 2015 15:04:55 -0600,
> > Chris Rorvick wrote:
> > >
> > > > At Fri, 9 Jan 2015 23:35:46 -0600,
> > > > Chris Rorvick wrote:
> > > >>
> > > >> I have
On Mon, Jan 12, 2015 at 05:35:01PM +0100, Takashi Iwai wrote:
> At Sun, 11 Jan 2015 15:04:55 -0600,
> Chris Rorvick wrote:
> >
> > > At Fri, 9 Jan 2015 23:35:46 -0600,
> > > Chris Rorvick wrote:
> > >>
> > >> I have a TonePort UX2 that I've used for testing, meaning that some of
> > >> this is re
On Wed, Dec 03, 2014 at 07:34:42PM +0100, Sam van Kampen wrote:
> This patch fixes the error "Macros with complex values should be enclosed in
> parentheses", as reported by checkpatch.pl.
>
> Signed-off-by: Sam van Kampen
> ---
> drivers/staging/line6/usbdefs.h | 2 +-
> 1 file changed, 1 inser
> -Original Message-
> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
> Sent: Monday, January 12, 2015 8:50 AM
> To: KY Srinivasan; de...@linuxdriverproject.org
> Cc: Haiyang Zhang; Greg Kroah-Hartman; linux-ker...@vger.kernel.org;
> Dexuan Cui
> Subject: [PATCH v3] Drivers: hv: vmbu
On Sun, Jan 11, 2015 at 10:29:00AM -0600, atull wrote:
> the FPGA image. If someone wants there to be only one FPGA image on
> the FGPA forever, they will probably not be using this framework; their
> FPGA will probably be loaded before Linux boots up.
Nonsense, loading the FPGA through Linux is
From: H Hartley Sweeten
This driver requires an IRQ and DMA in order to support async commands.
For aesthetics, introduce a helper function to request the IRQ and DMA
channels and allocate the DMA buffer. Since the async command support
is optional, make the helper function handle any request/al
When the cmd->stop_src == TRIG_COUNT the last DMA transfer might be smaller
than the buffer size. This results in invalid data being added to the async
buffer.
Add a 'size' member to the DMA descriptor and initialize it with the
actual size of the DMA transfer. Use that in interrupt and ai subdevi
For aesthetics, introduce a helper function to free the DMA channels and
allocated buffers.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/das1800.c | 30 --
1 file changed, 20 insertions(+), 10 deletions(-)
For aesthetics, move the freeing of the DMA channel and the buffers to
a helper function.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/pcl818.c | 23 +--
1 file changed, 17 insertions(+), 6 deletions(-)
diff --gi
Use dma_{alloc,free}_coherent() to allocate and free the DMA buffers.
This removes the dependancy on VIRT_TO_BUS.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/Kconfig | 2 +-
drivers/staging/comedi/drivers/das1800.c | 16 +
For aesthetics, move the freeing of the DMA channel and the buffers to
a helper function.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/pcl812.c | 27 +--
1 file changed, 17 insertions(+), 10 deletions(-)
diff
Use dma_{alloc,free}_coherent() to allocate and free the DMA buffers.
This removes the dependancy on VIRT_TO_BUS.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/Kconfig | 2 +-
drivers/staging/comedi/drivers/ni_labpc.h
For aesthetics, introduce a struct to hold the DMA descriptor data.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_labpc.h| 15 --
drivers/staging/comedi/drivers/ni_labpc_isadma.c | 58
drivers/s
For aesthetics, introduce a struct to hold the DMA descriptor data.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/pcl812.c | 100
1 file changed, 50 insertions(+), 50 deletions(-)
diff --git a/drivers
Currently this function always transfers the full DMA buffer to the comedi
async buffer. When the cmd->stop_src == TRIG_COUNT the last DMA transfer
might be smaller than the buffer size. This results in invalid data being
added to the asunc buffer.
Add a 'size' member to the DMA descriptor and ini
Use dma_{alloc,free}_coherent() to allocate and free the DMA buffers.
This removes the dependancy on VIRT_TO_BUS.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/Kconfig | 2 +-
drivers/staging/comedi/drivers/pcl818.c | 25 +++
The DAS16 board is an ISA device not a PCI device. For aesthetics, use
dma_{alloc,free}_coherent() to allocate and free the DMA buffers instead
of the PCI versions.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/das16.c | 9 -
DMA is optional with this driver. Introduce a helper function to request
the DMA channel and allocate the buffers. Don't fail the driver attach
if the user passed an invalid DMA channel or the channel cannot be
requested.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
--
Use dma_{alloc,free}_coherent() to allocate and free the DMA buffers.
This removes the dependancy on VIRT_TO_BUS.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/Kconfig | 2 +-
drivers/staging/comedi/drivers/ni_at_a2150.c | 17 +
The IRA and DMA are optional with this driver but both are required to
support async commands. Introduce a helper function to request the IRQ
and DMA channel and allocate the buffers. Don't fail the driver attach
if the user passed an invalid IRQ or DMA channel or they cannot be
requested.
Signed-
For aesthetics, introduce a struct to hold the DMA descriptor data.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/das1800.c | 145 +++
1 file changed, 70 insertions(+), 75 deletions(-)
diff --git a/drivers
An IRQ and at least one DMA channel are required to use DMA with this driver.
Move the check to the caller to reduce the indent level of this function.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/das1800.c | 129
Refactor this function so that a for loop can be used to request and
set up the two DMA descriptors.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/das1800.c | 52 +++-
1 file changed, 25 insertions(+), 27 d
DMA support is optional for the labpc driver. The return value from
labpc_init_dma_chan() is not even checked by the caller.
Change the return type to void and tidy up the function a bit.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers
For aesthetics, move the freeing of the DMA channel and the buffers to
a helper function.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/das16.c | 33 +++--
1 file changed, 19 insertions(+), 14 deletions(-)
For aesthetics, introduce a struct to hold the DMA descriptor data.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/dt282x.c | 111 +++-
1 file changed, 53 insertions(+), 58 deletions(-)
diff --git a/drivers
For aesthetics, introduce a struct to hold the DMA descriptor data.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/pcl816.c | 51 ++---
1 file changed, 28 insertions(+), 23 deletions(-)
diff --git a/drivers
DMA is optional with this driver. Introduce a helper function to request
the DMA channel and allocate the buffers. Don't fail the driver attach
if the user passed an invalid DMA channel or the channel cannot be
requested.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
--
For aesthetics, introduce a struct to hold the DMA descriptor data.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/das16.c | 48 ++
1 file changed, 26 insertions(+), 22 deletions(-)
diff --git a/drivers
From: H Hartley Sweeten
For aesthetics, introduce a helper function to free the DMA channel and
buffer.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_at_a2150.c | 20 +---
1 file changed, 13 insertions(+), 7 delet
This driver can use DMA or the hardware FIFO to read analog input samples.
When DMA is enabled it's also possible for some async commands to cause
DMA to be disabled and the FIFO is used instead.
Currently the first DMA channels buffer is used for the bounce buffer
when using the FIFO. For aesthet
Use dma_{alloc,free}_coherent() to allocate and free the DMA buffers.
This removes the dependancy on VIRT_TO_BUS.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/Kconfig | 2 +-
drivers/staging/comedi/drivers/pcl816.c | 20 +--
From: H Hartley Sweeten
For aesthetics, use the helper function to get the byte size of each sample
instead of using sizeof() the first buffer element.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_at_a2150.c | 8
1 file
Use dma_{alloc,free}_coherent() to allocate and free the DMA buffers.
This removes the dependancy on VIRT_TO_BUS.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/Kconfig | 2 +-
drivers/staging/comedi/drivers/dt282x.c | 13 ---
For aesthetics, introduce a struct to hold the DMA descriptor data.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/pcl818.c | 44 +++--
1 file changed, 25 insertions(+), 19 deletions(-)
diff --git a/drivers
The IRA and DMA are optional with this driver but both are required to
support async commands. Introduce a helper function to request the IRQ
and DMA channel and allocate the buffers. Don't fail the driver attach
if the user passed an invalid IRQ or DMA channel or they cannot be
requested.
Signed-
As indicated by checkpatch.pl, "WARNING: Use of volatile is usually
wrong: ...", the 'count' member of the private data does not need to
be volatile.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_at_a2150.c | 3 +--
1 file changed,
This driver no longer uses virt_to_bus(). Remove the dependancy.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/comedi/Kconfig b/drivers/staging/comedi/Kconfig
index a8
This series removes all the VIRT_TO_BUS dependancies from the legacy comedi
drivers. It also tidies up the allocation and freeing of the DMA and the
buffers used for DMA.
H Hartley Sweeten (37):
staging: comedi: adl_pci9118: remove VIRT_TO_BUS dependancy
staging: comedi: das1800: reduce indent
Use dma_{alloc,free}_coherent() to allocate and free the DMA buffers.
This removes the dependancy on VIRT_TO_BUS.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/Kconfig | 2 +-
drivers/staging/comedi/drivers/pcl812.c | 20 +--
For aesthetics, move the freeing of the DMA channel and the buffers to
a helper function.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/pcl816.c | 25 +
1 file changed, 17 insertions(+), 8 deletions(-)
diff --
DMA is optional with this driver. Introduce a helper function to request
the DMA channel and allocate the buffers. Don't fail the driver attach
if the user passed an invalid DMA channel or the channel cannot be
requested.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
--
For aesthetics, introduce a struct to hold the DMA descriptor data.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_at_a2150.c | 76 +++-
1 file changed, 41 insertions(+), 35 deletions(-)
diff --git a/drivers
> Here is a proposal to include in the staging tree the drivers from the
> fbtft project at https://github.com/notro/fbtft. This project contains
> a number of drivers small TFT LCD display modules, which are not
> otherwise supported by the Linux kernel. This set of drivers appears
> to be quite
On Mon, Jan 12, 2015 at 10:05:49AM -0600, Rob Herring wrote:
> On Sun, Jan 11, 2015 at 10:29 AM, atull wrote:
> > Previous uses of the firmware layer has been to use it to load once after
> > bootup; this is different since some use cases will want to switch out
> > the FPGA image. If someone wa
1 - 100 of 118 matches
Mail list logo
