[PATCH 01/27] staging: lustre: Convert "return seq_printf(...)" uses

2015-02-21 Thread Joe Perches
The seq_printf return value, because it's frequently misused, will eventually be converted to void. See: commit 1f33c41c03da ("seq_file: Rename seq_overflow() to seq_has_overflowed() and make public") Convert these "return seq_printf(...)" uses to: seq_printf(seq, ...); retu

[PATCH 02/27] staging: lustre: Convert seq_ hash functions to return void

2015-02-21 Thread Joe Perches
These functions don't need to return anything. No caller uses the return value. Miscellanea: Integrate the individual strings to reduce object size ~100 bytes. Signed-off-by: Joe Perches --- drivers/staging/lustre/include/linux/libcfs/libcfs_hash.h | 4 ++-- drivers/staging/lustre/lustre/libc

[PATCH 00/27] Convert seq_ output calls to return void

2015-02-21 Thread Joe Perches
As Al Viro said: we are getting well-meaning folks who try to check that return value, again and again, getting it wrong every time. Typical idiocies: * return some kind of error out of ->show() on overflows. Pointless *and* wrong - only hard errors (== fail read(2) with that) should be

[PATCH 17/27] staging: i2o: Remove use of seq_printf return value

2015-02-21 Thread Joe Perches
The seq_printf return value, because it's frequently misused, will eventually be converted to void. See: commit 1f33c41c03da ("seq_file: Rename seq_overflow() to seq_has_overflowed() and make public") Signed-off-by: Joe Perches --- drivers/staging/i2o/i2o_proc.c | 18 -- 1

[PATCH 03/27] staging: lustre: Convert uses of "int rc = seq_printf(...)"

2015-02-21 Thread Joe Perches
The seq_printf return value, because it's frequently misused, will eventually be converted to void. See: commit 1f33c41c03da ("seq_file: Rename seq_overflow() to seq_has_overflowed() and make public") Convert these uses to: seq_printf(seq, ...); return 0; Done via cocci sc

[PATCH 18/27] staging: rtl8192x: Remove use of seq_printf return value

2015-02-21 Thread Joe Perches
The seq_printf return value, because it's frequently misused, will eventually be converted to void. See: commit 1f33c41c03da ("seq_file: Rename seq_overflow() to seq_has_overflowed() and make public") Signed-off-by: Joe Perches --- drivers/staging/rtl8192e/rtllib_module.c | 4

[PATCH 04/27] staging: lustre: Convert remaining uses of "= seq_printf(...)"

2015-02-21 Thread Joe Perches
The seq_printf return value, because it's frequently misused, will eventually be converted to void. See: commit 1f33c41c03da ("seq_file: Rename seq_overflow() to seq_has_overflowed() and make public") Convert the remaining uses by hand. Miscellanea: o Convert fixed string output to seq_put

Re: [PATCH] Staging: fbtft: fix space prohibition

2015-02-21 Thread Matteo Semenzato
From: Matteo Semenzato This patch fixes the following warnings: space prohibited before that close parenthesis ')' space prohibited after that open parenthesis '(' Signed-off-by: Matteo Semenzato --- drivers/staging/fbtft/fb_bd663474.c | 100 ++-- 1 file changed

[PATCH] staging: media: lirc: Separate authors into own MODULE_AUTHOR

2015-02-21 Thread Boran Car
Fixes quoted string split accross lines checkpatch.pl warning. Signed-off-by: Boran Car --- drivers/staging/media/lirc/lirc_zilog.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/staging/media/lirc/lirc_zilog.c b/drivers/staging/media/lirc/lirc_zilog.c i

Re: [PATCH] Separate authors into own MODULE_AUTHOR

2015-02-21 Thread Greg KH
On Sat, Feb 21, 2015 at 07:38:57PM +, Boran Car wrote: > This fixes quoted string split accross lines. That's not an issue for this field, sorry. And your subject didn't say for what part of the kernel this is needed. thanks, greg k-h ___ devel ma

[PATCH] Separate authors into own MODULE_AUTHOR

2015-02-21 Thread Boran Car
This fixes quoted string split accross lines. Signed-off-by: Boran Car --- drivers/staging/media/lirc/lirc_zilog.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/staging/media/lirc/lirc_zilog.c b/drivers/staging/media/lirc/lirc_zilog.c index e16627c..344

[PATCH] staging: lustre: lnet: lnet: Remove unneeded braces in lib-eq.c

2015-02-21 Thread Edward Lipinsky
This patch fixes the checkpatch.pl warning: WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Edward Lipinsky --- drivers/staging/lustre/lnet/lnet/lib-eq.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lnet/lnet/lib

Re: [PATCH] [RFC] drivers/staging/fbtft: fix sparse warnings

2015-02-21 Thread Dan Carpenter
On Fri, Feb 20, 2015 at 11:34:09PM +0200, Andrey Utkin wrote: > See below how sparse output changed with these changes. > In few words: > - fixed printf specifiers for size_t; > - trying to fix address space specifiers issues, not sure what's correct > approach, ASKING FOR COMMENTS AND HELP; Send

Re: [PATCH] Staging: fbtft: fix space prohibition

2015-02-21 Thread Greg KH
On Sat, Feb 21, 2015 at 04:01:46PM +0100, Matteo Semenzato wrote: > From: Matt > > This patch fixes the following warnings: > space prohibited before that close parenthesis ')' > space prohibited after that open parenthesis '(' > Signed-off-by: Matteo Semenzato Your "From:" line doesn't match y

Re: [PATCH v2] staging: iio: trigger: iio-trig-periodic-rtc: Change frequency type to unsigned int

2015-02-21 Thread Jonathan Cameron
On 21/02/15 18:11, Jonathan Cameron wrote: > On 08/02/15 18:22, Rickard Strandqvist wrote: >> Change struct iio_prtc_trigger_info frequency >> type from int to unsigned int. >> Since it is always treated as such in the driver >> so they type should probably reflect this. >> >> Signed-off-by: Rickar

Re: [PATCH v2] staging: iio: trigger: iio-trig-periodic-rtc: Change frequency type to unsigned int

2015-02-21 Thread Jonathan Cameron
On 08/02/15 18:22, Rickard Strandqvist wrote: > Change struct iio_prtc_trigger_info frequency > type from int to unsigned int. > Since it is always treated as such in the driver > so they type should probably reflect this. > > Signed-off-by: Rickard Strandqvist The only argument against this is t

[PATCH] Staging: fbtft: fix space prohibition

2015-02-21 Thread Matteo Semenzato
From: Matt This patch fixes the following warnings: space prohibited before that close parenthesis ')' space prohibited after that open parenthesis '(' Signed-off-by: Matteo Semenzato --- drivers/staging/fbtft/fb_bd663474.c | 100 ++-- 1 file changed, 50 insertio

[PATCH] staging: unisys: Rework Kconfig dependencies

2015-02-21 Thread Jean Delvare
I find the Kconfig dependencies of the various Unisys drivers rather confusing. Due to the dependencies, you must select the drivers one by one to see the following ones. So if you are looking for a specific driver, it is not visible by default. And if you don't know exactly what you need, it's eve