Re: [PATCH] drivers: staging: speakup: fix sparse "warning: expression using sizeof bool"

2015-03-29 Thread Sudip Mukherjee
On Sat, Mar 28, 2015 at 08:57:01AM +0100, Piotr Witosławski wrote: > On Sat, Mar 28, 2015 at 11:56:40AM +0530, Sudip Mukherjee wrote: > > On Fri, Mar 27, 2015 at 09:36:07PM +0100, Witos wrote: > > > Changed bool to u8 to get rid of sparse warning. > > but i am not getting this warning. which versio

Re: [PATCH] staging: speakup: Fix warning of line over 80 characters.

2015-03-29 Thread Sudip Mukherjee
On Sat, Mar 28, 2015 at 05:26:34PM -0700, Shirish Gajera wrote: > On Sun, Mar 29, 2015 at 12:54:45AM +0100, Richard Weinberger wrote: > > //richard > > Are you sure you want me to do this changes. Because it will conflict > the things written on http://kernelnewbies.org/ where is the conflict? yo

Re: [PATCH 10/11] staging: rtl8192e: Decrease nesting of rtllib_rx_auth_resp()

2015-03-29 Thread Joe Perches
On Mon, 2015-03-30 at 01:21 +0200, Mateusz Kulikowski wrote: > On 30.03.2015 01:13, Joe Perches wrote: > > On Mon, 2015-03-30 at 00:41 +0200, Mateusz Kulikowski wrote: > >> Return from rtllib_rx_auth_resp() if auth_parse() fails. > >> diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c > >> b/d

[PATCH net-next 1/2] hv_netvsc: Cleanup the test for freeing skb when we use sendbuf mechanism

2015-03-29 Thread K. Y. Srinivasan
In preparation for embedding the rndis state and other packet state into the skb, cleanup the test for freeing the skb. Signed-off-by: K. Y. Srinivasan --- drivers/net/hyperv/netvsc.c |1 + drivers/net/hyperv/netvsc_drv.c |3 +-- 2 files changed, 2 insertions(+), 2 deletions(-) diff

[PATCH net-next 2/2] hv_netvsc: Eliminate memory allocation in the packet send path

2015-03-29 Thread K. Y. Srinivasan
The network protocol used to communicate with the host is the remote ndis (rndis) protocol. We need to decorate each outgoing packet with a rndis header and additional rndis state (rndis per-packet state). To manage this state, we currently allocate memory in the transmit path. Eliminate this allo

[PATCH net-next 0/2] hv_netvsc: Eliminate memory allocation in the send path

2015-03-29 Thread K. Y. Srinivasan
The network protocol used to communicate with the host is the remote ndis (rndis) protocol. We need to decorate each outgoing packet with a rndis header and additional rndis state (rndis per-packet state). To manage this state, we currently allocate memory in the transmit path. Eliminate this allo

Re: [PATCH 10/11] staging: rtl8192e: Decrease nesting of rtllib_rx_auth_resp()

2015-03-29 Thread Mateusz Kulikowski
Hi Joe, Thanks for reviewing my patches. On 30.03.2015 01:13, Joe Perches wrote: > On Mon, 2015-03-30 at 00:41 +0200, Mateusz Kulikowski wrote: >> Return from rtllib_rx_auth_resp() if auth_parse() fails. > > Hello Mateusz. Here are some trivial notes. > >> diff --git a/drivers/staging/rtl8192

Re: [PATCH 10/11] staging: rtl8192e: Decrease nesting of rtllib_rx_auth_resp()

2015-03-29 Thread Joe Perches
On Mon, 2015-03-30 at 00:41 +0200, Mateusz Kulikowski wrote: > Return from rtllib_rx_auth_resp() if auth_parse() fails. Hello Mateusz. Here are some trivial notes. > diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c > b/drivers/staging/rtl8192e/rtllib_softmac.c [] > + /* Dummy

[PATCH 06/11] staging: rtl8192e: Fix BRACES warning

2015-03-29 Thread Mateusz Kulikowski
Fix 'braces {} are not necessary for single statement blocks' checkpatch.pl warning Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmwar

[PATCH 11/11] staging: rtl8192e: Fix indentation in rtllib_rx_auth_resp()

2015-03-29 Thread Mateusz Kulikowski
Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtllib_softmac.c | 30 -- 1 file changed, 12 insertions(+), 18 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c index 9a4179c..c043d8c 100644

[PATCH 05/11] staging: rtl8192e: Fix LINE_CONTINUATIONS warning

2015-03-29 Thread Mateusz Kulikowski
Fix 'Avoid unnecessary line continuations' checkpatch.pl warning Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtllib_softmac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softma

[PATCH 09/11] staging: rtl8192e: Divide rtllib_rx_auth()

2015-03-29 Thread Mateusz Kulikowski
Move authentication response processing to rtllib_rx_auth_resp() function. No logic is affected. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtllib_softmac.c | 112 -- 1 file changed, 58 insertions(+), 54 deletions(-) diff --git a/drivers/staging/r

[PATCH 10/11] staging: rtl8192e: Decrease nesting of rtllib_rx_auth_resp()

2015-03-29 Thread Mateusz Kulikowski
Return from rtllib_rx_auth_resp() if auth_parse() fails. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtllib_softmac.c | 89 --- 1 file changed, 45 insertions(+), 44 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/stag

[PATCH 07/11] staging: rtl8192e: Fix DO_WHILE_MACRO_WITH_TRAILING_SEMICOLON warning

2015-03-29 Thread Mateusz Kulikowski
Fix 'do {} while (0) macros should not be semicolon terminated' checkpatch.pl warning Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtllib_debug.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192e/rtllib_debug.h b/drivers/staging/rtl81

[PATCH 08/11] staging: rtl8192e: Fix PRINTK_WITHOUT_KERN_LEVEL warnings

2015-03-29 Thread Mateusz Kulikowski
Replace custom hex dumping function with print_hex_dump_bytes() to make checkpatch.pl happy Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtllib.h | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/

[PATCH 04/11] staging: rtl8192e: Fix UNNECESSARY_PARENTHESES warnings

2015-03-29 Thread Mateusz Kulikowski
Fix 'Unnecessary parentheses' checkpatch.pl warning Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 4 ++-- drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 12 ++-- drivers/staging/rtl8192e/rtllib_rx.c | 2 +- 3 files changed, 9 insertions(+)

[PATCH 03/11] staging: rtl8192e: remove unused EXPORT_SYMBOL_RSL macro

2015-03-29 Thread Mateusz Kulikowski
This macro caused checkpatch.pl warning and is not used. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtllib.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h index dc9f675..5363b6f 100644 --- a/driver

[PATCH 01/11] staging: rtl8192e: Fix UNNECESSARY_ELSE warning

2015-03-29 Thread Mateusz Kulikowski
Fix checkpatch warnings 'else is not generally useful after a break or return' Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 72 +++--- drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 10 +- drivers/staging/rtl8192e/rtl8192e/rtl_cam.c| 7 +- driv

[PATCH 02/11] staging: rtl8192e: Fix RETURN_VOID warnings

2015-03-29 Thread Mateusz Kulikowski
Fix 'void function return statements are not generally useful' checkpatch.pl warnings Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 2 -- drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 8 drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 7 -

[PATCH 00/11] staging: rtl8192e: checkpatch.pl cleanups

2015-03-29 Thread Mateusz Kulikowski
This series of patches cleans bunch of checkpatch.pl warnings. It should apply to staging-next (153fe946) and staging-testing (f8da055a). Patch 10 changes code/logic a bit (but behaviour should not change). Remaining patches are trivial. Smoke tested on rtl8192e card vs staging-next: - Module loa

Re: [PATCH net-next] hv_netvsc: remove vmbus_are_subchannels_present() in rndis_filter_device_add()

2015-03-29 Thread David Miller
From: Haiyang Zhang Date: Thu, 26 Mar 2015 16:20:58 -0700 > The vmbus_are_subchannels_present() also involves opening the channels, which > may be too early at this point. Checking for subchannels is not necessary > here. > So this patch removes it. Subchannels will be opened when offer messages

Re: [PATCH net-next] hv_netvsc: Implement batching in send buffer

2015-03-29 Thread David Miller
From: Haiyang Zhang Date: Thu, 26 Mar 2015 09:03:37 -0700 > With this patch, we can send out multiple RNDIS data packets in one send > buffer > slot and one VMBus message. It reduces the overhead associated with VMBus > messages. > > Signed-off-by: Haiyang Zhang > Reviewed-by: K. Y. Srinivasa

Re: [PATCH 62/86] staging/comedi: use uapi/linux/pci_ids.h directly

2015-03-29 Thread Ian Abbott
On 29/03/15 14:42, Michael S. Tsirkin wrote: Header moved from linux/pci_ids.h to uapi/linux/pci_ids.h, use the new header directly so we can drop the wrapper in include/linux/pci_ids.h. Signed-off-by: Michael S. Tsirkin --- drivers/staging/comedi/comedidev.h | 2 +- 1 file changed, 1 insert

Prezado usuário

2015-03-29 Thread WEBMASTER
Prezado usuário Seu e-mail excedeu 2 GB criado pelo webmaster, você está atualmente rodando a 2,30 GB, que não pode enviar ou receber mensagem nova dentro o próximo 24 horas até que você verificar que a conta de e-mail. Por favor, digite seus dados abaixo para verificar a sua conta: (1) e-mail:

Prezado usuário

2015-03-29 Thread WEBMASTER
Prezado usuário Seu e-mail excedeu 2 GB criado pelo webmaster, você está atualmente rodando a 2,30 GB, que não pode enviar ou receber mensagem nova dentro o próximo 24 horas até que você verificar que a conta de e-mail. Por favor, digite seus dados abaixo para verificar a sua conta: (1) e-mail:

[PATCH 85/86] staging/olpc: drop pci dependencies

2015-03-29 Thread Michael S. Tsirkin
This file does not use any pci APIs, drop pci header includes. Signed-off-by: Michael S. Tsirkin --- drivers/staging/olpc_dcon/olpc_dcon.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c b/drivers/staging/olpc_dcon/olpc_dcon.c index 1787cd7..d115f5c 10

[PATCH 63/86] staging/olpc: use uapi/linux/pci_ids.h directly

2015-03-29 Thread Michael S. Tsirkin
Header moved from linux/pci_ids.h to uapi/linux/pci_ids.h, use the new header directly so we can drop the wrapper in include/linux/pci_ids.h. Signed-off-by: Michael S. Tsirkin --- drivers/staging/olpc_dcon/olpc_dcon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/st

[PATCH 62/86] staging/comedi: use uapi/linux/pci_ids.h directly

2015-03-29 Thread Michael S. Tsirkin
Header moved from linux/pci_ids.h to uapi/linux/pci_ids.h, use the new header directly so we can drop the wrapper in include/linux/pci_ids.h. Signed-off-by: Michael S. Tsirkin --- drivers/staging/comedi/comedidev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/stagi

[PATCH 1/4] staging: rtl8712: Drop unneeded cast on netdev_priv

2015-03-29 Thread Julia Lawall
From: Julia Lawall The result of netdev_priv is already implicitly cast to the type of the left side of the assignment. The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // @@ type T; T *x; @@ x = - (T *) netdev_priv(...) // Signed-off-by: Julia Lawal

[PATCH 3/4] staging: ft1000: Drop unneeded cast on netdev_priv

2015-03-29 Thread Julia Lawall
From: Julia Lawall The result of netdev_priv is already implicitly cast to the type of the left side of the assignment. The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // @@ type T; T *x; @@ x = - (T *) netdev_priv(...) // Signed-off-by: Julia Lawal

Re: [PATCH] staging: speakup: Fix warning of line over 80 characters.

2015-03-29 Thread Richard Weinberger
Am 29.03.2015 um 01:26 schrieb Shirish Gajera: > Are you sure you want me to do this changes. Because it will conflict > the things written on http://kernelnewbies.org/ Conflict with what? Thanks, //richard ___ devel mailing list de...@linuxdriverprojec