Nice. Whenever you see a bug like this, you should report it to
kernel-janitors because you know that 10 other people have made the same
mistake.
I will take care of it.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http:/
On Mon, 14 Dec 2015, Nicholas Mc Guire wrote:
> On Thu, Dec 10, 2015 at 11:13:38AM -0500, Mike Marciniszyn wrote:
> > From: Easwar Hariharan
> >
> > A code inspection pointed out that kmalloc_array may return NULL and
> > memset doesn't check the input pointer for NULL, resulting in a possible
Possible off by one, but mostly the whitespace makes me itch.
Jim was not on the CC list.
On Thu, Dec 17, 2015 at 07:24:15PM -0500, Jubin John wrote:
> From: Jim Snow
>
> The link state will transition from ARMED to ACTIVE when a non-SC15
> packet arrives, but the driver might not notice the ch
From: Mitko Haralanov
The previous patch in the series added the free/invalidate
function bodies. Now, it's time for the programming side.
This large function takes the user's buffer, breaks it up
into manageable chunks, allocates enough RcvArray groups
and programs the chunks into the RcvArray
From: Mitko Haralanov
This commit "flips the switch" on the TID caching feature
implemented in this patch series.
As well as enabling the new feature by tying the new function
with the PSM API, it also cleans up the old unneeded code,
data structure members, and variables.
Due to difference in
From: Mitko Haralanov
TID caching will rely on the MMU notifier to be told
when memory is being invalidated. When the callback
is called, the driver will find all RcvArray entries
that span the invalidated buffer and "schedule" them
to be freed by the PSM library.
This function is currently unus
From: Mitko Haralanov
Up to now, the functions which cleared the programmed
TID entries and gave PSM the list of invalidated TID entries
were just stubs. With this commit, the bodies of these
functions are added.
This commit is a bit asymmetric as it only contains the
free code path. This is don
From: Mitko Haralanov
Functions added by this patch are building blocks for the upcoming
TID caching functionality. The functions added are currently unsed
(and marked as such.)
The functions' purposes are to find physically contigous pages in
the user's virtual buffer, program the RcvArray grou
From: Mitko Haralanov
The exp_lock lock does not need to be a spinlock as
all its uses are in process context and allowing the
process to sleep when the mutex is contended might
be benefitial.
Signed-off-by: Mitko Haralanov
Reviewed-by: Ira Weiny
---
drivers/staging/rdma/hfi1/file_ops.c | 12
From: Mitko Haralanov
The upcoming TID caching feature requires different data
structures and, by extension, different initialization for each
of the MPI processes.
The two new functions (currently unused) perform the required
initialization and freeing of required resources and structures.
Sig
From: Mitko Haralanov
Convert bit definitions to use BIT() macro as per checkpatch.pl
requirements.
Reviewed-by: Ira Weiny
Signed-off-by: Mitko Haralanov
---
include/uapi/rdma/hfi/hfi1_user.h | 56 +++
1 file changed, 28 insertions(+), 28 deletions(-)
diff
From: Mitko Haralanov
Add mmu notify helper functions and TID caching function
stubs in preparation for the TID caching implementation.
TID caching makes use of the MMU notifier to allow the driver
to respond to the user freeing memory which is allocated to
the HFI.
This patch implements the ba
From: Mitko Haralanov
In preparation for adding the TID caching support, there is a set
of headers, structures, and variables which will be needed. This
commit adds them to the hfi.h header file.
Signed-off-by: Mitko Haralanov
Reviewed-by: Ira Weiny
---
drivers/staging/rdma/hfi1/hfi.h | 20 ++
From: Mitko Haralanov
Definitions and functions use to manage sets of TID/RcvArray groups.
These will be used by the TID cacheline functionality coming with
later patches.
TID groups (or RcvArray groups) are groups of TID/RcvArray entries
organized in sets of 8 and aligned on cacheline boundarie
From: Mitko Haralanov
There is no need to use a separate variable for a
return value and a label when returning right away
would do just as well.
Signed-off-by: Mitko Haralanov
Reviewed-by: Ira Weiny
---
drivers/staging/rdma/hfi1/file_ops.c | 11 ---
1 file changed, 4 insertions(+), 7
From: Mitko Haralanov
TID caching will use a new event to signal userland that cache
invalidation has occurred and needs a matching command code that
will be used to read the invalidated TIDs.
Add the event bit and the new command to the exported header file.
The command is also added to the sw
From: Ira Weiny
Expected receives work by user-space libraries (PSM) calling into the driver
with information about the user's receive buffer and have the driver DMA-map
that buffer and program the HFI to receive data directly into it.
This is an expensive operation as it requires the driver to
From: Mitko Haralanov
The HFI1_CAP_TID_UNMAP comment was incorrectly implying the
opposite of what capability actually did. Correct this error.
Reviewed-by: Ira Weiny
Signed-off-by: Mitko Haralanov
---
include/uapi/rdma/hfi/hfi1_user.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
di
From: Jim Snow
The link state will transition from ARMED to ACTIVE when a non-SC15
packet arrives, but the driver might not notice the change. With this
fix, if the slowpath receive interrupt handler sees a non-SC15 packet
while in the ARMED state, we queue work to call linkstate_active_work
fro
From: Dean Luick
Remove an invalid sanity check that compares the local link
credits with the peer link credits. The two have no dependency
on each other.
Reviewed-by: Dennis Dalessandro
Signed-off-by: Dean Luick
Signed-off-by: Jubin John
---
drivers/staging/rdma/hfi1/chip.c |3 +--
1 f
Fix the spelling of user_credit_return_threshold, it was incorrectly
spelled as user_credit_return_theshold causing two module parameters,
one with typo, to be shown in modinfo
Reviewed-by: Ira Weiny
Reviewed-by: Mike Marciniszyn
Signed-off-by: Jubin John
---
drivers/staging/rdma/hfi1/init.c |
Add vendor and device attributes to VMBUS devices. These will be used
by Hyper-V tools as well user-level RDMA libraries that will use the
vendor/device tuple to discover the RDMA device.
Signed-off-by: K. Y. Srinivasan
---
Documentation/ABI/stable/sysfs-bus-vmbus | 14 ++
drivers/
On Thu, Dec 17, 2015 at 02:23:39PM +0300, Dan Carpenter wrote:
> On Thu, Dec 17, 2015 at 02:00:18AM -0500, ira.we...@intel.com wrote:
> > From: Mitko Haralanov
> > +static int unprogram_rcvarray(struct file *fp, u32 tidinfo,
> > + struct tid_group **grp)
> > +{
> > + stru
On Thu, Dec 17, 2015 at 03:06:45PM +0300, Dan Carpenter wrote:
> On Thu, Dec 17, 2015 at 02:00:23AM -0500, ira.we...@intel.com wrote:
> > + mutex_lock(&uctxt->exp_lock);
> > + /*
> > +* The first step is to program the RcvArray entries which are complete
> > +* groups.
> > +*/
> > +
On Thu, Dec 17, 2015 at 02:59:52PM +0300, Dan Carpenter wrote:
> On Thu, Dec 17, 2015 at 02:00:18AM -0500, ira.we...@intel.com wrote:
> > +}
> > +
> > +static int program_rcvarray(struct file *fp, unsigned long vaddr,
> > + struct tid_group *grp,
> > + st
This patch fixes following compiler warning:
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c: In function
‘RxReorderIndicatePacket’:
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c:758:1: warning: the
frame size of 1064 bytes is larger than 1024 bytes
[-Wframe-larger-than=]
It replaces the st
On 17/12/15 15:53, Moritz König wrote:
This patch fixes the format of comments in plx9080.h.
Signed-off-by: Moritz König
Signed-off-by: Fabian Lang
---
Changes since v1:
* moving comments that would wrap over 80 columns onto the previous line
* using the usual block comment style
drive
On 12/11/2015 05:11 AM, john.c.harri...@intel.com wrote:
> From: Maarten Lankhorst
>
> Debug output assumes all sync points are built on top of Android sync points
> and when we start creating them from dma-fences will NULL ptr deref unless
> taught about this.
>
> v4: Corrected patch ownership.
On 12/11/2015 05:11 AM, john.c.harri...@intel.com wrote:
> From: Maarten Lankhorst
>
> This allows users of dma fences to create a android fence.
>
> v2: Added kerneldoc. (Tvrtko Ursulin).
>
> v4: Updated comments from review feedback my Maarten.
>
> Signed-off-by: Maarten Lankhorst
> Signed-
This patch fixes the format of comments in plx9080.h.
Signed-off-by: Moritz König
Signed-off-by: Fabian Lang
---
Changes since v1:
* moving comments that would wrap over 80 columns onto the previous line
* using the usual block comment style
drivers/staging/comedi/drivers/plx9080.h | 122 ++
This patch makes plx9080.h use kernel types.
Signed-off-by: Moritz König
Signed-off-by: Fabian Lang
Reviewed-by: Ian Abbott
Acked-by: Moritz Fischer
---
drivers/staging/comedi/drivers/plx9080.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/
This patchset fixes all the warnings and legitimate checks of
checkpatch.pl in plx9080.h.
The following warnings were fixed:
* WARNING: Block comments use a trailing */ on a separate line
* WARNING: Block comments use * on subsequent lines
* WARNING: line over 80 characters
The following check
This patch adds spaces around binary operators in plx9080.h.
Signed-off-by: Moritz König
Signed-off-by: Fabian Lang
Reviewed-by: Ian Abbott
---
drivers/staging/comedi/drivers/plx9080.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/plx9080.h
I could have added myself... No need.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Thu, Dec 17, 2015 at 02:00:23AM -0500, ira.we...@intel.com wrote:
> + mutex_lock(&uctxt->exp_lock);
> + /*
> + * The first step is to program the RcvArray entries which are complete
> + * groups.
> + */
> + while (ngroups && uctxt->tid_group_list.count) {
> +
On Thu, Dec 17, 2015 at 02:00:18AM -0500, ira.we...@intel.com wrote:
> +}
> +
> +static int program_rcvarray(struct file *fp, unsigned long vaddr,
> + struct tid_group *grp,
> + struct tid_pageset *sets,
> + unsigned start, u16
On Thu, Dec 17, 2015 at 02:00:18AM -0500, ira.we...@intel.com wrote:
> From: Mitko Haralanov
> +static int unprogram_rcvarray(struct file *fp, u32 tidinfo,
> + struct tid_group **grp)
> +{
> + struct hfi1_filedata *fd = fp->private_data;
> + struct hfi1_ctxtdata *
Put a v3 in the subject.
There are still paths where this is not freed, so we need a v4. Take
your time, there is no rush.
> drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 15 ++-
> 1 file changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192u/ieee8
Become our Consumer report analyst. You will earn $200.00 per venture. You will
be paid for shopping and dining out. Your job will be to evaluate and comment
on customer service, undetected, in a wide variety of shops, stores,
restaurants and services in your area. Consumer report analyst are n
Hello
I apologize for the inconvenience that my mail could cause you. Indeed I am
French Monsieur Scaroni Roberto.
Following a faintness during which I went to the hospital recently, my DOCTOR
let me know that suffered from the pernicious evil.
The diagnosis revealed that I suffered from very a
40 matches
Mail list logo
