On Mon, Nov 14, 2016 at 12:20:40PM +0530, Punit Vara wrote:
> Replace all occurances of (1< ks7010_sdio.h to get rid of checkpatch.pl "CHECK" output "Prefer using
> BIT macro"
>
> Signed-off-by: Punit Vara
Why the odd indentation?
Same for the Subject: line, why the extr
Replace all occurances of (1<
---
drivers/staging/ks7010/ks7010_sdio.h | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/ks7010/ks7010_sdio.h
b/drivers/staging/ks7010/ks7010_sdio.h
index c89e570..197b4c0 100644
--- a/drivers/staging/ks701
Make suggested modification from checkpatch in reference
to: CHECK: No space is necessary after a cast
Signed-off-by: Walt Feasel
---
drivers/staging/xgifb/vb_util.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/xgifb/vb_util.h b/drivers/staging/xgifb/vb
Make suggested modification from checkpatch in reference
to: CHECK: spaces preferred around that '+'
Signed-off-by: Walt Feasel
---
drivers/staging/xgifb/vb_table.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/xgifb/vb_table.h b/drivers/staging/xgif
Make suggested modification from checkpatch in reference
to: CHECK: Please use a blank line after
function/struct/union/enum declarations
Signed-off-by: Walt Feasel
---
drivers/staging/xgifb/vb_table.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/xgifb/vb_table.h b/drivers
Make suggested modification from checkpatch in reference
to WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: Walt Feasel
---
drivers/staging/xgifb/vb_setmode.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/xgifb/vb_setmod
Make suggested modification from checkpatch in reference
to CHECK: Alignment should match open parenthesis
Signed-off-by: Walt Feasel
---
drivers/staging/xgifb/vb_setmode.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/xgifb/vb_setmo
Make suggested modification from checkpatch in reference
to CHECK: Alignment should match open parenthesis
Signed-off-by: Walt Feasel
---
drivers/staging/xgifb/vb_setmode.c | 35 +++
1 file changed, 15 insertions(+), 20 deletions(-)
diff --git a/drivers/staging/x
Make suggested modification from checkpatch in reference
to CHECK: Alignment should match open parenthesis
Signed-off-by: Walt Feasel
---
drivers/staging/xgifb/vb_setmode.c | 44 --
1 file changed, 23 insertions(+), 21 deletions(-)
diff --git a/drivers/stagin
Make suggested modification from checkpatch in reference
to CHECK: Alignment should match open parenthesis
Signed-off-by: Walt Feasel
---
drivers/staging/xgifb/vb_setmode.c | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/xgif
Make suggested modification from checkpatch in reference
to CHECK: Alignment should match open parenthesis
Signed-off-by: Walt Feasel
---
drivers/staging/xgifb/vb_setmode.c | 36 ++--
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/drivers/staging/
Make suggested modification from checkpatch in reference
to CHECK: Alignment should match open parenthesis
Signed-off-by: Walt Feasel
---
drivers/staging/xgifb/vb_setmode.c | 25 +
1 file changed, 13 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/xgifb/vb_se
Make suggested modification from checkpatch in reference
to CHECK: Alignment should match open parenthesis
Signed-off-by: Walt Feasel
---
drivers/staging/xgifb/vb_setmode.c | 28
1 file changed, 12 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/xgifb/vb
Make suggested modification from checkpatch in reference
to CHECK: Alignment should match open parenthesis
Signed-off-by: Walt Feasel
---
drivers/staging/xgifb/vb_setmode.c | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/xgifb/
Make suggested modification from checkpatch in reference
to CHECK: Alignment should match open parenthesis
Signed-off-by: Walt Feasel
---
drivers/staging/xgifb/vb_setmode.c | 29 +++--
1 file changed, 15 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/xgifb/v
Make suggested modification from checkpatch in reference
to CHECK: No space is necessary after a cast
Signed-off-by: Walt Feasel
---
drivers/staging/xgifb/vb_setmode.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/xgifb/vb_setmode.c
b
Make suggested modification from checkpatch in reference
to CHECK: No space is necessary after a cast
Signed-off-by: Walt Feasel
---
drivers/staging/xgifb/vb_setmode.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/xgifb/vb_setmode.
Make suggested modification from checkpatch in reference
to CHECK: No space is necessary after a cast
Signed-off-by: Walt Feasel
---
drivers/staging/xgifb/vb_setmode.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/xgifb/vb_setmode.c
b/drive
Make suggested modification from checkpatch in reference
to CHECK: No space is necessary after a cast
Signed-off-by: Walt Feasel
---
drivers/staging/xgifb/vb_setmode.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/xgifb/vb_setmode.c
b/dri
Make suggested modification from checkpatch in reference
to CHECK: No space is necessary after a cast
Signed-off-by: Walt Feasel
---
drivers/staging/xgifb/vb_setmode.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/xgifb/vb_setmode.c
b/dri
Make suggested modification from checkpatch in reference
to CHECK: No space is necessary after a cast
Signed-off-by: Walt Feasel
---
drivers/staging/xgifb/vb_setmode.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/xgifb/vb_setmode.c
Make suggested modification from checkpatch in reference
to CHECK: No space is necessary after a cast
Signed-off-by: Walt Feasel
---
drivers/staging/xgifb/vb_setmode.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/xgifb/vb_setmode.c
b/dri
Make suggested modification from checkpatch in reference
to CHECK: Logical continuations should be on the previous line
Signed-off-by: Walt Feasel
---
drivers/staging/xgifb/vb_setmode.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/xgifb/vb_setmode.c
b/
Make suggested modification from checkpatch in reference
to CHECK: spaces preferred around that '+'
Signed-off-by: Walt Feasel
---
drivers/staging/xgifb/vb_setmode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/xgifb/vb_setmode.c
b/drivers/staging/xgifb/vb
Make spelling correction for 'vertical'
Signed-off-by: Walt Feasel
---
drivers/staging/xgifb/vb_setmode.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/xgifb/vb_setmode.c
b/drivers/staging/xgifb/vb_setmode.c
index 6467d96..1655d3a 100644
--- a/drivers/s
Make spelling corrections for 'correctly' and
'unregister'.
Signed-off-by: Walt Feasel
---
Removed the previously submitted U.S. spelling for
'initialise' to keep the correct U.K. spelling.
drivers/staging/vme/devices/vme_user.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff
On 11/13/16 15:16, Walt Feasel wrote:
> Make spelling corrections for 'initialize', 'correctly'
> and 'unregister'
>
> Signed-off-by: Walt Feasel
> ---
> drivers/staging/vme/devices/vme_user.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/vme/d
Make suggested modifications from checkpatch in reference
to: CHECK: Logical continuations should be on the previous line
Signed-off-by: Walt Feasel
---
drivers/staging/xgifb/vb_init.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/xgifb/vb_init.c b/driv
Make suggested modifications from checkpatch in reference
to: Alignment should match open parenthesis
Signed-off-by: Walt Feasel
---
drivers/staging/xgifb/vb_init.c | 24 +---
1 file changed, 13 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/xgifb/vb_init.c b/dr
Make spelling corrections for 'initialize', 'correctly'
and 'unregister'
Signed-off-by: Walt Feasel
---
drivers/staging/vme/devices/vme_user.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/vme/devices/vme_user.c
b/drivers/staging/vme/devices/vme_use
> +static const char slic_stats_strings[][ETH_GSTRING_LEN] = {
> + "rx_packets ",
> + "rx_bytes ",
> + "rx_multicasts ",
> + "rx_errors ",
> + "rx_buff_miss ",
> + "rx_tp_csum ",
> + "rx_tp_oflow",
> + "rx_tp_hlen ",
> + "rx_ip_csum
On Sun, Nov 13, 2016 at 12:57:25PM +, Jonathan Cameron wrote:
> On 12/11/16 18:19, Brian Masney wrote:
> > Move tsl2580, tsl2581, tsl2583 driver out of staging into mainline.
> >
> > Signed-off-by: Brian Masney
> I had another read through on this one. A few oddites.
>
> I fixed up the inde
On 12/11/16 18:19, Brian Masney wrote:
> Move tsl2580, tsl2581, tsl2583 driver out of staging into mainline.
>
> Signed-off-by: Brian Masney
I had another read through on this one. A few oddites.
I fixed up the indentation one way back in your patch fixing alignment.
Made applying this patch mo
On 12/11/16 18:19, Brian Masney wrote:
> Add Brian Masney's copyright to the header and to the MODULE_AUTHOR
> for all of the staging cleanups that has been done to this driver.
>
> The original MODULE_AUTHOR() did not have a space between his name and
> email address. This patch also adds the mis
On 12/11/16 18:19, Brian Masney wrote:
> The ret variable in tsl2583_suspend() and tsl2583_resume() was
> initialized to 0. This is not necessary so this patch removes the
> initialization.
>
> Signed-off-by: Brian Masney
Applied.
> ---
> drivers/staging/iio/light/tsl2583.c | 4 ++--
> 1 file ch
On 12/11/16 18:19, Brian Masney wrote:
> The entries in the lux table (als_device_lux) can be updated via sysfs
> through the function in_illuminance_lux_table_store(). The last row in
> the table must be terminated with values that are zero. The sysfs code
> already ensures that the last row is al
On 12/11/16 18:19, Brian Masney wrote:
> The comment that describes the code that clears the interrupt bit was
> vague and didn't provide much value. This patch adds more detail about
> why that bit needs to be cleared.
>
> Signed-off-by: Brian Masney
Applied.
> ---
> drivers/staging/iio/light/t
On 12/11/16 18:19, Brian Masney wrote:
> The comment for tsl2583_probe() does not provide any useful value.
> This patch removes the comment.
>
> Signed-off-by: Brian Masney
Applied
> ---
> drivers/staging/iio/light/tsl2583.c | 4
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/
On 12/11/16 18:19, Brian Masney wrote:
> The header only listed the tsl2580 and tsl2581 devices as supported by
> this driver. This patch adds the tsl2583 since it is also supported by
> this driver.
>
> Signed-off-by: Brian Masney
Applied.
> ---
> drivers/staging/iio/light/tsl2583.c | 2 +-
> 1
On 12/11/16 18:19, Brian Masney wrote:
> The driver contains a global lux table that can be updated via sysfs.
> Change this to a per device lux table so that multiple devices can be
> hooked up to the same system with different lux tables.
>
> There are 10 entries, plus 1 for the termination segm
On 12/11/16 18:19, Brian Masney wrote:
> in_illuminance_lux_table_store assumes that an unsigned int is 32 bits.
> Replace this with sizeof(value[1]).
>
> Signed-off-by: Brian Masney
Applied.
> ---
> drivers/staging/iio/light/tsl2583.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
On 12/11/16 18:19, Brian Masney wrote:
> in_illuminance_lux_table_store() contains some unnecessary parentheses.
> This patch removes them since they provide no value.
>
> Signed-off-by: Brian Masney
Applied.
> ---
> drivers/staging/iio/light/tsl2583.c | 4 ++--
> 1 file changed, 2 insertions(+)
On 12/11/16 18:19, Brian Masney wrote:
> tsl2583_als_calibrate() returns the newly computed gain_trim if the
> calibration was successful. This function is only called by
> in_illuminance_calibrate_store() and the return value inside that
> sysfs attribute is only checked to see if an error was ret
On 12/11/16 18:19, Brian Masney wrote:
> The check for ch1lux > ch0lux inside tsl2583_get_lux is only valid if
> the ratio is not equal to zero. Move the code block inside the else
> statement. This does away with the need to initialize the variables to
> zero.
>
> Signed-off-by: Brian Masney
App
On 12/11/16 18:19, Brian Masney wrote:
> If channel 0 does not have any data, then the code sets the lux to zero.
> The corresponding comment says that the last value is returned. This
> updates the comment to correctly reflect what the code does. It also
> clarifies the comment about why 0 is retu
On 12/11/16 18:19, Brian Masney wrote:
> The definition of the tsl2583_device_lux struct has a series of single
> line comments. There are two other cases where the multiline comments
> did not have an initial blank line. Change these comments to use the
> proper multiline syntax.
>
> Signed-off-b
On 12/11/16 18:19, Brian Masney wrote:
> There are two separate files describing the tsl2583 sysfs attributes.
> Combine the two files into one. Updated the name of the sysfs attributes
> to match the current ABI.
>
> Signed-off-by: Brian Masney
> Suggested-by: Peter Meerwald-Stadler
Applied.
>
On 12/11/16 18:19, Brian Masney wrote:
> Add and remove newlines to improve code readability in preparation for
> moving the driver out of staging.
>
> Signed-off-by: Brian Masney
Applied
> ---
> drivers/staging/iio/light/tsl2583.c | 14 --
> 1 file changed, 12 insertions(+), 2 delet
On 12/11/16 18:19, Brian Masney wrote:
> Fixed warning found by make W=2:
>
> warning: comparison between signed and unsigned integer expressions
> [-Wsign-compare]
>
> Signed-off-by: Brian Masney
Applied.
> ---
> drivers/staging/iio/light/tsl2583.c | 7 ---
> 1 file changed, 4 insertions(+
On 12/11/16 18:19, Brian Masney wrote:
> Most of the values in the #defines have their values aligned on a single
> column, but some do not. This changes the remaining defines to use
> consistent alignment with the majority to improve code readability.
>
> Signed-off-by: Brian Masney
Applied.
> -
On 12/11/16 18:19, Brian Masney wrote:
> Some functions and variables were prefixed with either taos, tsl258x,
> taos2583, or tsl2583. Change everything to use the tsl2583 prefix since
> that is the name of the .c file. The taos_settings member inside the
> taos_settings struct was renamed to als_s
On 12/11/16 18:19, Brian Masney wrote:
> There are several places in the code where the function name is
> hardcoded in the log message. Use the __func__ constant string to build
> the log message. This also clarifies some of the error messages to match
> the code and ensures that the correct prior
On 12/11/16 18:19, Brian Masney wrote:
> Address warning from checkpatch:
>
> CHECK: Do not include the paragraph about writing to the Free Software
> Foundation's mailing address from the sample GPL notice. The FSF has
> changed addresses in the past, and may do so again. Linux already
> includes
On 12/11/16 18:19, Brian Masney wrote:
> taos_probe() calls i2c_smbus_write_byte() to select the control
> register, however there are no subsequent calls to
> i2c_smbus_read_byte(). The write call is unnecessary and is removed by
> this patch.
>
> Verified that the driver still functions correctl
On 12/11/16 18:19, Brian Masney wrote:
> The current chip state is represented as a tristate (working, suspended,
> and unknown). The unknown state was not used. This patch changes the
> chip state so that it is now represented as a single boolean value
> (suspended).
>
> Signed-off-by: Brian Masn
On 12/11/16 18:19, Brian Masney wrote:
> The device probing and the suspend/resume code checks a flag internal to
> the driver that determines whether or not the chip is in a working
> state. These checks are not needed. This patch removes the unnecessary
> checks. It will do no harm to the hardwar
On 12/11/16 18:19, Brian Masney wrote:
> in_illuminance_calibrate_store() did not check to see if the chip is
> in a working state. This patch adds the proper check. The return value
> from taos_als_calibrate() was also not checked in this function, so the
> proper check was also added while change
On 12/11/16 18:19, Brian Masney wrote:
> taos_get_lux checks to see if the chip is in a working state. This
> check is not necessary since it is only called from tsl2583_read_raw
> and in_illuminance_calibrate_store (via taos_als_calibrate). The chip
> state is already checked by these functions.
>
On Fri, Nov 11, 2016 at 12:19:05PM +0900, Masahiro Yamada wrote:
> 2016-11-10 22:35 GMT+09:00 Greg Kroah-Hartman :
> > On Thu, Nov 10, 2016 at 10:24:21PM +0900, Masahiro Yamada wrote:
> >>
> >> sdhci_alloc_host() returns an error pointer when it fails.
> >> but mmc_alloc_host() cannot.
> >>
> >> Th
The following changes since commit a909d3e636995ba7c349e2ca5dbb528154d4ac30:
Linux 4.9-rc3 (2016-10-29 13:52:02 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/
tags/staging-4.9-rc5
for you to fetch changes up to d70674eeaa5ef
Hi Lino,
[auto build test ERROR on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Lino-Sanfilippo/net-ethernet-slicoss-add-slicoss-gigabit-ethernet-driver/20161113-125131
config: powerpc-allyesconfig (attached as .config)
compiler: powerpc64-linux-gnu-gcc (Debian 6.1.1-9
61 matches
Mail list logo
