RE: [PATCH 11/29] drivers, media: convert cx88_core.refcount from atomic_t to refcount_t

2017-03-06 Thread Reshetova, Elena
> Hello. > > On 03/06/2017 05:20 PM, Elena Reshetova wrote: > > > refcount_t type and corresponding API should be > > used instead of atomic_t when the variable is used as > > a reference counter. This allows to avoid accidental > > refcounter overflows that might lead to use-after-free > > situa

RE: [PATCH 21/29] drivers, s390: convert fc_fcp_pkt.ref_cnt from atomic_t to refcount_t

2017-03-06 Thread Reshetova, Elena
> On 03/06/2017 03:21 PM, Elena Reshetova wrote: > > refcount_t type and corresponding API should be > > used instead of atomic_t when the variable is used as > > a reference counter. This allows to avoid accidental > > refcounter overflows that might lead to use-after-free > > situations. > > The

[PATCH] staging: rtl8192e: fix coding style issue, improve error handling

2017-03-06 Thread Suniel Mahesh
Fix coding style issue and comments in rtl_core.c Return -ENOMEM, if it is out of memory Pointer comparison with NULL replaced by logical NOT Signed-off-by: Suniel Mahesh --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 253 +++ 1 file changed, 100 insertions(+), 153 de

[PATCH 4/4] staging: dgnc: remove item from TODO list

2017-03-06 Thread Tobin C. Harding
TODO file contains task to verify and correct function return sites. Need to check for and implement correct usage of goto's when there is work to be done before returning. Remove task from TODO list after already having completed audit of directory drivers/staging/dgnc. Signed-off-by: Tobin C.

[PATCH 2/4] staging: dgnc: audit goto's in dgnc_mgmt

2017-03-06 Thread Tobin C. Harding
TODO file requests fix up of error handling. Audit dgnc_mgmt.c and fix all return paths to be uniform and inline with kernel coding style. Signed-off-by: Tobin C. Harding --- drivers/staging/dgnc/dgnc_mgmt.c | 37 - 1 file changed, 20 insertions(+), 17 deleti

[PATCH 1/4] staging: dgnc: audit goto's in dgnc_driver

2017-03-06 Thread Tobin C. Harding
TODO file requests fix up of error handling. Audit dgnc_driver.c and fix all return paths to be uniform and inline with kernel coding style. Signed-off-by: Tobin C. Harding --- drivers/staging/dgnc/dgnc_driver.c | 27 +++ 1 file changed, 7 insertions(+), 20 deletions(-)

[PATCH 0/4] staging: dgnc: remove goto task from TODO list

2017-03-06 Thread Tobin C. Harding
TODO file contains task to verify and correct function return sites. Need to check for and implement correct usage of goto's when there is work to be done before returning. Patch series is broken up by file to ease review. Perhaps a single patch would have been more appropriate. Changes to dgnc_m

[PATCH 3/4] staging: dgnc: audit goto's in dgnc_tty

2017-03-06 Thread Tobin C. Harding
TODO file requests fix up of error handling. Audit dgnc_mgmt.c and fix all return paths to be uniform and inline with kernel coding style. Signed-off-by: Tobin C. Harding --- drivers/staging/dgnc/dgnc_tty.c | 219 1 file changed, 112 insertions(+), 107 d

Re: [PATCH] staging: vc04_services: open brace code style fix

2017-03-06 Thread Greg KH
On Sun, Mar 05, 2017 at 04:24:43PM +1100, Sergiy Redko wrote: > This fixes an error found by checkpatch about the open > brace not being on the same line as if statement. > It also adds a missing blank like to fix another > checkpatch warning. > > Signed-off-by: Sergiy Redko > --- > drivers/sta

Re: [lustre-devel] [PATCH] staging: lustre: fix sparse warning about different address spaces

2017-03-06 Thread Oleg Drokin
On Mar 1, 2017, at 6:57 PM, Mario Bambagini wrote: > fixed the following sparse warning by adding proper cast: > drivers/staging//lustre/lustre/obdclass/obd_config.c:1055:74: warning: > incorrect type in argument 2 (different address spaces) > drivers/staging//lustre/lustre/obdclass/obd_config.c

Re: [PATCH 2/2] staging: comedi: cb_pcidas64: refactor relocated code

2017-03-06 Thread Tobin C. Harding
On Tue, Feb 28, 2017 at 02:36:25PM +, Ian Abbott wrote: > On 27/02/17 21:08, Tobin C. Harding wrote: > >Code was moved to a separate function in a previous patch. Code > >structure wast maintained to ease review. Code may now be refactored > >to ease reading. > > > >Move multi-line dereference

[PATCH] staging: comedi: cb_pcidas64: move loop invariant

2017-03-06 Thread Tobin C. Harding
Loop invariant is inside the loop so code checks invariant on each iteration of the loop. Invariant can be moved outside of the loop so it is only checked once. Move loop invariant outside of for loop. Signed-off-by: Tobin C. Harding --- drivers/staging/comedi/drivers/cb_pcidas64.c | 4 ++-- 1

Re: [RFC PATCH v2 04/32] KVM: SVM: Add SEV feature definitions to KVM

2017-03-06 Thread Borislav Petkov
On Thu, Mar 02, 2017 at 10:12:48AM -0500, Brijesh Singh wrote: > From: Tom Lendacky > > Define a new KVM CPU feature for Secure Encrypted Virtualization (SEV). > The kernel will check for the presence of this feature to determine if > it is running with SEV active. > > Define the SEV enable bit

Re: [RFC PATCH v2 06/32] x86/pci: Use memremap when walking setup data

2017-03-06 Thread Bjorn Helgaas
On Fri, Mar 03, 2017 at 03:15:34PM -0600, Tom Lendacky wrote: > On 3/3/2017 2:42 PM, Bjorn Helgaas wrote: > >On Thu, Mar 02, 2017 at 10:13:10AM -0500, Brijesh Singh wrote: > >>From: Tom Lendacky > >> > >>The use of ioremap will force the setup data to be mapped decrypted even > >>though setup data

[PATCH 0/3] clean up ks_sdio_interrupt()

2017-03-06 Thread Tobin C. Harding
Checkpatch emits various warnings relating to function ks_sdio_interrupt(). Function is deeply nested. First reduce the indentation. Next make some whitespace changes, refactoring in line with kernel coding style. Lastly add an additional goto target, removing internal return's and clearing three

[PATCH 3/3] staging: ks7010: add additional goto target

2017-03-06 Thread Tobin C. Harding
Function contains multiple return sites. Function already contains a goto target that makes a function call before returning, the same function is called (with different arguments) before returning at an internal location. It would be clearer if both functions were called at the same place and labe

[PATCH 1/3] staging: ks7010: remove one level of indentation

2017-03-06 Thread Tobin C. Harding
Function ks_sdio_interrupt() is deeply nested. One level of indentation may be removed by inverting an 'if' statement conditional. Body of statement makes up the bulk of the function. Goto can be used to return early from function. It is not necessary to alter the function logic. Once completed, th

[PATCH 2/3] staging: ks7010: make whitespace changes

2017-03-06 Thread Tobin C. Harding
Function ks_sdio_interrupt may be refactored after previous patch reduced the level of indentation in the function. Refactor function inline with kernel coding style. Make only white space changes. Do not alter the program logic. Signed-off-by: Tobin C. Harding --- drivers/staging/ks7010/ks7010

Re: [PATCH 17/29] drivers, pci: convert hv_pci_dev.refs from atomic_t to refcount_t

2017-03-06 Thread Bjorn Helgaas
[+cc Hyper-V folks, -cc others] On Mon, Mar 06, 2017 at 04:21:04PM +0200, Elena Reshetova wrote: > refcount_t type and corresponding API should be > used instead of atomic_t when the variable is used as > a reference counter. This allows to avoid accidental > refcounter overflows that might lead t

[PATCH] staging: wilc1000: Fix sparse warnings incorrect type assignment

2017-03-06 Thread Andrea Ghittino
Fixed sparse warnings drivers/staging/wilc1000//wilc_wfi_cfgoperations.c:2011:52: warning: incorrect type in assignment (different base types) drivers/staging/wilc1000//wilc_wfi_cfgoperations.c:2011:52:expected unsigned short [unsigned] [assigned] [usertype] ht_ext_params drivers/staging/wilc

Re: [RFC PATCH v2 01/32] x86: Add the Secure Encrypted Virtualization CPU feature

2017-03-06 Thread Borislav Petkov
On Mon, Mar 06, 2017 at 01:11:03PM -0500, Brijesh Singh wrote: > Sending it through stg mail to avoid line wrapping. Please let me know if > something > is still messed up. I have tried applying it and it seems to apply okay. Yep, thanks. -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix

Re: [PATCH 1/3] staging: sm750fb: fixes add blank line after function/struct/union/enum declarations

2017-03-06 Thread Geert Uytterhoeven
Hi Arushi, On Sun, Mar 5, 2017 at 12:24 PM, Arushi Singhal wrote: > This patch fixes the warnings reported by checkpatch.pl > for please use a blank line after function/struct/union/enum > declarations. > > Signed-off-by: Arushi Singhal > --- > drivers/staging/sm750fb/ddk750_display.h | 1 + >

[PATCH] staging: vchiq_utils: Don't include headers twice

2017-03-06 Thread Stefan Wahren
There is no need to include types.h and vmalloc.h twice. This issue has been found by make includecheck. Signed-off-by: Stefan Wahren --- .../vc04_services/interface/vchiq_arm/vchiq_util.h |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/

Re: [RFC PATCH 06/12] staging: android: ion: Remove crufty cache support

2017-03-06 Thread Laura Abbott
On 03/06/2017 09:00 AM, Emil Velikov wrote: > On 6 March 2017 at 10:29, Daniel Vetter wrote: >> On Fri, Mar 03, 2017 at 10:46:03AM -0800, Laura Abbott wrote: >>> On 03/03/2017 08:39 AM, Laurent Pinchart wrote: Hi Daniel, On Friday 03 Mar 2017 10:56:54 Daniel Vetter wrote: > On T

[PATCH 1/1] Fix coding style errors

2017-03-06 Thread Elia Geretto
This patch fixes two conding style errors, reported by the checkpatch script. Signed-off-by: Elia Geretto --- drivers/staging/rtl8192u/r8192U_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_c

Re: [RFC PATCH 10/12] staging: android: ion: Use CMA APIs directly

2017-03-06 Thread Laura Abbott
On 03/06/2017 07:52 AM, Daniel Vetter wrote: > On Mon, Mar 06, 2017 at 03:43:53PM +0200, Laurent Pinchart wrote: >> Hi Daniel, >> >> On Monday 06 Mar 2017 11:32:04 Daniel Vetter wrote: >>> On Fri, Mar 03, 2017 at 10:50:20AM -0800, Laura Abbott wrote: On 03/03/2017 08:41 AM, Laurent Pinchart wr

Re: [PATCH 5/5] staging: lustre: osc_page.c: Use list_for_each_entry_safe

2017-03-06 Thread SIMRAN SINGHAL
On Mon, Mar 6, 2017 at 8:50 PM, James Simmons wrote: > >> Doubly linked lists which are iterated using list_empty >> and list_entry macros have been replaced with list_for_each_entry_safe >> macro. >> This makes the iteration simpler and more readable. >> >> This patch replaces the while loop co

Re: [RFC PATCH v2 01/32] x86: Add the Secure Encrypted Virtualization CPU feature

2017-03-06 Thread Brijesh Singh
On 03/04/2017 04:11 AM, Borislav Petkov wrote: > On Fri, Mar 03, 2017 at 03:01:23PM -0600, Brijesh Singh wrote: > > This looks like a wraparound... > > $ test-apply.sh /tmp/brijesh.singh.delta > checking file Documentation/admin-guide/kernel-parameters.txt > Hunk #1 succeeded at 2144 (offset -9 l

Re: [RFC PATCH 06/12] staging: android: ion: Remove crufty cache support

2017-03-06 Thread Emil Velikov
On 6 March 2017 at 10:29, Daniel Vetter wrote: > On Fri, Mar 03, 2017 at 10:46:03AM -0800, Laura Abbott wrote: >> On 03/03/2017 08:39 AM, Laurent Pinchart wrote: >> > Hi Daniel, >> > >> > On Friday 03 Mar 2017 10:56:54 Daniel Vetter wrote: >> >> On Thu, Mar 02, 2017 at 01:44:38PM -0800, Laura Abbo

Re: [Xen-devel] [PATCH 29/29] drivers, xen: convert grant_map.users from atomic_t to refcount_t

2017-03-06 Thread Boris Ostrovsky
On 03/06/2017 09:21 AM, Elena Reshetova wrote: > refcount_t type and corresponding API should be > used instead of atomic_t when the variable is used as > a reference counter. This allows to avoid accidental > refcounter overflows that might lead to use-after-free > situations. > > Signed-off-by: E

Re: [PATCH 21/29] drivers, s390: convert fc_fcp_pkt.ref_cnt from atomic_t to refcount_t

2017-03-06 Thread Benjamin Block
On Mon, Mar 06, 2017 at 04:27:11PM +0100, Johannes Thumshirn wrote: > On 03/06/2017 03:21 PM, Elena Reshetova wrote: > > refcount_t type and corresponding API should be > > used instead of atomic_t when the variable is used as > > a reference counter. This allows to avoid accidental > > refcounter

Re: [PATCH 11/29] drivers, media: convert cx88_core.refcount from atomic_t to refcount_t

2017-03-06 Thread Sergei Shtylyov
Hello. On 03/06/2017 05:20 PM, Elena Reshetova wrote: refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Ele

Re: [RESEND PATCH V4] staging: vchiq_arm: Add compatibility wrappers for ioctls

2017-03-06 Thread Michael Zoran
On Mon, 2017-03-06 at 17:11 +0100, Stefan Wahren wrote: > Am 06.03.2017 um 16:57 schrieb Michael Zoran: > > On Mon, 2017-03-06 at 14:01 +0100, Greg KH wrote: > > > On Sat, Mar 04, 2017 at 06:57:50AM -0800, Michael Zoran wrote: > > > > On Sat, 2017-03-04 at 14:58 +0300, Dan Carpenter wrote: > > > >

Re: [RESEND PATCH V4] staging: vchiq_arm: Add compatibility wrappers for ioctls

2017-03-06 Thread Stefan Wahren
Am 06.03.2017 um 16:57 schrieb Michael Zoran: > On Mon, 2017-03-06 at 14:01 +0100, Greg KH wrote: >> On Sat, Mar 04, 2017 at 06:57:50AM -0800, Michael Zoran wrote: >>> On Sat, 2017-03-04 at 14:58 +0300, Dan Carpenter wrote: On Wed, Mar 01, 2017 at 07:41:46PM -0800, Michael Zoran wrote: > C

Re: [RESEND PATCH V4] staging: vchiq_arm: Add compatibility wrappers for ioctls

2017-03-06 Thread Michael Zoran
On Mon, 2017-03-06 at 18:22 +0300, Dan Carpenter wrote: > > + > > +struct vchiq_completion_data32 { > > + VCHIQ_REASON_T reason; > > + compat_uptr_t header; > > + compat_uptr_t service_userdata; > > + compat_uptr_t bulk_userdata; > > +}; > > + > > +struct vchiq_await_completion32 { > > +

Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging

2017-03-06 Thread Daniel Vetter
On Mon, Mar 06, 2017 at 11:58:05AM +0100, Mark Brown wrote: > On Mon, Mar 06, 2017 at 11:40:41AM +0100, Daniel Vetter wrote: > > > No one gave a thing about android in upstream, so Greg KH just dumped it > > all into staging/android/. We've discussed ION a bunch of times, recorded > > anything we'

Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging

2017-03-06 Thread Daniel Vetter
On Mon, Mar 06, 2017 at 05:02:05PM +0200, Laurent Pinchart wrote: > Hi Daniel, > > On Monday 06 Mar 2017 11:38:20 Daniel Vetter wrote: > > On Fri, Mar 03, 2017 at 06:45:40PM +0200, Laurent Pinchart wrote: > > > - I haven't seen any proposal how a heap-based solution could be used in a > > > generi

Re: [RESEND PATCH V4] staging: vchiq_arm: Add compatibility wrappers for ioctls

2017-03-06 Thread Michael Zoran
On Mon, 2017-03-06 at 14:01 +0100, Greg KH wrote: > On Sat, Mar 04, 2017 at 06:57:50AM -0800, Michael Zoran wrote: > > On Sat, 2017-03-04 at 14:58 +0300, Dan Carpenter wrote: > > > On Wed, Mar 01, 2017 at 07:41:46PM -0800, Michael Zoran wrote: > > > > Changes: > > > > V1 - Complete rewrite

Re: [RFC PATCH 10/12] staging: android: ion: Use CMA APIs directly

2017-03-06 Thread Daniel Vetter
On Mon, Mar 06, 2017 at 03:43:53PM +0200, Laurent Pinchart wrote: > Hi Daniel, > > On Monday 06 Mar 2017 11:32:04 Daniel Vetter wrote: > > On Fri, Mar 03, 2017 at 10:50:20AM -0800, Laura Abbott wrote: > > > On 03/03/2017 08:41 AM, Laurent Pinchart wrote: > > >> On Thursday 02 Mar 2017 13:44:42 Lau

Re: [PATCH 21/29] drivers, s390: convert fc_fcp_pkt.ref_cnt from atomic_t to refcount_t

2017-03-06 Thread Johannes Thumshirn
On 03/06/2017 03:21 PM, Elena Reshetova wrote: > refcount_t type and corresponding API should be > used instead of atomic_t when the variable is used as > a reference counter. This allows to avoid accidental > refcounter overflows that might lead to use-after-free > situations. The subject is wron

Re: [PATCH] Staging: media: platform: bcm2835 - Style fix

2017-03-06 Thread Dan Carpenter
On Sun, Mar 05, 2017 at 10:43:19AM +1300, Derek Robson wrote: > On Sat, Mar 04, 2017 at 02:57:22PM +0300, Dan Carpenter wrote: > > Copy a patch prefix that everyone else has been using: > > > > git log --oneline drivers/staging/media/platform/bcm2835/ > > > > The subject is too vague as well. >

Re: [RESEND PATCH V4] staging: vchiq_arm: Add compatibility wrappers for ioctls

2017-03-06 Thread Dan Carpenter
On Wed, Mar 01, 2017 at 07:41:46PM -0800, Michael Zoran wrote: > This patch adds compatibility wrappers for the ioctls > exposed by vchiq/vc04_services. The compat ioctls are > completely implemented on top of the native ioctls. No > existing lines are modified. > > While the ideal approach woul

Re: [PATCH 5/5] staging: lustre: osc_page.c: Use list_for_each_entry_safe

2017-03-06 Thread James Simmons
> Doubly linked lists which are iterated using list_empty > and list_entry macros have been replaced with list_for_each_entry_safe > macro. > This makes the iteration simpler and more readable. > > This patch replaces the while loop containing list_empty and list_entry > with list_for_each_entr

Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging

2017-03-06 Thread Laurent Pinchart
Hi Daniel, On Monday 06 Mar 2017 11:38:20 Daniel Vetter wrote: > On Fri, Mar 03, 2017 at 06:45:40PM +0200, Laurent Pinchart wrote: > > - I haven't seen any proposal how a heap-based solution could be used in a > > generic distribution. This needs to be figured out before committing to > > any API/

[PATCH 28/29] drivers: convert sbd_duart.map_guard from atomic_t to refcount_t

2017-03-06 Thread Elena Reshetova
refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena Reshetova Signed-off-by: Hans Liljestrand Signed-off-

[PATCH 26/29] drivers, usb: convert dev_data.count from atomic_t to refcount_t

2017-03-06 Thread Elena Reshetova
refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena Reshetova Signed-off-by: Hans Liljestrand Signed-off-

[PATCH 29/29] drivers, xen: convert grant_map.users from atomic_t to refcount_t

2017-03-06 Thread Elena Reshetova
refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena Reshetova Signed-off-by: Hans Liljestrand Signed-off-

[PATCH 27/29] drivers, usb: convert ep_data.count from atomic_t to refcount_t

2017-03-06 Thread Elena Reshetova
refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena Reshetova Signed-off-by: Hans Liljestrand Signed-off-

[PATCH 25/29] drivers, usb: convert ffs_data.ref from atomic_t to refcount_t

2017-03-06 Thread Elena Reshetova
refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena Reshetova Signed-off-by: Hans Liljestrand Signed-off-

[PATCH 23/29] drivers: convert vme_user_vma_priv.refcnt from atomic_t to refcount_t

2017-03-06 Thread Elena Reshetova
refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena Reshetova Signed-off-by: Hans Liljestrand Signed-off-

[PATCH 24/29] drivers: convert iblock_req.pending from atomic_t to refcount_t

2017-03-06 Thread Elena Reshetova
refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena Reshetova Signed-off-by: Hans Liljestrand Signed-off-

[PATCH 22/29] drivers, scsi: convert iscsi_task.refcount from atomic_t to refcount_t

2017-03-06 Thread Elena Reshetova
refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena Reshetova Signed-off-by: Hans Liljestrand Signed-off-

[PATCH 21/29] drivers, s390: convert fc_fcp_pkt.ref_cnt from atomic_t to refcount_t

2017-03-06 Thread Elena Reshetova
refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena Reshetova Signed-off-by: Hans Liljestrand Signed-off-

[PATCH 20/29] drivers, s390: convert qeth_reply.refcnt from atomic_t to refcount_t

2017-03-06 Thread Elena Reshetova
refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena Reshetova Signed-off-by: Hans Liljestrand Signed-off-

[PATCH 19/29] drivers, s390: convert lcs_reply.refcnt from atomic_t to refcount_t

2017-03-06 Thread Elena Reshetova
refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena Reshetova Signed-off-by: Hans Liljestrand Signed-off-

[PATCH 18/29] drivers, s390: convert urdev.ref_count from atomic_t to refcount_t

2017-03-06 Thread Elena Reshetova
refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena Reshetova Signed-off-by: Hans Liljestrand Signed-off-

[PATCH 14/29] drivers, media: convert vb2_dc_buf.refcount from atomic_t to refcount_t

2017-03-06 Thread Elena Reshetova
refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena Reshetova Signed-off-by: Hans Liljestrand Signed-off-

[PATCH 17/29] drivers, pci: convert hv_pci_dev.refs from atomic_t to refcount_t

2017-03-06 Thread Elena Reshetova
refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena Reshetova Signed-off-by: Hans Liljestrand Signed-off-

[PATCH 15/29] drivers, media: convert vb2_dma_sg_buf.refcount from atomic_t to refcount_t

2017-03-06 Thread Elena Reshetova
refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena Reshetova Signed-off-by: Hans Liljestrand Signed-off-

[PATCH 16/29] drivers, media: convert vb2_vmalloc_buf.refcount from atomic_t to refcount_t

2017-03-06 Thread Elena Reshetova
refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena Reshetova Signed-off-by: Hans Liljestrand Signed-off-

[PATCH 13/29] drivers, media: convert vb2_vmarea_handler.refcount from atomic_t to refcount_t

2017-03-06 Thread Elena Reshetova
refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena Reshetova Signed-off-by: Hans Liljestrand Signed-off-

[PATCH 12/29] drivers, media: convert s2255_dev.num_channels from atomic_t to refcount_t

2017-03-06 Thread Elena Reshetova
refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena Reshetova Signed-off-by: Hans Liljestrand Signed-off-

[PATCH 11/29] drivers, media: convert cx88_core.refcount from atomic_t to refcount_t

2017-03-06 Thread Elena Reshetova
refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena Reshetova Signed-off-by: Hans Liljestrand Signed-off-

[PATCH 10/29] drivers, md: convert stripe_head.count from atomic_t to refcount_t

2017-03-06 Thread Elena Reshetova
refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena Reshetova Signed-off-by: Hans Liljestrand Signed-off-

[PATCH 09/29] drivers, md: convert table_device.count from atomic_t to refcount_t

2017-03-06 Thread Elena Reshetova
refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena Reshetova Signed-off-by: Hans Liljestrand Signed-off-

[PATCH 07/29] drivers, md: convert dm_dev_internal.count from atomic_t to refcount_t

2017-03-06 Thread Elena Reshetova
refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena Reshetova Signed-off-by: Hans Liljestrand Signed-off-

[PATCH 06/29] drivers, md: convert dm_cache_metadata.ref_count from atomic_t to refcount_t

2017-03-06 Thread Elena Reshetova
refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena Reshetova Signed-off-by: Hans Liljestrand Signed-off-

[PATCH 08/29] drivers, md: convert mddev.active from atomic_t to refcount_t

2017-03-06 Thread Elena Reshetova
refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena Reshetova Signed-off-by: Hans Liljestrand Signed-off-

[PATCH 05/29] drivers, md, bcache: convert cached_dev.count from atomic_t to refcount_t

2017-03-06 Thread Elena Reshetova
refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena Reshetova Signed-off-by: Hans Liljestrand Signed-off-

[PATCH 04/29] drivers, connector: convert cn_callback_entry.refcnt from atomic_t to refcount_t

2017-03-06 Thread Elena Reshetova
refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena Reshetova Signed-off-by: Hans Liljestrand Signed-off-

[PATCH 03/29] drivers, char: convert vma_data.refcnt from atomic_t to refcount_t

2017-03-06 Thread Elena Reshetova
refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena Reshetova Signed-off-by: Hans Liljestrand Signed-off-

[PATCH 02/29] drivers, firewire: convert fw_node.ref_count from atomic_t to refcount_t

2017-03-06 Thread Elena Reshetova
refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena Reshetova Signed-off-by: Hans Liljestrand Signed-off-

[PATCH 01/29] drivers, block: convert xen_blkif.refcnt from atomic_t to refcount_t

2017-03-06 Thread Elena Reshetova
refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena Reshetova Signed-off-by: Hans Liljestrand Signed-off-

[PATCH 00/29] drivers, mics refcount conversions

2017-03-06 Thread Elena Reshetova
This series, for various different drivers, replaces atomic_t reference counters with the new refcount_t type and API (see include/linux/refcount.h). By doing this we prevent intentional or accidental underflows or overflows that can led to use-after-free vulnerabilities. The below patches are ful

Guten Tag

2017-03-06 Thread Joanna D Christopher
Hallo, Mein Name ist Joanna Diane Christopher. Ich bin die einzige Tochter von spät Dr. Fredrick Christopher. Mein Vater war ein vorzüglicher Öl- und Gasunternehmer, bevor er starb. Er hatte auch umfangreiche Investitionen in Immobilien, Agrar- und Bankensektoren. Meine Mutter starb mit meinen

Re: [RFC PATCH 10/12] staging: android: ion: Use CMA APIs directly

2017-03-06 Thread Laurent Pinchart
Hi Daniel, On Monday 06 Mar 2017 11:32:04 Daniel Vetter wrote: > On Fri, Mar 03, 2017 at 10:50:20AM -0800, Laura Abbott wrote: > > On 03/03/2017 08:41 AM, Laurent Pinchart wrote: > >> On Thursday 02 Mar 2017 13:44:42 Laura Abbott wrote: > >>> When CMA was first introduced, its primary use was for

Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging

2017-03-06 Thread Michal Hocko
On Mon 06-03-17 11:40:41, Daniel Vetter wrote: > On Mon, Mar 06, 2017 at 08:42:59AM +0100, Michal Hocko wrote: > > On Fri 03-03-17 09:37:55, Laura Abbott wrote: > > > On 03/03/2017 05:29 AM, Michal Hocko wrote: > > > > On Thu 02-03-17 13:44:32, Laura Abbott wrote: > > > >> Hi, > > > >> > > > >> The

Re: [RESEND PATCH V4] staging: vchiq_arm: Add compatibility wrappers for ioctls

2017-03-06 Thread Greg KH
On Sat, Mar 04, 2017 at 06:57:50AM -0800, Michael Zoran wrote: > On Sat, 2017-03-04 at 14:58 +0300, Dan Carpenter wrote: > > On Wed, Mar 01, 2017 at 07:41:46PM -0800, Michael Zoran wrote: > > > Changes: > > > V1 - Complete rewrite of the ioctl code. > > > V2 - Rewrite of only ioctls that change

Re: [PATCH] staging: speakup: else is not generally useful after a break or return

2017-03-06 Thread kbuild test robot
Hi Arushi, [auto build test WARNING on staging/staging-testing] [cannot apply to v4.11-rc1 next-20170306] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Arushi-Singhal/staging-speakup-else-is

Re: [PATCH] Staging: bcm2835-audio: bcm2835-pcm: fix a brace coding style issue

2017-03-06 Thread Greg KH
On Wed, Mar 01, 2017 at 09:46:16PM +0100, Maciej Billewicz wrote: > Fix coding style issue. > > Signed-off-by: Maciej Billewicz > --- > drivers/staging/bcm2835-audio/bcm2835-pcm.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Does not apply to my tree, sorry :( greg k-h ___

Re: [PATCH 1/2] staging/vc04_services: initialize cache line size properly

2017-03-06 Thread Greg Kroah-Hartman
On Wed, Mar 01, 2017 at 05:59:38PM -0800, Michael Zoran wrote: > Hi Arnd, > > I submitted a change which is in Linux-next now that makes the whole > CACHE_LINE_SIZE macro meaningless. It now always reads the size from > the DT and errors out with -ENODEV if the property is missing. > > I was goi

Re: [PATCH] Staging: media: platform: bcm2835 - Style fix

2017-03-06 Thread Greg KH
On Sun, Mar 05, 2017 at 10:43:19AM +1300, Derek Robson wrote: > On Sat, Mar 04, 2017 at 02:57:22PM +0300, Dan Carpenter wrote: > > Copy a patch prefix that everyone else has been using: > > > > git log --oneline drivers/staging/media/platform/bcm2835/ > > > > The subject is too vague as well. >

Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging

2017-03-06 Thread Mark Brown
On Mon, Mar 06, 2017 at 11:40:41AM +0100, Daniel Vetter wrote: > No one gave a thing about android in upstream, so Greg KH just dumped it > all into staging/android/. We've discussed ION a bunch of times, recorded > anything we'd like to fix in staging/android/TODO, and Laura's patch > series here

Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging

2017-03-06 Thread Daniel Vetter
On Mon, Mar 06, 2017 at 08:42:59AM +0100, Michal Hocko wrote: > On Fri 03-03-17 09:37:55, Laura Abbott wrote: > > On 03/03/2017 05:29 AM, Michal Hocko wrote: > > > On Thu 02-03-17 13:44:32, Laura Abbott wrote: > > >> Hi, > > >> > > >> There's been some recent discussions[1] about Ion-like framework

Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging

2017-03-06 Thread Daniel Vetter
On Fri, Mar 03, 2017 at 06:45:40PM +0200, Laurent Pinchart wrote: > - I haven't seen any proposal how a heap-based solution could be used in a > generic distribution. This needs to be figured out before committing to any > API/ABI. Two replies from my side: - Just because a patch doesn't solve

Re: [RFC PATCH 10/12] staging: android: ion: Use CMA APIs directly

2017-03-06 Thread Daniel Vetter
On Fri, Mar 03, 2017 at 10:50:20AM -0800, Laura Abbott wrote: > On 03/03/2017 08:41 AM, Laurent Pinchart wrote: > > Hi Laura, > > > > Thank you for the patch. > > > > On Thursday 02 Mar 2017 13:44:42 Laura Abbott wrote: > >> When CMA was first introduced, its primary use was for DMA allocation >

Re: [RFC PATCH 06/12] staging: android: ion: Remove crufty cache support

2017-03-06 Thread Daniel Vetter
On Fri, Mar 03, 2017 at 10:46:03AM -0800, Laura Abbott wrote: > On 03/03/2017 08:39 AM, Laurent Pinchart wrote: > > Hi Daniel, > > > > On Friday 03 Mar 2017 10:56:54 Daniel Vetter wrote: > >> On Thu, Mar 02, 2017 at 01:44:38PM -0800, Laura Abbott wrote: > >>> Now that we call dma_map in the dma_bu