Re: [PATCH net 1/1] Revert "netvsc: optimize calculation of number of slots"

2017-07-25 Thread David Miller
From: Stephen Hemminger Date: Mon, 24 Jul 2017 21:03:19 -0700 > The logic for computing page buffer scatter does not take into > account the impact of compound pages. Therefore the optimization > to compute number of slots was incorrect and could cause stack > corruption a skb was sent with lots

[PATCH] Staging: wlan-ng: hfa384x.h: Fix endianness warning for hfa384x_ps_user_count

2017-07-25 Thread Manny Vindiola
The field in hfa384x_ps_user_count was defined as u16 but used as __le16 Changed type to __le16 for consistency Signed-off-by: Manny Vindiola --- drivers/staging/wlan-ng/hfa384x.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/sta

Re: [PATCH v1 6/6] device property: Switch to use new generic UUID API

2017-07-25 Thread Rafael J. Wysocki
On Tuesday, July 25, 2017 05:12:35 PM Mika Westerberg wrote: > On Wed, Jul 19, 2017 at 09:28:57PM +0300, Andy Shevchenko wrote: > > There are new types and helpers that are supposed to be used in new code. > > > > As a preparation to get rid of legacy types and API functions do > > the conversion

Re: [PATCH v1 6/6] device property: Switch to use new generic UUID API

2017-07-25 Thread Rafael J. Wysocki
On Wednesday, July 26, 2017 03:35:01 AM Andy Shevchenko wrote: > On Wed, Jul 26, 2017 at 3:21 AM, Rafael J. Wysocki wrote: > > On Tuesday, July 25, 2017 05:12:35 PM Mika Westerberg wrote: > >> On Wed, Jul 19, 2017 at 09:28:57PM +0300, Andy Shevchenko wrote: > >> > There are new types and helpers t

Re: [PATCH v1 6/6] device property: Switch to use new generic UUID API

2017-07-25 Thread Andy Shevchenko
On Wed, Jul 26, 2017 at 3:21 AM, Rafael J. Wysocki wrote: > On Tuesday, July 25, 2017 05:12:35 PM Mika Westerberg wrote: >> On Wed, Jul 19, 2017 at 09:28:57PM +0300, Andy Shevchenko wrote: >> > There are new types and helpers that are supposed to be used in new code. >> > >> > As a preparation to

[PATCH] staging: unisys: visorbus_main: constify attribute_group structures

2017-07-25 Thread Amitoj Kaur Chawla
Functions working with attribute_groups provided by work with const attribute_group. These attribute_group structures do not change at runtime so mark them as const. File size before: text data bss dec hex filename 142167304 832 223525750 drivers/staging/unisys/vis

Re: [PATCH net-next 3/5] netvsc: optimize receive completions

2017-07-25 Thread Stephen Hemminger
On Tue, 25 Jul 2017 13:04:20 -0700 Stephen Hemminger wrote: > Optimize how receive completion ring are managed. >* Allocate only as many slots as needed for all buffers from host >* Allocate before setting up sub channel for better error detection >* Don't need to keep copy of initial

[PATCH net-next 3/5] netvsc: optimize receive completions

2017-07-25 Thread Stephen Hemminger
Optimize how receive completion ring are managed. * Allocate only as many slots as needed for all buffers from host * Allocate before setting up sub channel for better error detection * Don't need to keep copy of initial receive section message * Only needt keep the transaction id, stat

[PATCH net-next 5/5] netvsc: allow smaller send/recv buffer size

2017-07-25 Thread Stephen Hemminger
The default value of send and receive buffer area for host DMA is much larger than it needs to be. Experimentation shows that 4M receive and 1M send is sufficient. Make the size a module parameter so that it can be adjusted as needed for testing or special needs. Signed-off-by: Stephen Hemminger

[PATCH net-next 2/5] netvsc: fix warnings reported by lockdep

2017-07-25 Thread Stephen Hemminger
This includes a bunch of fixups for issues reported by sparse and lockdep. * ethtool routines can assume RTNL * send is done with RCU lock (and BH disable) Most of the changes involve passing internal device struct (netvsc) as parameter, so that code called in both initialization and changes

[PATCH net-next 4/5] netvsc: signal host if receive ring is emptied

2017-07-25 Thread Stephen Hemminger
Latency improvement related to NAPI conversion. If all packets are processed from receive ring then need to signal host. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/netvsc.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/net/hyperv/netvsc.c b/

[PATCH net-next 1/5] netvsc: fix return value for set_channels

2017-07-25 Thread Stephen Hemminger
The error and normal case got swapped. Reported-by: Dan Carpenter Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/netvsc_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c index 262486ce8e2a..f1eaf6

[PATCH net-next 0/5] netvsc: fixes and performance related changes

2017-07-25 Thread Stephen Hemminger
The first two are more fixes to problems introduced in latest net-next changes. The rest are changes to improve performance and reduce memory footprint. The driver used to allocate large amounts of memory (33M) per interface, this reduces that down to about 7M. Stephen Hemminger (5): netvsc: f

[PATCH] Staging: rtl8188eu: core: fix brace coding style issue in rtw_mlme_ext.c

2017-07-25 Thread ArminSchoenlieb
From: Armin Schoenlieb This is a patch to the rtw_mlme_ext.c file that fixes up a brace error found by the checkpatch.pl tool Signed-off-by: Armin Schoenlieb --- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/

[PATCH] staging: pi433: fix Kconfig entry

2017-07-25 Thread Arnd Bergmann
I ran into a build error with the new pi433 driver and CONFIG_SPI disabled: drivers/staging/pi433/pi433_if.o: In function `pi433_probe.part.6': pi433_if.c:(.text+0x1657): undefined reference to `spi_write_then_read' drivers/staging/pi433/pi433_if.o: In function `pi433_probe': pi433_if.c:(.text+0x1

Re: [bug report] netvsc: fix netvsc_set_channels

2017-07-25 Thread Stephen Hemminger
On Tue, 25 Jul 2017 17:29:14 +0300 Dan Carpenter wrote: > Hello stephen hemminger, > > The patch 7ca4593338e1: "netvsc: fix netvsc_set_channels" from Jul > 24, 2017, leads to the following static checker warning: > > drivers/net/hyperv/netvsc_drv.c:761 netvsc_set_channels() > error:

[bug report] netvsc: fix netvsc_set_channels

2017-07-25 Thread Dan Carpenter
Hello stephen hemminger, The patch 7ca4593338e1: "netvsc: fix netvsc_set_channels" from Jul 24, 2017, leads to the following static checker warning: drivers/net/hyperv/netvsc_drv.c:761 netvsc_set_channels() error: 'nvdev' is not an ERR_PTR drivers/net/hyperv/netvsc_drv.c:

Re: [PATCH] staging: octeon: fix line over 80 characters

2017-07-25 Thread Dan Carpenter
On Tue, Jul 25, 2017 at 04:01:57PM +0300, catalin...@gmail.com wrote: > From: John Smith > > ethernet-rx.c: > > fix WARNING: line over 80 characters > > Signed-off-by: John Smith > --- > drivers/staging/octeon/ethernet-rx.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff -

Re: [PATCH v1 6/6] device property: Switch to use new generic UUID API

2017-07-25 Thread Mika Westerberg
On Wed, Jul 19, 2017 at 09:28:57PM +0300, Andy Shevchenko wrote: > There are new types and helpers that are supposed to be used in new code. > > As a preparation to get rid of legacy types and API functions do > the conversion here. > > Cc: "Rafael J. Wysocki" > Cc: Mika Westerberg Acked-by: M

[PATCH] staging: octeon: fix line over 80 characters

2017-07-25 Thread catalinnow
From: John Smith ethernet-rx.c: fix WARNING: line over 80 characters Signed-off-by: John Smith --- drivers/staging/octeon/ethernet-rx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/octeon/ethernet-rx.c b/drivers/staging/octeon/ethernet-rx.c index 72ba

Re: [PATCH] staging: octeon: fix line over 80 characters

2017-07-25 Thread Joe Perches
On Tue, 2017-07-25 at 16:01 +0300, catalin...@gmail.com wrote: > From: John Smith > > ethernet-rx.c: > > fix WARNING: line over 80 characters Instead of just shutting up checkpatch, how about restructuring the code a bit by adding a helper function to this very long cvm_oct_poll? > diff --git

Re: [PATCH 1/2] staging: greybus: light: Don't leak memory for no gain

2017-07-25 Thread Johan Hovold
[ +CC: Rui and Greg ] On Tue, Jul 18, 2017 at 09:41:06PM +0300, Sakari Ailus wrote: > Memory for struct v4l2_flash_config is allocated in > gb_lights_light_v4l2_register() for no gain and yet the allocated memory is > leaked; the struct isn't used outside the function. Fix this. > > Signed-off-by

Re: [PATCH v1 1/6] efi: Switch to use new generic UUID API

2017-07-25 Thread Andy Shevchenko
On Thu, 2017-07-20 at 13:18 +0100, Ard Biesheuvel wrote: > On 19 July 2017 at 19:28, Andy Shevchenko > wrote: > > There are new types and helpers that are supposed to be used in new > > code. > > > > As a preparation to get rid of legacy types and API functions do > > the conversion here. > > >

[PATCH] staging: vboxvideo: select GENERIC_ALLOCATOR

2017-07-25 Thread Hans de Goede
The vboxvideo code uses various gen_pool_* functions, so it needs lib/genalloc.c to be built. In some configs this is not happening, so add select GENERIC_ALLOCATOR to the Kconfig file to enforce this. Note all other Kconfig references to GENERIC_ALLOCATOR also use select. Signed-off-by: Hans de

Re: [PATCH 1/2] staging: net: wireless: add ESP8089 WiFi driver

2017-07-25 Thread Kalle Valo
(adding linux-wireless) Quentin Schulz writes: > Hi Marcel, > > On 21/07/2017 18:52, Marcel Holtmann wrote: >> Hi Quentin, >> > The Espressif ESP8089 WiFi chips can be often found in cheap tablets. > There is one in A23 Polaroid tablets for example. > > The chip is often embedde