Re: [PATCH 3/3] staging: rtlwifi: remove unused functions

On Tue, Sep 05, 2017 at 09:46:55AM -0500, Larry Finger wrote: > On 09/05/2017 01:53 AM, Tobin C. Harding wrote: > >Functions rtl_rfreg_delay() and rtl_bb_delay() are unused within the > >driver. Both functions call rtl_addr_delay(), this function is unused > >outside of these call sites.The driver

Re: [PATCH] iio staging: tsl2x7x: clean up limit checks

On Tue, Sep 05, 2017 at 05:02:55PM -0400, Brian Masney wrote: > On Tue, Sep 05, 2017 at 05:58:54PM +0300, Dan Carpenter wrote: > > On Sun, Sep 03, 2017 at 10:12:46PM -0400, Brian Masney wrote: > > > On Sun, Sep 03, 2017 at 12:35:05PM +0100, Jonathan Cameron wrote: > > > > On Mon, 21 Aug 2017 13:11:

Re: [PATCH] iio staging: tsl2x7x: clean up limit checks

On Tue, Sep 05, 2017 at 05:58:54PM +0300, Dan Carpenter wrote: > On Sun, Sep 03, 2017 at 10:12:46PM -0400, Brian Masney wrote: > > On Sun, Sep 03, 2017 at 12:35:05PM +0100, Jonathan Cameron wrote: > > > On Mon, 21 Aug 2017 13:11:03 +0300 > > > Dan Carpenter wrote: > > > > > > > The second part of

Re: [PATCH] tools: hv: handle EINTR in hv_fcopy_daemon

On Tue, Sep 05, KY Srinivasan wrote: > Were you planning on sending a patch for this. No, not yet. I dont know how SA_RESTART works. Olaf signature.asc Description: PGP signature ___ devel mailing list de...@linuxdriverproject.org http://driverdev.li

RE: [PATCH] tools: hv: handle EINTR in hv_fcopy_daemon

Olaf, Were you planning on sending a patch for this. K. Y > -Original Message- > From: Olaf Hering [mailto:o...@aepfle.de] > Sent: Friday, August 25, 2017 5:31 AM > To: Vitaly Kuznetsov > Cc: KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger > ; open list:Hyper-V CORE AND DRIVERS > ;

[PATCH] binder: fix an ret value override

From: Xu YiPing commit 372e3147df70 ("binder: guarantee txn complete / errors delivered in-order") incorrectly defined a local ret value. This ret value will be invalid when out of the if block Signed-off-by: Xu YiPing Signed-off-by: Todd Kjos --- drivers/android/binder.c | 1 - 1 file chang

[PATCH] binder: fix memory corruption in binder_transaction binder

From: Xu YiPing commit 7a4408c6bd3e ("binder: make sure accesses to proc/thread are safe") made a change to enqueue tcomplete to thread->todo before enqueuing the transaction. However, in err_dead_proc_or_thread case, the tcomplete is directly freed, without dequeued. It may cause the thread->tod

Re: [PATCH] staging: rtl8192u: fix incorrect mask when calculating TxPowerLevelCCK

Am 05.09.2017 18:32, schrieb Colin King: > From: Colin Ian King > > The mask of 0xff and right shift of 8 bits on ret always results in > a value of 0 for TxPowerLevelCCK. I believe this should be a mask of > 0xff00, however I do not have the hardware at hand to test this out, > so there is a

[PATCH v2 09/11] staging: typec: Add Generic TCPC mux driver using the mux subsys

So far the mux functionality of the tcpm code has not been hooked up in any tcpc drivers. This commit adds a generic TCPC mux driver using the mux subsys, which tcpc drivers can use to provide mux functionality in cases where an external my is used. Signed-off-by: Hans de Goede --- drivers/stagi

[PATCH v2 07/11] extcon: intel-int3496: Add support for controlling the USB-role mux

Cherry Trail SoCs have a built-in USB-role mux for switching between the host and device controllers, rather then using an external mux controller by a GPIO. There is a driver using the mux-subsys to control this mux, this commit adds support to the intel-int3496 driver to get a mux_controller han

[PATCH v2 11/11] platform/x86: intel_cht_int33fe: Add mux mappings for the Type-C port

We need to add mappings for the mux subsys to be able to find the muxes for the fusb302 driver to be able to control the PI3USB30532 Type-C mux and the device/host mux integrated in the CHT SoC. Signed-off-by: Hans de Goede Acked-by: Andy Shevchenko --- drivers/platform/x86/Kconfig

[PATCH v2 08/11] staging: typec: tcpm: Set mux to device mode when configured as such

Setting the mux to TYPEC_MUX_NONE, TCPC_USB_SWITCH_DISCONNECT when the data-role is device is not correct. Plenty of devices support operating as USB device through a (separate) USB device controller. So this commit instead splits out TYPEC_MUX_USB into TYPEC_MUX_USB_HOST and TYPEC_MUX_USB_DEVICE

[PATCH v2 10/11] staging: typec: fusb302: Hook up mux support using tcpc_gen_mux support

Add mux support to the fusb302 driver, call devm_tcpc_gen_mux_create() to let the generic tcpc_mux_dev code create a tcpc_mux_dev for us. Also document the mux-names used by the generic tcpc_mux_dev code in our devicetree bindings. Cc: Rob Herring Cc: Mark Rutland Cc: devicet...@vger.kernel.org

[PATCH v2 01/11] mux: core: Add of_mux_control_get helper function

Currently the mux_control_get implementation only deals with getting mux controllers on DT platforms. This commit renames the current implementation to of_mux_control_get to reflect this and makes mux_control_get a wrapper around of_mux_control_get. This is a preparation patch for adding support f

[PATCH v2 05/11] mux: Add Intel Cherrytrail USB mux driver

Intel Cherrytrail SoCs have an internal USB mux for muxing the otg-port USB data lines between the xHCI host controller and the dwc3 gadget controller. On some Cherrytrail systems this mux is controlled through AML code reacting on a GPIO IRQ connected to the USB OTG id pin (through an _AIE ACPI me

[PATCH v2 03/11] mux: core: Add usb.h header with MUX_USB_* and and MUX_TYPEC_* state constants

Add MUX_USB_* and MUX_TYPEC_* state constant defines, which can be used by USB device/host, resp. Type-C polarity/role/altmode mux drivers and consumers to ensure that they agree on the meaning of the mux_control_select() state argument. Signed-off-by: Hans de Goede --- Changes in v2: -Start numb

[PATCH v2 06/11] mux: Add Pericom PI3USB30532 Type-C mux driver

Add a driver for the Pericom PI3USB30532 Type-C cross switch / mux chip found on some devices with a Type-C port. Signed-off-by: Hans de Goede --- Changes in v2: -Adjust for new MUX_TYPEC_foo state defines -Add MAINTAINERS entry -Various code-style fixes --- MAINTAINERS | 5 +++ d

[PATCH v2 00/11] mux/typec: Add USB / TypeC mux drivers and hook them up on some x86 systems

Hi All, Here is v2 of my USB / Type-C mux series, addressing various comments from the reviews of v1. See the per patch changelogs for details. For reference here the cover letter of v1: This series consists of 4 parts: 1) Core mux changes to add support for getting mux-controllers on non DT

[PATCH v2 04/11] usb: xhci: Add Intel cherrytrail extended cap / otg phy mux handling

The Intel cherrytrail xhci controller has an extended cap mmio-range which contains registers to control the muxing to the xhci (host mode) or the dwc3 (device mode) and vbus-detection for the otg usb-phy. Having a mux driver included in the xhci code (or under drivers/usb/host) is not desirable.

[PATCH v2 02/11] mux: core: Add support for getting a mux controller on a non DT platform

On non DT platforms we cannot get the mux_chip by pnode. Other subsystems (regulator, clock, pwm) have the same problem and solve this by allowing platform / board-setup code to add entries to a lookup table and then use this table to look things up. This commit adds support for getting a mux cont

[PATCH] staging: rtl8192u: fix incorrect mask when calculating TxPowerLevelCCK

From: Colin Ian King The mask of 0xff and right shift of 8 bits on ret always results in a value of 0 for TxPowerLevelCCK. I believe this should be a mask of 0xff00, however I do not have the hardware at hand to test this out, so there is a distinct possibility I may be wrong on this. Detected

Re: [PATCH] iio staging: tsl2x7x: clean up limit checks

On Sun, Sep 03, 2017 at 10:12:46PM -0400, Brian Masney wrote: > On Sun, Sep 03, 2017 at 12:35:05PM +0100, Jonathan Cameron wrote: > > On Mon, 21 Aug 2017 13:11:03 +0300 > > Dan Carpenter wrote: > > > > > The second part of this patch is probably the most interesting. We > > > use "TSL2X7X_MAX_LU

Re: [PATCH 3/3] staging: rtlwifi: remove unused functions

On 09/05/2017 01:53 AM, Tobin C. Harding wrote: Functions rtl_rfreg_delay() and rtl_bb_delay() are unused within the driver. Both functions call rtl_addr_delay(), this function is unused outside of these call sites.The driver (and kernel) code base is cleaner if unused functions are removed. Rem

Re: [PATCH 2/3] staging: rtlwifi: use kcalloc instead of multiply

On 09/05/2017 01:53 AM, Tobin C. Harding wrote: checkpatch emits multiple warnings of type WARNING:ALLOC_WITH_MULTIPLY: Prefer kcalloc over kzalloc with multiply Replace two calls to kzalloc() with calls to kcalloc(). I have previously discussed this kind of change. This recommendation by ch

Re: [PATCH] staging:rtl8188eu Fix msleep < 20ms can sleep upto 20ms

On Tue, 2017-09-05 at 15:36 +0530, Janani Sankara Babu wrote: > This patch solves the following warning shown by checkpatch script > Warning: msleep < 20ms can sleep for up to 20ms [] > diff --git a/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c > b/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c [] >

Re: [PATCH] staging:rtl8188eu Fix msleep < 20ms can sleep upto 20ms

On Tue, Sep 05, 2017 at 03:36:41PM +0530, Janani Sankara Babu wrote: > This patch solves the following warning shown by checkpatch script > Warning: msleep < 20ms can sleep for up to 20ms > > Signed-off-by: Janani Sankara Babu > --- > drivers/staging/rtl8188eu/core/rtw_pwrctrl.c | 2 +- > 1 fil

[PATCH] staging:rtl8188eu:core Fix code Indent

This patch is created to solve the code indentation issue Signed-off-by: Janani Sankara Babu --- drivers/staging/rtl8188eu/core/rtw_xmit.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c b/drivers/staging/rtl8188eu/core/

[PATCH] staging:rtl8188eu Remove unneccessary parenthesis

This patch is creates in order to correct the coding style issues. It removes the unwanted parenthesis from the code. Signed-off-by: Janani Sankara Babu --- drivers/staging/rtl8188eu/core/rtw_xmit.c | 52 +++ 1 file changed, 26 insertions(+), 26 deletions(-) diff --

Re: [PATCH 05/11] mux: Add Intel Cherrytrail USB mux driver

Hi, On 04-09-17 13:19, Peter Rosin wrote: Hi! Some comments inline... On 2017-09-01 23:48, Hans de Goede wrote: Intel Cherrytrail SoCs have an internal USB mux for muxing the otg-port USB data lines between the xHCI host controller and the dwc3 gadget controller. On some Cherrytrail systems t

Re: [PATCH 02/11] mux: core: Add support for getting a mux controller on a non DT platform

Hi, On 04-09-17 13:19, Peter Rosin wrote: Hi! Some comments inline... On 2017-09-01 23:48, Hans de Goede wrote: On non DT platforms we cannot get the mux_chip by pnode. Other subsystems (regulator, clock, pwm) have the same problem and solve this by allowing platform / board-setup code to add

Re: [PATCH 00/11] mux/typec: Add USB / TypeC mux drivers and hook them up on some x86 systems

Hi Peter, On 04-09-17 13:18, Peter Rosin wrote: On 2017-09-01 23:48, Hans de Goede wrote: Hi All, This series consists of 4 parts: 1) Core mux changes to add support for getting mux-controllers on non DT platforms and to add some standardised state values for USB 2) Add Intel CHT USB mux

[patch 1/1] [patch] staging: speakup: fix speakup-r empty line lockup

When cursor is at beginning of an empty or whitespace-only line and speakup-r typed, kernel locks up. This happens because deadlock of in input_event function over dev->event_lock, as demonstrated by lockdep logs. The reason for that is speakup simulates a down arrow - because cursor is at an empty

[patch 0/1] staging: speakup: fix speakup-r empty line lockup

Hi, This patch fixes kernel lockup shown by lockdep log below. Further details are in patch header. Samuel, please note that I removed initialisation of the static int in_keyboard_notifier to zero as that is not required and reported as error by checkpatch. Thanks, Okash [ 1293.803242] ===

[PATCH] staging:rtl8188eu Fix coding style issues

This patch aims to solve coding style issues by placing constants on the right side of the test Signed-off-by: Janani Sankara Babu --- drivers/staging/rtl8188eu/core/rtw_pwrctrl.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_p

[PATCH] staging:rtl8188eu Fix use __func__ for function name

This patch fixes the WARNING: Prefer using '"%s...", __func__' to using this function's name, in a string Signed-off-by: Janani Sankara Babu --- drivers/staging/rtl8188eu/core/rtw_pwrctrl.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8188eu

[PATCH] staging:rtl8188eu Fix msleep < 20ms can sleep upto 20ms

This patch solves the following warning shown by checkpatch script Warning: msleep < 20ms can sleep for up to 20ms Signed-off-by: Janani Sankara Babu --- drivers/staging/rtl8188eu/core/rtw_pwrctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/co

Re: [PATCH 04/11] usb: xhci: Add Intel cherrytrail extended cap / otg phy mux handling

Hi, On 04-09-17 09:31, Heikki Krogerus wrote: Hi, On Fri, Sep 01, 2017 at 11:48:38PM +0200, Hans de Goede wrote: The Intel cherrytrail xhci controller has an extended cap mmio-range which contains registers to control the muxing to the xhci (host mode) or the dwc3 (device mode) and vbus-detect

[PATCH] android: binder: fix type mismatch warning

Allowing binder to expose the 64-bit API on 32-bit kernels caused a build warning: drivers/android/binder.c: In function 'binder_transaction_buffer_release': drivers/android/binder.c:2220:15: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] fd_array = (u32 *

[PATCH] Staging: xgifb: vb_setmode.c: Remove unnecessary parentheses.

Fixed warning produced by checkpatch.pl to remove unecessary parentheses Signed-off-by: Srishti Sharma --- drivers/staging/xgifb/vb_setmode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c index cea128b

Re: [PATCH 06/11] mux: Add Pericom PI3USB30532 Type-C mux driver

On 2017-09-04 13:19, Peter Rosin wrote: > Hi! > > One comment inline... Oh, and one more small nit, I think you should do s/pi3usb30532_mux/pi3usb30532/g to shorten the identifiers a bit. The _mux suffix (or infix) is kind of selfevident from where the file lives anyway. pi3usb30532_mux_set_mux

[PATCH] staging: rts5208: fix gcc-8 logic error warning

As gcc-8 points out, the bit mask check makes no sense here: drivers/staging/rts5208/sd.c: In function 'ext_sd_send_cmd_get_rsp': drivers/staging/rts5208/sd.c:4130:25: error: bitwise comparison always evaluates to true [-Werror=tautological-compare] However, the code is even more bogus, as we ha

[PATCH 3/3] staging: rtlwifi: remove unused functions

Functions rtl_rfreg_delay() and rtl_bb_delay() are unused within the driver. Both functions call rtl_addr_delay(), this function is unused outside of these call sites.The driver (and kernel) code base is cleaner if unused functions are removed. Remove unused functions. --- drivers/staging/rtlwifi

[PATCH 2/3] staging: rtlwifi: use kcalloc instead of multiply

checkpatch emits multiple warnings of type WARNING:ALLOC_WITH_MULTIPLY: Prefer kcalloc over kzalloc with multiply Replace two calls to kzalloc() with calls to kcalloc(). --- drivers/staging/rtlwifi/efuse.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/r

[PATCH 0/3] staging: rtlwifi: checkpatch fixes

Fix checkpatch warnings. Patch 1: Fix CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis. Patch 2: Fix WARNING:ALLOC_WITH_MULTIPLY: Prefer kcalloc over kzalloc with multiply. Patch 3: Remove unused functions (clears checkpatch warnings). Code is untested. Builds on x86_64. To

[PATCH 1/3] staging: rtlwifi: fix parenthesis alignment

Checkpatch emits multiple warnings of type CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis Fix parenthesis alignment in line with checkpatch suggestion. --- drivers/staging/rtlwifi/core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/stagi