Re: [PATCH] staging: ccree: Fix lines longer than 80 characters

2017-10-24 Thread Stephen Brennan
Hi Gilad & Tobin, > > Perhaps, if Stephen is willing, re-write the code to be more readable > > by, for example, using a temp > > variable for the register address, and in doing so both making the > > code more readable as well as > > treating the symptom? I'm definitely willing; however, I don't

Re: [RFC 05/12] dt-bindings: mtd: add Marvell NAND controller documentation

2017-10-24 Thread Rob Herring
On Wed, Oct 18, 2017 at 04:36:22PM +0200, Miquel Raynal wrote: > Document the bindings for the legacy and the new bindings relative to > Marvell NAND controller driver rework. > > Signed-off-by: Miquel Raynal > --- > .../devicetree/bindings/mtd/marvell-nand.txt | 95 >

Re: [PATCH v2 1/4] android: binder: Don't get mm from task

2017-10-24 Thread Arve Hjønnevåg
On Tue, Oct 24, 2017 at 12:28 AM, Greg Kroah-Hartman wrote: > On Mon, Oct 23, 2017 at 11:18:52AM -0700, Arve Hjønnevåg wrote: >> On Sat, Oct 21, 2017 at 1:15 AM, Greg Kroah-Hartman >> wrote: >> > On Fri, Oct 20, 2017 at 08:58:58PM -0400, Sherry Yang wrote: >> >> Use binder_alloc struct's mm_struc

Re: [PATCH v3 02/26] staging: most: integrate driver in kernel's device model

2017-10-24 Thread Christian Gromm
On Fri, 20 Oct 2017 16:56:10 +0200 Greg KH wrote: > On Fri, Oct 20, 2017 at 04:20:33PM +0200, Christian Gromm wrote: > > On 18.10.2017 16:29, Greg KH wrote: > > > On Wed, Oct 18, 2017 at 04:02:33PM +0200, Christian Gromm wrote: > > > > On 18.10.2017 14:12, Greg KH wrote: > > > > > On Mon, Oct 16,

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

2017-10-24 Thread Jordan Crouse
On Mon, Oct 23, 2017 at 05:55:37PM +0200, Benjamin Gaignard wrote: > Instead a getting only one common device "/dev/ion" for > all the heaps this patch allow to create one device > entry ("/dev/ionX") per heap. > Getting an entry per heap could allow to set security rules > per heap and global ones

Re: [PATCH v2] staging: greybus: Convert timers to use timer_setup()

2017-10-24 Thread Bryan O'Donoghue
On 24/10/17 15:49, Kees Cook wrote: In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Greg Kroah-Hartman Cc: "Bryan O'Donoghue" Cc: Johan Hovold Cc:

[PATCH v2] staging: greybus: Convert timers to use timer_setup()

2017-10-24 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Greg Kroah-Hartman Cc: "Bryan O'Donoghue" Cc: Johan Hovold Cc: Alex Elder Cc: greybus-...@lists.lina

Re: [PATCH] staging: greybus: Convert timers to use timer_setup()

2017-10-24 Thread Kees Cook
On Tue, Oct 24, 2017 at 6:30 AM, Bryan O'Donoghue wrote: > On 24/10/17 14:14, Kees Cook wrote: >> >> On Tue, Oct 24, 2017 at 5:52 AM, Bryan O'Donoghue >> wrote: >>> >>> On 24/10/17 13:47, Kees Cook wrote: On Tue, Oct 24, 2017 at 2:40 AM, Bryan O'Donoghue wrote: > > >>

Searching help for Linux support for RTL8812AU

2017-10-24 Thread txt.file
Hey Linux wireless list, A while ago I bought an ALFA Network AWUS036AC[0] which does not yet seem to be supported in Linux mainline. I would like to get it supported. The problem is that I have not that much experience doing software development. kind regards txt.file PS: Please keep me in CC

Re: [PATCH] staging: greybus: Convert timers to use timer_setup()

2017-10-24 Thread Bryan O'Donoghue
On 24/10/17 14:14, Kees Cook wrote: On Tue, Oct 24, 2017 at 5:52 AM, Bryan O'Donoghue wrote: On 24/10/17 13:47, Kees Cook wrote: On Tue, Oct 24, 2017 at 2:40 AM, Bryan O'Donoghue wrote: On 24/10/17 10:35, Bryan O'Donoghue wrote: On 24/10/17 09:25, Kees Cook wrote: In preparation for

Re: [PATCH] staging: greybus: Convert timers to use timer_setup()

2017-10-24 Thread Kees Cook
On Tue, Oct 24, 2017 at 5:52 AM, Bryan O'Donoghue wrote: > On 24/10/17 13:47, Kees Cook wrote: >> >> On Tue, Oct 24, 2017 at 2:40 AM, Bryan O'Donoghue >> wrote: >>> >>> On 24/10/17 10:35, Bryan O'Donoghue wrote: On 24/10/17 09:25, Kees Cook wrote: > > > In preparation f

Re: [PATCH 2/2] uio: Prefer MSI(X) interrupts in PCI drivers

2017-10-24 Thread Stephen Hemminger
On Fri, 20 Oct 2017 14:50:44 +0200 "gre...@linuxfoundation.org" wrote: > On Fri, Oct 06, 2017 at 07:57:00AM -0700, Stephen Hemminger wrote: > > On Fri, 6 Oct 2017 13:50:44 + > > "Stahl, Manuel" wrote: > > > > > MSI(X) interrupts are not shared between devices. So when available > > > thos

Re: [PATCH] staging: irda: resolve sparse errors due to implicit pci_power_t casts

2017-10-24 Thread Matthew Giassa
* Greg KH [2017-10-18 16:12:16 +0200]: On Thu, Oct 05, 2017 at 04:38:23PM -0700, Matthew Giassa wrote: Explicitly casting pci_power_t types to resolve sparse warnings (shown below). Also fixing a related logging bug where pci_power_t is cast to unsigned (can be negative, i.e. PCI_POWER_ERROR)

Re: [PATCH] staging: greybus: Convert timers to use timer_setup()

2017-10-24 Thread Bryan O'Donoghue
On 24/10/17 13:47, Kees Cook wrote: On Tue, Oct 24, 2017 at 2:40 AM, Bryan O'Donoghue wrote: On 24/10/17 10:35, Bryan O'Donoghue wrote: On 24/10/17 09:25, Kees Cook wrote: In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the ne

Re: [PATCH] staging: greybus: Convert timers to use timer_setup()

2017-10-24 Thread Kees Cook
On Tue, Oct 24, 2017 at 2:40 AM, Bryan O'Donoghue wrote: > On 24/10/17 10:35, Bryan O'Donoghue wrote: >> >> On 24/10/17 09:25, Kees Cook wrote: >>> >>> In preparation for unconditionally passing the struct timer_list pointer >>> to >>> all timer callbacks, switch to using the new timer_setup() and

Re: [PATCH] staging: greybus: Convert timers to use timer_setup()

2017-10-24 Thread Dan Carpenter
Actually, on further reflection, I don't care. However you write it is fine. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: greybus: Convert timers to use timer_setup()

2017-10-24 Thread Dan Carpenter
On Tue, Oct 24, 2017 at 01:25:50AM -0700, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Greg Kroah-Hartman > Cc: "Bryan O'

Re: [PATCH] staging: ccree: Fix lines longer than 80 characters

2017-10-24 Thread Greg Kroah-Hartman
On Tue, Oct 24, 2017 at 08:44:31PM +1100, Tobin C. Harding wrote: > Removing from CC list: > > - de...@driverdev.osuosl.org (this is the old address, it forwards to > driverdev-devel@linuxdriverproject.org now I believe). Both work equally well, and are interchangable for odd historical reason

Re: [PATCH] staging: ccree: Fix lines longer than 80 characters

2017-10-24 Thread Tobin C. Harding
Removing from CC list: - de...@driverdev.osuosl.org (this is the old address, it forwards to driverdev-devel@linuxdriverproject.org now I believe). - Linux Crypto Mailing List , should we be spamming these guys with checkpatch fixing discussions? Please do correct me if this is not the cor

Re: [PATCH] staging: greybus: Convert timers to use timer_setup()

2017-10-24 Thread Bryan O'Donoghue
On 24/10/17 09:25, Kees Cook wrote: In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Greg Kroah-Hartman Cc: "Bryan O'Donoghue" Cc: Johan Hovold Cc:

Re: [PATCH] staging: greybus: Convert timers to use timer_setup()

2017-10-24 Thread Bryan O'Donoghue
On 24/10/17 10:35, Bryan O'Donoghue wrote: On 24/10/17 09:25, Kees Cook wrote: In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Greg Kroah-Hartman

Re: [PATCH] staging: ccree: Fix lines longer than 80 characters

2017-10-24 Thread Gilad Ben-Yossef
Hi Tobin, On Tue, Oct 24, 2017 at 6:02 AM, Tobin C. Harding wrote: > On Mon, Oct 23, 2017 at 07:53:18AM -0700, Stephen Brennan wrote: >> Simply break down some long lines and tab-indent them. > > Hi Stephen, > > Welcome to the Linux kernel. Great that you have put in a patch, you are, > however,

Re: [PATCH v2 1/4] android: binder: Don't get mm from task

2017-10-24 Thread Greg Kroah-Hartman
On Mon, Oct 23, 2017 at 11:18:52AM -0700, Arve Hjønnevåg wrote: > On Sat, Oct 21, 2017 at 1:15 AM, Greg Kroah-Hartman > wrote: > > On Fri, Oct 20, 2017 at 08:58:58PM -0400, Sherry Yang wrote: > >> Use binder_alloc struct's mm_struct rather than getting > >> a reference to the mm struct through get

[PATCH] staging: rtl8723bs: Convert timers to use timer_setup()

2017-10-24 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. This performs some refactoring to remove needless wrapper functions, and adds a pointer back to the desired a

[PATCH] staging: vc04_services: Convert timers to use timer_setup()

2017-10-24 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Greg Kroah-Hartman Cc: Eric Anholt Cc: Stefan Wahren Cc: Michael Zoran Cc: Keerthi Reddy Cc: linux-

[PATCH] staging: ks7010: Convert timers to use timer_setup()

2017-10-24 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Greg Kroah-Hartman Cc: "Tobin C. Harding" Cc: de...@driverdev.osuosl.org Signed-off-by: Kees Cook ---

[PATCH] staging: greybus: Convert timers to use timer_setup()

2017-10-24 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Greg Kroah-Hartman Cc: "Bryan O'Donoghue" Cc: Johan Hovold Cc: Alex Elder Cc: greybus-...@lists.lina

[PATCH] staging: atomisp: i2c: Convert timers to use timer_setup()

2017-10-24 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Signed-off-by: Kees Cook --- drivers/staging/media/atomisp/i2c/lm3554.c | 8 +++- 1 file changed, 3 in

[PATCH] staging: VME: Remove PIO2 driver

2017-10-24 Thread Martyn Welch
The PIO2 device is (as far as I know) no longer manufactured. I no longer have access to the device and this seems unlikely to change. The only changes to this driver in a long time have been as a result of API changes else where. Time to remove it... Signed-off-by: Martyn Welch --- drivers/stag