[PATCH v2 1/2] Drivers: hv: vmbus: Change server monitor_pages index to 0

2019-02-18 Thread Kimberly Brown
Change the monitor_pages index in server_monitor_pending_show() to '0'. '0' is the correct monitor_pages index for the server. A comment for the monitor_pages field in the vmbus_connection struct definition indicates that the 1st page is for parent->child notifications. In addition, the server_moni

[PATCH v2 2/2] Drivers: hv: vmbus: Return -EINVAL if monitor_allocated not set

2019-02-18 Thread Kimberly Brown
There are two methods for signaling the host: the monitor page mechanism and hypercalls. The monitor page mechanism is used by performance critical channels (storage, networking, etc.) because it provides improved throughput. However, latency is increased. Monitor pages are allocated to these chann

[PATCH v2 0/2] Drivers: hv: vmbus: Fix sysfs functions that display monitor id and page data

2019-02-18 Thread Kimberly Brown
Some of the monitor id and monitor page data sysfs files display incorrect data. This patchset provides the following changes: 1) Change the monitor_pages index in server_monitor_pending_show() to '0', which is the correct index for the server. 2) If monitor pages are not allocated to a channel,

[PATCH -next] staging: rtlwifi: Remove set but not used variables 'dataempty, hoffset'

2019-02-18 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/staging/rtlwifi/efuse.c: In function 'efuse_pg_packet_write': drivers/staging/rtlwifi/efuse.c:922:24: warning: variable 'dataempty' set but not used [-Wunused-but-set-variable] drivers/staging/rtlwifi/efuse.c: In function 'efuse_get_current_

staging: rtl8188eu: fix bad indentation for conditional statement

2019-02-18 Thread Stephen Martin
Fixed else block indentation Signed-off-by: Stephen Martin --- drivers/staging/rtl8188eu/core/rtw_xmit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c b/drivers/staging/rtl8188eu/core/rtw_xmit.c index 3b1ccd138c3f..1723a47a96b4 100

Re: [PATCH] staging: comedi: ni_660x: fix missing break in switch statement

2019-02-18 Thread Gustavo A. R. Silva
Hi Sasha, On 2/18/19 3:14 PM, Sasha Levin wrote: > Hi, > > [This is an automated email] > > This commit has been processed because it contains a "Fixes:" tag, > fixing commit: 58dd7c0a2a6e Staging: comedi: add ni_660x driver. > > The bot has tested the following trees: v4.20.8, v4.19.21, v4.14.

Re: [PATCH] staging: comedi: ni_660x: fix missing break in switch statement

2019-02-18 Thread Sasha Levin
Hi, [This is an automated email] This commit has been processed because it contains a "Fixes:" tag, fixing commit: 58dd7c0a2a6e Staging: comedi: add ni_660x driver. The bot has tested the following trees: v4.20.8, v4.19.21, v4.14.99, v4.9.156, v4.4.174, v3.18.134. v4.20.8: Build OK! v4.19.21:

[PATCH 14/14] media: staging: fix several typos

2019-02-18 Thread Mauro Carvalho Chehab
Use codespell to fix lots of typos over frontends. Manually verified to avoid false-positives. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c | 2 +- drivers/staging/media/davinci_vpfe/dm365_isif.c | 4 ++-- drivers/staging/media/davinci_vpfe/

[PATCH] staging: vt6656: key: Mark expected switch fall-throughs

2019-02-18 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. This patch fixes the following warnings: drivers/staging/vt6656/key.c: In function ‘vnt_set_keymode’: drivers/staging/vt6656/key.c:70:19: warning: this statement may fall through [-Wimpli

Re: [PATCH] staging:iio:ad7152: Rename misspelled RESEVERD -> RESERVED

2019-02-18 Thread Rodrigo Ribeiro
Em seg, 18 de fev de 2019 às 11:46, Jonathan Cameron escreveu: > > On Thu, 14 Feb 2019 10:51:49 + > "Popa, Stefan Serban" wrote: > > > On Mi, 2019-02-13 at 22:25 -0200, Rodrigo Ribeiro wrote: > > > [External] > > > > > > > > > Em ter, 29 de jan de 2019 às 07:10, Alexandru Ardelean > > l.com>

Re: [PATCH v2 -next] staging: rtl8192e: Remove set but not used variables 'broad_addr, stype'

2019-02-18 Thread Dan Carpenter
Fantastic! Thanks. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v2 -next] staging: rtl8192e: Remove set but not used variables 'broad_addr, stype'

2019-02-18 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/staging/rtl8192e/rtl8192e/rtl_core.c: In function '_rtl92e_tx': drivers/staging/rtl8192e/rtl8192e/rtl_core.c:1732:28: warning: variable 'broad_addr' set but not used [-Wunused-but-set-variable] drivers/staging/rtl8192e/rtl8192e/rtl_core.c:17

Re: [PATCH v3 4/4] staging: iio: ad7780: moving ad7780 out of staging

2019-02-18 Thread Jonathan Cameron
On Thu, 14 Feb 2019 18:48:15 -0200 Renato Lui Geh wrote: > On 02/09, Jonathan Cameron wrote: > >On Tue, 5 Feb 2019 15:14:03 -0200 > >Renato Lui Geh wrote: > > > >> Move ad7780 ADC driver out of staging and into the mainline. > >> > >> The ad7780 is a sigma-delta analog to digital converter. Th

Re: [PATCH -next] staging: rtl8192e: Remove set but not used variables 'broad_addr, stype'

2019-02-18 Thread YueHaibing
On 2019/2/18 22:31, Dan Carpenter wrote: > On Mon, Feb 18, 2019 at 12:33:59PM +, YueHaibing wrote: >> @@ -1747,11 +1747,10 @@ static short _rtl92e_tx(struct net_device *dev, >> struct sk_buff *skb) >> header = (struct rtllib_hdr_1addr *)(((u8 *)skb->data) + fwinfo_size); >> fc = le16

Re: [PATCH v3 1/4] staging: iio: ad7780: add gain & filter gpio support

2019-02-18 Thread Jonathan Cameron
On Thu, 14 Feb 2019 18:31:12 -0200 Renato Lui Geh wrote: > Hi Jonathan, > > Thanks for the review. Comments inline. > > Renato > > On 02/09, Jonathan Cameron wrote: > >On Tue, 5 Feb 2019 15:13:00 -0200 > >Renato Lui Geh wrote: > > > >> Previously, the AD7780 driver only supported gpio for t

Re: [PATCH] staging:iio:ad7152: Rename misspelled RESEVERD -> RESERVED

2019-02-18 Thread Jonathan Cameron
On Thu, 14 Feb 2019 10:51:49 + "Popa, Stefan Serban" wrote: > On Mi, 2019-02-13 at 22:25 -0200, Rodrigo Ribeiro wrote: > > [External] > > > > > > Em ter, 29 de jan de 2019 às 07:10, Alexandru Ardelean > l.com> escreveu: > > > > > > On Sat, Jan 26, 2019 at 8:13 PM Jonathan Cameron > > wr

Re: [PATCH] Use the correct style for SPDX License Identifier in all header files across the kernel

2019-02-18 Thread Nishad Kamdar
On Sat, Feb 16, 2019 at 08:45:07PM +0100, Greg Kroah-Hartman wrote: > On Sat, Feb 16, 2019 at 04:04:02PM +0530, Nishad Kamdar wrote: > > 816 files changed, 970 insertions(+), 970 deletions(-) > > You have to break this up into subsystems at the very least, no one > person can take this patch, sor

Re: [PATCH -next] staging: rtl8192e: Remove set but not used variables 'broad_addr, stype'

2019-02-18 Thread Dan Carpenter
On Mon, Feb 18, 2019 at 12:33:59PM +, YueHaibing wrote: > @@ -1747,11 +1747,10 @@ static short _rtl92e_tx(struct net_device *dev, > struct sk_buff *skb) > header = (struct rtllib_hdr_1addr *)(((u8 *)skb->data) + fwinfo_size); > fc = le16_to_cpu(header->frame_ctl); > type = WL

Re: [PATCH v2] staging: android: ion: Allocate from heap ID directly without mask

2019-02-18 Thread Brian Starkey
On Fri, Feb 15, 2019 at 11:01:59AM -0800, John Stultz wrote: > On Fri, Feb 15, 2019 at 2:51 AM Brian Starkey wrote: > > > > Hi John, > > > > On Thu, Feb 14, 2019 at 09:38:29AM -0800, John Stultz wrote: > > > > > [snip] > > > > > Some thoughts, as this ABI break has the potential to be pretty painf

[PATCH -next] staging: rtl8192e: Remove set but not used variables 'broad_addr, stype'

2019-02-18 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/staging/rtl8192e/rtl8192e/rtl_core.c: In function '_rtl92e_tx': drivers/staging/rtl8192e/rtl8192e/rtl_core.c:1732:28: warning: variable 'broad_addr' set but not used [-Wunused-but-set-variable] drivers/staging/rtl8192e/rtl8192e/rtl_core.c:17

[PATCH -next] staging: mt7621-mmc: Remove unused including

2019-02-18 Thread YueHaibing
Remove including that don't need it. Signed-off-by: YueHaibing --- drivers/staging/mt7621-mmc/dbg.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/mt7621-mmc/dbg.c b/drivers/staging/mt7621-mmc/dbg.c index eabe0595978b..c7c091fa1da0 100644 --- a/drivers/staging/mt7621-mmc/dbg