Re: [PATCH 2/2] staging: erofs: switch to ->iterate_shared()

2019-02-24 Thread Gao Xiang
On 2019/2/25 9:36, Chao Yu wrote: > On 2019/2/21 10:34, Gao Xiang wrote: >> After commit 6192269444eb ("introduce a parallel variant of ->iterate()"), >> readdir can be done without taking exclusive inode lock of course. >> >> Signed-off-by: Gao Xiang > > Reviewed-by: Chao Yu Thanks for revi

Re: [PATCH 2/2] staging: erofs: switch to ->iterate_shared()

2019-02-24 Thread Chao Yu
On 2019/2/21 10:34, Gao Xiang wrote: > After commit 6192269444eb ("introduce a parallel variant of ->iterate()"), > readdir can be done without taking exclusive inode lock of course. > > Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Thanks, ___ deve

Re: [PATCH 1/2] staging: erofs: no need to take page lock in readdir

2019-02-24 Thread Chao Yu
On 2019/2/21 10:34, Gao Xiang wrote: > VFS will take inode_lock for readdir, therefore no need to > take page lock in readdir at all just as the majority of > other generic filesystems. > > Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Thanks, ___ d

Re: [PATCH v2] staging : speakup: Fix format issues in Kconfig

2019-02-24 Thread Samuel Thibault
Bharath Vedartham, le dim. 24 févr. 2019 18:41:42 +0530, a ecrit: > Fix the checkpatch.pl warning to replace ---help--- with help in > Kconfig. > > Signed-off-by: Bharath Vedartham Reviewed-by: Samuel Thibault Thanks! > --- > Changes since v1: > - Allign help and removed redundant space

Re: [PATCH] staging: Note that simple_strtoul can't simply be replaced by kstrtoul

2019-02-24 Thread Samuel Thibault
Greg KH, le dim. 24 févr. 2019 08:59:21 +0100, a ecrit: > On Sat, Feb 23, 2019 at 08:42:19PM +0100, Samuel Thibault wrote: > > We often receive patches which erroneously try to use kstrtoul in these > > places. > > > > Signed-off-by: Samuel Thibault > > Awe, it's fun to try to see people do this

Re: [PATCH net-next 7/8] net: switchdev: Replace port attr set SDO with a notification

2019-02-24 Thread Florian Fainelli
Le 2/23/19 à 2:32 AM, Ido Schimmel a écrit : > On Fri, Feb 22, 2019 at 03:59:25PM -0800, Florian Fainelli wrote: >> Drop switchdev_ops.switchdev_port_attr_set. Drop the uses of this field >> from all clients, which were migrated to use switchdev notification in >> the previous patches. >> >> Add a

Re: [PATCH net] staging: fsl-dpaa2: ethsw: Add missing netdevice check

2019-02-24 Thread Florian Fainelli
Le 2/23/19 à 12:45 AM, Ioana Ciornei a écrit : > >> Subject: [PATCH net] staging: fsl-dpaa2: ethsw: Add missing netdevice check >> >> port_switchdev_event() does not check that the target network device is >> actually backed by the ethsw driver, this could be problematic in a stacked >> environmen

[PATCH v2] staging : speakup: Fix format issues in Kconfig

2019-02-24 Thread Bharath Vedartham
Fix the checkpatch.pl warning to replace ---help--- with help in Kconfig. Signed-off-by: Bharath Vedartham --- Changes since v1: - Allign help and removed redundant spaces. --- drivers/staging/speakup/Kconfig | 42 - 1 file changed, 16 insertions(+