Re: [PATCH net] staging: rtl8188eu: use is_zero_ether_addr() instead of memcmp()

2019-03-11 Thread maowenan
On 2019/3/12 14:35, Joe Perches wrote: > On Tue, 2019-03-12 at 14:29 +0800, maowenan wrote: >> ping... >> >> On 2019/3/9 11:26, Mao Wenan wrote: >>> Using is_zero_ether_addr() instead of directly use >>> memcmp() to determine if the ethernet address is all >>> zeros. > [] >>> diff --git a/driver

Re: [PATCH net] staging: rtl8188eu: use is_zero_ether_addr() instead of memcmp()

2019-03-11 Thread maowenan
ping... On 2019/3/9 11:26, Mao Wenan wrote: > Using is_zero_ether_addr() instead of directly use > memcmp() to determine if the ethernet address is all > zeros. > > Signed-off-by: Mao Wenan > --- > drivers/staging/rtl8188eu/core/rtw_mlme.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(

[PATCH v2] hv: utils: enhance code for human read

2019-03-11 Thread Jesús Castro
The if/else block from hvt_op_open function can be written as a switch/case block, and the bool issue_reset variable is avoided. No functional change made. Suggested-by: Joe Perches Signed-off-by: Jesús Castro --- v2: Refactoring hvt_op_open function with a switch/case block. Change subje

Re: [PATCH] hv: utils: fix coding style

2019-03-11 Thread Jesús Castro
> > Checkpatch script is showing a coding style error and is showing: > > > > ERROR: else should follow close brace '}' > > + } > > + else if (hvt->mode == HVUTIL_TRANSPORT_NETLINK) { > > > > This commit fixes the coding style, not a functional change. > [] > > diff --git a/drivers/hv/hv_util

[PATCH 0/2] staging: remove mt7621-eth

2019-03-11 Thread NeilBrown
drivers/net/ethernet/mediatek/ now supports the mt7621 ethernet controller. So we can remove the drivers/staging driver, and update the devicetree file to work with this driver. NeilBrown --- NeilBrown (2): staging: remove mt7621-eth staging: mt7621-dts: update ethernet settings.

[PATCH 1/2] staging: remove mt7621-eth

2019-03-11 Thread NeilBrown
driver/net/ethernet/mediatek/ now supports this hardware, so we don't need a separate driver. Signed-off-by: NeilBrown --- drivers/staging/Kconfig|2 drivers/staging/Makefile |1 .../devicetree/bindings/net/mediatek-net-gsw.txt |

[PATCH 2/2] staging: mt7621-dts: update ethernet settings.

2019-03-11 Thread NeilBrown
The ethernet in mt7621 is now supported by drivers/net/ethernet/mediatek/ which provides support for the integrated switch through DSA. This requires some devicetree changes, and particularly allows a board dts to identify which switch ports are present. The second CPU interface - gmac1 - doesn

Re: [PATCH v4 9/9] staging: iio: ad7780: add device tree binding

2019-03-11 Thread Rob Herring
On Thu, 28 Feb 2019 11:26:28 -0300, Renato Lui Geh wrote: > Adds a device tree binding for the ad7780 driver. > > Signed-off-by: Renato Lui Geh > --- > .../bindings/iio/adc/adi,ad7780.txt | 48 +++ > 1 file changed, 48 insertions(+) > create mode 100644 Documentation/d

Re: [driver-core:fi_cleanup 1/1] drivers/infiniband//hw/hfi1/fault.c:277:2: error: implicit declaration of function 'DEBUGFS_SEQ_FILE_CREATE'; did you mean 'DEBUGFS_SEQ_FILE_OPEN'?

2019-03-11 Thread Greg Kroah-Hartman
On Tue, Mar 12, 2019 at 06:32:54AM +0800, kbuild test robot wrote: > tree: > https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git > fi_cleanup > head: e5f4139a329f9c5b0ddaa1e636721d546b179928 > commit: e5f4139a329f9c5b0ddaa1e636721d546b179928 [1/1] fault_inject: clean up >

Re: [RFC] simple_lmk: Introduce Simple Low Memory Killer for Android

2019-03-11 Thread Sultan Alsawaf
On Mon, Mar 11, 2019 at 03:15:35PM -0700, Suren Baghdasaryan wrote: > This what LMKD currently is - a userspace RT process. > My point was that this page allocation queue that you implemented > can't be implemented in userspace, at least not without extensive > communication with kernel. Oh, that'

[driver-core:fi_cleanup 1/1] drivers/infiniband//hw/hfi1/fault.c:277:2: error: implicit declaration of function 'DEBUGFS_SEQ_FILE_CREATE'; did you mean 'DEBUGFS_SEQ_FILE_OPEN'?

2019-03-11 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git fi_cleanup head: e5f4139a329f9c5b0ddaa1e636721d546b179928 commit: e5f4139a329f9c5b0ddaa1e636721d546b179928 [1/1] fault_inject: clean up fault_create_debugfs_attr config: x86_64-allmodconfig (attached as .config) comp

Re: [RFC] simple_lmk: Introduce Simple Low Memory Killer for Android

2019-03-11 Thread Sultan Alsawaf
On Mon, Mar 11, 2019 at 05:11:25PM -0400, Joel Fernandes wrote: > But the point is that a transient temporary memory spike should not be a > signal to kill _any_ process. The reaction to kill shouldn't be so > spontaneous that unwanted tasks are killed because the system went into > panic mode. It

Re: [PATCH] FBTFT: fbtft-bus: Fix code style problems

2019-03-11 Thread Ezequiel Garcia
On Mon, 11 Mar 2019 at 18:40, Sam Ravnborg wrote: > > Hi Eze > > > > Why is this driver still here? I thought we migrated everyhing to > > tinydrm already. > Some have been ported, some are waiting for a user to do the port. > If you looks at tinydrm you will see: > ili9225.c ili9341.c > > And we

Re: [PATCH] FBTFT: fbtft-bus: Fix code style problems

2019-03-11 Thread Sam Ravnborg
Hi Dante. > Hello Sam, thank you very much for your comments, > As I told Dan (my email did not reach the mailing list) this is my > first attempt to contribute, > So I'm learning a lot from your advice and corrections. > > I will look for TODO lists to see if there are more useful > contribution

Re: [PATCH] FBTFT: fbtft-bus: Fix code style problems

2019-03-11 Thread Sam Ravnborg
Hi Eze > > Why is this driver still here? I thought we migrated everyhing to > tinydrm already. Some have been ported, some are waiting for a user to do the port. If you looks at tinydrm you will see: ili9225.c ili9341.c And we also have under panel: panel-ilitek-ili9881c.c panel-ilitek-ili9322.

Re: [PATCH] FBTFT: fbtft-bus: Fix code style problems

2019-03-11 Thread Ezequiel Garcia
Hi everyone, Dante: please avoid top-posting. In other words, put your replies in-line, like I'm gonna do now. See below (and see how discussion goes on other threads). On Mon, 11 Mar 2019 at 17:34, DANTE JAVIER PAZ wrote: > > Hello Sam, thank you very much for your comments, > As I told Dan (my

Re: [RFC] simple_lmk: Introduce Simple Low Memory Killer for Android

2019-03-11 Thread Joel Fernandes
On Mon, Mar 11, 2019 at 01:46:26PM -0700, Sultan Alsawaf wrote: > On Mon, Mar 11, 2019 at 01:10:36PM -0700, Suren Baghdasaryan wrote: > > The idea seems interesting although I need to think about this a bit > > more. Killing processes based on failed page allocation might backfire > > during transi

Re: [RFC] simple_lmk: Introduce Simple Low Memory Killer for Android

2019-03-11 Thread Sultan Alsawaf
On Mon, Mar 11, 2019 at 01:10:36PM -0700, Suren Baghdasaryan wrote: > The idea seems interesting although I need to think about this a bit > more. Killing processes based on failed page allocation might backfire > during transient spikes in memory usage. This issue could be alleviated if tasks cou

Re: [PATCH] FBTFT: fbtft-bus: Fix code style problems

2019-03-11 Thread DANTE JAVIER PAZ
Hello Sam, thank you very much for your comments, As I told Dan (my email did not reach the mailing list) this is my first attempt to contribute, So I'm learning a lot from your advice and corrections. I will look for TODO lists to see if there are more useful contributions to make, all suggestion

Re: [RFC] simple_lmk: Introduce Simple Low Memory Killer for Android

2019-03-11 Thread Sultan Alsawaf
On Mon, Mar 11, 2019 at 06:43:20PM +0100, Michal Hocko wrote: > I am sorry but we are not going to maintain two different OOM > implementations in the kernel. From a quick look the implementation is > quite a hack which is not really suitable for anything but a very > specific usecase. E.g. reusing

Re: [RFC] simple_lmk: Introduce Simple Low Memory Killer for Android

2019-03-11 Thread Michal Hocko
On Sun 10-03-19 13:34:03, Sultan Alsawaf wrote: > From: Sultan Alsawaf > > This is a complete low memory killer solution for Android that is small > and simple. It kills the largest, least-important processes it can find > whenever a page allocation has completely failed (right after direct > rec

Re: [PATCH AUTOSEL 4.20 36/81] binder: fix CONFIG_ANDROID_BINDER_DEVICES

2019-03-11 Thread Sasha Levin
On Thu, Feb 28, 2019 at 04:24:07PM +0100, Greg Kroah-Hartman wrote: On Thu, Feb 28, 2019 at 10:07:28AM -0500, Sasha Levin wrote: From: Christian Brauner [ Upstream commit 793c8232937610ae00bc174b87d7fc324346eaea ] Several users have tried to only rely on binderfs to provide binder devices and

RE: [PATCH v2] makedumpfile: exclude pages that are logically offline

2019-03-11 Thread Kazuhito Hagio
-Original Message- > On 27.11.18 17:32, Kazuhito Hagio wrote: > >> Linux marks pages that are logically offline via a page flag (map count). > >> Such pages e.g. include pages infated as part of a balloon driver or > >> pages that were not actually onlined when onlining the whole section. >

Re: [RFC] simple_lmk: Introduce Simple Low Memory Killer for Android

2019-03-11 Thread Joel Fernandes
On Mon, Mar 11, 2019 at 12:32:33PM -0400, Joel Fernandes wrote: > On Sun, Mar 10, 2019 at 01:34:03PM -0700, Sultan Alsawaf wrote: > [...] > > > > /* Perform scheduler related setup. Assign this task to a CPU. */ > > retval = sched_fork(clone_flags, p); > > diff --git a/mm/page_alloc.c b/m

Re: [RFC] simple_lmk: Introduce Simple Low Memory Killer for Android

2019-03-11 Thread Joel Fernandes
On Sun, Mar 10, 2019 at 01:34:03PM -0700, Sultan Alsawaf wrote: [...] > > /* Perform scheduler related setup. Assign this task to a CPU. */ > retval = sched_fork(clone_flags, p); > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 3eb01dedf..fd0d697c6 100644 > --- a/mm/page_alloc

Re: [PATCH] FBTFT: fbtft-bus: Fix code style problems

2019-03-11 Thread Sam Ravnborg
Hi Dante Thanks for the patch. On Sat, Mar 09, 2019 at 06:48:52PM -0300, Dante Paz wrote: > From: Dante Paz > > Style and coding function issues were corrected, by avoiding macro > functions with a conflicting coding style. > Signed-off-by: Dante Paz But it raised a few comments. The

[PATCH] staging: erofs: fix to handle error path of erofs_vmap()

2019-03-11 Thread Chao Yu
From: Chao Yu erofs_vmap() wrapped vmap() and vm_map_ram() to return virtual continuous memory, but both of them can failed due to a lot of reason, previously, erofs_vmap()'s callers didn't handle them, which can potentially cause NULL pointer access, fix it. Fixes: 3883a79abd02 ("staging: erofs

Re: [PATCH] staging: davinci: drop pointless static qualifier in vpfe_resizer_init()

2019-03-11 Thread Dan Carpenter
On Mon, Mar 11, 2019 at 02:10:12PM +, Colin Ian King wrote: > On 11/03/2019 14:07, Dan Carpenter wrote: > > On Mon, Mar 11, 2019 at 10:14:05PM +0800, Mao Wenan wrote: > >> There is no need to have the 'T *v' variable static > >> since new value always be assigned before use it. > >> > >> Signed

Re: [PATCH v2] staging: davinci: drop pointless static qualifier in vpfe_resizer_init()

2019-03-11 Thread Dan Carpenter
Thanks! Reviewed-by: Dan Carpenter regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v2] staging: davinci: drop pointless static qualifier in vpfe_resizer_init()

2019-03-11 Thread Mao Wenan
There is no need to have the 'T *v' variable static since new value always be assigned before use it. Signed-off-by: Mao Wenan --- v1->v2: remove additional space character between resource_size_t and res_len. drivers/staging/media/davinci_vpfe/dm365_resizer.c | 2 +- 1 file changed, 1 inserti

Re: [PATCH] staging: davinci: drop pointless static qualifier in vpfe_resizer_init()

2019-03-11 Thread maowenan
On 2019/3/11 22:07, Dan Carpenter wrote: > On Mon, Mar 11, 2019 at 10:14:05PM +0800, Mao Wenan wrote: >> There is no need to have the 'T *v' variable static >> since new value always be assigned before use it. >> >> Signed-off-by: Mao Wenan >> --- >> drivers/staging/media/davinci_vpfe/dm365_re

Re: [PATCH] staging: davinci: drop pointless static qualifier in vpfe_resizer_init()

2019-03-11 Thread Colin Ian King
On 11/03/2019 14:07, Dan Carpenter wrote: > On Mon, Mar 11, 2019 at 10:14:05PM +0800, Mao Wenan wrote: >> There is no need to have the 'T *v' variable static >> since new value always be assigned before use it. >> >> Signed-off-by: Mao Wenan >> --- >> drivers/staging/media/davinci_vpfe/dm365_resi

Re: [PATCH] staging: davinci: drop pointless static qualifier in vpfe_resizer_init()

2019-03-11 Thread Dan Carpenter
On Mon, Mar 11, 2019 at 10:14:05PM +0800, Mao Wenan wrote: > There is no need to have the 'T *v' variable static > since new value always be assigned before use it. > > Signed-off-by: Mao Wenan > --- > drivers/staging/media/davinci_vpfe/dm365_resizer.c | 2 +- > 1 file changed, 1 insertion(+), 1

[PATCH] staging: davinci: drop pointless static qualifier in vpfe_resizer_init()

2019-03-11 Thread Mao Wenan
There is no need to have the 'T *v' variable static since new value always be assigned before use it. Signed-off-by: Mao Wenan --- drivers/staging/media/davinci_vpfe/dm365_resizer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/davinci_vpfe/dm365_resiz

Re: [PATCH v2 3/8] kexec: export PG_offline to VMCOREINFO

2019-03-11 Thread Dave Young
> > The patch has been merged, would you mind to send a documentation patch > > for the vmcoreinfo, which is added recently in > > Documentation/kdump/vmcoreinfo.txt > > > > A brief description about how this vmcoreinfo field is used is good to > > have. > > > > Turns out, it was already docume

Re: [PATCH v2 3/8] kexec: export PG_offline to VMCOREINFO

2019-03-11 Thread David Hildenbrand
On 11.03.19 10:04, Dave Young wrote: > Hi David, > On 11/22/18 at 11:06am, David Hildenbrand wrote: >> Right now, pages inflated as part of a balloon driver will be dumped >> by dump tools like makedumpfile. While XEN is able to check in the >> crash kernel whether a certain pfn is actuall backed b

Re: [PATCH v2 3/8] kexec: export PG_offline to VMCOREINFO

2019-03-11 Thread Dave Young
Hi David, On 11/22/18 at 11:06am, David Hildenbrand wrote: > Right now, pages inflated as part of a balloon driver will be dumped > by dump tools like makedumpfile. While XEN is able to check in the > crash kernel whether a certain pfn is actuall backed by memory in the > hypervisor (see xen_oldmem

Re: [PATCH] staging: iio: adc: ad7192: Add spaces around minus operator

2019-03-11 Thread Jeremy Sowden
On 2019-03-11, at 11:31:59 +0300, Dan Carpenter wrote: > On Mon, Mar 11, 2019 at 10:12:48AM +0200, Alexandru Ardelean wrote: > > On Sun, Mar 10, 2019 at 11:23 PM Karen Palacio > > wrote: > > > > > > Add spaces around minus operator to fix readibility. > > > > > > Signed-off-by: Karen Palacio > >

Re: [PATCH] Staging: rtl8712: Fix comment position, it goes after statment

2019-03-11 Thread Dan Carpenter
On Sun, Mar 10, 2019 at 11:58:56PM -0300, Mauro Furer wrote: > This patch fixes checkpatch.pl warning in file rtl871x_io.h > WARNING : Statements should start on a tabstop Fix the indenting in your commit message. > > Signed-off-by: Mauro Furer > --- > drivers/staging/rtl8712/rtl871x_i

Re: [PATCH] staging: iio: adc: ad7192: Add spaces around minus operator

2019-03-11 Thread Dan Carpenter
On Mon, Mar 11, 2019 at 10:12:48AM +0200, Alexandru Ardelean wrote: > On Sun, Mar 10, 2019 at 11:23 PM Karen Palacio > wrote: > > > > Add spaces around minus operator to fix readibility. > > > > Signed-off-by: Karen Palacio > > --- > > drivers/staging/iio/adc/ad7192.c | 2 +- > > 1 file changed,

Re: [PATCH] FBTFT: fbtft-bus: Fix code style problems

2019-03-11 Thread Dan Carpenter
I feel like you need to break the patch up a bit and do the white space fixes separate from the other changes. (Probably you're going to have to redo this several times because it's hard to review when it's so mixed up with multiple changes at the same time). regards, dan carpenter _

Re: [PATCH] staging: iio: adc: ad7192: Add spaces around minus operator

2019-03-11 Thread Alexandru Ardelean
On Sun, Mar 10, 2019 at 11:23 PM Karen Palacio wrote: > > Add spaces around minus operator to fix readibility. > > Signed-off-by: Karen Palacio > --- > drivers/staging/iio/adc/ad7192.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/iio/adc/ad7192.c > b/

Re: [PATCH] FBTFT: fbtft-bus: Fix code style problems

2019-03-11 Thread Dan Carpenter
On Sat, Mar 09, 2019 at 06:48:52PM -0300, Dante Paz wrote: > From: Dante Paz > > Style and coding function issues were corrected, by avoiding macro > functions with a conflicting coding style. > Signed-off-by: Dante Paz Line too long. No blank. Fix indenting. It's not really clear w