Re: [PATCH 3/3] dt-bindings: iio: adc: Add AD7616 ADC documentation

2019-04-05 Thread Rob Herring
On Tue, 2 Apr 2019 16:18:41 +0300, Beniamin Bia wrote: > Document support for AD7616 Analog to Digital Converter. > > Signed-off-by: Beniamin Bia > --- > Documentation/devicetree/bindings/iio/adc/adi,ad7606.txt | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Rob Herring __

Re: [PATCH v2 1/2] dt-bindings: phy: Add binding for Mediatek MT7621 PCIe PHY

2019-04-05 Thread Rob Herring
On Sat, 30 Mar 2019 06:50:37 +0100, Sergio Paracuellos wrote: > Add bindings to describe Mediatek MT7621 PCIe PHY. > > Signed-off-by: Sergio Paracuellos > --- > .../bindings/phy/mediatek,mt7621-pci-phy.txt | 28 +++ > 1 file changed, 28 insertions(+) > create mode 100644 > Doc

[PATCH -next] staging: rtlwifi: base: Remove set but not used variables

2019-04-05 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/staging/rtlwifi/base.c: In function 'rtl_tx_agg_stop': drivers/staging/rtlwifi/base.c:1733:23: warning: variable 'tid_data' set but not used [-Wunused-but-set-variable] drivers/staging/rtlwifi/base.c: In function 'rtl_check_beacon_key': driv

[PATCH -next] staging: rtl8192e: Remove set but not used variable 'VenderID'

2019-04-05 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/staging/rtl8192e/rtl8192e/rtl_pci.c: In function 'rtl92e_check_adapter': drivers/staging/rtl8192e/rtl8192e/rtl_pci.c:36:6: warning: variable 'VenderID' set but not used [-Wunused-but-set-variable] u16 VenderID; ^ It's never used and

[PATCH -next] staging: rtlwifi: rtl8822be: Remove set but not used variable 'curtxbw_40mhz'

2019-04-05 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/staging/rtlwifi/rtl8822be/hw.c: In function 'rtl8822be_update_hal_rate_mask': drivers/staging/rtlwifi/rtl8822be/hw.c:2144:5: warning: variable 'curtxbw_40mhz' set but not used [-Wunused-but-set-variable] It's never used and can be removed.

[PATCH -next] staging: comedi: dyna_pci10xx: remove set but not used variables 'chan' and range'

2019-04-05 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/staging/comedi/drivers/dyna_pci10xx.c: In function 'dyna_pci10xx_insn_write_ao': drivers/staging/comedi/drivers/dyna_pci10xx.c:109:21: warning: variable 'range' set but not used [-Wunused-but-set-variable] unsigned int chan, range; driver

Re: [greybus-dev] [PATCH] Staging: greybus: Fix spinlock_t definition without comment

2019-04-05 Thread Alex Elder
On 4/5/19 3:53 PM, Dan Carpenter wrote: > On Fri, Apr 05, 2019 at 03:00:46PM -0500, Madhumitha Prabakaran > wrote: >> Fix spinlock_t definition without comment. >> >> Signed-off-by: Madhumitha Prabakaran Madhumitha, the reason one would want a comment associated with a lock field in a structure

Re: [PATCH] Staging: greybus: Fix spinlock_t definition without comment

2019-04-05 Thread Dan Carpenter
On Fri, Apr 05, 2019 at 03:00:46PM -0500, Madhumitha Prabakaran wrote: > Fix spinlock_t definition without comment. > > Signed-off-by: Madhumitha Prabakaran > --- > drivers/staging/greybus/connection.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/grey

[PATCH] Staging: greybus: Cleanup in header file control.h

2019-04-05 Thread Madhumitha Prabakaran
Fix a blank line after function/struct/union/enum declarations. Also, convert to_gb_control() macro into an inline function in order to maintain Linux kernel coding style based on which the inline function is preferable over the macro. Signed-off-by: Madhumitha Prabakaran --- drivers/staging/gr

[PATCH] Staging: greybus: Fix spinlock_t definition without comment

2019-04-05 Thread Madhumitha Prabakaran
Fix spinlock_t definition without comment. Signed-off-by: Madhumitha Prabakaran --- drivers/staging/greybus/connection.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/greybus/connection.h b/drivers/staging/greybus/connection.h index 5ca3befc0636..0aedd246e9

[PATCH] Staging: olpc_dcon: Use WARN_ON() instead of BUG_ON()

2019-04-05 Thread Madhumitha Prabakaran
Use WARN_ON() instead of BUG_ON(), as the WARN_ON() produces a backtrace without crashing the kernel. Issue found by checkpatch.pl. Signed-off-by: Madhumitha Prabakaran --- drivers/staging/olpc_dcon/olpc_dcon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/

Re: [PATCH 3/3] staging: vchiq: make wait events interruptible

2019-04-05 Thread Stefan Wahren
Am 05.04.19 um 13:34 schrieb Nicolas Saenz Julienne: > The killable version of wait_event() is meant to be used on situations > where it's not meant to fail at all costs, but still have the convenience > of being able to kill it if really necessary. For instance it's used > while waiting on an page

Re: [PATCH 0/3] staging: vchiq: use interruptible waits

2019-04-05 Thread Stefan Wahren
Hi Nicolas, Am 05.04.19 um 13:34 schrieb Nicolas Saenz Julienne: > Hi, > this series tries to address an issue that came up in Raspbian's kernel > tree [1]. After pulling from upstream some changes that moved wait calls > from a custom implementation to the more standard killable family some > use

Re: [PATCH 1/3] Revert "staging: vchiq_2835_arm: quit using custom down_interruptible()"

2019-04-05 Thread Nicolas Saenz Julienne
On Fri, 2019-04-05 at 15:02 +0300, Dan Carpenter wrote: > On Fri, Apr 05, 2019 at 01:34:20PM +0200, Nicolas Saenz Julienne wrote: > > This reverts commit ff5979ad86368425b7da3a25f4e84650b51ff5fd. > > --- > > Git kind of sets you up for failure with reverts... > > Fix the subject, add a commit mes

Re: [PATCH 1/3] Revert "staging: vchiq_2835_arm: quit using custom down_interruptible()"

2019-04-05 Thread Dan Carpenter
On Fri, Apr 05, 2019 at 01:34:20PM +0200, Nicolas Saenz Julienne wrote: > This reverts commit ff5979ad86368425b7da3a25f4e84650b51ff5fd. > --- Git kind of sets you up for failure with reverts... Fix the subject, add a commit message and a Signed off by etc. We need all the regular stuff. See com

[PATCH 2/3] Revert "staging: vchiq: switch to wait_for_completion_killable"

2019-04-05 Thread Nicolas Saenz Julienne
This reverts commit a772f116702e3f0afdd7e6acadc1b8fb3b20b9ff. --- .../interface/vchiq_arm/vchiq_arm.c | 21 ++- .../interface/vchiq_arm/vchiq_core.c | 21 ++- .../interface/vchiq_arm/vchiq_util.c | 6 +++--- 3 files changed, 25 insertion

[PATCH 0/3] staging: vchiq: use interruptible waits

2019-04-05 Thread Nicolas Saenz Julienne
Hi, this series tries to address an issue that came up in Raspbian's kernel tree [1]. After pulling from upstream some changes that moved wait calls from a custom implementation to the more standard killable family some users complained that all the VCHIQ threads showed up in D state (which is the

[PATCH 1/3] Revert "staging: vchiq_2835_arm: quit using custom down_interruptible()"

2019-04-05 Thread Nicolas Saenz Julienne
This reverts commit ff5979ad86368425b7da3a25f4e84650b51ff5fd. --- .../staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c b/drivers/staging/vc04_services/

[PATCH 3/3] staging: vchiq: make wait events interruptible

2019-04-05 Thread Nicolas Saenz Julienne
The killable version of wait_event() is meant to be used on situations where it's not meant to fail at all costs, but still have the convenience of being able to kill it if really necessary. For instance it's used while waiting on an page write on some file systems. Wait events in VCHIQ don't fit

Re: [PATCH v3 05/14] staging: most: enable configfs support

2019-04-05 Thread kbuild test robot
Hi Christian, Thank you for the patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] [also build test ERROR on v5.1-rc3 next-20190404] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0d

Re: [PATCH] staging: vc04_services: add missing __user annotations

2019-04-05 Thread Stefan Wahren
Hi Jasminko, Am 24.03.19 um 18:17 schrieb Jasminko Dedic: > This patch fixes the following sparse warnings by adding missing __user > annotations. It also cleans up two related unnecessary casts by reuseing > casts already made a few lines up. Remaining sparse warnings are of a > different type. >